18fd930722
text browser updates.
2001-12-03 19:55:56 +00:00
44515cd547
add features to allow text browsers to view status tables.
2001-12-03 19:55:12 +00:00
f2caf61441
update tests to accomidate new text browser features and conventions.
2001-12-03 19:53:31 +00:00
d16a4fb99e
add support for an ALL page.
...
fix a bunch of minor bugs and typos.
2001-12-03 19:52:38 +00:00
7159883a59
add link back to the current status page from which ever status page
...
you are looking at.
2001-12-03 19:50:00 +00:00
30a67530a4
add support for text browser characters.
2001-12-03 19:48:47 +00:00
5435f59bc5
generalize treestate so that we can provide data to text browsers.
2001-12-03 19:47:24 +00:00
8520facc07
add support for an ALL page.
2001-12-03 19:46:04 +00:00
4fc42ad4a7
add support for text browsers: colorized characters which discribe the build
...
cell state. Also allow users to chose the brief/full log from the
status page.
2001-12-03 19:44:26 +00:00
a7bc21333b
add support for text browsers including, special colorized characters
...
and click through text of notices.
2001-12-03 19:43:28 +00:00
379d9ec222
add support for text browsers.
2001-12-03 19:42:45 +00:00
1c0429a7de
removing jrgm's version of &days=, Date::Calc version is working.
2001-12-03 09:07:16 +00:00
fadd93a4b6
Adding &days=n argument.
2001-12-03 08:56:28 +00:00
65b27a5000
Adding &days=n argument. Left in jrgm's attempt as a comment for now.
2001-12-03 08:40:42 +00:00
565a298208
Adding &days=n argument. Needs Bit::Vector and Date::Calc perl modules.
2001-12-03 08:11:15 +00:00
59e59f9a28
Added &autoscale=1 option, default is still the btek hack [1300:1400]
2001-12-02 21:54:25 +00:00
054a3a5136
First commit.
2001-12-02 21:50:59 +00:00
5cb9f92791
Ignore db directory
2001-12-02 21:31:30 +00:00
b57c93f41e
Added &autoscale=1 option to autoscale y-axis.
2001-12-02 21:30:31 +00:00
4ac50ff849
Fixed a bug in the main run loop whereby the objects array wasn't freed until shutdown, which sometimes meant objects got destroyed after the application, which is bad when the objects use the application to find services, etc. (This doesn't happen with services since services are not allowed to store references to the application, either directly or indirectly through references to objects or service instances.) Fixed the logout code to wait until the user tries to do something that requires login before clearing the logging out flag. This fixes a bug with HTTP whereby if a user logged out then his UA wouldn't ever be sent a 401 so wouldn't ever lose the authentication info, because browsers send the authentication info regardless of whether a page needs it or not. Also took the opportunity to remove a potential bug in the input validator code: store the admin message instead of a reference to the user object which might end up with a lifetime longer than expected.
2001-12-01 04:37:26 +00:00
6d68f3ce28
Removed an outdated comment. It is now safe to have a single module be a service, one or more service instances, and one or more objects all at the same time.
2001-12-01 04:29:20 +00:00
2841b9ae98
Add support for keyed channels to mozbot. A lot of work, like it said in the INSTALL file. :-) b=112955 r=timeless
2001-11-30 23:38:21 +00:00
a07abaeaeb
Get the file list of files to scan for templates from Support::Files instead of glob('*')
2001-11-30 21:49:47 +00:00
928179724c
Made all dependencies load their modules on demand rather than on startup (cuts down the page serving time by about 50%). Also removed some debugging statements in certain high profile areas.
2001-11-30 20:48:36 +00:00
05b0232a3b
Added support for easily getting the original key name of a munged key: added a virtual '.coses: original key' entry to all hashes in COSES (works similar to the virtual '.length' item that all arrays have). Edited the debug string to mention these virtual items.
2001-11-30 16:20:22 +00:00
223ca141d1
Fixing an inconsistency between getArgument() and peekArgument(). peekArgument() now returns an empty list in an array context if there is no such argument, instead of undef. This makes it act like getArgument(), which just returns the list of values in an array context. Similarly, made the default implementation of peekArgument() whine about not being implemented instead of returning undef, since by design peekArgument() should return the same as getArgument() if the argument is present.
2001-11-30 16:13:00 +00:00
c790c34e51
Adding error handling for the case where the user prefs editor is called with bogus user IDs.
2001-11-30 16:06:45 +00:00
cad0aefadc
Implemented logout and explicit new account creation in the login service. Had to add removeObject() to the Controller module (the opposite of the exisiting addObject()).
2001-11-30 13:31:29 +00:00
d0e2eaa81c
close the file to get it to write to disk
2001-11-30 08:41:27 +00:00
ae65a5cc2d
match changes from startup test.
2001-11-30 08:38:05 +00:00
d8c369daf3
better error message when no data file is found.
2001-11-30 08:32:53 +00:00
30436cd379
try to fix error-on-first-report
2001-11-30 07:57:19 +00:00
4ec5a46977
avg -> value
2001-11-30 05:53:01 +00:00
1367a664e4
switching avg to value
2001-11-30 05:49:19 +00:00
5dd51d6943
Fixing Y axis label
2001-11-30 05:44:07 +00:00
df79caa59b
First add. Clone of startup cgis. plans to make this a general graph cgi are in the wings, this is a temporary get-this-going hack
2001-11-30 04:51:04 +00:00
0d7332f336
Minor fixes to make the previous checkin actually compile...
2001-11-29 20:23:48 +00:00
25b1d12a51
* Corrected some inaccurate comments I came across.
...
* Added support for group membership levels (now you can be a normal member, as before, but also a group op or a group admin) -- this affected the user data source, the mysql data source, and the user service.
* Added a getFieldsHierarchically() method to the user data source.
* Added a getFieldsByCategory() method to the user data source.
* Fixed a typo in some of the SQL in the rights management part of the MySQL user data source.
* Added support in the arguments input module for treating the arguments as dot-delimited trees and returning a specific branch.
* Added support in the passwords service for encrypting a specific password.
* Added a getFieldByID() method to the user service.
* Made the groups in the user service be indexed by both ID and Name.
* Implemented the user preferences component.
2001-11-29 18:03:38 +00:00
b35462663d
Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it.
...
r=louie, myk
2001-11-27 15:04:52 +00:00
6c017b5495
Solaris needs LD_LIBRARY_PATH help for /usr/local/lib
2001-11-27 05:01:47 +00:00
91e7099173
Find gnuplot
2001-11-27 04:43:32 +00:00
0195aa1082
First add. code=jrgm, modified by mcafee
2001-11-27 02:26:48 +00:00
4ab8b1cc2d
minor html fix
2001-11-27 02:19:00 +00:00
880817f69f
Fix for bug 109802: Make it clear how to enter mysql passwords with special characters into localconfig.
...
Patch by Dave Miller <justdave@syndicomm.com>.
r=ddkilzer,louie.
2001-11-27 00:49:26 +00:00
6cc1e85202
Fix for bug 101875: Put the product column before the component column rather than after.
...
Patch by Paul Baker <pbaker@where2getit.com>.
Low risk, r=myk, no second review needed.
2001-11-26 23:29:29 +00:00
8faf89a56a
Bug 109530 - xml.cgi was quoting stuff way too much. This is because it was incorrectly quoted in Bug.pm
...
r= justdave, louie
2001-11-26 14:16:10 +00:00
7873addd19
Bugzilla Bug 107823 change nsIFile
...
to use 'Modified' instead of 'Modification'
r=akkana sr=brendan
2001-11-26 08:05:05 +00:00
8db5cd827f
mkdir requires the second argument in perl 5.005. b=111730, r=daniele
2001-11-25 14:17:19 +00:00
ba0995062e
Mozbot shipped with a broken default bugsDWIMQueryDefault -- made the code more consistent. b=93203, r=timeless
2001-11-25 13:59:53 +00:00
3e1a0552b7
oops, stray dot meant the private karma scores were getting corrupted! r=kerz
2001-11-25 01:25:27 +00:00
f06a83769d
Initial checkin of a karma module. r=kerz b=111757
2001-11-25 01:01:35 +00:00
948a9f08ad
Changing 'will soon be available as an open source resource' to 'is available as an open source resource'
2001-11-23 16:50:57 +00:00
35ca97689e
work in progress: a component that provides a way for users and admins to edit user preferences, settings, contact details, password, etc.
2001-11-23 00:16:44 +00:00
36d2cbf8bf
changing the argument names from the cosesEditorXYZ form to the cosesEditor.x.y.z form. This will make them more consistent with how things work elsewhere in PLIF.
2001-11-22 20:15:45 +00:00
4f7a051ce1
* Created service- and serviceInstance- specific constructors so that a single module can have distinct constructors depending on how it is invoked. These constructors are called serviceInit() and serviceInstanceInit(), and both chain to the existing init() constructor (so no change are required by this).
...
* Changed FileStrings so that it doesn't have to be updated every time the file string format changes. The format is now one line per piece of metadata, then a blank line, then the string data. If additional metadata is added later then this will automatically support it.
* Renamed the dataSource.strings service to dataSource.strings.customised, and renamed its get() method to getCustomisedString().
* Changed the semantics of dataSource.strings.customised so that it no longer looks for a default string if it can't find a customised one (and thus removed getDefaultString).
* Abstracted the Generic output module even more. It now consists of output.generic (a service instance with its own constructor) and dataSource.strings (a pure service), the latter of which is a wrapper around dataSource.strings.customised and dataSource.strings.defaults.
* Updated Coses to work with the new dataSource.strings insterface.
* Removed the test app DataSource::ConsoleStrings and DataSource::HTTPStrings files, since they were redundant with the default output files.
* Removed all the default strings in the CosesEditor and Login components since they are pretty pointless.
* Factored out the call to dump() in the GenericOutputs module.
* Changed setString in the MySQL string data source so that it will now add a blank string (it used to delete the string if it was blank, but that meant that it was not possible to customise strings away).
* Added a piece of metadata to strings: their version number.
* Updated the customised string data source stubs to mention the version data now stored with all strings
* Added a getAllStringVersions method to the customised strings data source which returns all the string names and their version numbers.
* Made the customised strings data source check the version number of every string in its database during setupInstall to make sure that they are all up to date, version-wise. If any are out of date, the user is notified.
* Added support for the new version column to the MySQL version of the customised string data source.
* Updated the increasingly misnamed CosesEditor to support the versioned strings stuff.
* Factored out some code in the CosesEditor.
* Added version information to all default strings. All default strings are now at version 1.
* Fixed a typo in a FileStrings dump statement.
* Fixed the calls to setProgress in the MySQL user and strings data sources and in the user field factory to use the correct syntax (a parsable dotted string instead of unlocalisable plain English).
* Updated the Generic output module's documentation to match what now happens.
2001-11-22 15:46:42 +00:00
0206bbfc6b
Fix for bug 61634: explain what "Milestone URL" is on the editproducts page.
...
patch by Matthew Tuck <matty@chariot.net.au>
r= caillon, justdave
2001-11-22 15:46:27 +00:00
7ef2e8aa47
Bug 104261 - incorrect template paths. r=myk, ddk.
2001-11-22 06:12:36 +00:00
f363635a93
Fix for bug 99864: consistant use of "product" vs "program"
...
Patch by Josh Soref <timeless@mac.com>
r= dkl, justdave
2001-11-21 19:56:28 +00:00
aeecd12fc5
Bugzilla Bug 93754�describe should be #directable
...
r=justdave,dkl
2001-11-21 16:44:38 +00:00
a3c85a4b84
Fix for bug 102141: SECURITY FIX - the Product popup menu on the show_bug form listed all products, even if the user didn't
...
have access to all of them. It now only shows products the user has access to (and the product the bug is in, if the user is
viewing it because of some other override)
Patch by George Hotelling <george.hotelling@iconideas.com> and Dave Miller <justdave@syndicomm.com>
r= bbaetz, caillon
2001-11-21 08:30:47 +00:00
8e0097b0b6
Bug 110276:SQL error in globals.pl.
...
Patch by me, r=bbaetz,caillon.
2001-11-21 08:09:32 +00:00
222606c397
Added blurb about unified diffs.
2001-11-20 20:16:24 +00:00
fc7bcb91a9
Taint mode note.
2001-11-20 20:11:41 +00:00
ba053594df
Added Javascript, Cookies, and Templatization requirements to Hacking
...
Bugzilla.
2001-11-20 20:09:06 +00:00
b85affb329
Added tip about checking sanitycheck.cgi if you make schema changes,
...
per bug 98049.
2001-11-20 19:56:31 +00:00
c334680554
Removed references to bugzilla.mozilla.org so we can avoid
...
spurious bug postings. However, this file will need some significant
treatment for 2.16 release since the query.cgi interface has changed.
2001-11-20 18:22:30 +00:00
c7b1c4586d
Backing out previous checkin, this file is distributed with Bugzilla, we don't need mozilla-specific information in it.
2001-11-20 18:11:05 +00:00
f0765154a7
Added one liner mentioning that mozilla.org provides only one vote
...
per bug.
2001-11-20 17:46:14 +00:00
a19d4e76a4
Modified Win32 notes regarding system() calls per bug 99595.
2001-11-20 17:26:45 +00:00
bf809cb430
Fixed CPAN locations per bug 97582.
2001-11-20 17:18:03 +00:00
94ac0a442c
Added bit about needing proper <Directory> permissions in order
...
for .htaccess to function. See bug 97668.
2001-11-20 17:09:38 +00:00
1dd927c668
Changed openjade compilation instructions to match new commands
...
required by XML conversion of the Guide.
2001-11-20 16:41:23 +00:00
8b9625c015
Initial conversion to XML format from SGML.
...
Note this is a work-in-progress. It compiles cleanly, but I am not yet
submitting compiled HTML and text.
There is one notable problem: nsgmls barfs on the <imagedata> tag in
database.sgml during validation. openjade handles it fine. Weird.
2001-11-20 16:36:28 +00:00
aff499106e
Removing server-side pageloader data reporting, use client-side scrape mechanism
2001-11-20 06:30:18 +00:00
22b65b48c7
Remove server-side data reporting for pageloader test, use client-based scrape mechanism now.
2001-11-20 06:27:33 +00:00
98e36644c3
bloat.pl not needed, use scrape.pl
2001-11-20 05:42:46 +00:00
94e3253a89
Removing old bloat data reporting stuff, use scrape reporting now.
2001-11-20 05:27:29 +00:00
d46c802b3d
no more startup.dat
2001-11-20 03:50:25 +00:00
9956d2e8f4
startup.pl should use scrape.pl mechanism now.
2001-11-20 03:47:05 +00:00
ce46a32119
startup data goes to scrapt.dat now.
2001-11-20 03:43:27 +00:00
2f64efe730
Fix for bug 109240: fixes the regression that changed the way comments regarding attachment creation are formatted.
...
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org , no second review needed.
2001-11-20 02:59:55 +00:00
838c6271c6
Fix for bug 107120, templates/default/global/header has invalid HTML.
...
Patch removes a <meta> tag as per bug 38856.
Patch by David D. Kilzer <mailto:ddkilzer@theracingworld.com>.
r1=Christopher Aillon <mailto:caillon@returnzero.com>. No 2nd review
required as per caillon.
2001-11-20 01:59:57 +00:00
19dbd1a21b
Bug 98707. Query.cgi rewrite. Patch by me, layout by mpt and others, r=justdave, mattyt. Wahey!
2001-11-18 22:23:31 +00:00
5113e53556
Bug 98707. Query.cgi rewrite, reformatting and templatisation. Patch by me, layout by mpt and others, r=justdave,matty. Wahey!
2001-11-18 22:20:20 +00:00
3f0b596d78
Moving a comment to the right place, in order to be able to make a comment about my previous check in that accidentally got checked in without a comment, and hence didn't show up on Tinderbox I think.
...
It was a change to CGI.pl, a fix for bug 105812: Rename "Components" link in sub GetCommandMenu() to "Products".
The patch was by James A Laska <jlaska@us.ibm.com>.
2001-11-18 03:54:54 +00:00
fd9c2b1485
*** empty log message ***
2001-11-18 03:22:50 +00:00
bb7bdda329
Fix for bug 100788: enter_bug.cgi wasn't correctly interpretting whether or not a partial URL needed an http:// added to the
...
front of it, which had the side-effect of duplicating the http:// on the front when a URL was passed from Bugzilla Helper.
Patch by Josh Soref <timeless@mac.com>
r= justdave, caillon
2001-11-17 23:05:48 +00:00
93abcfb95c
Fix for bug 109354: After entering a new bug, the link offering to add an attachment to the bug you just created pointed at
...
the old attachment form instead of the new one.
Patch by Josh Soref <timeless@mac.com>
r= myk x2
2001-11-17 22:40:02 +00:00
e07bf06a25
Fix for bug 107120: templates/default/global/header was generating HTML that wouldn't validate as HTML 4.01 Transitional
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake, bbaetz
2001-11-17 22:25:15 +00:00
ea04da60e1
Fix for bug 92500: line-feeds were not being properly converted when submitting parameter changes with some Mac browsers.
...
Patch by Gervase Markham <gerv@mozilla.org>
r= ddk, justdave
2001-11-17 22:18:07 +00:00
ccbd1927a9
Backing out previous checkin, it broke the tree. :(
2001-11-17 21:28:24 +00:00
9e45dbe567
Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they
...
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk
2001-11-17 21:12:53 +00:00
8e732cee75
Fix for bug 12284: allow user to specify which columns to display in a bug list
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= gerv, kiko
2001-11-17 21:04:37 +00:00
be09bc22df
Correct some XML errors in the default output strings.
2001-11-17 20:57:42 +00:00
4d3d22fd56
Fix the double testing of .pm files.
...
No review needed for tests at this time.
2001-11-17 17:29:06 +00:00
684e7d2b3e
Bug 104677 : Votes field (text style) on showvotes.cgi defaults to size 5, not natural size and doesn't include a maxlength attribute.
...
Patch by Christoper Aillon <caillon@returnzero.com>.
2001-11-17 10:29:55 +00:00
25d7a72c73
Bug 101560, pt 2. Perl 5.00503 gives a (bogus?) warning which 5.6 doesn't.
...
Quote manually rather than using qw to get arround this
2001-11-17 07:57:25 +00:00
cc44249c91
Bug 101560 - clear some more env vars so that system calls will run in
...
taint mode. The perforce integration stuff needs this.
r=gerv,mattyt
2001-11-17 07:19:46 +00:00
10bf56a918
removing server-side startup data reporting, use client-side TinderboxPrint: now.
2001-11-17 06:52:50 +00:00
cf51b7ef54
leave the update function early if we have not updated anything.
2001-11-16 20:45:24 +00:00
afe028e17c
remove comment which was left over from the original code copy. It refered
...
to some other code.
2001-11-16 20:44:54 +00:00
a0e2e53abb
add support for the Req Ticketing system.
2001-11-16 20:43:30 +00:00
1ede4d5550
Bug 6419 - command-line query tools by Andreas Franke <afranke@ags.uni-sb.de>.
2001-11-15 17:04:58 +00:00
887485d3d7
turn apostrophe into accute accent to work arround netscape bug.
2001-11-14 21:59:55 +00:00
18fc48ad50
document most important change.
2001-11-14 21:25:49 +00:00
1cd8fc493c
admin scripts I use.
2001-11-14 21:24:36 +00:00
3edd568683
my echo statements had leading '$', how did they get there?
...
I added to the test command so that you can see exactly how it was called.
change the example to show how --tree now works.
2001-11-14 21:23:40 +00:00
fc8ddcbf60
make the checkouts of -D be in sync with the tinderbox boxes by ensuring
...
-D is really the start time.
2001-11-14 21:22:13 +00:00
323a86cd04
allow for alternating builds using a single build process.
2001-11-14 21:21:02 +00:00
82f85833db
Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older
...
mysql versions don't support. Remove the checksetup.pl restriction, too.
r=jake x2
2001-11-14 15:12:23 +00:00
0640e35ec9
We don't really need to look for fragments that are pulled in by [% INCLUDE %] or [% PROCESS %]. While removing this code bit doesn't allow us to seperatly check that those fragments exist and compile, they'll be checked atomatically when the the template that wants them is run through the process() routine by the 004template.t test. This issue was raised because bug 98707 introduced a [% BLOCK %] element and the syntax for using that is the same as for including a template fragment.
2001-11-14 03:44:07 +00:00
545feb9f44
Fix license headers and make attachment changed page look like bug changed page. Bug 99518 and 98110. r-myk, no second review.
2001-11-13 17:24:24 +00:00
021098c73b
Fix for bug 86300 - If a bug didn't exist and GetBugLink() tried to create a tooltip for it, you'd get uninitialized variables warnings in your error log. This path also introduces a cache so if the same bug # is mentioned more than once during the same running of the script, it only has to query the database once.
...
r= mattyt, gerv
2001-11-12 13:43:59 +00:00
39e18dd016
Oops. Bug 109690 again, r=justdave, gerv
2001-11-12 05:47:24 +00:00
ed2d22e292
Bug 109690: Check $bug before using it.
...
r=justdave,gerv
2001-11-12 05:39:14 +00:00
48581a451e
Some very primitive default HTML output files for login.accessDenied and login.detailsSent.
2001-11-11 15:37:48 +00:00
1d1d2fdc11
We should be able to access strings with uppercase letters -- oops. Changing regexp to include 'A-Z' as well as 'a-z'. Also adding a dump statement in the failure case to help when analysing the log looking for a bug.
2001-11-11 15:33:59 +00:00
a407bc5001
Missed a return statement in the setupInstall method. This was causing setup to fail every time, because the function returned a defined value. Also took the opportunity to add a call to setupProgress.
2001-11-11 11:54:06 +00:00
42945cc97c
Missed a return statement in the setupInstall method. This was causing setup to fail every time, because the function returned a defined value.
2001-11-11 11:48:14 +00:00
60f8f8e52e
Should have been checking for a defined value, not a true value -- there is nothing to stop a failure from being '0', for instance. (The important thing is to be consistent with the SelectingServiceList code, really, and it uses defined().)
2001-11-11 11:47:02 +00:00
7fd1b0b329
Implement a module to give the main application the ability to add rights and do other configuration related stuff.
2001-11-11 09:36:02 +00:00
f630cad412
Switching to arg form of system call to avoid security hole (76109)
2001-11-11 09:08:56 +00:00
aa60bc0c1c
typo! fixes bug
2001-11-11 08:30:21 +00:00
780bafd2d5
Mute the Net::AIM warnings and add some null-checking code to the close() method.
2001-11-11 08:08:26 +00:00
27d6b3677b
First stab at primitive AIM output support as an alternative to e-mail.
2001-11-11 04:18:09 +00:00
2d2a3a4414
Fix typo (PLIFF->PLIF)
2001-11-11 00:58:48 +00:00
19caa91092
Fix the DESTROY method to actually call the close() method like it was supposed to.
2001-11-11 00:14:07 +00:00
42c3677574
Change the order of the settings so as to match the order in which they are requested. This causes the error message to mention the setting that the user aborted on, instead of some random later setting.
2001-11-10 22:06:54 +00:00
eef789350b
Change createArgument so that we drop the default on the floor -- the default should only be used when explicitly requested (e.g. by the user in interactive mode), not in all cases. CommandLine.pm was in fact already assume that this was the case.
2001-11-10 22:04:34 +00:00
fbdd67e2de
Switching to batch mode involves changing the 'batch' argument, not the one being requested... ahem.
2001-11-10 21:59:13 +00:00
23d64bed66
Bracket shuffling to fix a warning in Perl 5.0.x.
2001-11-10 21:57:07 +00:00
d2161e155f
Handle the case where the user hits Ctrl+D during input, and the case where the user piped a file into us and the file was too short.
2001-11-10 21:53:49 +00:00
9d72a19ae8
Correct an error in the default handler of the namespaced XML walker: we have to shift out the first argument otherwise weird things will naturally happen.
2001-11-10 21:44:28 +00:00
331ec2cf4d
The User object was not saving anything if its userID started off as undef (i.e., new user) and the code never changed any properties (which is normal for a new user). Changed the code to automatically assume it is dirty if it starts with an undefined userID. Changed writeProperties to use the return value from the data source to save any changes to userID, so that when it is defined (by inserting a new record, probably) then we can remember it. Finally, changed propertySet so that when userID is changed from an undefined value to a defined value, the change is propagated to the fields and the groups are marked dirty, which will force them to be written out too.
2001-11-10 21:00:37 +00:00
e64ea5cbbc
Fix the output template to support multiple authentication protocols now that the code is not lying about that.
2001-11-10 20:55:39 +00:00
3721143d6e
Changed a comment in UserField.pm to be more accurate: it is actually safe to change the userID on the fly from an undefined value to a defined value because the code only uses it at two points: creation, if it was defined (used by the caller) and destruction (at which point it is passed to the data source to save any changes).
2001-11-10 20:53:37 +00:00
fcddf1ed99
s/smtp/email/go -- have to be consistent with the rest of the code\!
2001-11-10 20:46:29 +00:00
e079c802fb
Return the user ID even when the user exists, so that there is no need for callers to check the return value.
2001-11-10 20:43:44 +00:00
600f91c209
Fixing ill-formedness error.
2001-11-10 20:34:00 +00:00
89a3414cef
fixing perl error
2001-11-10 20:21:38 +00:00
e487a1691b
Switching to proper log-header variable
2001-11-10 19:26:42 +00:00
710a521be4
implemented getFieldNamesByCategory() in the user data source, and used it to fill in the list of contact methods for the loginFailed output handler.
2001-11-10 10:55:33 +00:00
924ea00e2f
Made the phrase 'or to have your password sent to you,' appear regardless of the value of data.tried
2001-11-10 10:51:10 +00:00
c9028cce74
Fix a typo on the To: line which was resulting in a blank To: field, made the Subject: line be dynamically generated, and made the text actually be useful.
2001-11-10 06:26:28 +00:00
1090fd8014
proper checking for scrape_builds data
2001-11-10 06:01:35 +00:00
59c262180b
Oops, syntax error.
2001-11-10 05:21:17 +00:00
387c5bc05c
Use the actual From: address (now that the outputter tells us what it is...).
2001-11-10 05:12:06 +00:00
c5902010d2
Added another set of data to the data hash: the outputter hash. This will be useful for strings that have to embed things like the e-mail address of the application itself. Added hash methods to the Email and Stdout generic outputter modules to support this change. Renamed 'from' to 'address' in the Email outputter to make it easier to reuse the code (hehe). Also, in the same module, changed some of the comments, changed a double quote string literal to a single quote string literal, and added the word 'configure' where it was missing in one of the dump statements.
2001-11-10 05:00:14 +00:00
c7ad8bda1e
Implement some primitive error handling for sending mail.
2001-11-09 21:59:21 +00:00
33d918a98e
Adding scrapebuilds.pl check
2001-11-09 21:37:02 +00:00
e7cfe96b62
Adding scrape_builds
2001-11-09 21:35:25 +00:00
5d5f512a43
Adding scrapebuilds toggle ui
2001-11-09 21:32:41 +00:00
9b2192655b
Adding scrapebuilds.pl
2001-11-09 21:31:19 +00:00
e383d0629d
Removing unnecessary spammy debug output (this code works now... honest\!)
2001-11-09 21:22:32 +00:00
29e9dfc2dc
Decode %XX-encoded strings.
2001-11-09 21:19:59 +00:00
73179ecb4f
Added some more comments that might help people get this working on Apache.
2001-11-09 20:23:42 +00:00
657b6ffe1a
Factored out the connect/disconnect code, added settings for the host and the from address and made them be handled by a setup.configure handler, wrapped the call to Net::SMTP->new() in a warning-free block.
2001-11-09 20:21:11 +00:00
53e6d5ac79
Adding support for generic saving and retrieving of settings.
2001-11-09 20:13:21 +00:00
0c4ffdbd75
Adding a comment on the use of assert()
2001-11-09 20:09:22 +00:00
dcc2097dae
Refactored the Database::DBI code. Added support for default values in the setup code. Added support to create the database and the user (although some of this may need refactoring into separate MySQL submodules).
2001-11-09 17:23:41 +00:00
0bcc147053
Changing the order of loaded modules to make sure they are set up in the right order.
2001-11-09 17:16:50 +00:00
791fc529b1
Added a missing 'return' statement so that the user.fields setup routine doesn't appear to have failed when it hasn't (without a return statement, the value of the last statement is the return value).
2001-11-09 17:15:13 +00:00
b8414702ac
Changed the DESTROY method to make sure it calls its parent.
2001-11-09 17:13:27 +00:00
0cb23ea40f
Added support for printing the default value for requests.
2001-11-09 17:12:18 +00:00
9d7bf3c600
Added the ability to find the length of an array (array.length to go with array.0, array.1, etc). Added assertions to handle the case of invalid order or sort attributes on <set>. Added two new sort types ('default' and 'reverse default').
2001-11-09 17:10:22 +00:00
725d3308e9
Added two assertions to make sure the handle is defined before using it, and added a check that the handle is defined before releasing it. Also changed the DESTROY method to call its parent.
2001-11-09 17:07:18 +00:00
744e2e3847
Removing excess trailing spaces on one line, and moving a warn from level 5 ('important events') to level 8 ('frequent important events').
2001-11-09 17:03:40 +00:00
20f63b1ced
Fixed DESTROY method to make sure it calls its parent.
2001-11-09 17:00:28 +00:00
4da016547c
Removing the @arguments array from a dump statement, because if any of the elements in the array are undef then a runtime warning is printed (undef elements is not always a bug).
2001-11-09 16:58:38 +00:00
7444cd2f92
Added a level 5 dump indicating the completion of the PLIF program.
2001-11-09 16:56:49 +00:00
b8d1bff110
Fixed DESTROY method to make sure it called it's parent.
2001-11-09 16:52:08 +00:00
f939cf3dd2
Change default DEBUG level from 9 to 4, which is what it should be in production releases. Added comments explaining debug levels 6 (reserved for personal use) and 8. Added level 10 debug info to the DESTROY method (makes it easier to track down bugs during shutdown).
2001-11-09 16:50:47 +00:00
fcf68a1cc0
Made it so the setupEnding event is sent out after the setup failure message is printed but before the setup success message is printed (reduces the number of error messages if you cancel during setup). Changed the semantics of the output.progress string's data.component data. It is now a dotted hierarchical string giving progressively more detail about what is being set up. e.g., 'database', 'database.default.settings', 'database.default.settings.connection.port'. If outputters are interpreting data.component then any trailing unknown levels of detail should be ignored. This allows the setup routines to potentially give much more useful output. Fixed the default stdout output string for setup (it has <text variable=""> instead of value="").
2001-11-09 16:39:29 +00:00
749f837a11
Bugzilla Bug 109138 platform detection not working on macintosh
...
r=bbaetz,dkl
2001-11-09 05:32:43 +00:00
d8061828ca
Fix for bug 109048: fixes error when creating attachments without logging in.
...
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv
2001-11-09 01:11:09 +00:00
1b1a10e431
Also send default values to output.
2001-11-08 17:27:07 +00:00
e4827e8055
Implement default values for arguments. getArgument() and createArgument() now take two parameters like setArgument(). Changed the CommandLine module's createArgument() method so that if the user hits enter at the prompt, the default value is used. Added some comments to clarify what is going on with the 'batch' argument. Changed setArgument() and createArgument() in the Arguments module and createArgument() in the CommandLine module to be more efficient (less array copying).
2001-11-08 17:09:11 +00:00
f0f9512da4
Adding comments to clearly indicate that no dump()s, warn()s or error()s should have a level lower than 5 unless they are not expected to occur during normal operation. Also changing the default level at which the user is notified of problems from 3 to 1.
2001-11-08 16:47:25 +00:00
c944fd6100
Added two new hooks into the setup code: a start notification and an end notification. Added the ability to disable the string datasource (causes it to only use the default strings and not the database). Made the string datasource automatically disable itself during configuration, using the two hooks added to the setup code. This removes the warning messages that are output during a clean setup ('could not get string from database', etc).
2001-11-08 16:42:42 +00:00
7555438b4c
Improved error handling for the case where the database configuration doesn't exist and therefore every output attempt raises database errors. Fatal database errors are now fatal, missing database configurations is not. This would be a lot cleaner if Perl exceptions were objects... Also improved some of the error messages.
2001-11-08 16:10:21 +00:00
8c7914277e
Added a little more level 9 verbose debugging feedback to help track down where output is going wrong.
2001-11-08 05:07:42 +00:00
7c20665250
Stop complaining about the configuration file missing -- if it is not there then just assume there is nothing to worry about. This makes the output of the initial run with the 'setup' argument a lot quieter.
2001-11-08 05:06:27 +00:00
00f010f948
Make the STDOUT generic outputter flush everything it outputs -- this fixes a bug whereby sometimes prompts wouldn't appear until after the user had replied to them.
2001-11-08 05:03:57 +00:00
5e6a01c718
Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
...
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
2001-11-08 03:38:12 +00:00
32f4159790
Fix for bug 104652: Duplicate bugs in the dependency tree now get marked with the message "This bug appears elsewhere in this tree." so users know why the bug does not appear to have dependencies.
...
Patch by Gerv <gerv@mozilla.org>.
r=jake@acutex.net ,myk@mozilla.org
2001-11-08 02:43:55 +00:00
8343293339
Fix for bug 108822: Prevent any user from changing their own groupset.
...
Patch by Jake <jake@acutex.net>.
r=bbaetz,myk
2001-11-08 00:54:15 +00:00
cba5adf358
Fix for bug 108821: Prevent users with any blessgroupset privileges from blessing any group set.
...
Patch by Jake <jake@acutex.net> and Bradley <bbaetz@cs.mcgill.ca>.
r=jake,myk for Bradley's portion, r=bbaetz,myk for Jake's portion.
2001-11-08 00:52:13 +00:00
faff2bf103
Fix for bug 108812: Prevent users from running queries containing arbitrary SQL.
...
Patch by Jake <jake@acutex.net>
r=bbaetz,myk
2001-11-08 00:49:18 +00:00
67cff5d825
Require (temporarily) mysql >= 3.23.5 for the ~ operator, needed for the
...
fix to bug 107718. This should be removed when the group stuff lands (bug
60822).
r=justdave x 2
2001-11-07 22:42:32 +00:00
8262999a16
Bug 101166 - users seeing a bug via _accessible bits should see that its
...
the group
r=justdave,jake
2001-11-07 16:11:33 +00:00
3cdfdecef1
Bug 108547 - Make the JavaScript use proper DOM
...
Patch by Christopher Aillon <caillon@returnzero.com>
r= timeless@bemail.org , kiko@async.com.br
2001-11-07 14:58:56 +00:00
8d66d47bac
Disambiguate the names of the two methods 'hash' and 'sort'. They are now called 'genericHash' and 'genericSort' so as not to clash with the perl builtins 'CORE::hash' and 'CORE::sort'.
2001-11-07 02:49:21 +00:00
354aaaa6f6
Changing the shebang to point to a more likely location of the perl interpreter.
2001-11-07 02:46:38 +00:00
9afda81c2a
Initial checkin of the first PLIF test application.
2001-11-07 01:42:05 +00:00
85bc7a97ee
Refixing bug 71840 - The name should be the 'name' should be the same as what the 'href' points it too...
...
r= justdave@syndicomm.com
2001-11-06 18:06:02 +00:00
cf93f342f9
SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2
2001-11-05 20:47:17 +00:00
65cddcfd90
SECURITY FIX see bug 108516: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to file a
...
bug pretending to be someone else if you edited the HTML by hand before submitting.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
2001-11-05 20:43:35 +00:00
74ecd5d3e0
scrape comment
2001-11-05 08:50:55 +00:00
8dfc5d01e9
Bugzilla Bug 107672 Browser OS/Platform discrimination alg sucks
...
r=bbaetz, jake
Windows XP references are #'d because of bug 92763
2001-11-05 04:44:34 +00:00
f5ab0d9a21
Bug 107718 - mass changes give all changed bugs the groupset of the first
...
bug in the list.
Do bit fiddling instead of adding groupsets from the first bug.
r=justdave, jake
2001-11-03 05:49:23 +00:00
17cd7b028d
remove unused remove_build sub.
2001-11-03 05:14:10 +00:00
95069efe13
Adding multi-line support.
2001-11-03 02:10:05 +00:00
50e9ba7770
Fix for bug 105773: Email addresses in the CC list are now sorted case-insensitively
...
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2
2001-11-03 02:05:43 +00:00
1a437bdad5
cut&paste bug
2001-11-03 01:18:39 +00:00
2eb5f7fa1c
Adding basic scrape functionality. Pick off TinderboxPrint: token and print the argument in the corresponding build box. Currently limited to one line, multi-line change coming next.
2001-11-03 00:50:13 +00:00
b551cab760
Adding scrape.dat
2001-11-02 22:55:09 +00:00
a7306dfd1f
Switching to TinderboxPrint:aaa,bbb,ccc format. r=pchen
2001-11-02 22:41:40 +00:00
dcfb5d6374
Fix for bug 95615: cosmetic change to clarify error message when trying to use too many votes
...
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2
2001-11-02 20:05:13 +00:00
0699f99205
Adding scrape scan.
2001-11-02 09:43:12 +00:00
62ac6bc208
Tinderbox,aaa,bbb,ccc,ddd format.
2001-11-02 09:37:35 +00:00
05281255b8
General purpose version of bloat.pl
2001-11-02 05:22:00 +00:00
c3dc15ab8b
no warn.pl anymore
2001-11-02 05:20:25 +00:00
4e57ea4f39
Checking in fix for bug #86920 , fix from jake@acutex.net
2001-10-31 04:30:33 +00:00
c5aeb3016c
Checking in patch for bug #44641 , patch from Ian Wells
2001-10-31 04:20:28 +00:00
a84ddb446f
Checking in patch for bug#36597, patch from miri@punknet.cz
2001-10-31 04:07:25 +00:00
811101a3b4
Fixing tinderbox bustage (removing <Tab>s and adding a "use vars" line)
2001-10-31 03:31:00 +00:00
a07f057d55
Have the tests test .pm files as well, yes this creates bustage, this is
...
intentional!
No review needed for tests at this time.
2001-10-31 01:06:31 +00:00
6b4b5c2b1e
Fix test bustage by removing tabs.
2001-10-31 00:21:28 +00:00
e67b38e912
Fix for bug 98602: re-implementation of "create attachment" page.
...
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org ,jake@acutex.net
2001-10-30 23:42:22 +00:00
d3e20732b5
Fix for bug 96675: checksetup should require admin e-mail address satisfy emailregexp. This fix has
...
checksetup.pl use the emailregexp set in params if the params file exists, or ensures that it matches the
default emailregexp from defparams.pl.
r1=justdave, r2=bbaetz.
2001-10-28 03:40:59 +00:00
4d2830186b
A few enhancements to the template test:
...
* If there's a compilation error, report what it is
* Don't try to compile a template if it doesn't exist
- We already tested for that and issued an ERROR
* Define the 'url' FILTER
2001-10-27 15:27:31 +00:00
96664b4739
Bug 105879 - Footer links have an extra | by Sanity Check
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com , jake@acutex.net
2001-10-26 18:49:33 +00:00
e101daceeb
Bug 81594 - SQL error after editing user entry when changing numerous things at once (including the login name).
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com , jake@acutex.net
2001-10-26 18:35:04 +00:00
745a1518eb
Check templates for tabs, also.
2001-10-26 13:21:38 +00:00
85615413b7
Change %f to %d for page load times.
2001-10-26 06:37:31 +00:00
2219cf5bf4
Use ms instead of s for pageloader time.
2001-10-26 06:32:58 +00:00
e41d92589f
Fix for bug 98602: re-implementation of "create attachment" page.
...
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org ,jake@acutex.net
2001-10-25 20:37:53 +00:00
45dc65778f
Bug 104065 - Stop uninitilized string warnings from getting into the error log when the login cookie doesn't exist.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= gerv@mozilla.org , jake@acutex.net
2001-10-25 14:46:58 +00:00
926fc6c1f9
Bug 104540 LXR updates for .idl collaboration diagrams
...
by mozilla@elemental.com (Brian Bramlett)
r=endico
2001-10-25 01:05:07 +00:00
9db53c7a32
Fixed "used only once" warning coming from my patch for bug 97469. The
...
warning was hidden from the tests by bug 106424.
r=Jake, no 2nd review needed.
2001-10-24 20:33:49 +00:00
5f621e5961
Don't rely on the TEST_VERBOSE environment variable (no longer exported from runtests.sh) and instead print to the TESTOUT file handle pulled in from Test::More. This will allow the testing backend to check for verbosity rather than having to handle it in the .t files.
2001-10-24 18:41:53 +00:00
282e2eab08
Bug 106424 - We weren't going orange on warnings such as "used only once". This script now properly outputs the --WARNING and fails on such a condition.
2001-10-24 13:29:49 +00:00
75faca54fd
Fix for bug 106315: Link on bug list for emailing QA contacts.
...
Patch by Dave Miller <justdave@syndicomm.com>.
r=myk@mozilla.org , no second review needed.
2001-10-24 01:31:09 +00:00
afa66d34ff
Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
...
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.
Also fxed bug 101560, by clearing BASH_ENV
r=myk,justdave
2001-10-23 15:44:53 +00:00
d6397d0d5a
Bug 63249 - The Bug Counts report was running very slowly due to unneeded fields/joins in the SQL query.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org , jake@acutex.net
2001-10-23 14:45:45 +00:00
78adb43687
Fix missing description problem for options that required multiple lines for the description.
2001-10-21 19:11:25 +00:00
cd5915781c
Bug 71840 - Make comments referenceable using a #c4 to get the fourth comment.
...
Patch by Gerv <gerv@mozilla.org> and Myself.
r= jake@acutex.net , gerv@mozilla.org , justdave@syndicomm.com
2001-10-20 13:03:14 +00:00
2edcc77a4b
Backing out previous change, the wrong patch got checked in.
2001-10-20 12:59:57 +00:00
2c9c137ea1
Bug 71840 - make comments referenceable. Patch by gerv/jake. r=justdave, jake/gerv.
2001-10-20 01:06:59 +00:00
3b1570750c
Bug 105480 - Use the friendly name from the fielddefs table when reporting strictvalue errors if it's available.
...
Patch by James A. Laska <jlaska@us.ibm.com>
r= justdave@syndicomm.com , jake@acutex.net
2001-10-20 00:50:27 +00:00
d1b5c1f437
Bug 104340 - Changing the UI of the toolbar for hiding bugs in the dependency tree.
...
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com , gerv@mozilla.org
2001-10-20 00:22:52 +00:00
3905de3eb0
Bug 73180 - We now put a notice at the top of the versioncache file saying that it should not be edited.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org , jake@acutex.net
2001-10-19 23:49:37 +00:00
86dccb7385
Bug 103664 - Tests should "use strict;" and not contain any tabs. We should also use the TEST_VERBOSE environment variable instead of VERBOSE.
...
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
Additional edits by myself to add the emacs mode line. Also, the change to runtests.sh was done by me.
2001-10-19 22:39:51 +00:00
1755af2c9d
Fix for bug 105365 - Hacker's Guide should be in SGML. This will make it easier to do other additions to the hacker's guide.
2001-10-19 16:18:10 +00:00
21fe682b44
yet another meaningless whitespace change to test tinderbox with
2001-10-19 13:03:52 +00:00
8febda1bc1
another useless whitespace change to test tinderbox with
2001-10-19 06:19:52 +00:00
dd631f42a6
Adding one more sig fig for startup time.
2001-10-19 06:15:24 +00:00
eda1eed498
switching search token to __avg_startuptime, we are going to iterate the test now and report an average time.
2001-10-19 05:56:38 +00:00
4c8e89a6a6
whitespace change to test tinderbox again.
2001-10-19 05:33:23 +00:00
d7672429e0
whitespace change to do a test checkin to see how tinderbox reacts
2001-10-19 04:36:19 +00:00
kestes%walrus.com
mcafee%netscape.com
ian%hixie.ch
jake%acutex.net
myk%mozilla.org
timeless%mac.com
justdave%syndicomm.com
gerv%gerv.net
matty%chariot.net.au
barnboy%trilobyte.net
zach%zachlipton.com
bbaetz%cs.mcgill.ca
tara%tequilarista.org
waterson%netscape.com
seawood%netscape.com