276a4fa320
* Implemented dispatcher.output service in CosesEditor.pm
...
* Implemented dispatcher.output.generic service in CosesEditor.pm
* Fixed a semantic error in the string data source
2001-06-23 04:07:21 +00:00
b3fa6accc6
(this checkin comment applies to the previous checkin on this file as well)
...
* Added some comments to various files indicating work to do and documenting some methods
* Fleshed out the Strings Data Source API (and implemented it in the MySQL version)
* Added the name "MySQL" to the MySQL-specific ID method of the Database Helper
* Factored out the XML parser dependency into an XML service
* Added a generic content sink implementation to the XML service
* Added a convenience method for manipulating user settings
* Added and implemented all the COSES commands
* Removed trailing spaces
2001-06-23 00:20:22 +00:00
d21968d31c
* Added some comments to various files indicating work to do and documenting some methods
...
*
2001-06-23 00:10:43 +00:00
612f397227
Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checksetup.pl, so the change to them during doeditparams was nullified if you updated. Other recent changes have nullified the reason for changing it in editparams anyway, so just backing that part out.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-21 15:03:11 +00:00
d0985be7f8
Fix for "used only once" error reported by tinderbox after the last checkin. (Aaargh!)
2001-06-21 02:42:41 +00:00
208706e674
Fix for bug 47914: buglist.cgi always had a not-logged-in footer if you were unlucky enough to have a login cookie that got corrupted in the shadow database. This patch makes buglist.cgi switch back to the primary database before looking up your login cookie for the footer.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-21 02:02:30 +00:00
336f1bf129
Fix for bug 86447 - ChangeFieldType() wasn't dealing with 'not null' properly.
...
r= justdave@syndicomm.com
2001-06-20 01:37:19 +00:00
1e6085864c
Fix for bug 85833: show_bug.cgi (and probably others) now allow leading or trailing spaces in the bug id, to allow for user input error. This used to work, and recent bug validation changes broke it.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-19 22:48:21 +00:00
e9d91b0a04
Fix for bug 45918: the old password field on the userprefs page is now used to log you back in if you try to change your password with cookies turned off, which avoids the confusing login screen after entering your new password in which you used to have to enter your old password one more time in order to let it set your new password (yes, it used to be as confusing as that just sounded :)
...
r= tara@tequilarista.org
2001-06-19 22:02:53 +00:00
4b69b94fcd
Changing despot owner to endico@mozilla.org with her permission
2001-06-19 04:04:34 +00:00
1a56480df1
Running a query using the Added Comment option was very slow (bug 57350).
...
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-19 02:05:08 +00:00
06a95c3b47
Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes".
2001-06-19 01:37:02 +00:00
b56688d21e
Allow '\' as a path delimiter (bug 29064)
...
Patch Concept by <timeless@mac.com>
r= jake@acutex.net
2001-06-18 23:13:18 +00:00
46dd08d79f
Fix for bug 85832 - QuickSearch should strip leading and trailing spaces.
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-18 19:24:17 +00:00
7d0248c021
applying handy patch to refix version table to be 64 instead of 16--partial fix of bug 9352
2001-06-16 23:01:12 +00:00
583e8ba725
Fix for bug 71396 - $::db->do isn't needed anymore
...
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-06-16 14:51:16 +00:00
4c159e297e
Fix for bug 83619 - QuickSearch was crashing Netscape 4.76 and 4.77 on Unix
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-15 20:16:59 +00:00
aced5efdec
Checking in the cleaner version of the fix for "No Available Products". This was attached to bug 65311.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-14 20:02:31 +00:00
11d8239204
Backing out previous changes as there was a better patch already attached to a different bug
2001-06-14 20:00:03 +00:00
c52c3207f3
Bugzilla shouldn't display empty header in the New: email notifications (bug 85734)
...
r=timeless
2001-06-14 14:16:27 +00:00
d12c665fae
Fix for bug 84596: Syncshadowdb wasn't using the db_user and db_pass from localconfig, which meant that it previously wouldn't run unless it was running under a user that had access to the bugs and shadowbugs dbs and didn't have a password. It now looks for db_user and db_pass and specifies them on the command line to mysqldump and mysql if they're in use.
...
r= tara
2001-06-10 17:38:15 +00:00
0caf63ff4b
Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works.
...
r= tara
2001-06-10 17:15:56 +00:00
f3b1e25aea
Give a logical error message if no products are available to a user for bug entry (bug 84285).
...
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net
2001-06-08 13:12:13 +00:00
89f9bad83e
Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
...
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-07 21:26:49 +00:00
e5c14c816c
Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-07 20:26:40 +00:00
88476cc75c
fix typo
2001-06-07 01:31:51 +00:00
8da17e3922
Fix "used only once" error, per tinderbox build log.
2001-06-06 23:09:54 +00:00
6a4944b94c
Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
...
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-06 21:17:42 +00:00
fa59d128b6
Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net , tara@tequilarista.org
2001-06-06 21:10:47 +00:00
48ffd8c640
Users should only be able to view attachments if they can view the bug that the file is attached to (bug 70189)
...
r=tara
2001-06-06 18:36:25 +00:00
79fc592bf7
Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295).
2001-06-06 14:25:18 +00:00
7337f9ee7a
Fix for bug 39557: doeditvotes.cgi will no longer create a vote record for a nonexistant bug if the HTML is tampered with or other bugs cause bad bug numbers in the submitted form.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 04:51:55 +00:00
16951bbe32
Fix for bug 82781: describecomponents.cgi now checks viewing permissions to make sure you can see a product
...
Patch by Myk Melez <myk@mozilla.org>
r= tara@tequilarista.org
2001-06-06 04:32:45 +00:00
1e4536e632
Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-06 04:28:52 +00:00
72e876fa2d
Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 03:16:52 +00:00
b0ae801a6f
* Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables
...
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts
2001-06-04 06:13:22 +00:00
008ca7535f
Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components
2001-06-03 23:06:09 +00:00
4e83d4d77b
Moved AdminCommands.pm and Login.pm to a Component directory
2001-06-03 22:45:37 +00:00
eb1fb18fb5
Minor bug fixes required to make the code run without crashing...
2001-06-03 16:14:41 +00:00
17da5d7b8a
Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking)
2001-06-03 15:27:16 +00:00
f71bddbcc2
Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles!
2001-06-03 14:49:41 +00:00
0157ac85b3
* Added some comments (including some XXX comments where I realised we had missing code)
...
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.
2001-06-03 10:11:58 +00:00
71c26619d6
Landing Myk's patch for bug #71767
2001-06-02 22:02:02 +00:00
7e84b3b87a
sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-02 14:24:45 +00:00
bf46713283
Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-02 04:02:13 +00:00
6887947dcb
Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-02 03:19:26 +00:00
c6f5cbc4aa
Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:57:22 +00:00
16c44fa582
Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:53:01 +00:00
40da63cff5
More leak pluggin. This one fixes bug 39526.
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-01 13:38:01 +00:00
6e938b4597
Fix for bug 83633: perl warnings in 5.6
...
r= Hixie
2001-06-01 10:03:52 +00:00
ian%hixie.ch
justdave%syndicomm.com
jake%acutex.net
dmose%mozilla.org
tara%tequilarista.org