4bb3a24d67
Change callers to use new nsIFrame overflow APIs. (Bug 542595, patch 20) r=roc a2.0=blocking2.0:beta8
2010-10-06 21:25:47 -07:00
3ac4e6a8d6
Fix miscellaneous reflow methods to use new overflow area APIs. (Bug 542595, patch 19) r=roc a2.0=blocking2.0:beta8
2010-10-06 21:25:46 -07:00
caeb4fbd2d
Bug 572649 - Attempting to scroll a textarea with a horizontal scrollbar using the mouse jumps to its bottom right (focusing a textarea with the mouse scrolls the selection into view); r=roc a=blocking-betaN+
...
--HG--
rename : layout/forms/test/test_bug353539.html => layout/forms/test/test_bug572649.html
2010-09-20 19:30:07 -04:00
a5bd7779d0
Bug 557087 (3/6) - Make layout aware of the new disabled state rule. r=dbaron a=sicking
...
--HG--
extra : rebase_source : 9e7d0a515c3f1bcacdcccc906c611849654ab484
2010-09-19 03:43:15 +02:00
ddc27c5ad6
Back out bug 588712 and bug 595337 due to leaks and test failures. a=orange
2010-09-14 23:04:50 +05:30
390e0c4132
Bug 595337 - Crash [@ nsTextEditorState::InitializeKeyboardEventListeners] on print preview close with iframe, position:fixed and input r,a=roc
2010-09-13 16:36:43 -04:00
083078d645
Bug 240933 - Part 9: Simplify text control frame's DOM point to offset conversion code; r=roc a=dbaron
...
--HG--
extra : rebase_source : 1ed8187ad31ca40bd0b4d5a5a3c7494aacfee495
2010-07-20 08:47:28 -04:00
8a7fe3ff4d
Rename -moz-box-shadow to box-shadow: mechanical changes. (Bug 590039) r=bzbarsky a2.0=blocking2.0:beta6
...
Generated with:
find * -type f -exec sed -i -e 's/\<MozBoxShadow\>/boxShadow/g;s/-moz-box-shadow/box-shadow/gi' {} \;
2010-09-11 09:27:12 -07:00
c77957d25b
Change blur radii in themes and in some tests to match change in how we interpret text-shadow and -moz-box-shadow blur radii. (Bug 590039) r=dao a2.0=blocking2.0:beta6
2010-09-11 09:27:12 -07:00
225ef1286e
Bug 591325 Fix regression due to relativesrcdir landing in xpchsell test, continued cleanup in chrome tets r=ctalbert a=NPOTB
2010-09-10 10:20:38 -07:00
00f202c9fa
Bug 451134 (1/2): switch to the official border-radius property names: purely mechanical changes. r=dbaron a2.0=blocking2.0:beta6
...
This was generated with the command:
LC_ALL=C grep -irlEZe '[-_]moz[-_]border[-_]radius([-_](top|bottom)(right|left))?' * | xargs -0 perl -pi -e \
's/-moz-border-radius-(top|bottom)(left|right)/border-${1}-${2}-radius/gi;
s/_moz_border_radius_(top|bottom)Right/border_${1}_right_radius/g;
s/_moz_border_radius_(top|bottom)Left/border_${1}_left_radius/g;
s/-moz-border-radius/border-radius/gi;
s/_moz_border_radius/border_radius/g;'
2010-09-09 08:21:47 -07:00
f5af27e90e
Clip contents of elements with overflow != visible to the border radius. (Bug 459144, patch 14) r=roc a2.0=blocking2.0:beta6
2010-09-09 08:21:46 -07:00
ec704773ad
Make nsIFrame::DisplaySelectionOverlay take an nsDisplayList* instead of nsDisplayListSet&. (Bug 485501) r=roc a2.0=blocking:beta6
2010-09-09 08:21:46 -07:00
583b8917f4
Use nsIFrame::GetBorderRadii so that we pick up when it is overridden. (Bug 459144, patch 7) r=roc a2.0=blocking:beta6+
2010-09-07 15:20:35 -07:00
2ba0a36460
Bug 583863: Refactor <input> implementation to deal with files that aren't on the disk. r=sicking a=blocking-fennec
...
--HG--
extra : rebase_source : 2b3605042aea4e4c8273cdad5ec7f05af15959cc
2010-09-05 14:00:05 -04:00
ff605f156a
Backed out changeset af1365b24066
2010-09-05 11:32:57 -04:00
55184b48c6
Bug 583863: Refactor <input> implementation to deal with files that are not on the disk. r=sicking a=blocking-fennec
2010-09-05 09:09:04 -04:00
05dd2c5a12
Back out bug 240933 and bug 590554 because of reftest failure on Win7 and also bug 593211
2010-09-02 19:54:23 -04:00
3defea6edd
Bug 240933 - Part 9: Simplify text control frame's DOM point to offset conversion code; r=roc a=dbaron
...
--HG--
extra : rebase_source : 134895e08a57c7aeb39f25266d8925cde4595159
2010-07-20 08:47:28 -04:00
3f755b35dd
Bug 36619 - Add a test checking that we can call .click() to show the filepicker if the originating element is a regular click (thus passing the popup blocker check). r=sicking a2.0=blocking
2010-09-01 08:09:28 +02:00
70a219e76b
Bug 579323. Part 1: Add FrameLayerBuilder::InvalidateThebesLayersInSubtree, and call it from InvalidateOverflowRect. r=tnikkel,sr=dbaron
...
--HG--
extra : rebase_source : c1dbc5b625e23d55ba030709f5cd429122977685
2010-08-31 12:46:26 +12:00
7c2828ef05
Disabling failing test for now. a=dholbert|sheriff for CLOSED TREE
2010-08-27 14:02:23 -04:00
f142eb0a5d
Tests for Bug 36619 r=sicking a=blocking
2010-08-27 11:49:10 -04:00
b3bcc9aa67
Bug 36619 - allow file input .click() to bring up filepicker r=sicking a=blocking
2010-08-27 11:49:06 -04:00
693416bb89
Bug 590302 - Crash [@ nsTextControlFrame::CalcIntrinsicSize] on print preview with textarea, position:fixed; r=roc a=blocking2.0:final+
2010-08-25 01:44:18 -04:00
64c4e38da6
Bug 584282. Use nsDisplayItem::ToReferenceFrame() instead of calling nsDisplayListBuilder::ToReferenceFrame, wherever possible. r=tnikkel,a=dbaron
...
--HG--
extra : rebase_source : 730ba8640cb37bd8484ff069b5d6fd46d9bc3e84
2010-08-13 22:01:58 +12:00
4b2e3494b8
Bug 584282. Add nsDisplayItem::mToReferenceFrame and initialize it in the constructor. r=tnikkel,a=dbaron
...
--HG--
extra : rebase_source : 496cbde7c495eb8872c3d0ffc0ca4c57c2a6a777
2010-08-13 22:01:13 +12:00
52a90eea8e
Bug 587530 - Put nsICapturePicker in the properly named xpt, and package it for Firefox, r=roc, a=gavin
2010-08-15 18:37:53 -07:00
957a298bce
Bug 568441 - Explicitely show the caret in nsTextControlFrame when the content is no longer disabled and focused. r=roc a2.0=blocking+
2010-08-15 11:19:34 -04:00
d272840c23
Remove unneeded nsIDOMNSHTMLInputElement interface by merging it into nsIDOMHTMLInputElement. (Bug 582303) r=jst
2010-08-04 22:40:18 -04:00
b64f460e63
Bug 578604 - Crash [@ nsTextControlFrame::SetInitialChildList(nsIAtom*, nsFrameList&) ] when print preview; r=roc a=blocking2.0+
2010-08-04 22:13:57 -04:00
10594e918c
Fix bustage from bug 570329 with s/windowsWidget/winWidget/g.
2010-07-30 20:50:52 -07:00
b2e63de23c
Switch reftest manifests to new, shorter syntax for widget toolkit tests. (Bug 570329) a2.0=tests
...
This patch was created by running the following sed commands:
s/MOZ_WIDGET_TOOLKIT=="\(gtk2\|cocoa\|qt\|windows\)"/\1Widget/g
s/MOZ_WIDGET_TOOLKIT!="\(gtk2\|cocoa\|qt\|windows\)"/!\1Widget/g
on all *.list files in the tree.
2010-07-30 16:48:57 -07:00
ce613918a6
Bug 578588 - Test suite may not work correctly on Win64 because navigator.platform is Win64. r=sayrer, a=Test Only
2010-07-30 17:18:45 +09:00
83ff4cd04a
Remove unneeded nsIDOMNSHTMLSelectElement interface by merging it into nsIDOMHTMLSelectElement. (Bug 582303) r=jst
2010-07-28 16:43:52 -07:00
fd81de054a
Bug 567323: Layout bindings for camera. r=sicking sr=roc
2010-07-23 14:35:51 -07:00
0217f8561d
Back out bug 567323 because of consistent Mochitest-4 errors:
...
1530 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/forms/test/test_bug411236.html | Test timed out.
1578 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/forms/test/test_bug534785.html | Test timed out.
1702 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/forms/test/test_bug563642.html | Test timed out.
1709 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/forms/test/test_bug564115.html | Test timed out.
2010-07-23 16:16:39 -04:00
18972f50e4
Bustage fix for Bug 567323
2010-07-23 11:24:49 -07:00
8c6a068337
Bug 567323: Layout bindings for camera. r=sicking sr=roc
2010-07-23 10:58:58 -07:00
e9c6bd7bea
Bug 566466 - speed up createElement(), r=jst, peterv
2010-07-23 12:49:57 +03:00
78c56717df
Bug 569397 - Eagerly initialize the input controls with spellcheck="true"; r=roc ui-r=faaborg approval2.0=benjamin
2010-06-02 22:39:29 -04:00
83d57fba16
Bug 549475: Implement HTML5-specified value sanitization algorithm for HTMLInputElement. r=sicking,ehsan,bsmedberg sr=jst
...
--HG--
rename : layout/reftests/editor/newline-1.html => layout/reftests/editor/newline-4.html
2010-07-21 02:11:19 +02:00
9235241113
Bug 574570: Followup to address missed review comment.
2010-07-21 09:12:19 -07:00
4eeaf179df
Bug 574570: Parse the 'accept' attribute in accordance with the HTML5 spec. r=sicking,volkmar
2010-07-21 09:07:55 -07:00
cf96564254
Bug 565272: Implement the accept attribute for audio/*, video/*. r=sicking
2010-07-17 00:00:28 -07:00
12a1a65607
Bug 564991. Part 3: Create unique nsDisplayItem types for every single display item. r=tnikkel
2010-07-16 09:07:49 +12:00
1998eeabf2
Bug 553576, change -moz-resize to resize, r=dbaron
2010-07-05 10:41:04 -04:00
81f8091b20
Bug 563878. Part 5. Rename nsIFrame::GetWindow(Offset) to GetNearestWidget. r=mats
2010-07-02 14:11:04 -05:00
d7cb16f9a4
Add bug numbers for all remaining asserts() annotations in crashtests and reftests
2010-07-01 19:33:56 -07:00
94ef4d2ac3
Merge mozilla-central to the bug 568691 branch.
...
--HG--
rename : gfx/public/nsITheme.h => gfx/src/nsITheme.h
2010-06-30 14:23:23 -04:00
a29563d496
Don't override the filepicker CID, just the contractID in this test: required because of the changes in bug 568691.
2010-06-25 11:34:10 -04:00
d513ca2acf
Bug 574898 - "ASSERTION: called nsGenericElement::SetText" with spellcheck; r=roc
2010-06-28 14:04:37 -04:00
fa0b9ecc8b
Bug 573706 - make frame based accessible creation more pellucid, r=davidb, sr=roc
2010-06-28 21:02:03 +09:00
50d4d2c2ea
Bug 571352 - <select multiple> does not reset the anchor <option> properly when the anchor is removed. r=bzbarsky
2010-06-27 22:53:47 +02:00
736c6f6527
Remove stray line breaks from NS_ERROR messages, since they interfere with log processing. rs=jst
...
--HG--
extra : rebase_source : 87421691da969e0ebe5fbfbc44cd8f18617d1351
2010-06-17 13:28:38 -07:00
c7c5144bb6
Add some crashtests and reftests
...
--HG--
extra : rebase_source : a167ccf140387fa50e3668422b5a74bea0527255
2010-06-17 13:21:24 -07:00
28e4721900
Bug 572406 - Test that the value is correctly updated when the firstChild.nodeValue of a textarea is changed; r=ehsan
2010-06-16 12:36:12 -04:00
ef89685d4e
Bug 570624 - "ASSERTION: called nsGenericElement::SetText"; r=roc
...
--HG--
extra : rebase_source : 24d41a8eccef1c6d8b3adc6a04ca1a20912263ef
2010-06-09 14:14:42 -04:00
bff9ad37a8
Add a bunch of crashtests
2010-06-08 17:53:08 -07:00
69fb28434c
Bug 534785 - Move the ownership of editor and selection controller from the text frame to the content node; r=roc,jst sr=roc
...
(transplanted from 2437636244f39bbdc7d20b062e2c978b9d85c239)
--HG--
rename : layout/reftests/forms/placeholder/placeholder-14.html => layout/reftests/forms/placeholder/placeholder-18.html
extra : transplant_source : %247cbD%F3%9B%BD%C7%D2%0B%06.%2C%97%8B%9D%85%C29
2010-04-21 16:17:41 -04:00
198a1e4114
Bug 568373 - Use "Desktop" on all platforms; r=roc
2010-05-31 09:55:06 -04:00
adb709b5e9
One more bustage fix for bug 568373
2010-05-30 21:53:03 -04:00
b27cf250ee
Bug 568373 - Use "Desktop" for Windows, because apparently we don't have a useful notion of "Home" on Windows
2010-05-30 21:50:11 -04:00
6d1cdd8d9b
Bug 568373 - test bustage fix
2010-05-30 19:44:10 -04:00
6ebf9f5105
Bug 568373 - Private browsing saves the path of Uploaded files in Gmail; r=roc
2010-05-30 18:54:34 -04:00
cd6846690f
Bug 336104 - "ASSERTION: no frame, see bug #188946"; r=roc,dbaron
2010-05-21 16:36:42 -04:00
d96cee98fa
Bug 565569. Set primary frame for anonymous text in buttons. r=mats
2010-05-21 15:20:48 +12:00
32ef4c4bf5
Try to fix test_bug536537
2010-05-20 00:35:37 -04:00
2f314e0803
Bug 377624 - [Test Part] "Implement the accept attribute for the form and file upload controls form "image/*"" [r=sicking, feedback=ehsan]
2010-05-19 22:28:08 -04:00
afd8698c25
Bug 377624 - "Implement the accept attribute for the form and file upload controls form "image/*"" [r=enndeakin,roc]
2010-05-19 22:28:01 -04:00
cb3b3e8e7b
Bug 560647 - add startup timeline instrumentation; r=vlad
2010-05-19 19:22:19 -04:00
009fde6aa1
Bug 565775 - The editor will not be correctly initialized for <input type=tel> on user events; r=roc
2010-05-13 18:56:24 -04:00
b8a5f835e8
Back out part of fix for bug 538062 to fix accessibility tests
...
--HG--
extra : rebase_source : ffdabcf1caa16e68fa654e4f2830ffd235be91be
2010-05-13 14:52:39 +12:00
640996ce06
Bug 538062. Remove mTextFrame field from nsComboboxControlFrame since it's no longer needed. r=mats
2010-05-13 12:56:11 +12:00
66ca95d73c
Bug 538062. Call SetPrimaryFrame when we create the text frame for the text content in the display node of a combobox, so that the text frame will be notified when the content changes. r=mats,sr=dbaron
2010-05-13 12:56:09 +12:00
5063fb7171
Bug 557620 - Implement <input type="tel">. r=smaug,dolske,dao sr=sicking
2010-05-12 09:17:07 +02:00
d612ab1550
Bug 564115 - activating the browser window scrolls the document (to show the focused text control); r=roc
2010-05-06 19:19:35 -04:00
f93efd7b6f
Bug 562447 - when navigating in gmail sometimes get a screen full of white; r=roc
2010-05-06 18:12:21 -04:00
ed08b322dd
Bug 564574. Pass the first appended node to ContentAppended. r=jst, sr=sicking
2010-05-10 21:12:34 -04:00
e00d9fd996
Annotate remainder of crashtest mainfests (all but one test) with the tests that are known to assert. (Bug 472557)
2010-05-06 09:28:01 -07:00
462871ffa0
Test for bug 365410.
2010-05-06 17:37:40 +02:00
b7519d1272
Make PAGE_UP/DOWN scroll at least 1 item, if possible. b=563642 r=bzbarsky
2010-05-06 17:37:40 +02:00
86a0160673
Bug 365410. Set our mNumDisplayRows even if we have a height set. r=mats
2010-05-05 14:18:04 -04:00
1122c69800
Part 1 of fix for bug 560273 (Stop using DOM tearoffs from quickstubs) - add nsINode::GetBaseURI. r=sicking.
...
--HG--
extra : rebase_source : 5a07f12d9d13d92b796fd5f2cb182b069c3f87bf
2010-04-19 17:40:15 +02:00
3a279be650
Bug 429175: Make sure to only set aNotify to true when we should. r=peterv
2010-05-03 06:23:36 -07:00
9b6c3b34d0
Bug 562688 part 12. Eliminate eELEMENT usage in the rest of layout except layout/style. r=dbaron
2010-04-30 09:12:06 -04:00
3d1b2b634a
Bug 560095 - Use mozilla::services::GetObserverService(). r=biesi,dveditz,gavin,josh,jst,mrbkap,roc,sdwilsh,shaver,sicking,smontagu,surkov
2010-04-29 18:59:13 +02:00
e038066235
Bug 559710 - Don't add a br node under text controls when the editor is not initialized for them yet; r=roc,davidb a=1hr
2010-04-15 21:25:40 -04:00
9a20a613e9
Bug 418521, improve the way focus indicators are displayed to correlate better with system behaviour, add -moz-focusring property to apply only when focus rings should be drawn, r=dao,jmathies,dbaron sr=neil
2010-04-21 10:53:42 -04:00
e66cb3f76e
Bug 559819 - Change the string id for the isindex prompt. r=l10n.
...
--HG--
extra : rebase_source : 34212e52674deb7e3c20ef3dab91785d3f70bdf4
2010-04-20 17:19:30 +03:00
e652002cac
Bug 560271: Reorder nsTextControlFrame constructor init list to fix build warning. r=ehsan
2010-04-19 12:00:45 -07:00
c387f6152a
Bug 558954 - Don't show/hide placeholder if we're about to initialize the editor; r=roc
2010-04-12 20:32:29 -04:00
cc201a3c58
Bug 557689 - Mochitest-3 (debug) crash after running test_bug366682.html or test_selection_move_commands.xul as a result of bug 542919 [@ nsCOMPtr<nsIMutationObserver>::assign_with_AddRef] (underlying issue will be fixed in bug 534785); r=jrmuizel
2010-04-12 02:13:17 -04:00
3980f7ac34
Bug 221820 - Part 7: Wrap the calls to nsTextControlFrame::EnsureEditorInitialized in a weak frame check; r=roc
2010-04-06 16:44:46 -04:00
78abac833e
Bug 221820 - Part 6: Fix a failing test; r=bzbarsky
2010-04-06 16:44:12 -04:00
28d5dc53e9
Bug 221820 - Part 5: Make lazy editor initialization compatible with placeholder values; r=bzbarsky
2010-04-06 16:43:39 -04:00
04551d011d
Bug 221820 - Part 4: Fix the newline handling for text fields without an editor; r=bzbarsky
2010-02-22 16:15:56 -08:00
e15a112510
Bug 221820 - Part 3: Debug-only assertion for reentrancy detection; r=bzbarsky
2010-02-09 20:29:11 -05:00
60528bbd3e
Bug 221820 - Part 2: Make the editor initialization lazy (initialize only when needed); r=bzbarsky
2010-02-02 10:49:55 -05:00
cdeff48269
Bug 221820 - Part 1: Call EnsureEditorInitialized from all places where editor needs to exist; r=bzbarsky
2010-02-01 23:00:12 -05:00
7a8c29d63b
Bug 542919 - Maintain the exact same behavior in editor initialization (don't try to set the editor value if the default value is empty) in an attempt to fix the crash of bug 557689
2010-04-11 16:00:36 -04:00
f25c7f50e1
Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
2010-02-01 23:00:06 -05:00
dcddb98106
Bug 557416: Remove unnecessary includes and forward declarations of nsPresContext. r=roc
2010-04-10 16:10:12 -04:00
9d6c65cee7
Bug 557416: Remove unnecessary includes and forward declarations of nsIPresShell. r=roc
2010-04-10 16:09:38 -04:00
5ff6f33f77
Bug 489127 - nodesFromRect required for better usability on mobile devices (part 1+2) [r=roc]
2010-04-07 20:31:26 -04:00
1db46ea87f
Back out the editor lazy inititialization patches (bug 221820) to try to solve the orange in bug 557689
2010-04-06 21:08:58 -04:00
2e860d5587
Bug 221820 - Part 7: Wrap the calls to nsTextControlFrame::EnsureEditorInitialized in a weak frame check; r=roc
...
--HG--
extra : rebase_source : e8ea41dfa8e4b591e21176fb654f968671cc3ba1
2010-04-06 16:44:46 -04:00
8d632d4354
Bug 221820 - Part 6: Fix a failing test; r=bzbarsky
...
--HG--
extra : rebase_source : 7ffe1d5c7840be9e84ec66851f96b61c69aeeda4
2010-04-06 16:44:12 -04:00
53dc5e0e1b
Bug 221820 - Part 5: Make lazy editor initialization compatible with placeholder values; r=bzbarsky
...
--HG--
extra : rebase_source : f7e1954482d34f5a229307ff7a6bc4fa527171ff
2010-04-06 16:43:39 -04:00
248d184822
Bug 221820 - Part 4: Fix the newline handling for text fields without an editor; r=bzbarsky
...
--HG--
extra : rebase_source : 92d9e491351a6183f0232604cd989c14d10d5fad
2010-02-22 16:15:56 -08:00
7208f0885b
Bug 221820 - Part 3: Debug-only assertion for reentrancy detection; r=bzbarsky
...
--HG--
extra : rebase_source : 0b3e81c649178ebff2b08856f652a37be59d7547
2010-02-09 20:29:11 -05:00
cb01da266b
Bug 221820 - Part 2: Make the editor initialization lazy (initialize only when needed); r=bzbarsky
...
--HG--
extra : rebase_source : bf84341934b14c78fadc162607721e9325673fc4
2010-02-02 10:49:55 -05:00
d02a89b5ac
Bug 221820 - Part 1: Call EnsureEditorInitialized from all places where editor needs to exist; r=bzbarsky
...
--HG--
extra : rebase_source : 91df07eb7a6a52c35d8f4d52212663045450b95a
2010-02-01 23:00:12 -05:00
8e1f917128
Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
...
--HG--
extra : rebase_source : 9c043d3cb30420f061d543e11e3000a1f8e18e27
2010-02-01 23:00:06 -05:00
81deb6e11f
Bug 556446: Remove dead code in layout. r=roc,bz
2010-04-03 07:36:19 -04:00
ef0e1ee85c
Use the appropriate color based on visitedness for nsCSSRendering::PaintBorder users of the 'border-*-color' properties. (Bug 147777) r=zweinberg
2010-04-02 18:58:26 -07:00
7b6b6d2167
Bug 494117: Mechanically change 'ReParent' to 'Reparent' throughout the tree. r=bzbarsky
2010-04-01 23:07:43 -07:00
b5f57540e7
Bug 253889: DeCOMtaminate nsIPresShell - GetCaret(). r=roc
...
--HG--
extra : rebase_source : 2a05050d8cbb10dd3bb763d5d5a158cc5f3dd814
2010-03-31 08:39:31 -04:00
1d6875d653
Backed out changeset 4b8936ac4a31
2010-03-30 19:56:44 -04:00
980532022a
Bug 253889: More deCOMtamination of nsIPresShell. r=roc
2010-03-28 19:21:11 -04:00
32476c4258
Bug 554072, resizer should account for borders and padding when retrieving current element size, r=roc
2010-03-23 14:52:56 -04:00
f2dd8fc239
Bug 442228, support resizers in scrollable areas and enable them by default for textareas, r=roc,sr=dbaron
2010-03-19 07:49:34 -04:00
e03725b062
Bug 543563, fix build error due to conflict with bug 544472
2010-03-18 16:45:29 -04:00
8b7622198f
Bug 543563, textarea in xul textbox doesn't take into account any assigned widths/heights, r=dbaron
2010-03-18 15:58:12 -04:00
8e36207435
Bug 353539 - textarea.focus() puts caret at end without scrolling it into view; r=roc
...
--HG--
extra : rebase_source : 775c2c16cfbb0ef9a9024dd53c42c803ee08e8ae
2010-03-18 12:14:40 -04:00
a3fd6db5ed
Bug 231389 - Textarea scrolls to top after changing its .value, regardless of cursor position; r=roc
...
--HG--
extra : rebase_source : 01f1129bc5289c3b56d15a7965e647002a0b1198
2010-03-18 12:14:08 -04:00
5a22815ee5
Bug 544097 Chaning mochitests to run against mochi.test instead of localhost r=ted, waldo, dwitte p=jmaher. Landed on CLOSED TREE
2010-03-12 13:53:36 -08:00
7cbcdf1446
test for Bug 549208 - Dragging a text in an input/textarea element doesn't make the placeholder disappear; r=smaug
2010-03-12 13:06:19 +01:00
4492ee705c
backing out changesets e939397fc6a5, 88529662c474 and 3d7c54b194bb due to random hangs in pgo tests
2010-03-09 22:33:11 -05:00
acb95ebf6d
Bug 544097 changing mochitests to use mochi.test instead of localhost for windows mobile refactoring p=jmaher, r=ted,dwitte, sayrer, waldo, ctalbert
2010-03-09 08:55:39 -08:00
f78a715db2
Backed out changeset 8ce70abd7777
2010-03-09 01:14:21 -05:00
4b8aff6ea3
Bug 544097 Change mochitests to use mochi.test instead of localhost for mobile refactoring p=jmaher r=ted,dwitte,sayrer
2010-03-08 19:21:33 -08:00
b962e844a9
Backed out changeset b4372055f473 -- due to unexplained orange on OS X Leak test (Bd) box
2010-03-07 17:34:23 -08:00
0c7928ce7d
Bug 544097 - Change mochitests to use mochi.test instead of localhost for mobile test refactoring p=jmaher, r=sayrer,dwitte
2010-03-07 16:08:05 -08:00
e9e4a9e303
Bug 549208 - Dragging a text in an input/textarea element doesn't make the placeholder disappear; r=bzbarsky
...
--HG--
extra : rebase_source : 13dc342d24bef26815bda5ef9958cfcb11a68a10
2010-03-01 10:35:40 -08:00
b04de541c5
Bug 457800 - Implement placeholder attribute for text input fields; r=ehsan,bzbarsky,bolter sr=roc ui-r=faaborg
...
--HG--
extra : rebase_source : 2e2f3a73553d720b32812603b0ce96c89b9a6261
2010-02-26 10:47:38 -08:00
6ff6df71ee
Bug 544642: Make frames report an error event if the frame src is pointed at a local file url. And don't make setAttribute thrown an exception in that scenario. r=smaug
2010-02-24 18:45:43 -08:00
a2d69be435
Bug 536567 - call InitUploadLastDir only when needed. r=ehsan
2010-02-21 15:52:51 +01:00
70f9774516
Bug 534527 - Accessibility needs new DOM API part 2, r=smaug, sr=bz
2010-02-20 16:52:50 -08:00
a98c3c5ce8
Backed out changeset e6cf06cfcef9
2010-02-18 19:03:28 -05:00
d50ab4a1a2
Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
...
--HG--
extra : rebase_source : 5c6baa16c4f3c91f8564cfdf394d70c8ea507861
2010-02-01 23:00:06 -05:00
5a7b76c5ad
Remove extra dump statements from tests
2010-02-11 14:14:26 -08:00
8d8a39b8e2
Bug 534527 - Accessibility needs new DOM API, r=olli.pettay, sr=roc
2010-02-12 01:34:01 +08:00
10161ff293
Bug 536567 - Store the value of the per-site last file upload directories inside the memory while private browsing is active. r=ehsan
...
--HG--
rename : toolkit/components/contentprefs/public/nsIContentURIGrouper.idl => dom/interfaces/base/nsIContentURIGrouper.idl
2010-02-11 09:35:49 +01:00
fe15fe1bb4
Bug 345681: Remove the vestigial nsICheckboxControlFrame and nsIRadioControlFrame interfaces. r=roc
2010-02-09 14:06:37 -08:00
f6cd82cadf
Bug 539907 - Have getPref use asynchronous statements when called with an optional callback. r=myk, sr=robstrong
2010-02-09 05:28:39 -05:00
c0e253bee7
Bug 518122, improve textarea.value+= performance, r=bz
2010-02-07 21:44:32 +02:00
32f8745a98
Bug 517553: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE'
2010-02-07 10:52:43 -05:00
585e563257
Bug 542914 - Add some tests for text input fields to make sure their basic behavior and appearance does not regress; r=roc
...
--HG--
extra : rebase_source : 9d642f48af7ff927ad5e73d0e22d763fbcc9d5a7
2010-01-29 13:22:15 -05:00
2f722cae6a
Bug 541382. Buttons with non-visible overflow should clip their contents. r=roc
2010-01-25 11:03:43 -05:00
8ea35ec392
Bug 526394. Part 31: Move scroll implementation into nsGfxScrollFrame. r=mats
2009-10-08 16:01:15 +13:00
ce4c3eb045
Bug 526394. Part 29: Create new nsLayoutUtils methods and remove useless code from nsListControlFrame::CaptureMouseEvents. r=mats
2010-01-12 10:45:18 +13:00
8274a10d56
Bug 526394. Part 18: Remove nsIScrollableViewProvider and its implementations, now that we've removed all its users. r=mats
2009-09-09 17:40:01 +12:00
edc2d25913
Bug 526394. Part 17: Convert some selection-related code in nsTextControlFrame and nsSelection. r=mats
2009-09-03 17:23:47 +12:00
6af148a1c0
Bug 526394. Part 16: Convert nsListControlFrame. r=mats
2009-09-03 16:49:16 +12:00
da6f26ea07
Bug 526394. Part 4: Obsolete nsIScrollableViewProvider by adding nsIFrame::GetScrollTargetFrame. r=mats,sr=dbaron
2009-09-01 23:22:31 +12:00
ddc476c737
Bug 526394. Part 2: Remove pointless code in nsTextControlFrame, nsGfxScrollFrame handles this already. r=mats
2009-07-29 22:07:04 +12:00
bef46bcb1d
Bug 488771. Stop nsIRollUpListener from inheriting from nsISupports. r=roc
...
--HG--
extra : rebase_source : 0af5c537b7be03c1407f4b658ba7802081ad3f01
2009-12-22 17:49:33 -06:00
9489bdf2ac
Bug 500882 part 5. Switch layout module to using the new GetPrimaryFrame API. r=roc
2009-12-24 16:20:06 -05:00
34d199a5c4
Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc
2009-12-24 00:21:15 -05:00
457fa4eb68
Bug 508473 Part I: Remove nsIFrame::RemovedAsPrimary r=bz sr=roc
2009-12-24 00:20:20 -05:00
ef6b66cf4a
Bug 524408. File inputs should remember the last-used directory on a per-site basis. r=bzbarsky
...
--HG--
rename : toolkit/components/contentprefs/public/nsIContentPrefService.idl => dom/interfaces/base/nsIContentPrefService.idl
2009-12-22 20:05:26 -05:00
9706b562c0
bug 531176, r=sicking, sr=jst
2009-12-18 21:27:57 +02:00
db9b2aaefe
Bug 525608 part 3. Change all style set consumers that ask for a pseudo style context to indicate what they're actually asking for (pseudo-element, anonymous box, or xul tree thing). r=dbaron
2009-12-11 02:37:40 -05:00
db14a0dddb
Backing out bug 525608 and bug 525952
2009-12-10 18:28:08 -08:00
2a81b03ca3
Bug 525608 part 3. Change all style set consumers that ask for a pseudo style context to indicate what they're actually asking for (pseudo-element, anonymous box, or xul tree thing). r=dbaron
2009-12-10 14:36:05 -08:00
6662ca9126
bug 530367 - passwords from password manager flash in clear text r=neil
2009-11-25 12:41:23 -05:00
2a9b428ed5
Bug 522787. Always register an editor observer. r=smaug
2009-11-19 12:38:11 +13:00
776a8e4c40
Bug 259636. Don't do sync reflow when setting .value on text inputs. r=roc, sr=dbaron
2009-11-11 18:28:16 -05:00
e5bf3a90e7
Bug 488771. Stop nsIsIndexFrame from inheriting from nsISupports. r=roc
...
--HG--
extra : rebase_source : 75ec78edbb8c169dc9cf7d4f959865002b884512
2009-11-03 16:43:23 -06:00
b8fffc69cb
Back out bug 487059, fix tests and EM to cope, r=gavin,beltzner, bug 524995
...
--HG--
extra : rebase_source : d8414b8de165cf2fa534719c36416d82d21872c6
2009-10-29 14:44:10 +01:00
10079d5a9d
Bug 523771: Support the 'multiple' attribute on <input type=file>. r=benjamn sr=jst
2009-10-24 21:13:30 -07:00
934da11d00
Bug 515096. Add a weak frame check in nsComboboxControlFrame methods HandleRedisplayTextEvent and RemoveOption because flushing could kill us. r=bz
...
--HG--
extra : rebase_source : e7f6a175a5fd0c8992329288f0e8c2752c270ed6
2009-10-15 21:49:57 -05:00
5921a124ac
Backed out changeset 1aea70ef6f63 (temporary debugging code for bug 523934).
2009-10-23 10:47:25 -04:00
925434e8f6
Add temporary debugging code to debug bug 523934
2009-10-23 10:21:00 -04:00
65fd1fc16f
Trying to fix the test for bug 411236, a=sheriff on a CLOSED TREE
2009-10-22 20:25:06 +03:00
b358ce2f34
Bug 513082. Instead of passing aDirtyRect to nsDisplayItem::Paint, have nsDisplayList::OptimizeVisibility (renamed to ComputeVisibility) compute the intersection of the visible region with the bounds of each display item and store the result in the item's mVisibleRect. This lets us do less work to paint display items which have a small intersection with the visible region but a large intersection with the bounding-box of the visible region. r=dbaron
...
--HG--
extra : rebase_source : 76db4b87ef9e5a6e9de7677edc08c26e2cbc462e
2009-09-07 12:35:14 +12:00
d02e15eb86
Bug 514660. Use classes instead of an explicit 'style' attribute to style the anonymous DIV of a text control, so that the styles are treated as user-agent styles and not removed when author styling is disabled. r=bzbarsky
...
--HG--
extra : rebase_source : 949e902529b2e0f48539d40141614038dfea0ea2
2009-09-23 23:02:27 +12:00
51cc52c705
Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst
2009-08-24 16:02:07 -04:00
3593f39647
Bug 233463, patch 5 - Remove nsFrameList(nsIFrame*) ctor. r=bzbarsky
2009-09-18 13:09:36 +02:00
0741d79bb3
Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc
2009-09-16 17:01:36 +02:00
1407ec3768
Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug
2009-09-13 09:13:16 -04:00
0af5a8f40d
Bug 435296 - Sync decode handling for decode-on-draw. r=roc
2009-09-12 16:44:18 -06:00
e65a77e1b7
Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc
2009-09-12 17:49:24 +01:00
00be9d327e
Bug 503943, back out mouse capture patch, CLOSED TREE
2009-09-10 12:11:41 -04:00
6d0ee32302
Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug
2009-09-10 08:51:36 -04:00
2365bba515
Don't scroll to the selected element if the reflow was interrupted, we'll do it later. b=512410 r=bzbarsky
2009-09-04 23:07:38 +02:00
6399d22ef3
Bug 513032 - remove empty conditionals in our makefiles, r=ted
2009-08-27 10:48:18 -07:00
cc45454b7a
Bug 513185. Cleanup - get rid of unused PresContext argument of nsComboboxControlFrame::ShowList. r=roc
...
--HG--
extra : rebase_source : def06a931fc16d51b5783a327c0374a774f52895
2009-09-02 14:46:47 +12:00
0ff6d9d22b
Bug 513185. Calculate an opaque backstop color for a dropdown combobox (select) before possible scroll (which leads to painting). r=roc
...
--HG--
extra : rebase_source : 0ad5b14f24291dd16779328b1901a7f1a0091840
2009-09-02 14:46:47 +12:00
8a9fb4d41e
Add more crashtests
2009-08-27 21:11:40 -07:00
305909d6eb
Add crashtests
2009-08-27 19:48:20 -07:00
c4ea86fa0e
Additional followup to bug 398573 - remove REQUIRES from the tree even when they are in makefile conditional blocks
...
--HG--
extra : rebase_source : cc65c34a414e6c67a5651fc9cf0b6bd709ebcdbd
2009-08-27 08:53:13 -07:00
2824c696a7
Backed out changeset e2927bb26412
2009-08-26 14:49:18 -07:00
7167944a1b
Bug 497495 part 3a: rationalize the queryframe-implementation macro naming scheme, restructure the implementation to detect duplicate entries, and a couple fixes to the frame ID enumeration. r=dbaron sr=roc
...
Bug 497495 part 3b: update users of queryframe macros (strictly mechanical change). r=dbaron
--HG--
extra : rebase_source : ee672a17934227b408b83dc6b5cc4e4909652f72
2009-08-26 09:27:42 -07:00
9b904b824f
Bug 511323. If a dropdown combobox (select) is given a translucent background color make sure to draw an opaque color on the dropdown's opaque widget so we don't get garbage painted. r=roc
2009-08-25 12:07:57 -07:00
28fb767bd1
Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted
2009-08-25 08:59:31 -07:00
79edda8c98
Backed out changeset 4aa19414e651 (bug 488249) to fix test orange.
...
--HG--
extra : rebase_source : ae1c0155ec32b0887eff27ded77c6ba2b37dda64
2009-08-24 20:51:57 -04:00
ac5c73f4b2
Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst
2009-08-24 16:02:07 -04:00
c51488146f
Bug 506481. Make sure that we'll scroll to the selected option even if it's added after our initial reflow but before we finish adding initial option kids. r=mats
2009-08-24 14:17:56 -04:00
e03cef86e8
Crash test for bug 321894.
2009-08-24 01:21:40 +02:00
af8d8584e5
Bug 510651: Fold nsIFrameDebug into nsFrame. r=dbaron sr=mrbkap
2009-08-20 14:52:48 -07:00
d69e61bc00
Bug 503791. ComboboxControlFrame should not assume that the origin of the screen is (0,0) because that is not true with more than one display. r=dbaron
2009-08-17 20:21:07 -07:00
44f7f9d413
Bug 489502 - Replace NS_ASSERTION(0, ...) by NS_ERROR(...) in mozilla-central; r=benjamin
2009-08-14 16:09:00 +02:00
120ba3d396
Bug 510323 Multiline <select> doesn't ignore middle clicks correctly r=smaug
2009-08-14 11:59:24 +01:00
2cf0b81d57
Back out bug 431098
2009-08-10 16:40:29 -07:00
bd1c4e3455
Add crashtest for bug 403148
2009-08-08 15:32:54 -07:00
6e8df662a1
Bug 424780 - Typing into <select> dropdown can cause nsStringBuffer leak. r=sicking
2009-08-08 15:00:26 -07:00
4f75d75337
Bug 502942. Make fieldsets use their content's last-line baseline. r=dbaron
2009-08-03 10:42:59 -04:00
39072906a0
Bug 281387. Make nsIFrame::Append/InsertFrames use nsFrameList. r=bernd,roc, sr=dbaron
2009-07-30 13:23:32 -04:00
d69901f7d3
Bug 504221 part 12. Switch SetInitialChildList to nsFrameList. r=fantasai, r+sr=roc
2009-07-28 08:53:20 -04:00
061a1b80fc
Bug 504221 part 5. Switch from GetFirstChild to GetChildList (returning an nsFrameList). For now, keep a GetFirstChild shim so callers don't have to be updated. r=fantasai, r+sr=roc
2009-07-28 08:51:09 -04:00
ca443085e9
Bug 491180. <button> should not clip overflowing contents. r=roc
2009-07-22 21:31:45 -04:00
9c23ca0770
Bug 753 - Remove nsIImage, gfxIImageFrame, and their implementations, and expose an equivalent api on imgIContainer. r=roc,josh,bz,longsonr,vlad,karlt,jimm,bsmedberg,mfinkle,peterw,peterv sr=vlad,roc
...
--HG--
rename : gfx/src/shared/gfxImageFrame.cpp => modules/libpr0n/src/imgFrame.cpp
rename : gfx/src/shared/gfxImageFrame.h => modules/libpr0n/src/imgFrame.h
2009-07-20 18:50:15 -07:00
35e9d1187d
Bug 500208: select element should update label when script changes selection, r=bzbarsky
2009-07-06 09:39:54 -04:00
37934236d9
Bug 495385. Text inputs should set the white-space style of the anonymous inner div when that div is created, not later when it will trigger a restyle. r+sr=bzbarsky
...
--HG--
extra : rebase_source : bef3008f365592d754039e74bac0b428a8c84794
2009-06-13 21:16:27 +12:00
fc4e632aa1
Bug 404766, right click on a bookmark menuitem closes it instead of opening another context menu, r+sr=roc
2009-06-12 14:23:16 -04:00
d47464bb7b
Bug 496840. Make dynamic insertion and removal of legends work in the presence of multiple legends. r+sr=bzbarsky
...
--HG--
extra : rebase_source : c11c9ac211575f01ac810eac7c1feb684ed76d7a
2009-06-12 14:01:05 +12:00
c78cc06ad6
Bug 178324, refactor focus by moving all focus handling into one place and simplifying it, add many tests, fixes many other bugs too numerous to mention in this small checkin comment, r=josh,smichaud,ere,dbaron,marco,neil,gavin,smaug,sr=smaug (CLOSED TREE)
2009-06-10 14:00:39 -04:00
5ce5655c12
Bug 468708 - namespaceURI for HTML elements should be http://www.w3.org/1999/xhtml (also make localName return in lower case) r=sicking, sr=peterv, a=beltzner
2009-06-09 10:41:19 +03:00
d4bcb6458c
Bug 494667. Don't apply optimization to shrink drawn background area to exclude solid borders, if we're not going to draw those borders (e.g. in tables with collapsing borders). r+sr=dbaron,a=beltzner
2009-05-28 17:01:42 +12:00
d03a116215
Bug 492387. Flush out content notifications before initing our editor. r+sr=jst
2009-05-19 10:49:57 -04:00
1a34a67e20
b=481751 block-height line-height for text input and strut baseline for textarea r=bz,sr=dbaron
...
--HG--
extra : rebase_source : 1241360066ea9387d15c71936da9468399240640
2009-05-19 10:13:12 +12:00
2c7f8533bf
Bug 463350. Don't allow fieldsets to break vertically. r+sr=dbaron
...
--HG--
extra : rebase_source : b40a725617805871f6c463f630099390749ca2a0
2009-05-08 13:55:22 +12:00
bd3965a189
Switch HTML mochitests from using MochiKit.js to packed.js. (Bug 490955) r=sayrer
2009-05-06 13:46:04 -07:00
a3f2b448ea
bug 378670 - mochikit test by Martijn Wargers.
2009-04-24 10:08:18 -07:00
79e356924c
bug 343510 - crash test by Martijn Wargers.
2009-04-24 10:08:13 -07:00
cc5e007233
bug 317502 - crash test by David Baron.
2009-04-24 10:08:09 -07:00
a41abfb92e
Remove some unused AddRef/Release methods on frame classes. (Bug 488774) r+sr=roc
2009-04-22 10:13:48 -07:00
a0e39130ad
Bug 489224 - Printing doesn't print text field values, r+sr=roc
2009-04-22 12:35:45 +03:00
22c6682386
Bug 487059 - clearUserPref shouldn't throw if a pref doesn't have a default or user value. r+sr=bsedberg
2009-04-10 10:24:24 +02:00
4908551014
Bug 475535 - don't go through PaintBackgroundWithSC to draw non-native radio buttons and checkboxes; remove special UA pseudo-elements for styling these. r+sr=roc
2009-04-03 10:45:17 +02:00
2be40fed8f
Backed out changeset cc4fae01938c
2009-04-02 12:03:52 +02:00
26daaa1428
Bug 475535 - don't go through PaintBackgroundWithSC to draw non-native radio buttons and checkboxes; remove special UA pseudo-elements for styling these. r+sr=roc
2009-04-02 09:57:13 +02:00
d37e6bf09c
Bug 431634 - Part 1 - clean up header pollution; r+sr=roc
2009-04-01 13:59:02 -08:00
72f01993d8
Adding crashtest
2009-03-16 20:52:30 -04:00
563e81691f
Mochitest for bug 478219
2009-03-16 13:21:28 -04:00
d430566602
Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking
2009-03-16 07:50:04 -04:00
7c129c93b3
Backed out changeset 12e163f4f272
2009-03-16 15:00:57 +01:00
322820f523
Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking
2009-03-16 07:50:04 -04:00
75904cb6f2
Bug 478245 - Crash [@ nsEventStateManager::PreHandleEvent], r+sr=dbaron
2009-03-11 17:43:08 +02:00
d5a0ae67c7
Bug 431098: Make pressing 'cancel' in the file picker clear the file upload control. r/sr=bz
...
--HG--
extra : rebase_source : fb5a6deb1984475e55dd03ef7607044c5ce75bcb
2009-03-09 23:14:57 -07:00
4f4d8a567d
Remove unnecessary #includes. b=462203 r+sr=roc
2009-02-19 21:18:49 +01:00
66bd405efc
Bug 400226. Do text redisplay as soon as it's safe, not after a trip to the event loop. r+sr=mats
2009-02-17 22:27:25 -05:00
178aac4c56
Bug 477700. Push a null JSContext around editor init, so it'll work no matter what JS is on the stack. r+sr=smaug
2009-02-16 09:11:41 -05:00
81b4a03e38
Add crashtests
2009-02-13 14:54:17 -08:00
6784138b72
Bug 477531. Support CSS3 :indeterminate pseudo-class. r+sr=dbaron,r=bzbarsky
...
--HG--
extra : rebase_source : 03d1be9b5742e8d17114aaeb0b5de20d61926d51
2009-02-11 14:19:37 +13:00
e0ff240014
Add a bunch of crashtests
2009-02-10 22:18:05 -08:00
7a2af3b188
Bug 476738. Implement 'inset' box-shadows. r+sr=roc,r=dbaron
2009-02-10 21:45:13 +13:00
6718129c1f
Bug 476308. Box-shadows for buttons should not capture events. r+sr=roc
2009-02-05 21:22:02 +13:00
L. David Baron
Ehsan Akhgari
Mounir Lamouri
Siddharth Agarwal
Joel Maher
Zack Weinberg ext:(%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
Kyle Huey
Robert O'Callahan
Boris Zbarsky
David Zbarsky
Phil Ringnalda
Makoto Kato
Kyle Huey
Benjamin Smedberg
Olli Pettay
Michael Ventnor
Neil Deakin
Timothy Nikkel
Jesse Ruderman
Alexander Surkov
Mats Palmgren
Peter Van der Beken
Jonas Sicking
Mitchell Field
Henri Sivonen
Daniel Holbert
Craig Topper
Felipe Gomes
Ehren Metcalfe
Brad Lassey
Clint Talbert
Joel Maher
Geoff Lankow
Ryan Flint
Jae-Seong Lee-Russo
fantasai
Gijs Kruitbosch
Bobby Holley
Hashem Masoud
Neil Rashbrook
Joe Drew
Mark Finkle
Karl Tomlinson
Bob Clary
Dão Gottwald
Jeremy D. Lea
Martijn Wargers
Mats Palmgren
Michael Ventnor
Michael Ventnor