e11c732a35
The selectedindex is now getting set to -1 when there are no more items selected and it
...
is sending onchange events by clearing the mOldSelectedIndex.
Bug 68135 r=kmcclusk sr=attinasi a=dbaron
2001-06-06 10:41:17 +00:00
f8b424129b
Fixed up reload to it will correctly reflow to w/h of zero
...
Bug 58220 r=kmcclusk sr=attinasi a=dbaron
2001-06-05 18:09:13 +00:00
2bf7260d28
Fix for 78695 (rule matching improvements). r/sr=attinasi, jst, waterson
2001-05-31 22:19:43 +00:00
3cd44086a1
Bug 77834: Fix problem where form control state is being restored to the wrong form control or not restored at all when going back and forth through session history. The problem was that the hash key we used was the content ID, which was not consistent from page load to page load. The fix was to key instead by index of form in document / index of control in form, with logic to fall back to content ID if we are unable to do this. r=nisheeth@netscape.com, sr=jst@netscape.com, a=drivers@mozilla.org (blizzard@mozilla.org)
2001-05-30 11:26:21 +00:00
43d27cb937
Fix for 80746, fix smoketest blocker by backing out 61336 fix. r:harishd
2001-05-14 18:54:06 +00:00
23789ace1c
Fix 61336, call onchange event for changes made by scripts. sr:jst, r:pollmann
2001-05-14 01:57:33 +00:00
621060c4fd
Landing the XPCDOM_20010329_BRANCH branch, changes mostly done by jband@netscape.com and jst@netscape.com, also some changes done by shaver@mozilla.org, peterv@netscape.com and markh@activestate.com. r= and sr= by vidur@netscape.com, jband@netscape.com, jst@netscpae.com, danm@netscape.com, hyatt@netscape.com, shaver@mozilla.org, dbradley@netscape.com, rpotts@netscape.com.
2001-05-08 17:42:36 +00:00
fd9e9c8891
Fix for 77859. r=danm, sr=waterson
2001-04-28 03:48:38 +00:00
31a850a277
Fix for 77002. reviewers=jst,waterson,hixie,shaver,brendan,pavlov
2001-04-25 19:52:49 +00:00
9adc217d52
Bug 74639: Preserve frame state through form demotion, don't store uninitialized frame state, r=nisheeth@netscape.com, sr=jst@netscape.com
2001-04-24 08:33:57 +00:00
e8a58aef11
Fixed the Onchange event, so it fires at the correct time.
...
Bug 62753 r=pollmann sr=attinasi
2001-04-09 12:08:40 +00:00
d44332bdf7
fix Bug 70989 Clean up lots of "shadows" and other common warnings
...
r=peterv, jst, ducarroz, edburns. sr=jst, shaver
2001-03-21 05:32:22 +00:00
5176f190e8
fixed move mouse over selected item in dropdown, it will no longer hilite disabled items
...
Bug 72226 r=waterson sr=attinasi
2001-03-20 11:48:27 +00:00
bbb8ce0256
bug 71339; author=simon@softel.co.il; r=rods; sr=erik; changes from IBM
...
bidi project (Hebrew, Arabic, etc); in ifdef IBMBIDI for now
2001-03-19 23:20:21 +00:00
fe6f8fcf66
Display frame reflow counts (turned via config file define)
...
Bug 71514 r=kmclusk sr=attinasi
2001-03-13 01:47:22 +00:00
9f51057c61
change PRBool to PRPackedBool
...
Scroll to first item on DidReflow of Initial Reflow
Bug 54496 r=kmcclusk sr=attinasi
2001-03-09 03:21:51 +00:00
c05ae96710
Skipp disabled items when pressing first letter
...
Bug 57580 r=kmcclusk sr=buster
2001-03-08 02:29:21 +00:00
8d8070a9fa
Fix smoketest blocker bug 70683 by making some changes blake missed with his fix for bug 60703. r=mao sr=alecf a=kysmith
2001-03-02 18:39:22 +00:00
42db2b170f
Now only doing 1 reflow for each reflow request in the ListControlFrame
...
for initial and full resize reflows
Bug 69869 r=kmcclusk sr=attinasi
2001-02-23 01:45:45 +00:00
0b4f1ec612
Bug 62713: Only save form input values in SH if changed plus cleanups (error handling, NS_LITERAL_STRING), r=jst@netscape.com, sr=vidur@netscape.com
2001-02-06 01:59:59 +00:00
87f28b43c8
makes optgroups so they you can't click on them and it fixes the focus issue.
...
Bug 63006 r=kmcclusk sr=buster
2001-02-01 22:45:32 +00:00
9c6f7ccade
This checkin enables mozilla to support the printing of selection, the printing of page ranges, and
...
the printing of headers and footers.
Printing of selection is implemented by the frames figuring out if they are in the selection and painting
if they or not they they don't paint. This also only allows the printing of the first page of
selections, alothough it is well documented where this is implemeted so it can be removed.
Bugs 63426, 31218, 61075 r=dcone,kmcclusk,erik,buster sr=waterson
2001-01-27 14:09:34 +00:00
e6efaf8e39
changed add ref to from NS_ADDREF to NS_IF_ADDREF
...
Bug 63329, r=kmcclusk sr=buster
2001-01-08 14:06:34 +00:00
c81b2c3b26
removing most all NS_DEFINE_IID and replacing them with NS_GET_IID macros
...
Bug 61274, r=buster sr=waterson
2001-01-04 20:44:42 +00:00
44ea7c2a67
When clicking away from the dropdown, it wasn't resetting itself correctly.
...
If only the mouse was being used for selection, then it needs to reset itself to the state before dropping down
if arrow keys had been used then it needs to keep that selection
The combobox chaches the current selection, so when arrow keys are used it has the correct selection
when the mouse is used it holds the old selection. So therefore, we can compare against it
to determine what to do.
Bug 63247
r=waqar sr=hyatt
2000-12-20 23:25:40 +00:00
7dc59420b7
53259 - min-width and max-width not supported on form control
...
53457 - multiple items can be selected in select size=1 or in single select listbox
50376 - Cannot select with DOM option on dynamically created SELECT element
62442 - Incorrect extended selection behavior in listboxes
First big change is getting rid of local variables for border and padding and use the ones in the reflow state
Changed "IsInDropDownMode() == PR_TRUE && mComboboxFrame" to "IsInDropDownMode() == PR_TRUE"
Fix for regression from changing of how key events work (no bug assigned), this fix enabled the user to hit 'f' or 'F' and get to the first item that start with 'f' or 'F'
r=kmcclusk sr=buster
2000-12-20 15:15:28 +00:00
9b0fb27e9a
Removed unneded setting of index to kNothingSelected when an disabled option is selected
...
r=blake, sr=buster Bug 57580
2000-12-18 21:36:01 +00:00
4189314fdb
Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
2000-10-28 22:17:53 +00:00
6e35f97e31
Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
2000-10-27 22:43:51 +00:00
0ab595abc9
#=53502
...
r=rods@netscape.com
a=buster@netscape.com
d=Fixes the problem with listbox and modifier keys.
2000-10-12 14:20:02 +00:00
e13fae3ffe
Fixed bug 52526, the cause was that image load event was bubbling even though the specs say it should not. Previously we were not even sending the load event on image load. I also fixed bug 50478 by fixing the logic in GetBubbles and GetCancelable of the DOMEvent. This helps in testing the first bug. I also fixed several cases where we had wrong combination of event class and event struct type. a=waterson, r=joki,rods.
2000-09-19 21:47:04 +00:00
6cc70ebd6c
Bug 37275, Changing value of all progids, and changing everywhere a progid
...
is mentioned to mention a contractid, including in identifiers.
r=warren
2000-09-13 23:57:52 +00:00
8f431163b3
Bug 51124: Tabbing into text control now again scrolls it into view if offscreen, also adding additional bulletproofing per code review; r=jst@netscape.com
2000-09-08 05:53:28 +00:00
328224be4f
KeyPress events now let <ctrl<,<slt>,<meta> continue on through, which stopped commonads keys from working
...
Fixed a couple of off by one errors
Fixed multiple selection with shift key
Fixed focus stealing problem (ifdef'ed out code that was put in to specifically fix this problem)
Fixed div by zero
b=50024,50442,48903
2000-08-29 13:24:38 +00:00
faca5dee86
Added a lot of asserts to help debug any potential problems, check for nullcontent
...
moved up to GetPrimaryFrameFor doesn't get called with a null content
b=49993 r=kmcclusk
2000-08-25 13:12:59 +00:00
b3a4ade60d
DOM string changes. All nsString& in DOM interfaces (and interfaces needed by DOM implementations) have been changed to nsAReadableString& and nsAWritableString&. String implementation additions (sanctioned by scc) to support DOM needs. Bug 49091. r=vidur,jst,scc
2000-08-23 17:27:06 +00:00
602e714184
listbox - selecting with keyboard no longer allows you to stop on a disabled option, it skips them
...
as does page up and page down
combobox - selecting a disabled option didn't clear the "mouse down" flag and it still thought it was selecting
combobox - selecting a disabled option clears mSelectedIndex, this side effect could be seen by selected
a disabled item then clicking on a link and then hit "back",
b=48903 r=kmcclusk
2000-08-17 21:38:15 +00:00
3a306b3f7a
was not unregistering the listers correctly. Not they unreg with the
...
listener object.
b=48915 r=kmcclusk
2000-08-14 22:05:28 +00:00
b6e988da63
added weak reference and ref counted event listener to listbox intead of
...
having the the non-recounted frame add itself. It is now the same as GfxList
b=21629, r=kmcclusk
2000-08-14 14:42:12 +00:00
7ff1e18afc
More bustage fixing with style struct return types.
2000-08-09 00:52:02 +00:00
a19bcfbde3
Fix for bug 25161 -- allow editor to handle pages with forms by implementing user-select and user-input for form controls. r=rods, pierre, mjudge.
2000-08-08 23:38:00 +00:00
5b203b9391
Bug 42662: Values of disabled form elements should not be submitted; r=kmcclusk
2000-08-03 23:32:02 +00:00
2db1221bdc
40000 - right-click events don't go through listboxes (onmoused
...
44454 - Can't drag-scroll/-select in single-select HTML listbox
42301 - select generates onchange when it shouldn't
33421 - <optgroup> in <select> breaks scrolling drop down lists
14771 - GFX list/combo box doesn't respond to keyboard input
b=40000, 44454, 42301, 33421, 14771 r=kmcclusk
2000-08-03 14:13:58 +00:00
021eb5de93
If the click is not on on item in the dropdown and not in the comboxbox display area then
...
the click count is set to zero so the JS event doesn't get fired. If it IS over the combobox
display area then the JS event does get fired.
b=40382 r=pollmann
2000-07-07 01:35:23 +00:00
b3961cd107
ifdef'ing out the where we get the value of the label
...
currently we aren't supporting "label" for options because they get
concatentated with the content
b=4050 r=kmcclusk
2000-06-15 13:00:23 +00:00
ad5bd8dcb3
no longer subtracting off scrollbar width when mComputedSize is set
...
b=36548, r=kmcclusk
2000-06-02 20:59:57 +00:00
9161f31f32
set the clickCoubt appropriately on MouseUp so onclicks are sent or disabled correctly
...
b=40382 , r=joki
2000-05-26 23:31:25 +00:00
f4137f0157
Preventing event from bubbling, capture and default causes a mismatch in mousecapture
...
and this causes the lock. After a lot of testing it appears that the original reason
this was needed is no longer there.
Bug 38422 r=kmcclusk
2000-05-22 21:35:00 +00:00
91e64c7b7d
fix for bug 15189 along with an annoying assert that just started. r: rods
2000-05-16 21:58:37 +00:00
b2e873d830
Updating mozilla to DOM Level 2 events support. Fixes for bug 34722, 35378, 8411, 10330, plus some others that weren't filed.
2000-05-16 11:35:12 +00:00
9c57b5ce10
temporary fix for 38825, the frame gets notified that an option has been added
...
before it is actually added into the content model, so the selection cache and the
content model can be of by 1
2000-05-11 14:05:44 +00:00
6077a0a71b
get char code instead of key code
...
bug 34630
2000-05-08 22:18:38 +00:00
138e4bd554
The press event always delivers the key as lowercase where key down gives you the key that was pressed
...
need to change str to lowercase instead of uppercase
b=34630
2000-05-05 21:51:56 +00:00
8877c991d4
bryner's fix for key repeat (thanks a lot)
...
need to make press event not bubble
b=38072, r=rods
2000-05-03 22:01:47 +00:00
207bd15b6b
Fix leak of nsHTMLOptionElement. r=pollmann@netscape.com
2000-05-01 04:00:38 +00:00
af703fcc29
add OptionDisabled so the nsHTMLOptionElement can notify a select that an option
...
has just been disabled
2000-04-28 23:24:59 +00:00
3851e31b9f
fixes for 5995, 7304, 10573, 22832, and 9668.
...
Changes to event handling to deal with reentrant events, cursor fixes, and return value fixes.
2000-04-24 04:41:27 +00:00
1118f2af9d
Add ifdef'ed Performance Reflow Counting code
...
also added asserts for improper sizes being passed back in reflow
send onChange events on all navigation bug 29440
2000-04-21 22:16:23 +00:00
df05a11b26
change char detection to use unichar and upper case so now pressing 't' or 'T'
...
gets you the first item that begin with 't' ot 'T'
Bug 34630
2000-04-19 14:57:44 +00:00
2ad7174d88
Not enabling creator's to be asked if they want to create a special frame for anonymous content
...
bug 33515
2000-04-19 13:55:17 +00:00
8624ce5d67
making string conversions explicit
2000-04-16 11:19:26 +00:00
886073840d
Few warning cleanups
...
Return NS_OK when MouswDown on Combobox (not dropdown), this enables
it to get focus.
b=32144
2000-03-28 15:11:16 +00:00
fb036a0b2e
now handling the incremental reflow better for options
...
when one more options have no label or content the height is zero, so we
now go get the first frame calculate a height based on the font metrics
r=dcone b=32383
2000-03-21 15:22:53 +00:00
a06c2054bf
Bug 28143: Set selectedIndex to -1 should deselect all options (1 of 2 - when frame exists) r=waqar
2000-03-20 23:43:07 +00:00
c0726b3245
Added adaptive sizing for dropdown with small screen sizes
...
The setting of the cached available size only happens when it is not unconstrained
Added GetOptionsContainer method
Fixed minor problem in GetScrollableView (not actually passing back the frame)
Added the Flushing of content on arrow keys
b=31987,25774 r=kmcclusk
2000-03-18 14:17:34 +00:00
4b5db8f52f
Fix 32199 (visibility:collapse is not being interpreted as hidden on block and inline level elements) and parts of 21701 (misuse of style attr mVisible).
In the following files, replacing disp->mVisible with disp->IsVisible() is a BUG FIX: nsBlockFrame, nsBulletFrame, nsHRFrame, nsHTMLContainerFrame, nsImageFrame, nsTextFrame.
In all the other files, replacing disp->mVisible with disp->IsVisible() or disp->IsVisibleOrCollapsed() is merely a SYNTACTICAL CHANGE. The respective owners will later review the use of IsVisibleOrCollapsed() and in some cases replace it with IsVisible(). See bug 21701.
2000-03-17 10:15:13 +00:00
6ba4a8f08d
factored out a GetScrolableView method, implemented extended selection for drag select and shift->up/down keys
...
added page up and down support, but it isn't supported by nsScrollFrame (works for Gfx)
should be generating the coorect DOM selection events now
r=dcone, b=14771, 30463
2000-03-15 15:55:30 +00:00
ee84e699f6
fixing VC5 build (bug 31868)
2000-03-15 06:22:09 +00:00
f9554cf7d1
Fixed Combobox and ListBox frame to be more effecient in processing reflows
...
added Block and text frame for displaying the selected option for the combobox
Fixes Bugs 30463, 28835, 29544
r=buster,kmcclusk a=jar
2000-03-07 15:54:31 +00:00
932879ce4d
Backout plan, this check only fixes bug 28628
...
a=jar
2000-03-03 07:14:58 +00:00
0de348eef2
modified the reflow method for better handling incremental and for optimization
...
b=28593, r=buster,kmclusk a=jar
2000-03-03 04:28:59 +00:00
3b493e429f
Bug 12513: Add OptionCollection interface for Nav DOM compatability. r=vidur a=rickg
2000-02-24 00:08:00 +00:00
f0c4b3a651
ifdef'ing out a badly formed optimization for incremental reflow.
...
r=buster b=24798
2000-02-16 05:20:21 +00:00
45ed3c6864
They now cache their state properly in the PresState
...
b 21945 r=pollmann
2000-02-15 15:04:38 +00:00
fc8c04ec37
Let's try a non-COMPtr fix, I wish COMPtr would work the same on all platforms....
2000-02-12 17:49:11 +00:00
e4f9b03cb9
same old thing Linux hates comparing a nsCOMPtr to a non-OMCPtr
2000-02-12 17:01:35 +00:00
e9740dbb06
now remembers state when selected for single select combos and listboxes,
...
it does not remember mulitple selections (more work needed in content class)
converted over to rnsCOMptr as much as I could
b=21945, r=pollmann
2000-02-12 16:21:37 +00:00
d05eeaa676
removing unneeded native frames and unneeded frame classes that these derived from
...
fixing checkbox and radiobutton state restore
fixing right btn click on dropdown
adding in initial work for accesskey
bug 17027,26296,27063,7559; carpool a=leaf; r=kmcclusk
2000-02-09 19:34:39 +00:00
43d7ba4273
Converting ::GetIID() into NS_GET_IID(). Bug #20232 . r=scc, r=mozbot
2000-02-02 22:24:56 +00:00
e501b48066
add extra debug; added some inremenal reflow code;
...
doing much better job check return vars;GetText now check for NS_OK;
r dcone, b 24292
2000-01-31 23:36:50 +00:00
f1a8910137
backing out rods to fix options lists
2000-01-28 19:03:34 +00:00
e7e764db46
added check so it doesn't do a reset on the incremental reflow
...
r=dcone bug=none
2000-01-28 15:04:19 +00:00
bcb43fcaf0
Bug 18649: non FormControlFrame derived form elements also only scroll when not at all visible r=rods
2000-01-25 22:19:39 +00:00
e468aef1ea
r=vidur. Add support for a new pref "layout.reflow.async.afterDocLoad" that enables async reflow in the pres shell only after the document is done loading. Cleaned up ExitReflowLock() so that it uses preferences to decide whether to do async reflow, not a parameter.
2000-01-25 16:00:44 +00:00
7335d90bfb
changed signature of GetFont b=905 r=dcone
2000-01-25 15:25:46 +00:00
84cbca2516
floating views. bug=21966, r=troy, rods, a=brendan
2000-01-25 01:53:34 +00:00
eca7ac464e
Backing out one line from the previous checkin in order to fix #24344 ("Crash when displaying a list box").
2000-01-19 12:27:40 +00:00
cde6e415cd
Initial shift click will now work correctly for mulitple with selected items
...
it now will scroll to the selected items on start up
b 24178,7025 r=kmcclusk
2000-01-18 23:33:22 +00:00
489fa24f63
Fixes for bugs 17460 and 21656. r=travis
2000-01-14 09:28:54 +00:00
4139a0f457
use proper key for disconguous selection on Mac (r=jfrancis)
2000-01-13 16:01:04 +00:00
cee7c68c6f
Listbox was handle clicks in the combobox incorrectly and this caused the
...
dropdown to rollup too soon.
b=23484 r=kmcclusk
2000-01-11 20:36:37 +00:00
de25ed658f
Added unconstrainted reflow optimizations
...
r=kmcclusk,dcone bug=12653
2000-01-09 01:41:11 +00:00
a25e7644fc
backed out all changes from today (1/5/2000)
2000-01-05 16:42:47 +00:00
2eeffb7cab
Added unconstrainted reflow optimizations
...
reworked reflow to more accurately calculate its size
r=kmcclusk,dcone bug=12653
2000-01-05 15:46:29 +00:00
42e7039924
fix warnings
1999-12-28 19:41:57 +00:00
7c47447ac9
Fixed the edge case where the select may have zero options or one option
...
with no lable and no content and it sizes out to be zero high
also fixed twhere visibility wasbeing check incorrectly
r=kmcclusk
1999-12-22 19:49:36 +00:00
1aa5067600
stripping out all the whitespace for form data submission
...
commented changing the visible directly
bug 21276, r=pollmann a=chofmann
1999-12-14 14:16:09 +00:00
3f9fa43e97
Massive rewrite of the focus/blur architecture. Things should behave better
...
now. r=saari
1999-12-08 04:54:29 +00:00
58000ea4b5
Always passing back that the frames are there, this still isn't right and needs to be
...
reworked again. But this will able some XUL selects to work that otherwise would be
broken and I haven't found it to cause any problems with a lot of testing. I have
regressed to this situation in the past and it worked OK.
r=kmcclusk, bug=none but hangas (or self) would have filed one by end of day.
1999-12-08 00:08:41 +00:00
6e773b0546
removing unused variables (bloat) and using nsLayoutAtoms::optionSelectedPseudo instead of
...
using a string and creating and deleting it each time.
r=kmcclusk
1999-12-06 22:59:43 +00:00
rods%netscape.com
hyatt%netscape.com
pollmann%netscape.com
joki%netscape.com
jst%netscape.com
timeless%mac.com
erik%netscape.com
dbaron%fas.harvard.edu
warren%netscape.com
waqar%netscape.com
heikki%netscape.com
rayw%netscape.com
sfraser%netscape.com
scc%netscape.com
pierre%netscape.com
dveditz%netscape.com
pp%ludusdesign.com
leaf%mozilla.org
nisheeth%netscape.com
beard%netscape.com
brade%netscape.com
sspitzer%netscape.com