62f7fc6ea3
Backing out to attempt to fix Mac orange. Bug 232691
2004-05-22 19:26:52 +00:00
b733dd59da
Convert users of nsC?String(), nsC?AutoString(), and NS_LITERAL_C?STRING("") to
...
using EmptyC?String instead. Bug 232691, patch by Charles Fenwick
<clf03f@garnet.acns.fsu.edu>, r+sr=bzbarsky
2004-05-22 17:04:53 +00:00
f1f89a9129
Backing out 233441.
2004-05-17 16:29:13 +00:00
d247d3f525
Fixing bug 242734. deCOMtaminate nsITextContent. r+sr=bryner@brianryner.com
2004-05-07 20:55:17 +00:00
e508d2a0ad
Bug 233441. Make nsViewManager always have a root view, you can't change it. r+sr=dbaron
2004-05-06 03:17:14 +00:00
7927c18306
Implement basic support for DOM level 2 UIEvents, and implement DOMActivate for HTML form control elements. Also minor usage cleanup for nsIDOMUIEvent. Bug 60212, r+sr=jst.
2004-04-30 23:55:16 +00:00
6f486a3c92
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:21:17 +00:00
4cba32786b
Make nsXULElement::GetChildNodes use the same (live) node list that
...
nsGenericElement uses. Bug 240633, r+sr=jst on the C++ changes, r=neil, sr=jst
on the JS changes.
2004-04-15 22:14:39 +00:00
62c142565c
More nsIPresContext deCOMtamination (bug 229371). r+sr=roc.
2004-04-13 00:28:44 +00:00
f3a6db059e
allow the editor to correctly handle DL/DT/DD, switching from DT to DD when the user presses enter and vcie-versa; b=233261, r=timeless, sr=dbaron, a=tor
2004-04-09 13:55:59 +00:00
fd6bbb093e
don't dirty editor if there are no transactions and undo or redo are called (bug 237834; r=glazman, sr=kin, a=asa)
2004-03-26 14:20:04 +00:00
1775c22dcc
Bug 236620: kill nsIContent::CanContainChildren
...
r/sr=jst
2004-03-06 00:22:03 +00:00
9ec9ee5f4d
fix for bug 32768; relativize urls (if possible) on insertion; r=Neil, glazman, smfr; sr=dmose
2004-03-04 18:47:49 +00:00
f17303d967
supplimental fix for bug #228879
2004-03-02 17:34:22 +00:00
7f19665189
landing fix for bug #228879
...
Bogus Text when pasting from open office spread sheet or word processor to Mail Compose
working around bug http://www.openoffice.org/issues/show_bug.cgi?id=25864 in open office
r=jfrancis, sr=mscott
2004-03-02 16:03:56 +00:00
1d2d419885
landing dbaron's patch for bug 235735 "fix callers that cast away const on result of ns[C]String::get" r+sr=darin
2004-02-28 22:34:07 +00:00
d6b0d386ee
deCOMtaminate nsIPresContext::GetEventStateManager. Bug 229371, r+sr=roc.
2004-02-27 17:17:37 +00:00
8c818ed6c3
landing string defragmentation patch for bug 231995, r/sr=dbaron,jst,dougt
2004-02-19 02:44:03 +00:00
91cc24c280
bug 208095: crashes when ASCII characters are entered before any characters that go through an XIM server. patch by smontagu, r=katakai, sr=sfraser, a=choffman
2004-02-14 00:22:15 +00:00
d576bb7676
Fixing bug 206859. Don't allow drag & drop into file inputs. r=caillon@aillon.org, sr=bryner@brianryner.com, a=chofmann@mozilla.org
2004-02-11 21:31:53 +00:00
b26298f7c2
Inline TwipsToPixels and PixelsToTwips on nsIPresContext. Bug 229371, r+sr=dbaron.
2004-02-11 04:57:07 +00:00
cf491c34c8
fixes annoying assertion in the editor: b=217906, r=brade, sr=kin
2004-02-06 14:34:54 +00:00
0f4260f296
Fixing debug build bustage.
2004-01-30 21:09:49 +00:00
1804c4910c
Fixing bug 232503. Start using Empty[C]String() to save a bit on code-size. r+sr=peterv@propagandism.org
2004-01-29 22:04:45 +00:00
e19997ed86
Bug #229203 --> thunderbird needs new liness converted to commas when pasting into single cell text boxes.
...
This comes up when pasting address data from spreadsheet programs into the addressing widget. This pref cannot be turned on for seamonkey because it effects all single line text boxes.
r=glazman, moa=glazman
sr=bienvenu
2004-01-29 16:55:01 +00:00
eff4dc2930
Remove all text styles menu item and key binding both no longer working in Composer and mail composer; b=215406; r=floppymoose,sr=dbaron
2004-01-29 14:52:43 +00:00
d62aed44c4
Fixing bug 230840. DeCOMtaminating nsIDocumentObserver, nsIAttribute, nsIContentList, and nsIContentIterator, and doing some other cleanup. r=jonas@sicking.cc, sr=bryner@brianryner.com
2004-01-24 00:46:17 +00:00
f97835d45d
Bug 231368 Remove unused nsIPref includes p=arne.anka@stupido.com r/sr=dbaron
2004-01-23 13:31:07 +00:00
290494e26b
Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky.
2004-01-21 09:35:59 +00:00
172440f1a9
Fix for bug 230439 (Remove anonymous nodeinfomanager and other cleanup). r=caillon, sr=jst.
2004-01-18 14:52:21 +00:00
75c2b9acde
Remove nsIHTMLContentContainer, merge those three functions into nsIDocument,
...
and make XUL style attribute dynamic changes get a proper CSSLoader off the
document. Bug 211376, r+sr=jst
2004-01-13 23:14:49 +00:00
242c0d7716
Make Ctrl+Delete and Ctrl+Backspace delete words in the expected direction in right-to-left text. Bug 209430, r=daniel@glazman,org, sr=dbaron@dbaron.org
2004-01-12 23:39:40 +00:00
4ab234b8be
General deCOMtamination of nsIDocument, nsIContent, and nsIFormSubmission. Eliminating nsIAttributeContent, and doing some URL->URI changes. r+sr=peterv@propagandism.org
2004-01-09 23:54:21 +00:00
9611f22db6
Composer's table cell properties' dialog did not allow to reset width and hight and the switch between TD and TH did not work (regression): b=230165, r=timeless, sr=dbaron
2004-01-09 20:52:07 +00:00
9c81944cb6
Eliminate nsIStyleSet as an XPCOM interface, making the implementation internal to layout. Frame constructor ownership moves to the pres shell, and the style set methods that forward to the frame constructor are gone. Rewrote style set sheet add/remove to reduce code size. For more details, see bug 64116. r+sr=dbaron.
2004-01-07 22:30:53 +00:00
1f4ab81acd
Continuing to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 13:37:00 +00:00
f0bfff2628
Beginning to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 01:22:31 +00:00
6380d7fd12
Fixing bug 225837. DeCOMtaminating nsIContent more, making GetTag() return a weak raw pointer, and renaming GetTag() to Tag(), and making GetRangeList() return an const nsVoidArray*, and changing GetContentID() to return the id, and renaming it to ContentID(). r=jonas@sicking.cc, sr=bryner@brianryner.com.
2003-11-19 01:20:56 +00:00
93d52bd385
Bug 225991 DRefTool analysis for editor files
...
r=roc sr=roc
2003-11-17 20:45:37 +00:00
816b00b6cc
Fix for bug 224231 (Need AppendASCIItoUTF16). r=jst, sr=dbaron.
2003-11-01 10:57:41 +00:00
b444821722
Fixed crash in table editing, b=217717, r=mozeditor, sr=dbaron, a=asa
2003-10-24 23:01:30 +00:00
a0e219b348
deCOMtaminate nsIDocument by changing methods to use return value instead of out-params, eliminating unused nsresult return values, moving some members to nsIDocument and inlining the getters/setters. Bug 222134, r=bzbarsky, sr=jst.
2003-10-22 06:09:48 +00:00
9e3cd4cc05
Bug 221719 Disable Composer's Paste As Quotation menuitem in the subject and address fields r=brade sr=alecf
2003-10-10 19:02:28 +00:00
a767be1764
fix for topcrash 218556: I made the object resize listener hold weak pointer to the editor to fix resize timer firings on stale editors. r=brade; sr=peterv
2003-10-09 22:08:59 +00:00
f207a10e67
removing bogus comments
2003-10-09 22:07:48 +00:00
8801e97e8f
Make presshell batch processing of style changes (using BeginUpdate/EndUpdate
...
notifications). Bug 200931, r=peterv, sr=jst
2003-10-02 21:29:40 +00:00
8aa7b563d2
Fixing bug 215981. DeCOMtaminating nsIContent and nsIDocument some, and also some minor changes to other related interfaces. r=caillon@aillon.org, sr=peterv@propagandism.org.
2003-09-27 04:18:26 +00:00
6bed557bd4
Bug 190735. Final patch for deCOMtamination of core nsIFrame methods! rs=dbaron
2003-09-23 17:05:29 +00:00
fd34e45fa0
Bug 219673 : Uninitialized variable in nsHTMLEditor r=glazman sr=sfraser
2003-09-20 05:59:44 +00:00
cb01f2577b
Don't create style rule DOM wrappers for inline style, since we are not supposed to, and ours crash when used on inline style. b=218222 r+sr=bzbarsky
2003-09-13 19:18:52 +00:00
352e645b90
Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan.
2003-09-07 22:05:34 +00:00
01ad844c3b
Bug #216753 --> Message compose should not automatically convert HTML attributes to CSS styles.
...
Fix this by setting a flag in editor to not use CSS styles for the background image.
Then back out my fixes in mailnews to work around the inline style editor was giving us.
With this change, mail compose now handles background images again and they are preserved when you save as draft
or save as template.
r=neil
sr=bienvenu
a=glazman for the editor change
a=asa for 1.5 final
2003-09-05 17:49:36 +00:00
3998f855c6
remove unused variables, fix typos, code cleanup (r=glazman, sr=tor, a=asa, bug=216054)
2003-09-03 13:58:00 +00:00
073a5613ee
remove redundant code and unused variables, cleanup (r=glazman, sr=tor, a=asa, bug=216054)
2003-09-03 13:56:21 +00:00
09622112c8
add helper methods for dealing with pixels; reduce string usage; code cleanup (r=glazman, sr=tor, a=asa, bug=216045)
2003-09-03 13:54:36 +00:00
d7cc2379d6
fix typo, removed unused string, code cleanup (r=glazman, sr=tor, a=asa, bug=216045)
2003-09-03 13:49:22 +00:00
2e986e9fe2
fix for bug #216581
...
Rewrap is broken
thanks to Akkana (akkzilla@shallowsky.com ) for the fix
r=brade a=sspitzer for 1.5 final
2003-09-03 04:17:45 +00:00
f9b076e455
Note: the editor portion of this change is to a routine only used by mailnews.
...
Make mail news handle inline background url styles which is how editor now sets background urls instead of using the obsolete background attribute on the body:
Bug #116867 --> convert background images from file urls to inline cid urls and attach the image as an inline part.This allows thunderbird and mozilla mail to support background images again.
Bug #170504 --> Compose from template/draft containing "Inline Styles" and a background image loses the background image drops the
inline style.
r=bienvenu
sr=sspitzer
a=sspitzer
2003-08-18 05:18:05 +00:00
e2a72c1c4c
fix for bugs 192507 and 181677. r=brade; sr=kin;
2003-07-31 07:09:42 +00:00
d2932a7552
Bug 214025 [@ nsHTMLCSSUtils::IsCSSEditableProperty]
...
r=glazou sr=bz
2003-07-29 14:48:44 +00:00
4881ca3964
fix compiler warning
2003-07-28 22:18:42 +00:00
95256ce645
DeCOMify GetParent/GetBindingParent/GetDocument on nsIContent. Bug 213823,
...
r+sr=jst
2003-07-28 21:35:53 +00:00
124b8fe78d
more Is* method usage / code cleanup; r=glazman, sr=bz, bug=212683
2003-07-28 20:31:08 +00:00
64838ba838
fix tinderbox bustage
2003-07-28 14:27:49 +00:00
7756228f66
cleanup of editor code, bug=209548, r=jfrancis, sr=blizzard
2003-07-28 13:13:50 +00:00
f1efc20ae6
Bug 213602: Switch some users of NS_GetWeakReference over to do_GetWeakReference. r=bzbarsky, sr=dbaron
2003-07-25 19:06:59 +00:00
ef99140d6d
Bug 213601: Switch some users of NS_NewAtom over to do_GetAtom. r=bzbarsky, sr=dbaron
2003-07-24 04:53:13 +00:00
f008bc2bad
Bug 25886: Get rid of a bunch of unused NS_DEFINE_IID, NS_DEFINE_CID. r=caillon, sr=dbaron
2003-07-20 07:47:59 +00:00
1333f0d2fc
reduce string usage by using atom version of method; r/sr=dbaron, bug=213101
2003-07-19 08:51:54 +00:00
2b9515c5b8
fix includes; r=kaie, sr=tor, bug=180316
2003-07-18 19:03:34 +00:00
f487989f20
editor cleanup; r=jfrancis, sr=blizzard, bug=209548
2003-07-18 14:12:51 +00:00
40787e3814
fix bug found when reading source, replace ending space to match intent and version 1; r=jfrancis, sr=blizzard, bug=209548
2003-07-18 14:09:34 +00:00
b995a3ac74
call GetIsDocumentEditable which will check CanModify for us; r=jfrancis, sr=blizzard, bug=209548
2003-07-18 14:06:21 +00:00
c9c87af134
remove misplaced #ifdef NS_DEBUG; bug 209548
2003-07-18 13:06:18 +00:00
9329fb77dc
remove misplaced #ifdef NS_DEBUG
2003-07-18 13:04:46 +00:00
92d49f7efb
use Truncate instead of SetLength(0); r=cmanske, sr=bz, bug=209548
2003-07-18 02:27:19 +00:00
f516c0768a
code cleanup (remove some NS_LITERAL_STRINGs in favor of existing ut
...
ility methods); r=cmanske, sr=tor, bug=209548
2003-07-17 23:44:13 +00:00
7edc4ab000
Fixing --enable-plaintext-editor-only bustage (bug 209548). Patch by brade, r/sr=me.
2003-07-16 22:19:59 +00:00
898cdcb4b8
editor cleanup of NodeIsType; r=kin, sr=darin, bug=209548
2003-07-15 13:47:15 +00:00
bf82a649b9
Bug 212272: Switch some Substring users over to String(Begins|Ends)With. r=dwitte, sr=bzbarsky
2003-07-14 07:37:39 +00:00
a33f58cdd0
Backing out part of patch for bug 211128, since it regressed all sorts of
...
XBL-ish stuff. r=stuff-is-broken sr=jag for the backout.
2003-07-14 05:35:09 +00:00
20004e3489
Bug 73353: clean up MODULE/REQUIRES story. r=cls, sr=bryner
2003-07-13 22:29:00 +00:00
9fad3e7dfe
Make XBL anonymous content get its base URI from the XBL document (the binding
...
URI) instead of from the document of the bound element. This way relative URIs
in a binding are always relative to the binding. Bug 211128, r=caillon, sr=jst
2003-07-11 23:06:26 +00:00
095064be64
remove unused local variable; fixes warning; no bug, no reviewers
2003-07-08 22:12:04 +00:00
7cdb30f095
fix warning for cstring charset change made a week or two ago; editor code cleanup (use contract IDs); r=timeless; sr=kin; bug=209548
2003-07-08 20:38:51 +00:00
32f3fd3d64
editor code cleanup (use contract IDs); r=timeless; sr=kin; bug=209548
2003-07-08 20:35:09 +00:00
0d360e211d
editor code cleanup (use contract IDs); r=timeless; sr=kin; bug=209548
2003-07-08 20:22:56 +00:00
b04654bcc2
editor code cleanup (use contract IDs); r=timeless; sr=kin; bug=209548
...
CVS ----------------------------------------------------------------------
2003-07-08 20:18:18 +00:00
494e98c23f
Fix for bug 211378 (Unable to paste into editor widgets with middle mouse button)
...
Modified MouseUp() and MouseClick() so that they call thru to the base class versions. This regression was caused by the fix for bug 137092.
r=brade@netscape.com sr=bzbarsky@mit.edu
2003-07-08 17:38:13 +00:00
25471a836d
Add nsIContent::GetBaseURL; get rid of similar functions on nsIXMLContent and
...
nsIHTMLContent. Bug 209573, r=caillon, sr=jst.
2003-07-03 02:45:34 +00:00
6d59e7a395
Fix some issues related to focus changes in onfocus and onblur handlers:
...
- Abort firing blur events on the document and/or window if one of the blur handlers focuses something else. This ensures that the caret doesn't get confused about whether it should be active.
- Release any mouse or key grab when the view manager sees a deactivate event; this fixes event targeting when a mousedown handler opens a modal dialog.
- Make sure the editor element is actually focused before activating the caret. Just receiving a focus event isn't good enough, since a focus change does not cancel propagation of the original event.
Bug 53579, r=jkeiser, sr=roc.
2003-07-01 22:46:55 +00:00
9a868d3c9a
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 19:10:53 +00:00
70046e0ec5
code cleanup continued; r=timeless, sr=kin, bug=209548
2003-06-30 18:55:06 +00:00
6c5cc2f94c
code cleanup, r=timeless, sr=kin, bug=209548
2003-06-30 17:28:52 +00:00
610a10752a
code cleanup, r=timeless, sr=kin, bug=209548
2003-06-30 15:02:48 +00:00
b8311b327c
remove unused headers, r=timeless, sr=kin, bug=209548
2003-06-30 14:59:04 +00:00
6688138229
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 14:57:59 +00:00
2933c5d0d8
code cleanup, r=timeless, sr=kin, bug=209548
2003-06-30 14:56:22 +00:00
f0d1bfb89c
code cleanup; r=timeless, sr=kin, bug 209548
2003-06-30 14:46:41 +00:00
830f0a8d60
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 14:41:55 +00:00
ba4180665b
code cleanup; r=timeless, sr=kin, bug 209548
2003-06-30 14:39:27 +00:00
f9f1ac623b
code cleanup, r=timeless, sr=kin, bug 209548
2003-06-30 14:33:23 +00:00
5fbb4f79d1
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 14:31:48 +00:00
9976465a07
code cleanup; r=timeless; sr=kin; bug=209548
2003-06-30 14:24:40 +00:00
5fa10bf2fe
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 14:20:49 +00:00
eec8607ca7
code cleanup, r=timeless, sr=kin, bug=209548
2003-06-30 14:17:15 +00:00
b23121c488
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 14:14:01 +00:00
395d6d85a7
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 14:05:25 +00:00
57743e4eb1
code cleanup; r=timeless, sr=kin, bug=209548
2003-06-30 13:42:22 +00:00
6cca4ccd3e
NS_IMPL macro cleanup; r=timeless; sr=kin; bug=209548
2003-06-27 14:19:40 +00:00
6c295fc019
jst@netscape.com's fix for tree blocker bug 210641 (Crash using Japanese IME)
...
mozilla/editor/libeditor/html/nsHTMLEditor.cpp
mozilla/editor/libeditor/text/nsPlaintextEditor.cpp
- Fixed INTERFACE_MAP macros so that they call through to the class we inherit from.
r=brade@netscape.com sr=kin@netscape.com
2003-06-25 19:21:59 +00:00
9e7ea0ab4e
Support for Absolute Positioning, Snap to Grid, and Inline Table Editing in Composer
...
r=brade, sr=jst
2003-06-25 08:50:48 +00:00
7928e4930c
deCOMtaminate nsIFrame::GetWindow; the COM wrapper doesn't ADDREF when it should, the easiest thing to do is to just not use the wrapper. r+sr=dbaron
2003-06-24 13:39:15 +00:00
42b06cc4f5
DeCOMtaminate nsIFrame::GetView and SetView, and add HasView, GetClosestView, and AreAncestorViewsVisible to consolidate common patterns. b=208004 r+sr=roc
2003-06-19 23:44:01 +00:00
3cb1785e6d
Composer's structure toolbar was showing anonymous content; b=190279, r=Neil, sr=peterv
2003-06-19 14:06:05 +00:00
998dd77226
fixing typo - s/cahced/cache
2003-06-18 23:04:50 +00:00
6e7d099d26
bug 140357: improving fix to handle redundant backspaces. r=brade, sr=kin
2003-06-18 22:42:24 +00:00
5614718dd3
fix for bug 209220 - now that i18n APIs take ASCII charset names, update consumers to avoid excess conversions.. which usually means storing charset names as ASCII and updating a few other APIs
...
r=jkeiser, sr=jst and some great comments from jshin@mailaps.org
2003-06-17 16:40:34 +00:00
aa9050e11d
Was impossible to outdent a subset of an indented block in CSS mode
...
b=194963, r=kaie, sr=kin
2003-06-17 09:35:46 +00:00
bef7afc6f3
Removing text styles in CSS mode was potentially removing too much if the styles were added in HTML mode
...
The fix creates a span element that will carry the inline styles and class of the HTML element to be removed, if any.
b=202037, r=kaie, sr=dmose
2003-06-17 08:45:54 +00:00
ba75de772b
Bug 209087
...
Content interface out-parameters should use ptr-to-ptrs instead of ref-to-ptrs and some small deCOMtamination.
r+sr=jst@netscape.com
2003-06-13 20:10:01 +00:00
79d9d260c7
error in nsHTMLEditor::SetFlags(), has side-effects on CSS editing; b=209086, r=brade, sr=kin
2003-06-13 12:39:35 +00:00
c242ab28d5
remove unused params; r=akkana, sr=kin, bienvenu, bug=208967
2003-06-12 14:51:37 +00:00
9360cadfed
Fix HP-UX bustage from jfrancis checkin.
2003-06-12 11:20:00 +00:00
511d25c3f6
CSS indentation was not dropping non-editable nodes; b=203723, r=kaie, sr=peterv
2003-06-12 07:43:07 +00:00
4e3a501c39
improvement to 140357 fix: reducing bloat of previous patch, extending functionality to css-mode editting, and improving TypeInState to recognize redundant selection change notifications.
...
fix for 208317: css-mode editing left empty spans around, which could cause disapearing carets
r=brade; sr=kin
2003-06-11 19:33:01 +00:00
b497c6895c
b=207183 Smiley gets deleted, editor tries to manipulate whitespace in the -moz-user-select:all block
...
r=jfrancis sr=kin
2003-06-11 12:02:49 +00:00
6678fd2394
b=202166 Edit actions place caret on invalid position
...
r=jfrancis sr=kin
2003-06-11 11:50:36 +00:00
271780827f
remove some useless local variables, fix whitespace, add param to insertion hook (sourceDoc), r=rogermw, sr=kin, bug=208539
2003-06-10 18:53:11 +00:00
3b206d0ebf
add param to insertion hook (sourceDoc), r=rogermw, sr=kin, bug=208539
2003-06-10 18:52:31 +00:00
948ea9868f
bug 140357: (html editor) deletion should preserve style state. r=brade; sr=kin
2003-06-02 22:21:06 +00:00
eb1326faf2
Bug 205347 warning: `PRBool IsInlineNode(class nsIDOMNode *)' defined but not used
...
r=brade,jfrancis sr=sfraser
2003-05-23 22:10:06 +00:00
08a70ed81d
Bug 204076 Remove unused variable `PRBool sameNode' from nsHTMLEditorStyle.cpp:524
...
r=brade sr=tor
2003-05-23 21:55:17 +00:00
5ef0585a3c
Bug 199989 Remove gNoisy code from libeditor.
...
r=brade sr=alecf
2003-05-23 21:43:10 +00:00
149f719c00
bug 100649: Length() being used where IsEmpty() is meant
...
treewide changes to convert incorrect usages of string.Length() to string.IsEmpty().
thanks to afatecha@idea.com.py (Ariel Fatecha) for the patch. r=dwitte, sr=jst.
got the ok from Asa to land into a closed tree.
2003-05-23 21:34:47 +00:00
c8633873f1
Fix drag and drop to/from textarea and input (bug 194802), r=bryner@netscape.com, sr=jst@netscape.com, a=sspitzer@netscape.com
2003-05-21 00:42:32 +00:00
279209f254
Bug 206287 things Will be re-ordered to match declaration order
...
r=roc+moz sr=roc+moz a=roc+moz
2003-05-20 02:02:56 +00:00
00ca69f01d
crash when doing multiple redo commands in Composer; r=brade, sr=peterv, a=sspitzer
2003-05-16 09:08:03 +00:00
a15b9f2cf4
Clean up API (and its callers) for getting style data: remove unneeded null checks and switch to new inline member functions (one for each struct) that return values. b=197205 r+sr=roc a=brendan
2003-05-15 03:42:21 +00:00
e922d41efb
b=169213 hitting backspace deletes HR above, fix confusing caret placement around <hr> lines
...
r=jfrancis sr=sfraser a=sspitzer
2003-05-14 13:20:09 +00:00
3977ca8978
b=200417 backspace, enter keys have no visible impact
...
r=jfrancis sr=sfraser a=sspitzer
2003-05-14 13:17:32 +00:00
9cd318825f
api change to insertion filter to add flag for delete selection; r=timeless; sr=kin; a=asa; bug=204066
2003-05-09 18:33:14 +00:00
0f6a3aedcb
api change to insertion filter to add flag for delete selection; r=timeless; sr= kin; a=asa; bug=204066
2003-05-09 18:32:50 +00:00
376c526961
api change to include event (similar to paste/drop hook); r=cmanske, sr=sfraser, a=asa bug=203365
2003-05-09 18:30:02 +00:00
c64e4eee66
cmd_clearUndo implementation; r/sr=smfr a=sspitzer bug 195506
2003-05-09 18:21:00 +00:00
8050d83eca
cleanup transferable hooks in editor; defer selection manipulation in plain text; ensure hooks are properly positioned (bug 203062) r=kaie, kin; sr=smfr
2003-04-25 21:05:32 +00:00
7ba09392a6
move docshell here to support hook utility methods (bug 203062; r=kin/kaie, sr=smfr)
2003-04-25 21:03:15 +00:00
fd1224e85f
missing hook from bug 192171 (r=brian johnson, sr=sfraser)
2003-04-22 20:32:59 +00:00
efcf8d6576
Fix bug 196704: implement commands to get the selected text, and insert text, to allow for embedders (like Camino) to use them, e.g. for the Mac OS X services menu. Also fix image copy. r=brade, sr=kin.
2003-04-22 18:11:12 +00:00
78f946e42d
Bug 199412: optimize nsTypedSelection::ScrollIntoView r/sr=sfraser
2003-04-20 01:03:40 +00:00
ebd37e392b
fix for plaintext editor, fallout from bug 201982
...
sr=sfraser
2003-04-17 18:28:35 +00:00
ca3fdeb474
editor changes for drag/drop/copy/paste hooks (bug 197121) r=jfrancis, sr=smfr
2003-04-17 13:18:51 +00:00
d95e3e2d05
Bug 198546: Format -> Font submenu doesn't deal with "unknown" font. r=glazou, r=Neil, sr=bryner, moa=brade.
2003-04-17 07:35:55 +00:00
6673301edc
fix for bug 201982 - r=brade, sr=smfr
...
nsIEditProperty was an interface with no methods and only static members - moved it to an entirely static class.
2003-04-17 05:42:33 +00:00
0a8b9a815b
b=201974 Caret partially/completely visible with initial <p> </p>
...
r=jfrancis sr=sfraser
2003-04-16 20:18:41 +00:00
6e0de691c9
b=68767 extra blank space added when block level element (hr, table) is inserted at the end of a line, between two lines
...
r=jfrancis sr=kin
2003-04-15 20:53:15 +00:00
be2a207097
add insertion listener; bug 192567 (r=jfrancis, sr=kin)
2003-04-15 14:07:30 +00:00
5df3b30a3b
Make CreateContextualFragment know what document the fragment is destined for.
...
Fixes some issues with images and innerHTML. Bugs 198486, 198989, 201865.
r=jfrancis, sr=jst
2003-04-15 01:09:09 +00:00
01d0c60590
MakeList is redundant with AppendList. Bug 179810, r=jfrancis, sr=kin
2003-04-13 04:30:16 +00:00
8b7145ecb4
fix for bug 199170 - convert editor over to using nsStaticAtoms
...
r=brade, sr=sfraser
2003-04-10 21:04:07 +00:00
4dbf4f2abf
Appease the Windows __stdcall gods. Bug 201257.
2003-04-10 20:45:17 +00:00
d61e2195a4
Fix bug 201257 -- clean up use of nsIControllerCommandManager by editor:
...
Renaming nsIControllerCommandManager to nsIControllerCommandTable to reduce confusion.
Moving the immutability flag from the nsBaseCommandController to the nsControllerCommandTable.
Renaming the 'refcon' on nsIControllerContext to 'context', and giving nsIControllerContext an Init() method that optionally takes a command table.
Fixing the editor and composer module code to create pre-filled nsIControllerCommandTables as services, and the controller constructors to create singleton command tables with do_GetService.
r=brade, sr=alecf.
2003-04-10 18:44:03 +00:00
cfcce2de81
Fix for bug 199490: A crash occurs after clicking in (HTML tags )document - Trunk [@
...
nsHTMLEditor::SetFinalSize]
- A one line fix in HideResizers() which prevents the
reported crash by setting mIsResizing to false. I assume
we can't be resizing if the resize handles are being hidden.
The assertion and null check in SetFinalSize() are just because
I'm paranoid, but they should never be triggered if HideResizers()
is called first.
- The changes in StartResizing() makes it so that we don't create
a new mouse motion listener if we already have one. We were
creating a new listener each time we clicked on the handles, and
never unregistering the old one ... this meant that the old
listeners could be triggered if the editor were ever destroyed
and the document left in tact ... allowing us to crash because the
listeners keep an un-addref'd pointer to the HTMLEditor. Note that
this crash is not likely to be hit in Mozilla since we always
destroy the document and editor in Composer and MailCompose, but
it can happen in an embedding context.
r=glazman@netscape.com sr=sfraser@netscape.com
2003-04-09 21:10:58 +00:00
8468c6fa68
Fix for bug 200549:Double click selects just the image in a -moz-user-select:all
...
subtree
mozilla/editor/libeditor/html/nsHTMLEditor.cpp
- jfrancis' fix for netscape bug 615240 (applying mozilla patch
on branch. Fixing problems of improper handling of del and
backspace keys with file attachments.) which was originally
landed in revision 1.445.6.3. This patch is necessary to make
the fix for bug 200549 work properly.
r=sfraser@netscape.com sr=kin@netscape.com
mozilla/editor/libeditor/html/nsHTMLEditorMouseListener.cpp
mozilla/editor/libeditor/html/nsHTMLEditorMouseListener.h
- Modified nsHTMLEditorMouseListener::MouseDown() to
call FindUserSelectAllNode() so that the root of a
-moz-user-select:all subtree gets selected during
a double or context click.
- Modified nsHTMLEditorMouseListener so that it stores an nsHTMLEditor*
instead of an nsIEditor* so we could have access to FindUserSelectAllNode().
r=brade@netscape.com sr=sfraser@netscape.com
2003-04-07 14:32:23 +00:00
150409662a
Fix for bug 42046: One click select and drag for images, hrs, and -moz-user-select:all
...
subtrees
mozilla/layout/html/base/src/nsFrame.cpp
- Added utility method ContentContainsPoint()
- Modified HandlePress() to allow selection of images, hrs and
-moz-user-select:all subtrees, and then disable selection
processing of drag events.
mozilla/editor/libeditor/html/nsHTMLDataTransfer.cpp
- Modified InsertFromDrop() so that it prevents a drop from
happening in a -moz-user-select:all subtree. (Temporary
workaround to avoid bug 195957 and bug 195959)
r=mjudge@netscape.com sr=sfraser@netscape.com
2003-04-07 14:28:51 +00:00
03308d1b07
Fix for bug # :Hiding resize handles triggers assertion in ~nsGenericHTMLElement()
...
Modfied DeleteRefToAnonymousNode() so that it set the content node's document and parent to nsnull.
r=brade@netscape.com sr=sfraser@netscape.com
2003-04-04 20:51:36 +00:00
086e9f0622
Fixes for bug 192569 (allow foreign transactions to be added to the queue)
...
mozilla/editor/idl/nsIEditor.idl
mozilla/editor/libeditor/base/nsEditor.cpp
mozilla/editor/libeditor/base/PlaceholderTxn.cpp
mozilla/editor/libeditor/html/nsHTMLCSSUtils.cpp
mozilla/editor/libeditor/html/nsHTMLEditor.cpp
mozilla/editor/libeditor/text/nsTextEditRules.cpp
- Renamed nsIEditor::Do() to nsIEditor::DoTransaction() so that it
can be called from JavaScript.
- Cleaned up nsEditor::Begin/EndUpdateViewBatch() so that
nothing happens outside the check of mUpdateCount.
- Modified PlaceholderTxn.cpp so that it checks to see
if a merged transaction implements nsPIEditorTransaction
before attempting to cast it to (EditorTxn*).
mozilla/editor/ui/composer/content/EditorCommandsDebug.js
mozilla/editor/ui/composer/content/editorOverlay.xul
mozilla/editor/ui/composer/locale/en-US/editorOverlay.dtd
- Added debug menu items to test execution of foreign transactions
via the txnmgr and editor.
r=jfrancis@netscape.com sr=sfraser@netscape.com
2003-04-04 20:50:25 +00:00
0ec32e88c8
Fix for bug #195959 : Drop causes image in -moz-user-select:all subtree to be duplicated
...
Prevent nsHTMLEditRules::CreateStyleForInsertText() from trying to split non-container nodes.
r=jfrancis@netscape.com sr=sfraser@netscape.com
2003-04-04 15:29:59 +00:00
676f90b0b2
Add defined(XP_MACOSX) to bail early when !mInIMEMode. r=brade, sr=lumpy
2003-04-04 13:26:12 +00:00
9eae2082b5
Bug 200638: fix drag copy modifier key on Mac OS X. r=Neil, sr=peterv
2003-04-04 12:48:23 +00:00
a5a80015e1
Remove nsIIndpendentSelection, moving its one method onto nsISelectionPrivate. Bug 192827. r/sr=kin.
2003-04-04 01:45:06 +00:00
9d2930b43f
require all users of htmleditor to have EditorOverride.css so resizing will work
...
; bug 196075; r=jfrancis, sr=bryner
2003-04-03 08:05:23 +00:00
de59dbee4b
Purge XP_PC.
...
Bug #56767 r=mkaply sr=alecf
2003-04-02 22:45:08 +00:00
b7df6947aa
Patch for bug 35296: SetCaretEnabled() takes too long
...
Patch by Leon.Zhang@sun.com
r=sfraser, sr=kin
2003-04-02 05:48:09 +00:00
b11cb5e21e
Oops, removing ^M characters. Fixing IRIX bustage.
2003-04-02 04:52:53 +00:00
d77ece64e2
Fix ctrl+enter in the mail compose window by getting rid of editor's key listeners in the client event pass entirely (everything now happens in the system event pass). r=brade, sr=sfraser.
2003-04-02 03:31:18 +00:00
8381c0d44d
Remove unused file. b=198627 r+sr=sfraser
2003-04-01 19:32:59 +00:00
925955c81d
landing attempt #2 for 195262 - support for static atoms, and converting atoms over to UTF8 to reduce bloat - now without performance regressions!
...
sr=darin, r=dbaron
2003-03-25 18:55:59 +00:00
e330f0c63e
Fix for bug 199133: mfc embed drag&drop doesn't work within same editor
...
Make DragOver() consume the drag event so that the default browser drag listener that is present during embedding, isn't triggered.
r=brade@netscape.com sr=dbaron@dbaron.org
2003-03-25 15:38:17 +00:00
8bfa453ecb
meta-fix for image and table resizing bugs in html editor
...
solves bugs 195412, 196624, 196122, 195849, 197158, 195141, 195126, 199013
r=brade, sr=kin
2003-03-25 15:24:08 +00:00
965ba28bb1
Bug 106386 rid source of misspellings
...
patch by nb@ipnode.info r=biesi sr=dmose
2003-03-24 04:15:34 +00:00
2e125db44a
Move editor's key event listener, xbl commands, and typeahead find into the system event group. This allows event listeners in content to reliably cancel key events. Bug 54035, r=jkeiser and aaronl, sr=hyatt and kin.
2003-03-24 04:00:58 +00:00
ee778d7be5
fix for 189225: deleting text at beginning of line adds extra space.
...
r=brade; sr=kin
2003-03-23 20:49:49 +00:00
b8893ea45e
fix for 187955: improvements to html fragment sink and paste code. Fixes problems seen with "Create table From Selection" and also with CF_HTML paste.
...
r=brade; sr=kin
2003-03-23 20:45:47 +00:00
8c1895d104
fixes for:
...
178304 - deleting only char in text node places caret in previous block
174867 - caret in wrong place after delete-to-end in list
181898 - select into mailcite, type: inserted text is in cite
r=brade; sr=kin
2003-03-23 20:22:15 +00:00
03b6da655f
fix for 161969: remove empty mailcites when editting
...
r=brade; sr=kin
2003-03-23 19:51:03 +00:00
bb2efc3630
fix for bug #198624
...
bulletproof for crasher in nsHTMLEditor::HideResizers()
r=brade,sr=kin
2003-03-22 17:22:22 +00:00
16af458ceb
backout my static atom patch for now until I figure out the performance loss! :(
...
bug 195262
2003-03-21 20:13:08 +00:00
c4ea07bc53
fix for bug 195262:
...
- convert atoms to UTF8 because 99% of the time, that is what they are used for
- add support for static atoms, where the strings are declared in a large const array and not copied into the heap
r=dbaron, sr=darin
this is an experimental landing - if there are performance issues, I will back it out.
2003-03-21 06:26:32 +00:00
be629223b6
Create a new xpcom obsolete library (and component library).
...
Moved nsFileSpec and related classes into this obsolete library.
Moved nsRegistry and related libreg functionality into the obsolete library.
Updated many callers using the obsolete nsFile spec to use nsIFile and Necko to do file IO.
Combined the following DLLs (source -> dest)
uriloader -> docshell
shistory -> docshell
jsurl -> jsdom
gkview -> gklayout
Moved nsAdapterEnumerator out of xpcom/ds and into mailnews, since they're the only consumer
Modifed the xpt_link tool so that you can specify a �only include� cid list that can mask CID�s that you are not interested in.
Added build options:
Prevent the building of xpinstall (--disable-xpinstall)
Prevent the building js component loader (--disable-jsloader)
A build option to only build a single profile (--enable-single-profile)
A build flag to only built the required xpfe components (--disable-xpfe-components).
Removal or hiding of unused functions and classes including nsEscape*, nsDequeIterator, nsRecyclingAllocatorImpl, nsDiscriminatedUnion, nsOpaqueKey, nsCRT::strlen, NS_NewCommandLineService
Bug 194240, r/sr = darin, alec.
2003-03-15 01:04:32 +00:00
27eabbf773
allow only compatible trasferable flavors (bug 196728, r=smfr, sr=kin)
2003-03-11 19:02:18 +00:00
03772aaf53
remove a few lines of code that landed by mistake and cause trouble with embedded editor; b=195800, r=brade; sr=dbaron
2003-03-04 02:14:19 +00:00
44ebe7e101
Fix for bug 74404 -- show caret drag feedback. r=brade, sr=kin
2003-02-27 23:20:15 +00:00
0fce5c3a3b
Fix bug 74404: show caret drag feedback. r=brade, sr=kin
2003-02-27 23:09:51 +00:00
54e564e2a5
Fix for bug 191762 (dragged image doesn't land where it's dropped)
...
editor/libeditor/base/nsSelectionState.cpp
- Reworked the logic in SelAdjJoinNodes() to avoid adding aOldLeftNodeLength twice to the calculated offset when the start/end node is the parent.
editor/libeditor/html/nsHTMLDataTransfer.cpp
editor/libeditor/text/nsPlaintextDataTransfer.cpp
- Modified the InsertFromDrop() to use an nsAutoTrackDOMPoint, instead of relying on range gravity, to calculate the correct insert position after deleting the current selection.
r=jfrancis@netscape.com sr=sfraser@netscape.com
2003-02-27 14:53:03 +00:00
034aaf432f
missing files for b=47066, r=brade,cmanske, sr=kin
2003-02-24 10:18:18 +00:00
2a1389ecba
Allow mouse-driven resizing of images and tables in all instances of editor.
...
For the default Mozilla build, this includes Composer and Mail Composition.
Embeddors willing to disable this feature should look at |nsHTMLEditor::SetIsImageResizingEnabled()|
Displays eight resizing handles plus an info box. Images are resized real-time.
Uses HTML attributes in pure HTML mode (mail composition for instance) and CSS properties when available.
Undoable and Redoable. Does not grind coffe and make a good expresso yet.
Thanks if you really read to that line.
b=47066, r=brade, r=cmanske (for the algo part inheriting from the XBL patch), sr=kin
2003-02-24 09:37:18 +00:00
dd40836ee4
Make double-click on text in composer select word again (bug 193689), r=bryner@netscape.com, sr=jst@netscape.com, a=asa@mozilla.org
2003-02-22 08:12:11 +00:00
d4ce4ad061
Make text drag work again (bug 193568), r=bryner@netscape.com, sr=jst@netscape.com, a=asa@mozilla.org
2003-02-22 08:10:46 +00:00
cc390fbe51
Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron.
2003-02-22 00:32:13 +00:00
bzbarsky%mit.edu
roc+%cs.cmu.edu
jst%mozilla.jstenback.com
bryner%brianryner.com
gerv%gerv.net
daniel%glazman.org
brade%comcast.net
sicking%bigfoot.com
scott%scott-macgregor.org
darin%meer.net
jshin%mailaps.org
neil%parkwaycc.co.uk
peterv%propagandism.org
smontagu%smontagu.org
bsmedberg%covad.net
timeless%mozdev.org
peter%propagandism.org
cmanske%jivamedia.com
mozeditor%floppymoose.com
uid502
hpradhan%hotpop.com
dbaron%dbaron.org
jfrancis%netscape.com
brade%netscape.com
jaggernaut%netscape.com
kin%netscape.com
bryner%netscape.com
glazman%netscape.com
stephend%netscape.com
alecf%flett.org
caillon%returnzero.com
peterv%netscape.com
kaie%netscape.com
dwitte%stanford.edu
jkeiser%netscape.com
sfraser%netscape.com
leon.zhang%sun.com
alecf%netscape.com
seawood%netscape.com
henry.jia%sun.com
sspitzer%netscape.com
dougt%netscape.com