2096a3d175
Bug 61339. Static accessor iid/cid should be 'const'. r=scc, sr=jband,rpotts
2000-12-21 00:38:31 +00:00
8c07dbcef8
Backing myself out to save mac build
2000-12-19 22:54:40 +00:00
02f4ae5d2d
Bug 62432, remove nsHTMLToTXTSinkStream from build. r=akkana@netscape.com, sr=vidur@netscape.com
2000-12-19 21:38:36 +00:00
2e0d69112c
fix for #58238 . sr=bienvenu. fix crash when growing the hash table
...
that contained the list of atoms. see bug report for all the details.
thanks to bienvenu, scc, brendan, and hyatt for the help.
2000-12-18 19:58:20 +00:00
c7df7a399f
51327: mozilla doesn't parse java properties files correctly
...
patch from erik, r=tao,sr=alecf
2000-12-15 00:52:09 +00:00
2ba196efa3
Checking in scc's fix for blocker bug 62818, nsSlidingSubstring::GetReadableFragment(..., kFragmentAt, ...) wasn't implemented and that caused a crash when serializing HTML to plain text. r=me.
2000-12-14 22:16:10 +00:00
29590cb129
Fix for assert when loading content from the memory cache (ie. hitting Back). r=jst
2000-12-13 23:11:32 +00:00
ecb860149b
fix bustage to XPCOM_STANDALONE from fix to bug 43591. r=dbaron sr=brendan
2000-12-13 04:36:53 +00:00
6c79d931ea
OS/2 TB breakage
...
r=jag, a=scc
Don't use initializer on template
2000-12-13 04:07:21 +00:00
3782a44b72
Fix for Solaris compiler warning from scc. r=vidur
2000-12-12 23:02:01 +00:00
ba827dfaf8
Changes to parser to allow less copying. Use of the new nsSliding[Sub]String classes so that tokens can hold substrings that keep references into the scanner buffer. Cleaned up token interface and general string usage. r=harishd,heikki sr=jst
2000-12-12 21:58:14 +00:00
1f40cba7d1
Implementation of ReadSegments to support less copying in the parser. r=rpotts, sr=jst
2000-12-12 21:57:47 +00:00
7400488426
Fixing compiler warnings, not part of the build yet. r=vidur
2000-12-12 21:52:08 +00:00
a0e417a643
Bug 51932 - Allow getting the FSSpec of a file which doesn't exist.
r=sdagley, sr=sfraser
2000-12-12 20:14:03 +00:00
7834c50d26
New file for buffer management for shared strings, written by scc. Not yet added to the build. r=vidur
2000-12-12 20:13:33 +00:00
3edfe573ec
Fix realloc bookkeeping blunder (r=waterson,pnunn, NOT PART OF DEFAULT BUILD).
2000-12-12 05:48:16 +00:00
ce70f2ae82
Fix for #62572
...
Removed obsolete code that allowed implicit declaration of nsid types.
This will cause a rebuild.
r=mccabe
sr=jband
2000-12-11 23:06:26 +00:00
ea5cb696b9
delete thread log in main thread dtor. bug 54303 code=jonsmirl@mediaone.net r=me,dougt,brendan
2000-12-11 21:55:47 +00:00
198833687a
Attempt to fix |address_of| bustage on IRIX. r=scc@mozilla.org b=59414
2000-12-10 03:13:53 +00:00
7b872d2d83
Fix bustage. Forgot to change NS_IMETHODIMP in function definitions.
2000-12-09 04:58:10 +00:00
33c4278ab5
Convert correct usage of |nsCOMPtr<T>::operator&| to use |address_of| since the operator& will soon become private. b=59414 r=disttsc@bart.nl sr=waterson@netscape.com
2000-12-09 04:46:08 +00:00
7f9852c286
Work in progress for bug 59414. Prepare to make |nsCOMPtr|'s |operator&| private to prevent many cases of accidental usage, and provide |address_of| for clients who really want a pointer to an nsCOMPtr. r=scc@mozilla.org sr=waterson@netcape.com
2000-12-09 04:45:43 +00:00
2eea32ae2b
Fix incorrect usage of nsCOMPtr where nsCOMPtr::operator& was used instead of getter_AddRefs. b=59414 r=disttsc@bart.nl sr=waterson@netscape.com
2000-12-09 04:21:51 +00:00
66a2bbb5f5
Avoid relying on static constructor for nsFSStringConversion in nsLocalFile by making all methods static and avoiding the need for an object and then doing cleanup during XPCOM shutdown. b=43591 r=dougt@netscape.com sr=waterson@netscape.com
2000-12-09 04:11:05 +00:00
7deb0a6b7a
OS/2 build break
...
Need PR_CALLBACK
2000-12-08 20:36:53 +00:00
6ed07118de
Fix for bug 61692: IDLify nsIEventQueue and nsIEventQueueService. This makes it possible to create an nsISupports proxy for calling across threads in languages other than C++ (eg JS). r=dougt@netscape.com, r=jband@netscape.com, sr=brendan@mozilla.org
2000-12-08 04:30:36 +00:00
23b20cc8d1
Fix to 8734. Make xpidl produce its' output file in the same directory it is run in. This only applies when the -o someotheroutname option isn't supplied. Previous behavior was to produce the output file in the same directory as the input file. Hopefully this'll save some confusion for first-time xpidl users.
...
Thanks to Mike Ang <mang@subcarrier.org> for fixing several errors in the initial version of this patch.
r=mang
sr=jband
2000-12-07 04:25:07 +00:00
526d571978
Usage message spelling fix courtesy Mike Ang <mang@subcarrier.org>.
...
r=mccabe
2000-12-07 04:22:24 +00:00
1ba66904f2
Fix to 54913. Add check against 'const unsigned long = -4', and centralize many const checks in xpidl_util.c from the various xpidl backends.
...
This'll cause the tree to rebuild.
sr=jband.
2000-12-07 04:17:33 +00:00
469d258cc8
fix warnings from fix to bug 61369
2000-12-06 19:40:56 +00:00
d03997d28a
Bug 61571. Improve speculative RTTI heuristics by adding one more instruction to the signature for typeinfo(). r=brendan, sr=beard
2000-12-06 00:05:45 +00:00
27f2bc6ec7
Add information to stack trace format so it can be processed by addr2line. b=59136
...
Make logging not crash when dll unloading is enabled. b=60710
r=waterson@netscape.com sr=brendan@mozilla.org
2000-12-02 16:10:50 +00:00
225afd6723
Fixes to 52520 and 13813. Move checks against [retval] usage from xpidl_typelib code to the common xpidl_util code used by all modes, and add a new check asserting that [retva] is only applied to the last parameter. XPConnect has had this restriction for a long time.
...
no r=, but it's very similar to previous approved changes. I want to get it in with other xpidl modifications, as everybody's tree needs to be rebuilt anyway.
2000-11-30 10:51:39 +00:00
3c7a9fd3d1
Fix to 13765. Disallow IDL interfaces with [shared] parameters that aren't string, wstring or native. Also disallow [shared] with nsid or [array] parameters.
...
sr=jband
2000-11-30 09:52:29 +00:00
2acfdd4b04
Better fix to problem with 57094; reinstate 57094 fix and add a conditional #undef of NS_NO_VTABLE to nsISupportsUtils.h before defining it there.
...
r=jband
2000-11-30 08:08:24 +00:00
0e85b6fe5f
Fix to 57094 is running into trouble on windows, commenting out.
2000-11-30 07:56:47 +00:00
9223fb4e50
Tweak to previous checkin. Rectify 'to to' typo in comment added to generated header files. Thanks to jband for saving me the shame.
2000-11-30 07:52:16 +00:00
0edadf5d11
Fixes for 40008, 40152, 40016, 51795, 57094.
...
Fix various aspects of xpidl, including:
don't fail on empty idl / idl containing only #includes
use error location instead of typedef location when reporting type errors
warn on interfaces that lack a uuid attribute (thanks Warren for the prod)
add include guards to generated .h files - faster mac compilation?
xpidl-generated headers don't need NS_NO_VTABLE defined.
This'll cause a tree rebuild.
r=mang (several)
sr=jband.
2000-11-30 07:51:02 +00:00
b7c28460cd
fix bug 58959 and groundwork for bug 57370. Handle interface whose name has changed correctly and add support for comparing iids without fetching. r=mccabe sr=hyatt
2000-11-30 06:55:40 +00:00
2e9adc92ab
Add some thread stress tests used to figure out problem in bug 61369. r=brendan sr=waterson
2000-11-30 05:26:15 +00:00
c7a4242a1a
fix bug 61369. Race between nsThread Init and Main. Also additions to make the interface more useful to non-C++ code. r=brendan sr=waterson
2000-11-30 05:24:53 +00:00
6798cb61fa
Oops, remove one 'bamboozler' that isn't globally exported, except in my build.
2000-11-29 21:18:03 +00:00
1c7febd7de
Bug 61241. Change trace-malloc's live object output format to mimic beard's format from Boehm. r=brendan, sr=jband
2000-11-29 21:16:53 +00:00
8478a39a8b
#56767
...
r/a=cls,leaf
Remove XP_PC - use XP_WIN or XP_OS2 explicitly
2000-11-28 23:51:05 +00:00
03dfe57690
#56767
...
r/a=cls,leaf
Remove XP_PC - use XP_WIN or XP_OS2 explicitly
2000-11-28 23:27:38 +00:00
5158e1cb08
ignore busy threads when determining whether to add a new thread to the pool. bugs 55032,56337,58404,60338, others. r=beard,brendan,dougt,saari
2000-11-28 22:38:02 +00:00
0db45ef92a
Fix linux/sparc test to work for sparc64 arch.
...
Thanks to Myth <frb@wiw.org> for the patch.
Bug #57501 r=cls@seawood.org
2000-11-28 05:27:19 +00:00
4f971553a7
Fix the BeOS implementation of Normalize().
...
Thanks to Hiromasa Kato <hiro@eng.iastate.edu> for the patch.
Bug #53014 r=cls@seawood.org sr=scc@mozilla.org
2000-11-28 01:43:09 +00:00
5b1e0aaaa4
Under BeOS, we must call Normalize() on a local file before it can be used.
...
Thanks to Hiromasa Kato <hiro@eng.ia.state.edu> for the patch. Bug #53014 . r=cls@seawood.org sr=scc@mozilla.org
2000-11-28 01:41:05 +00:00
0167f0416d
OpenVMS specific fix for defeciency in stat.
...
b=60199 r=dougt a=waterson
2000-11-27 11:19:41 +00:00
531b866424
added macros for deallocating XPCOM arrays. r=alecf@netscape.com, moa=scc@mozilla.org, sr=brendan@mozilla.org
2000-11-22 20:15:23 +00:00
4c89c9e0d6
Revamp REALLOC record for rayw's tool; add flush-log-files function (r=rayw, a=waterson, not part of build).
2000-11-22 08:05:05 +00:00
36dc294e5e
Static Module Patch. r=valeski,warren@netscape.com, sr/a=cls@netscape.com
2000-11-21 23:40:34 +00:00
fc9c54cb3d
Oops. Fixing bustage introduced by previous checkin. I forgot that XPIDL_MODULE is sometimes set by MODULE. r=blizzard Bug 59454
2000-11-21 00:18:46 +00:00
8bd122b3d5
Resurrect REQUIRES so that we have some sort of means to track intermodule dependencies. Bug #59454 r=blizzard@mozilla.org
2000-11-20 07:16:06 +00:00
b9887b3ac3
removing glowcode directives. won't affect you unless you use an obsolete version of glowcode.
2000-11-18 02:13:42 +00:00
2dabba2cb5
two line change to remove iostreams from this test list. r=alecf,jag sr=scc
2000-11-17 21:17:53 +00:00
7941b9e959
fix for #45797 - fix NS_IMPL_ISUPPORTS consumers
...
r=dveditz a=self
2000-11-17 03:41:41 +00:00
07648e22b2
Checking error code from IsDirectory().
2000-11-15 22:39:43 +00:00
6c8057de84
Fix iteration type in ConvertTo(Upper|Lower)Case in nsReadableUtils.cpp, bug=60047, r=dmose, a=scc
2000-11-15 01:58:23 +00:00
41f0fe6bb5
Bug 55891
r=brade, sr=sfraser
2000-11-14 15:58:54 +00:00
26a448532e
Checking in the correct patch for bug 59526.
2000-11-10 01:30:07 +00:00
611dee4bab
bug 59526
...
sr=waterson
r=valeski
This bullet-proofs the code so the one thread does not exit twice.
2000-11-09 23:49:57 +00:00
db8731ea9c
minor fix. sr=warren
2000-11-08 23:59:13 +00:00
55cfa3d436
#58462
...
r=av, sr/a=waterson
Add OS/2 calling conventions for plugins
2000-11-08 21:28:38 +00:00
0faff5bb11
Remove the last remnants of the misspelled nsTextFormater and remove the misspelled files. r=erik@netscape.com sr=brendan@mozilla.org b=16951
2000-11-08 03:02:17 +00:00
1e87ecd0e8
#58805
...
r=mkaply, a=blizzard
Code from jkobal to make appshell more like Windows and make timers more efficient
2000-11-02 19:36:30 +00:00
10916476ce
#58776
...
r=mkaply, a=blizzard
Code from jkobal to fix helper apps
2000-11-02 15:41:44 +00:00
444ddc36b5
fixing the broken indenting from dougt's checking (he applied my -wu patch). This is a whitespace change only (cvs diff -wu shows no change). If I don't fix this it will bother me forever!
2000-11-02 03:31:06 +00:00
3f952fb855
Fix leaks for 'unregistered' monitors and locks (55498, r=beard, sr=jband).
2000-11-01 22:21:28 +00:00
60276dd954
small tweak to get nspr logging running again. bug 58514 r=warren
2000-11-01 20:30:47 +00:00
79ac2801ac
#55813
...
r=dougt, sr/a=waterson
Support for a MOZILLA_HOME dir to specify pref location
2000-11-01 20:04:59 +00:00
aa140b75d1
Moving leak fixes from logging_102900_branch to trunk to quite tinderbox a bit more.
2000-11-01 01:41:15 +00:00
49730c167b
Wrong casts being used
...
Caused outside contributor to be unable to build
2000-10-31 15:55:46 +00:00
305ae0863f
Remove extraneous line I introduced in previous checkin. r=waterson
2000-10-31 05:39:34 +00:00
2950d05f29
Fix gcc 2.7.x bustage by defining |operator+()| for combinations involving |nsPromiseSubstring|, within |#ifdef NEED_CPP_DERIVED_TEMPLATE_OPERATORS|. (Based on scc's proposal earlier.) r=waterson
2000-10-31 04:33:32 +00:00
818494d7d5
fix 55003 null protection in closing nsOutputStream r=kandrot sr=waterson
2000-10-30 15:20:31 +00:00
4189314fdb
Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
2000-10-28 22:17:53 +00:00
17abb45de7
Fix for leak in Vprintf: taking patrick's patch instead
2000-10-28 05:24:32 +00:00
ca6ebab047
Fix for leak in Vprintf
2000-10-28 05:21:54 +00:00
298e1f6ca9
Fixed leak beard pointed out on PR_vsmprintf
2000-10-28 04:36:33 +00:00
4a0d5baedc
Added AddRef/Release method for nsLog so that they don't appear to leak. Changed comments too.
2000-10-28 03:12:02 +00:00
cbd35e264a
Remove extra 0 param. (Fix warren's bustage.) r=warren
2000-10-28 02:30:42 +00:00
f35d808e1e
Terminate statements with semicolon, not colon. (Fixing warren's bustage.)
2000-10-28 02:07:38 +00:00
39006d8481
Added def for NS_GetLog for optimized builds
2000-10-28 01:58:42 +00:00
ab8a583af3
Added NS_GetLog to export list
2000-10-27 23:50:07 +00:00
84a4779d57
Removed extra 0 arg from macro
2000-10-27 23:41:27 +00:00
5805bff56a
Added nslog.h
2000-10-27 23:25:45 +00:00
6e35f97e31
Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
2000-10-27 22:43:51 +00:00
6292c437ea
fix wrong error return; bug #57981 r=waterson, sr=brendan
2000-10-27 21:46:20 +00:00
6ce155d267
OS/2 Tinderbox break
...
Need PR_CALLBACK for OS/2, and bad include of windows.h for XP_PC...hurrah we have XP_WIN now
2000-10-27 18:30:16 +00:00
0dc463131e
Added forgotten nsILoggingService.idl
2000-10-27 06:41:11 +00:00
8a69f1b13e
Bug 47207 - removing printf / logging changes. Sticking in big toe. r=valeski,sr=waterson
2000-10-27 06:18:39 +00:00
80bd113db4
Changes to build on Mac.
2000-10-27 05:11:58 +00:00
4969105044
Bug 56793. Add support for building unix mozilla with a default
...
MOZILLA_FIVE_HOME. Build changes r=cls. Small XPCOM change sr=scc.
2000-10-21 08:33:16 +00:00
2d6e08d17f
Added new file - not in build yet.
2000-10-20 01:14:47 +00:00
f6ed582870
Fix for 56998 which blocks 56041. nsLocalFile::Exists() could return TRUE if the file in fact didn't exist. Happened with files for which the volume or dir didn't exist. r=sfraser.
2000-10-19 20:41:55 +00:00
a34a06b196
Look for 'NSPL' as well as 'shlb'. Fix for bug #45697 . r=av, sr=scc, a=rtm++.
2000-10-17 18:06:23 +00:00
da4553a248
#56636 , remove debug cruft, r/sr=blizzard
2000-10-17 17:15:36 +00:00
5188af5a8c
Removing unneeded TK_LIBS from LIBS. r=rcassin@supernova.org sr=shaver@mozilla.org
2000-10-14 17:18:42 +00:00
9188bf8d81
Fix for 53310; implement IsLowMemory() on Mac, and turn on the low memory detection thread. r=waterson, sr=scc.
2000-10-14 00:39:16 +00:00
b7f75aebe8
(Checking in for jefft@netscape.com). Fixing rtm++ bug 56129. The file input stream wasn't always setting the EOF state correctly, this caused problems with saving mail messages to the sent folder and also problems with 'Save As Draft'. r=ducarroz, r=sspitzer, sr=mscott.
2000-10-13 11:14:48 +00:00
2850a2c385
Rolling in the last of the NOXIF changes from the Netscape 6 branch, code mostly written by jfrancis. Fixes bugs 50742, 55806, 56000 and 55669. sr=kin, scc. r=kandrot, jst.
2000-10-11 22:50:14 +00:00
e278f4f966
Fix to 53929. Fix previously-broken UnregisterListener method on console service, by proxy-wrapping the service we've been asked to remove before comparing it to those in the listener list. The saved listeners are already proxy-wrapped, so the previous straight compare failed.
...
The equality check works because the proxy service caches proxies, and will always return the same wrapper.
This fixes a leak and a situation that led to some asserts in XPConnect on shutdown. (Some listeners were proxy-wrapped JS objects.)
r=jband.
2000-10-09 23:45:59 +00:00
2512c4fdb8
Fixes 64 bit address conversion in proxy. Also fixes proxing char parameters. p=jband, r=dougt, a=brendan. 52200, 26560.
2000-10-08 18:19:28 +00:00
9c1d9336f0
Fixing rtm++ bug 55587. nsAReadableString::FindChar() was returning the index from the offset to the character if found in stead of the index from the beginning of the string. r=kin, sr&a=scc
2000-10-07 01:50:36 +00:00
d7d0b2da00
Add |.get()| to NS_ConvertUCS2toUTF8 to make getting rid of some MLKs easier, bug=54740, r=scc, a=waterson
2000-10-07 00:08:47 +00:00
31f05a72fc
#55327
...
r=mkaply, a=blizzard
OS/2 only code - bring nsLocalFileOS2 to current level
2000-10-05 20:44:11 +00:00
3d7f4e7e66
r=dougt, sr=blizzard, bugzilla=55163
...
OpenVMS-specific change to handle HOME
correctly. Fixes location of appreg bug.
2000-10-05 10:12:15 +00:00
1e7caf9ea7
Fix win32 build bustage, r=scc
2000-10-05 07:48:20 +00:00
30ae0dfa95
and trying to fix OS/2 bustage
2000-10-05 07:24:51 +00:00
41d87bafb2
sr=mscott,r=vishy (this is racham's code), bugzilla=48981
...
for standalone app, the profile data has to go in the windows
app data directory - not where the app is running
2000-10-05 03:34:18 +00:00
b0e94a7f54
and a access error ... r=waterson on this fix
2000-10-05 03:28:41 +00:00
6a1323eb68
damn typo
2000-10-05 01:51:52 +00:00
3f234f0b17
bug #54601 : r=waterson, a=brendan. Fix string allocation policy -- allocate exact size, double on fault ... thanks to everybody who helped me test this patch.
2000-10-05 01:19:59 +00:00
59ad75ad57
fixed comments (so people are aware of the allocation policy)
2000-10-05 01:07:40 +00:00
e61e3bb742
bug #54712 , r=rjc, a=waterson. Added a |Distance| function to calculate the span between two iterators, then added a constructor and appropriate global function to allow |Substring|s to be made from iterators in addition to the old scheme of {index,length}
2000-10-05 01:07:02 +00:00
fa015f33ba
Replaces check for processingEvents. r=danm, darin a=hyatt
2000-10-04 19:47:12 +00:00
86276db0b2
#52455
...
r=dougt a=blizzard
These are OS/2 specific porting fixes in an XP file (plevent.c)
I'm checking it in without super-review because we desperately
need these fixes in our nightly build.
2000-10-03 00:20:05 +00:00
ac9f11352d
Fixes threadpool to maximize thread usage r=wtc@netscape.com, warren@netscape.com, brendan@mozilla.org, a=brendan@mozilla.org b=36750
2000-10-01 05:35:03 +00:00
1e16252324
#54535
...
r=mkaply, dougt, a=jband
Code from jpedemonte to fix profile creation
2000-09-29 20:40:10 +00:00
64c248b2e4
Bug 53353. Factor nsMemoryImpl create/destroy from flusher thread startup/shutdown. Avoids creation of second memory flusher thread after XPCOM shutdown. r=scc, sr=warren
2000-09-28 23:17:49 +00:00
1402d1a2c7
Merging pr3 branch to trunk:
...
Renaming "Plugins" -> "Plug-ins"
b=53976
r=ssu
a=sfraser
2000-09-28 22:52:51 +00:00
59b0d7d700
OS/2 Tinderbox breakage
...
HOME dir isn't working on OS/2, so profile can't be created so the browser won't come up.
Change to OS2 dir to get things working.
r=dr
2000-09-22 17:32:10 +00:00
bc5c04c70f
checking in patch from Jon Smirl <jonsmirl@mediaone.net> that lets us see past xptcall 'SharedStub' frames in stack traces. Because xptcall was doing a non-standard frame the debuggers and trace tools were not showing callers. This fixes that problem and will allow us to get *much* better data on crashes and other problems where the stack crosses xptcall. Tested on debug and release. r=jband@netscape.com, a=brendan@mozilla.org, a=waterson@mozilla.org. Thank you Jon!
2000-09-22 10:09:23 +00:00
9a12ae8988
Fix for #52181
r=dougt, a=buster
2000-09-21 13:45:31 +00:00
075350b1c8
Landing jar packaging from jar_restructuring_branch. r=hyatt,dprice,sfraser,dveditz,vishy,sgehani
2000-09-20 19:35:24 +00:00
367d6c0a03
Fix orangeness on Linux.
2000-09-20 07:31:53 +00:00
c71e04b66a
Bug 44352. Remove nsIMemoryPressureObserver in favor of nsIObserverService et al., and convert existing nsIMemoryPressureObserver clients. Add memory flusher thread. Add debug UI to force memory flush. r=alecf,sfraser,warren a=warren
2000-09-20 05:44:19 +00:00
387af722ce
Allow for detection and graceful failure when we stumble upon an incompatible typelibs which might exist in the future. bug 53155. NOT fixing brendan's nit about the grammar in the comment. a=brendan@mozilla.org, r=shaver@mozilla.org,mccabe@netscape.com
2000-09-19 21:42:47 +00:00
e8fdc10d23
[Not part of build] Changed getServices() to attribute services.
2000-09-19 14:48:11 +00:00
bc35c73f74
[Not part of build] Added traceCollection, getServices methods.
2000-09-19 05:40:17 +00:00
753070b755
Fixes to use atomic rename(2) if possible in nsLocalFile::MoveTo (33098, r=?),
...
plus a bunch of other fixes and cleanups:
- Fix comment misstatements of fact in nsIFile.idl, improve style slightly.
- Fix typo in comment in nsILocalFile.idl.
- Avoid gratuitous nsCString and nsXPIDLCString copy-constructions, which
entail malloc'ing, in nsLocalFileUnix.cpp's CopyTo and GetParent methods.
But do use nsXPIDLCString instead of raw nsMemory::Alloc/Free.
- Get rid of unnecessary mLL_II2L and mLL_L2II macros, use "prlong.h" API only.
Also use the LL_* macros consistently in case a Unix lacking long long type
support wants to use this code.
* BTW, the "Date" methods should be renamed to use "Time" instead -- after all
PRTime is the type, and traditionally "time" refers to the time-number, a
scalar independent of one's position on the surface of the earth, while
"date" refers to a struct full of locale-specific information derived from
time and some "environment" variables such as DST. Can we rename these
nsIFile methods before Mozilla 0.9 / Netscape 6?
- Use CHECK_mPath consistently and first, before any assertions relating to
arguments (which logically come after the 'this' parameter CHECK_mPath is
making assertions about).
- Use nsCOMPtr for singly-inheriting implementations of XPCOM interfaces, to
avoid scary-when-scaled 0-refcnt instances from being handled (these all
got a ref via QI or equivalent soon enough, but you never know). This also
removed some naked deletes.
- Canonize all paths copied into mPath to lack trailing slashes, so we don't
need to strip trailing slashes elsewhere, in higher-frequency methods (you
set path less often than you get it or a substring of it).
- ssize_t for strlen return values.
- Since shaver used a function pointer to consolidate creat/mkdir logic, but
didn't fold the necessary close of the new fd returned by non-failing creat
into the pointed-at function, I did that.
- AppendRelativePath forbids .. as a component (bounded by / or beginning or
end of string on either side), not just in the middle of fragment (so that
foo..bar is not an illegal relative pathname -- it should not be). BTW,
what the heck is the difference between NS_ERROR_FILE_UNRECOGNIZED_PATH and
...INVALID_PATH?
- SetLeafName was overallocating the new pathname buffer by failing to subtract
the old leafname's length.
- CopyTo was failing to return an NSRESULT_FOR_ERRNO(), it just called that
macro on a line by itself -- eek! It also contained redundant if (newFD
== nsnull) {...} cleanup code, it did a useless PR_GetFileInfo call, and it
leaked FDs on read or write error.
- Implemented CopyToFollowingLinks as a forwarded call to CopyTo, Unix does
not support "copying" a symlink via normal file i/o. Should we instead
lstat in CopyTo and if a link is the source of the copy, do readlink and
then symlink?
- Fixed the readlink method (GetTarget) to null-terminate the link string in
the out parameter (readlink does not do that for you).
- Lots of little nsnull vs. NULL vs. 0, == and != applied to boolean or null
literals, white-space, indentation, bracing, comment, and sloppy code order
(e.g., declaring an initialized variable that's not used till after early
returns) fixes. Also invert some return logic so that NS_OK is the normal,
least indented, final return.
2000-09-19 00:22:41 +00:00
a5f7f8a4e5
Ignore generated files
2000-09-18 17:43:15 +00:00
5df390a44e
Define QI now that XPConnect wraps JS objects; fix comments (NOT PART OF BUILD).
2000-09-18 02:31:11 +00:00
a97d2340f7
If MOZ_ENABLE_JAR_PACKAGING is set, do not install the xpcom.properties. They will be in the the jar file
2000-09-15 22:16:01 +00:00
d39d9e6d59
Bug fix for 52648 -- remaining stash of progids which I missed on
...
the mega-change yesterday. This will fix a few more issues.
r=warren
2000-09-14 23:20:49 +00:00
c3c864a472
+ Added OnSecurityChange() to nsIWebProgressListener interface.
...
+ Added dummy function to all users of nsIWebProgressListener
+ Added new security event sink.
+ Hooked up new event sink to docloader and friends.
+ Fixed memory leaks and crashes in nsSecureBrowserImpl.
+ Added AlertPrompt to nsIPrompt Interface.
+ Enabling xpcom test on unix.
Fixes bug 46872. r=valeski/rpotts
2000-09-14 22:56:56 +00:00
a2fa9edcb5
small but pervasive change to make nsIDOMSelection an xpidl interface. also broke it into 2 interfaces, nsISelection and nsISelectionPrivate. moved nsIDOMSelectionListener also to xpidl. these new idl files live in layout/base/public. r=sfraser, r=anthonyd bug 48575
2000-09-14 11:45:01 +00:00
b28b504455
File went back by mistake, reverting.
2000-09-14 04:21:39 +00:00
52476868db
fix to mal-formed contract id introduced in mega-check-in:x
2000-09-14 04:18:07 +00:00
6cc70ebd6c
Bug 37275, Changing value of all progids, and changing everywhere a progid
...
is mentioned to mention a contractid, including in identifiers.
r=warren
2000-09-13 23:57:52 +00:00
939a715e0d
changing C++ comments to C comments since for some reason
...
nscore.h is being included by intl/lwbrk/src/rulebrk.c &
modules/libpref/src/prefapi.c
r= scc@mozilla.org & brendan@mozilla.org
2000-09-13 12:22:17 +00:00
d45f7f68c3
adding |.get()| for the other half of |NS_LITERAL_STRING|
2000-09-13 03:44:58 +00:00
347980e152
if you want a pointer to the characters, you're going to have to |.get()| it
2000-09-13 02:56:52 +00:00
d8c335f9f1
fix typo
2000-09-13 02:56:13 +00:00
45bdeed06d
fixed indentation, added inheritance that makes classes cooperate in our buffer sharing strategy, added |get()| to flat classes, as we're deprecating implicit operators for this task
2000-09-13 02:41:06 +00:00
2f527d624e
fixed ugly name |nsXXXBufferHandle| --> |nsFlexBufferHandle|; hey, it may not be perfect, but it's better than 'XXX'
2000-09-13 02:27:11 +00:00
6226adb881
fixing signatures, includes
2000-09-13 02:24:55 +00:00
605a3292ea
#44426 , fix FreeBSD > 2.5, a=brendan
2000-09-12 19:57:02 +00:00
waterson%netscape.com
bratell%lysator.liu.se
sspitzer%netscape.com
tao%netscape.com
jst%netscape.com
rpotts%netscape.com
jband%netscape.com
mkaply%us.ibm.com
vidur%netscape.com
ccarlen%netscape.com
brendan%mozilla.org
mang%subcarrier.org
danm%netscape.com
dbaron%fas.harvard.edu
dmose%mozilla.org
mccabe%netscape.com
cls%seawood.org
colin%theblakes.com
dougt%netscape.com
blizzard%redhat.com
alecf%netscape.com
disttsc%bart.nl
edburns%acm.org
warren%netscape.com
bienvenu%netscape.com
scc%mozilla.org
ramiro%eazel.com
bnesse%netscape.com
shaver%mozilla.org
sfraser%netscape.com
hyatt%netscape.com
vishy%netscape.com
sgehani%netscape.com
beard%netscape.com
mcafee%netscape.com
rayw%netscape.com
mjudge%netscape.com
jdunn%netscape.com