Benjamin Smedberg
c0b8dd79be
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
507daffc50
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
b0f322f21c
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
7f933168f7
Stop using nsAreaFrame for anything other than xul:label, which is the only thing for which it does anything different from nsBlockFrame, and rename it accordingly. (Bug 471356) r+sr=roc
...
--HG--
rename : layout/generic/nsAreaFrame.cpp => layout/xul/base/src/nsXULLabelFrame.cpp
rename : layout/generic/nsAreaFrame.h => layout/xul/base/src/nsXULLabelFrame.h
2008-12-29 10:07:38 -05:00
Benjamin Smedberg
19c238fa3c
Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc
2008-10-27 20:27:55 -04:00
joshmoz@gmail.com
21632d3639
extra measure of security for password textfields on Mac OS X. b=394107 r=smorgan sr=roc
2007-09-27 09:01:32 -07:00
bzbarsky@mit.edu
e5eb2da603
Make auto-height abs-pos textfields with top and bottom offsets both set use their intrinsic height, per spec. Bug 385870, r+sr+a=dbaron
2007-08-21 20:07:25 -07:00
benjamin@smedbergs.us
0ab7558e7b
Bug 376636 - Building with gcc 4.3 and -pendatic fails due to extra semicolons, patch by Art Haas <ahaas@airmail.net>, rs=me
2007-04-23 07:21:53 -07:00
roc+@cs.cmu.edu
0054412272
Bug 374866. Reftests for text-transform. r=dbaron
2007-03-22 16:01:14 -07:00
joshmoz%gmail.com
c0c79373ed
extra measure of security for password textfields on Mac OS X. b=394107 r=smorgan sr=roc
2007-09-27 16:01:34 +00:00
bzbarsky%mit.edu
4f54ccf349
Make auto-height abs-pos textfields with top and bottom offsets both set use
...
their intrinsic height, per spec. Bug 385870, r+sr+a=dbaron
2007-08-22 03:07:25 +00:00
benjamin%smedbergs.us
3fb4912f5d
Bug 376636 - Building with gcc 4.3 and -pendatic fails due to extra semicolons, patch by Art Haas <ahaas@airmail.net>, rs=me
2007-04-23 14:22:04 +00:00
Olli.Pettay%helsinki.fi
7d17706351
Bug 373586 , r+sr=roc
2007-03-19 10:23:29 +00:00
Olli.Pettay%helsinki.fi
baa57a0277
Backout bug 373586
2007-03-19 08:13:01 +00:00
Olli.Pettay%helsinki.fi
5ded4359e5
Bug 373586 , r+sr=roc
2007-03-19 06:30:41 +00:00
dbaron%dbaron.org
b985c7a438
Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc
2007-02-24 18:33:33 +00:00
asqueella%gmail.com
3be3ebf36a
bug 257868 - remove the nsIPresShell::SetAnonymousContentFor() API, make the frames store strong refs to the anonymous content instead. Decomtaminate nsIAnonymousContentCreator.
...
r+sr=roc
2007-02-18 17:34:09 +00:00
Olli.Pettay%helsinki.fi
7bea6078a1
Bug 243370, deCOMtaminate parts of nsIFrame that come from nsIBox, part 2, p=anlan@lange.cx, r+sr=roc
2007-01-31 16:02:42 +00:00
bzbarsky%mit.edu
1556078e33
Don't do XUL collapsing stuff with HTML text inputs or HTML scrollframes. Bug
...
335628, r+sr=roc
2007-01-22 04:27:31 +00:00
bzbarsky%mit.edu
dd57a299d6
deCOMtaminate nsIFrame::GetMinSize/GetPrefSize/GetMaxSize. Bug 243370, patch
...
by Andreas Lange <anlan@lange.cx>, r+sr=roc
2007-01-08 02:57:59 +00:00
mats.palmgren%bredband.net
6798eb7996
OnChange is sometimes triggered for scripted changes. b=265047 r+sr=jst
2007-01-05 16:31:07 +00:00
dbaron%dbaron.org
116da6be23
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
bzbarsky%mit.edu
8e26e8602c
When setting the textfield value via the filepicker, tell it that it's not
...
focused so that onchange will fire as it should. Bug 355362, r+sr=jst
2006-10-15 15:39:35 +00:00
bzbarsky%mit.edu
c3ff848eca
Reinstate reflow count painting when it's needed. Bug 352851, r+sr=roc
2006-09-19 04:26:20 +00:00
pkasting%google.com
48d836c35d
Bug 339127: Add "spellcheck" attribute to control spellchecking.
...
r=brettw
sr=sicking
2006-07-29 00:04:40 +00:00
mats.palmgren%bredband.net
3c7c571960
Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part)
2006-07-06 10:43:51 +00:00
jst%mozilla.jstenback.com
82e5cf9fb2
Fixing bug 313337. Make input control onchange events only fire when the change is made by the user, not by script. r=bzbarsky@mit.edu, sr=bugmail@sicking.cc
2006-07-05 22:15:01 +00:00
Olli.Pettay%helsinki.fi
1c7c15de85
Bug 336381, Crash [@ nsRange::InsertNode] involving ranges in detached nodes, r=sicking,glazman,sr=bz
2006-05-15 19:35:12 +00:00
roc+%cs.cmu.edu
d4d6564919
Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc
2006-04-26 02:01:07 +00:00
roc+%cs.cmu.edu
64bd04b75c
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
roc+%cs.cmu.edu
dba51376ea
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
pavlov%pavlov.net
f33ad65b06
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
roc+%cs.cmu.edu
f4d2e578db
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
sharparrow1%yahoo.com
acef3d3622
Bug 327868: nsIFrameSelection cleanup. r+sr=roc
2006-02-21 00:49:04 +00:00
bzbarsky%mit.edu
f886e188c9
Make it possible to enable spell-check for text inputs too (not just
...
textareas). Make the pref controlling the whole thing live. Bug 151040, patch
by Julian Pellico <jpellico@yahoo.com>, r=bzbarsky, sr=bryner
2006-02-09 03:50:53 +00:00
roc+%cs.cmu.edu
5451e97878
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00
roc+%cs.cmu.edu
ae7c6937c0
Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc
2005-12-12 23:53:06 +00:00
bzbarsky%mit.edu
63ebcc227e
Remove no longer needed event hack. Bug 146399, patch by Vidar Haarr
...
<vhaarr+bmo@gmail.com>, r=dbaron, sr=rbs
2005-12-08 01:44:30 +00:00
brettw%gmail.com
97c9c6513a
Bug 302050: inline spellchecking for textboxes backend. r=bryner sr=bzbarsky
2005-12-05 18:07:33 +00:00
cvshook%sicking.cc
9c1b72f7f8
Bug 311827: Make GetAttr return a bool rather then an nsresult.
...
r/sr=bz
2005-10-28 11:25:24 +00:00
roc+%cs.cmu.edu
b1e6622e4e
Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman.
2005-09-19 02:15:54 +00:00
bzbarsky%mit.edu
cfe8503483
Remove the pointless nsIContent arg of nsIFrame::AttributeChanged. Bug 281390,
...
patch by Vidar Braut Haarr <vhaarr+bmo@gmail.com>, r+sr=bzbarsky
2005-09-07 16:49:21 +00:00
bzbarsky%mit.edu
9b94f5f8c3
Make frames know whether they're leaves or not from the frame construction
...
point of view; use this in the frame constructor. Bug 265367, r+sr=dbaron
2005-08-16 22:52:48 +00:00
jst%mozilla.jstenback.com
c4b8dd4f16
Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org
2005-04-28 23:48:28 +00:00
bryner%brianryner.com
5b8aeed3b1
Remove nsIPresState (bug 279699). r+sr=roc.
2005-01-27 22:52:53 +00:00
cvshook%sicking.cc
163b6ef1cc
Bug 236476: Change GetHTMLAttribute to GetParsedAttr. Also fixes bug 232706 by removing final uses of nsHTMLValue.
...
r=bz sr=jst
2005-01-25 00:02:58 +00:00
bryner%brianryner.com
5e2d6d2947
Remove nsIHTMLContent interface (bug 276959). r+sr=jst.
2005-01-12 19:45:38 +00:00
neil%parkwaycc.co.uk
416f37d27d
Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron
2005-01-01 17:26:29 +00:00
bugzilla%arlen.demon.co.uk
c2ea7ec445
Bug 270708 remove nsPresContext variable from AttributeChanged and cleaned up comment in nsIFrame.h
...
p=bugmail@q1n.org r=pkwarren sr=bzbarsky
2004-12-31 01:13:27 +00:00
smontagu%smontagu.org
1fcd4a6f26
Bug 167001: Anything below the baseline goes out of input field. Patch by Hideo Saito <saito@densan.co.jp>, r+sr=dbaron
2004-10-10 18:30:28 +00:00