From c0ab963e96631853a400497c64cfd1f6895f49d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matja=C5=BE=20Horvat?= <matjaz.horvat@gmail.com>
Date: Sun, 1 Sep 2024 19:31:58 +0200
Subject: [PATCH] Speed up Django Admin New and Edit pages (#3310)

By introducing autocomplete_fields for fields with a lot of entries. All raw_id_fields are also replaced with autocomplete_fields.
---
 pontoon/actionlog/admin.py   |  3 ++-
 pontoon/base/admin.py        | 26 ++++++++++++++++++++------
 pontoon/checks/admin.py      |  2 +-
 pontoon/sync/admin.py        |  4 ++++
 pontoon/terminology/admin.py |  2 +-
 5 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/pontoon/actionlog/admin.py b/pontoon/actionlog/admin.py
index 775cbdcfe..095c79bd1 100644
--- a/pontoon/actionlog/admin.py
+++ b/pontoon/actionlog/admin.py
@@ -16,7 +16,8 @@ class ActionLogAdmin(admin.ModelAdmin):
         "entity_id",
         "locale_id",
     )
-    raw_id_fields = (
+    autocomplete_fields = (
+        "performed_by",
         "entity",
         "translation",
     )
diff --git a/pontoon/base/admin.py b/pontoon/base/admin.py
index c48d71ae5..7c2febe56 100644
--- a/pontoon/base/admin.py
+++ b/pontoon/base/admin.py
@@ -222,6 +222,7 @@ class ProjectAdmin(admin.ModelAdmin):
         "enabled",
     )
     ordering = ("disabled",)
+    autocomplete_fields = ["contact"]
 
     @admin.display(ordering="contact__first_name")
     def contact_person(self, obj):
@@ -268,6 +269,7 @@ class ProjectLocaleAdmin(admin.ModelAdmin):
     search_fields = ["project__name", "project__slug", "locale__name", "locale__code"]
     list_display = ("pk", "project", "locale", "readonly", "pretranslation_enabled")
     ordering = ("-pk",)
+    autocomplete_fields = ["translators_group", "latest_translation"]
 
 
 class ResourceAdmin(admin.ModelAdmin):
@@ -279,17 +281,24 @@ class TranslatedResourceAdmin(admin.ModelAdmin):
     search_fields = ["resource__path", "locale__name", "locale__code"]
     list_display = ("pk", "resource", "locale")
     readonly_fields = AGGREGATED_STATS_FIELDS + ("latest_translation",)
-    raw_id_fields = ("resource",)
+    autocomplete_fields = ("resource",)
 
 
 class EntityAdmin(admin.ModelAdmin):
     search_fields = ["string", "string_plural"]
-    raw_id_fields = ("resource",)
+    autocomplete_fields = ("resource",)
 
 
 class TranslationAdmin(admin.ModelAdmin):
     search_fields = ["string"]
-    raw_id_fields = ("entity",)
+    autocomplete_fields = [
+        "entity",
+        "user",
+        "approved_user",
+        "unapproved_user",
+        "rejected_user",
+        "unrejected_user",
+    ]
 
 
 class ProjectSlugHistoryAdmin(admin.ModelAdmin):
@@ -302,13 +311,13 @@ class LocaleCodeHistoryAdmin(admin.ModelAdmin):
 
 class CommentAdmin(admin.ModelAdmin):
     search_fields = ["content"]
-    raw_id_fields = ("translation", "entity")
+    autocomplete_fields = ("author", "translation", "entity")
 
 
 class TranslationMemoryEntryAdmin(admin.ModelAdmin):
     search_fields = ["source", "target", "locale__name", "locale__code"]
     list_display = ("pk", "source", "target", "locale")
-    raw_id_fields = (
+    autocomplete_fields = (
         "entity",
         "translation",
     )
@@ -318,7 +327,7 @@ class ChangedEntityLocaleAdmin(admin.ModelAdmin):
     search_fields = ["entity__string", "locale__name", "locale__code"]
     # Entity column should come last, for it can be looong
     list_display = ("pk", "when", "locale", "entity")
-    raw_id_fields = ("entity",)
+    autocomplete_fields = ("entity",)
 
 
 class UserRoleLogActionAdmin(admin.ModelAdmin):
@@ -336,6 +345,11 @@ class UserRoleLogActionAdmin(admin.ModelAdmin):
         "created_at",
     )
     ordering = ("-created_at",)
+    autocomplete_fields = (
+        "performed_by",
+        "performed_on",
+        "group",
+    )
 
     def get_user_edit_url(self, user_pk):
         return reverse(
diff --git a/pontoon/checks/admin.py b/pontoon/checks/admin.py
index 4c6bcf313..5623b6a8b 100644
--- a/pontoon/checks/admin.py
+++ b/pontoon/checks/admin.py
@@ -5,7 +5,7 @@ from pontoon.checks import models
 
 class FailedCheckModelAdmin(admin.ModelAdmin):
     search_fields = ["message", "library"]
-    raw_id_fields = ("translation",)
+    autocomplete_fields = ("translation",)
 
     list_display = (
         "translation",
diff --git a/pontoon/sync/admin.py b/pontoon/sync/admin.py
index 0b11774c1..fe8173485 100644
--- a/pontoon/sync/admin.py
+++ b/pontoon/sync/admin.py
@@ -27,6 +27,7 @@ class ProjectSyncLogInline(admin.TabularInline):
 
 
 class SyncLogAdmin(admin.ModelAdmin):
+    search_fields = ("sync_log",)
     list_display = TIMES
     inlines = (ProjectSyncLogInline,)
 
@@ -38,15 +39,18 @@ class RepositorySyncLogInline(admin.TabularInline):
 
 
 class ProjectSyncLogAdmin(admin.ModelAdmin):
+    search_fields = ("project_sync_log",)
     list_display = (
         "project",
         "status",
     ) + TIMES
     inlines = (RepositorySyncLogInline,)
+    autocomplete_fields = ("sync_log",)
 
 
 class RepositorySyncLogAdmin(admin.ModelAdmin):
     list_display = ("repository_url",) + TIMES
+    autocomplete_fields = ("project_sync_log",)
 
     @admin.display
     def repository_url(self, obj):
diff --git a/pontoon/terminology/admin.py b/pontoon/terminology/admin.py
index f5037d70e..e37d08468 100644
--- a/pontoon/terminology/admin.py
+++ b/pontoon/terminology/admin.py
@@ -29,7 +29,7 @@ class TermAdmin(admin.ModelAdmin):
         "do_not_translate",
         "forbidden",
     )
-    raw_id_fields = ("entity",)
+    autocomplete_fields = ("entity", "created_by")
 
     def save_model(self, request, obj, form, change):
         obj.created_by = request.user