Merge pull request #10 from rwldrn/t970

Fixed ctor to throw friendlier exception on invalid media selectors [#970]

popcorn.js

@@ -202,6 +202,12 @@
       //  Check if entity is a valid string id
       matches = rIdExp.exec( entity );
 
+      try {
+        document.querySelector( entity );
+      } catch(e) {
+        throw new Error( "Popcorn.js Error: Invalid media element selector: " + entity );
+      }
+
       //  Get media element by id or object reference
       this.media = matches && matches.length && matches[ 2 ] ?
                      document.getElementById( matches[ 2 ] ) :

test/popcorn.unit.js

@@ -703,6 +703,16 @@ test( "Instance", function() {
 
 });
 
+test( "Bogus Selector", 1, function() {
+  try {
+    Popcorn( "#[object HTMLDivElement]" );
+
+    ok(false, "Should not fail silently" );
+  } catch(e) {
+    ok( true, "Exception raised on bogus selector: " + e.message );
+  }
+});
+
 module( "Popcorn Static" );
 
 test( "Popcorn.[addTrackEvent | removeTrackEvent].ref()", function() {