Bug 1070614 - Fix some TypeErrors and SyntaxErrors seen when running mozmill tests. r=Neil

--HG--
extra : amend_source : 5633a30b93a0cbd9f984b126cb3fb8e1733a12f6
extra : histedit_source : e6648f947d092d60d4386fa558301ddc6c21f4c9

mailnews/addrbook/src/nsAbAutoCompleteSearch.js

@@ -361,7 +361,7 @@ nsAbAutoCompleteSearch.prototype = {
       result._searchResults = [...result._collectedValues.values()];
       // Order by descending popularity, then primary email before secondary
       // for the same card, then for differing cards sort by email.
-      function order_by_popularity_and_email(a, b) {
+      let order_by_popularity_and_email = function(a, b) {
         return (b.popularity - a.popularity) ||
                ((a.card == b.card && a.isPrimaryEmail) ? -1 : 0) ||
                ((a.value < b.value) ? -1 : (a.value == b.value) ? 0 : 1);

mailnews/base/util/msgDBCacheManager.js

@@ -128,10 +128,7 @@ var msgDBCacheManager =
       let dbs = [];
       for (let i = 0; i < openDBs.length; i++)
         dbs.push(openDBs.queryElementAt(i, Ci.nsIMsgDatabase));
-      function sortByLastUse(a, b) {
-        return a.lastUseTime > b.lastUseTime;
-      }
-      dbs.sort(sortByLastUse);
+      dbs.sort(function(a, b) a.lastUseTime > b.lastUseTime);
       let dbsToClose = maxOpenDBs - dbs.length;
       for each (let [, db] in Iterator(dbs)) {
         if (MailServices.mailSession.IsFolderOpenInWindow(db.folder))