Bug 1804523 - Port bug 1643309: About dialog falsely claims App "is up to date" when offline. r=freaktechnik

Differential Revision: https://phabricator.services.mozilla.com/D164119

--HG--
extra : moz-landing-system : lando

mail/base/content/aboutDialog-appUpdater.js

@@ -147,6 +147,9 @@ appUpdater.prototype = {
         }
         break;
       }
+      case AppUpdater.STATUS.CHECKING_FAILED:
+        this.selectPanel("checkingFailed");
+        break;
       case AppUpdater.STATUS.NO_UPDATES_FOUND:
         this.checkingForUpdatesDelayPromise.then(() => {
           if (Services.policies.isAllowed("appUpdate")) {

mail/base/content/aboutDialog.xhtml

@@ -116,6 +116,9 @@
                 <html:div id="noUpdatesFound" class="update-deck-container">
                   <html:span>&update.noUpdatesFound;</html:span>
                 </html:div>
+                <html:div id="checkingFailed" class="update-deck-container">
+                  <html:span data-l10n-id="aboutdialog-update-checking-failed"></html:span>
+                </html:div>
                 <html:div id="otherInstanceHandlingUpdates"
                           class="update-deck-container">
                   <html:span>&update.otherInstanceHandlingUpdates;</html:span>

mail/components/preferences/general.inc.xhtml

@@ -835,6 +835,13 @@
               &update.checkForUpdatesButton.label;
             </html:button>
           </html:div>
+          <html:div id="checkingFailed" class="update-deck-container">
+            <html:span data-l10n-id="aboutdialog-update-checking-failed"></html:span>
+            <html:button accesskey="&update.checkForUpdatesButton.accesskey;"
+                         onclick="gAppUpdater.checkForUpdates();">
+              &update.checkForUpdatesButton.label;
+            </html:button>
+          </html:div>
           <html:div id="otherInstanceHandlingUpdates"
                     class="update-deck-container">
             <html:span>&update.otherInstanceHandlingUpdates;</html:span>

mail/components/preferences/preferences.xhtml

@@ -43,6 +43,7 @@
   <link rel="localization" href="messenger/preferences/preferences.ftl" />
   <link rel="localization" href="messenger/preferences/fonts.ftl" />
   <link rel="localization" href="messenger/preferences/languages.ftl" />
+  <link rel="localization" href="messenger/aboutDialog.ftl"/>
 
   <!-- Links below are only used for search-l10n-ids into subdialogs -->
   <link rel="localization" href="messenger/preferences/receipts.ftl" />

mail/locales/en-US/messenger/aboutDialog.ftl

@@ -19,3 +19,5 @@ aboutDialog-version = { $version } ({ $bits }-bit)
 #   $isodate (String): date in ISO format, e.g. 2019-01-16
 #   $bits (Number): bits of the architecture (32 or 64)
 aboutDialog-version-nightly = { $version } ({ $isodate }) ({ $bits }-bit)
+
+aboutdialog-update-checking-failed = Failed to check for updates.