Bug 1565075 - Convert textbox type=autocomplete to HTML input, part 4, a11y. r=mkmelin

calendar/base/content/dialogs/calendar-event-dialog-attendees.xul

@@ -82,7 +82,7 @@
           <hbox class="addressingWidgetCell" width="16">
             <image class="usertype-icon"/>
           </hbox>
-          <hbox class="addressingWidgetCell" flex="1">
+          <hbox class="addressingWidgetCell" flex="1" role="combobox">
             <html:input is="autocomplete-input" id="attendeesInput"
                         class="plain textbox-addressingWidget uri-element"
                         autocompletesearch="addrbook ldap"

mail/components/addrbook/content/abEditListDialog.xul

@@ -58,10 +58,11 @@
 
     <richlistbox id="addressingWidget" style="height: 15em;" onclick="awClickEmptySpace(event.target, true)">
       <richlistitem class="addressingWidgetItem" allowevents="true">
-        <hbox class="addressingWidgetCell input-container" flex="1">
+        <hbox class="addressingWidgetCell input-container" flex="1" role="combobox">
           <image onclick="this.nextElementSibling.select();" class="person-icon"/>
           <html:input is="autocomplete-input" id="addressCol1#1"
                       class="plain textbox-addressingWidget uri-element"
+                      aria-labelledby="addressCol1#1"
                       autocompletesearch="addrbook ldap"
                       autocompletesearchparam="{}"
                       timeout="300"

mail/components/addrbook/content/abMailListDialog.xul

@@ -71,10 +71,11 @@
 
     <richlistbox id="addressingWidget" style="height: 15em;" onclick="awClickEmptySpace(event.target, true)">
       <richlistitem class="addressingWidgetItem" allowevents="true">
-        <hbox class="addressingWidgetCell input-container" flex="1">
+        <hbox class="addressingWidgetCell input-container" flex="1" role="combobox">
           <image onclick="this.nextElementSibling.select();" class="person-icon"/>
           <html:input is="autocomplete-input" id="addressCol1#1"
                       class="plain textbox-addressingWidget uri-element"
+                      aria-labelledby="addressCol1#1"
                       autocompletesearch="addrbook ldap"
                       autocompletesearchparam="{}"
                       timeout="300"

mail/components/compose/content/messengercompose.xul

@@ -2035,7 +2035,7 @@
                   </menupopup>
                 </menulist>
               </hbox>
-              <hbox class="addressingWidgetCell input-container" flex="1">
+              <hbox class="addressingWidgetCell input-container" flex="1" role="combobox">
                 <html:input is="autocomplete-input" id="addressCol2#1"
                             class="plain textbox-addressingWidget uri-element"
                             aria-labelledby="addressCol1#1"

mailnews/addrbook/content/abMailListDialog.js

@@ -427,7 +427,7 @@ function awAppendNewRow(setFocus) {
       awSetFocusTo(input);
     }
   }
-  return input ? input : null;
+  return input;
 }
 
 // functions for accessing the elements in the addressing widget