From 6d91eb032bd4a9cf1cf7b55796619ebf00fe8a7f Mon Sep 17 00:00:00 2001
From: eslint <eslint@bugzilla.kewis.ch>
Date: Fri, 8 Jul 2016 11:19:26 +0200
Subject: [PATCH] Bug 1280898 - Set up eslint for calendar files - enable
 no-empty rule. r=MakeMyDay

MozReview-Commit-ID: GTKBMVIjnmC

--HG--
extra : rebase_source : ba4d6809febc5eb2ef88d245884f8ef3997bba14
---
 calendar/.eslintrc                             |  8 +++++++-
 calendar/base/backend/icaljs/calICSService.js  |  5 ++++-
 calendar/base/content/calendar-clipboard.js    |  5 ++++-
 calendar/base/content/calendar-daypicker.xml   |  9 +++------
 calendar/base/content/calendar-extract.js      |  9 +++++++--
 .../calendar-event-dialog-recurrence.js        |  2 --
 .../base/content/preferences/categories.js     |  2 ++
 calendar/base/modules/calAuthUtils.jsm         |  1 +
 calendar/base/modules/calProviderUtils.jsm     |  4 +++-
 calendar/base/src/calUtils.js                  |  8 ++------
 .../lightningTextCalendarConverter.js          |  5 +++--
 calendar/lightning/content/lightning-utils.js  |  1 +
 .../content/messenger-overlay-sidebar.js       |  3 +--
 calendar/providers/ics/calICSCalendar.js       | 10 ++++++----
 calendar/providers/memory/calMemoryCalendar.js |  4 +++-
 .../providers/storage/calStorageUpgrade.jsm    |  2 ++
 calendar/providers/wcap/calWcapSession.js      |  2 ++
 calendar/resources/content/calendarCreation.js |  4 +++-
 .../datetimepickers/datetimepickers.xml        | 18 ++++++++++++------
 calendar/resources/content/publish.js          |  2 ++
 calendar/test/unit/test_alarm.js               |  8 ++++++--
 calendar/test/unit/test_gdata_provider.js      |  4 +++-
 22 files changed, 77 insertions(+), 39 deletions(-)

diff --git a/calendar/.eslintrc b/calendar/.eslintrc
index 8bbebfee81..a27506884b 100644
--- a/calendar/.eslintrc
+++ b/calendar/.eslintrc
@@ -183,6 +183,13 @@
     // Always require use of semicolons wherever they are valid.
     "semi": [2, "always"],
 
+    // Disallow empty statements. This will report an error for:
+    // try { something(); } catch (e) {}
+    // but will not report it for:
+    // try { something(); } catch (e) { /* Silencing the error because ...*/ }
+    // which is a valid use case.
+    "no-empty": 2,
+
     // Will enable these rules later
     "block-spacing": 0,
     "no-lonely-if": 0,
@@ -190,7 +197,6 @@
     "computed-property-spacing": 0,
     "consistent-return": 0,
     "no-redeclare": 0,
-    "no-empty": 0,
 
     // The following rules will not be enabled currently, but are kept here for
     // easier updates in the future.
diff --git a/calendar/base/backend/icaljs/calICSService.js b/calendar/base/backend/icaljs/calICSService.js
index baaecb2d29..c2dacf44cc 100644
--- a/calendar/base/backend/icaljs/calICSService.js
+++ b/calendar/base/backend/icaljs/calICSService.js
@@ -416,7 +416,10 @@ calIcalComponent.prototype = {
             if (dt && dt.timezone) {
                 this._getNextParentVCalendar().addTimezoneReference(dt.timezone);
             }
-        } catch (e) {}
+        } catch (e) {
+            // If there is an issue adding the timezone reference, don't make
+            // that break adding the property.
+        }
 
         let jsprop = unwrapSingle(ICAL.Property, prop);
         this.innerObject.addProperty(jsprop);
diff --git a/calendar/base/content/calendar-clipboard.js b/calendar/base/content/calendar-clipboard.js
index 0ce0fc3587..baf87bbb68 100644
--- a/calendar/base/content/calendar-clipboard.js
+++ b/calendar/base/content/calendar-clipboard.js
@@ -134,7 +134,10 @@ function pasteFromClipboard() {
                                       .createInstance(Components.interfaces.calIIcsParser);
             try {
                 icsParser.parseString(data);
-            } catch (e) {}
+            } catch (e) {
+                // Ignore parser errors from the clipboard data, if it fails
+                // there will just be 0 items.
+            }
 
             let items = icsParser.getItems({});
             if (items.length == 0) {
diff --git a/calendar/base/content/calendar-daypicker.xml b/calendar/base/content/calendar-daypicker.xml
index 9b94d3f6c9..12508458b4 100644
--- a/calendar/base/content/calendar-daypicker.xml
+++ b/calendar/base/content/calendar-daypicker.xml
@@ -120,13 +120,10 @@
 
       <constructor><![CDATA[
         Components.utils.import("resource://gre/modules/Services.jsm");
+        Components.utils.import("resource://gre/modules/Preferences.jsm");
+
+        this.weekStartOffset = Preferences.get("calendar.week.start", 0);
 
-        this.weekStartOffset = 0;
-        try {
-            this.weekStartOffset =
-                Services.prefs.getIntPref("calendar.week.start");
-        } catch (ex) {
-        }
         var props =
             Services.strings.createBundle(
                 "chrome://calendar/locale/dateFormat.properties");
diff --git a/calendar/base/content/calendar-extract.js b/calendar/base/content/calendar-extract.js
index 3d7792a64e..ae11f7fb08 100644
--- a/calendar/base/content/calendar-extract.js
+++ b/calendar/base/content/calendar-extract.js
@@ -22,7 +22,9 @@ var calendarExtract = {
 
             try {
                 langName = cal.calGetString("languageNames", langName, null, "global");
-            } catch (ex) {}
+            } catch (ex) {
+                // If no language name is found that is ok, keep the technical term
+            }
 
             let label = cal.calGetString("calendar", "extractUsing", [langName]);
             if (localeParts[3] != "") {
@@ -115,7 +117,10 @@ var calendarExtract = {
                 sel = document.getElementById("multimessage")
                               .contentDocument.querySelector(".iframe-container iframe")
                               .contentDocument.getSelection();
-            } catch (ex) {}
+            } catch (ex) {
+                // If Thunderbird Conversations is not installed that is fine,
+                // we will just have a null selection.
+            }
         }
         let collected = extractor.extract(title, content, date, sel);
 
diff --git a/calendar/base/content/dialogs/calendar-event-dialog-recurrence.js b/calendar/base/content/dialogs/calendar-event-dialog-recurrence.js
index 5d2b0945a7..65552d41a4 100644
--- a/calendar/base/content/dialogs/calendar-event-dialog-recurrence.js
+++ b/calendar/base/content/dialogs/calendar-event-dialog-recurrence.js
@@ -562,8 +562,6 @@ function updateRecurrenceRange() {
 
     var durationSelection = document.getElementById("recurrence-duration")
                                     .selectedItem.value;
-    if (durationSelection == "forever") {
-    }
 
     if (durationSelection == "ntimes") {
         rangeTimesCount.removeAttribute("disabled");
diff --git a/calendar/base/content/preferences/categories.js b/calendar/base/content/preferences/categories.js
index a1648800e7..6359399db1 100644
--- a/calendar/base/content/preferences/categories.js
+++ b/calendar/base/content/preferences/categories.js
@@ -129,6 +129,7 @@ var gCategoriesPane = {
         try {
             currentColor = categoryPrefBranch.getCharPref(categoryNameFix);
         } catch (ex) {
+            // If the pref doesn't exist, don't bail out here.
         }
 
         if (list.selectedItem) {
@@ -157,6 +158,7 @@ var gCategoriesPane = {
         try {
             categoryPrefBranch.clearUserPref(categoryNameFix);
         } catch (ex) {
+            // If the pref doesn't exist, don't bail out here.
         }
 
         // Remove category entry from listbox and gCategoryList.
diff --git a/calendar/base/modules/calAuthUtils.jsm b/calendar/base/modules/calAuthUtils.jsm
index eb8240e05c..a98d04292f 100644
--- a/calendar/base/modules/calAuthUtils.jsm
+++ b/calendar/base/modules/calAuthUtils.jsm
@@ -155,6 +155,7 @@ cal.auth = {
                 }
             }
         } catch (exc) {
+            // If no logins are found, fall through to the return statement below.
         }
         return false;
     }
diff --git a/calendar/base/modules/calProviderUtils.jsm b/calendar/base/modules/calProviderUtils.jsm
index 3918e885a4..0de4dff45e 100644
--- a/calendar/base/modules/calProviderUtils.jsm
+++ b/calendar/base/modules/calProviderUtils.jsm
@@ -260,7 +260,9 @@ cal.getEmailIdentityOfCalendar = function calGetEmailIdentityOfCalendar(aCalenda
         let identity = null;
         try {
             account = MailServices.accounts.defaultAccount;
-        } catch (exc) {}
+        } catch (exc) {
+            // If no default account can be found that is fine
+        }
 
         for (let i = 0; accounts && (i < accounts.length) && (!account || !identity); ++i) {
             if (!account) { // Pick an account only if none was set (i.e there is no default account)
diff --git a/calendar/base/src/calUtils.js b/calendar/base/src/calUtils.js
index b581db269a..ccad2e767f 100644
--- a/calendar/base/src/calUtils.js
+++ b/calendar/base/src/calUtils.js
@@ -914,14 +914,10 @@ function _log(message, flag) {
  *              properties should be logged.
  */
 function LOG(aArg) {
-    var shouldLog = false;
-    try {
-        shouldLog = Services.prefs.getBoolPref("calendar.debug.log");
-    } catch (ex) {}
-
-    if (!shouldLog) {
+    if (!Preferences.get("calendar.debug.log", false)) {
         return;
     }
+
     ASSERT(aArg, "Bad log argument.", false);
     var string = aArg;
     // We should just dump() both String objects, and string primitives.
diff --git a/calendar/lightning/components/lightningTextCalendarConverter.js b/calendar/lightning/components/lightningTextCalendarConverter.js
index 56e2b3de34..f55296c45a 100644
--- a/calendar/lightning/components/lightningTextCalendarConverter.js
+++ b/calendar/lightning/components/lightningTextCalendarConverter.js
@@ -67,11 +67,12 @@ ltnMimeConverter.prototype = {
                 let msgWindow = null;
                 try {
                     let msgUrl = this.uri.QueryInterface(Components.interfaces.nsIMsgMailNewsUrl);
-                    // msgWindow is optional in some scenarios
-                    // (e.g. gloda in action, throws NS_ERROR_INVALID_POINTER then)
                     msgWindow = msgUrl.msgWindow;
                 } catch (exc) {
+                    // msgWindow is optional in some scenarios
+                    // (e.g. gloda in action, throws NS_ERROR_INVALID_POINTER then)
                 }
+
                 if (msgWindow) {
                     let sinkProps = msgWindow.msgHeaderSink.properties;
                     sinkProps.setPropertyAsInterface("itipItem", itipItem);
diff --git a/calendar/lightning/content/lightning-utils.js b/calendar/lightning/content/lightning-utils.js
index abfd2a75e3..f46c82896d 100644
--- a/calendar/lightning/content/lightning-utils.js
+++ b/calendar/lightning/content/lightning-utils.js
@@ -64,6 +64,7 @@ function ltnInitMailIdentitiesRow() {
         }
         menuListSelectItem("email-identity-menulist", sel ? sel.key : "none");
     } catch (exc) {
+        // Don't select anything if the message identity can't be found
     }
 }
 
diff --git a/calendar/lightning/content/messenger-overlay-sidebar.js b/calendar/lightning/content/messenger-overlay-sidebar.js
index 039e719d90..641df8235d 100644
--- a/calendar/lightning/content/messenger-overlay-sidebar.js
+++ b/calendar/lightning/content/messenger-overlay-sidebar.js
@@ -606,8 +606,7 @@ function LtnObserveDisplayDeckChange(event) {
         return;
     }
 
-    var id = null;
-    try { id = deck.selectedPanel.id; } catch (e) { }
+    let id = deck.selectedPanel && deck.selectedPanel.id;
 
     // Switch back to mail mode in case we find that this
     // notification has been fired but we're still in calendar or task mode.
diff --git a/calendar/providers/ics/calICSCalendar.js b/calendar/providers/ics/calICSCalendar.js
index 4c73cdb260..6a2983024d 100644
--- a/calendar/providers/ics/calICSCalendar.js
+++ b/calendar/providers/ics/calICSCalendar.js
@@ -424,6 +424,7 @@ calICSCalendar.prototype = {
             httpChannel = request.QueryInterface(Components.interfaces.nsIHttpChannel);
             requestSucceeded = httpChannel.requestSucceeded;
         } catch (e) {
+            // This may fail if it was not a http channel, handled later on.
         }
 
         if (httpChannel) {
@@ -675,12 +676,13 @@ calICSCalendar.prototype = {
                 let file = backupDir.clone();
                 file.append(filteredFiles[i].name);
 
-                // This can fail because of some crappy code in nsILocalFile.
-                // That's not the end of the world.  We can try to remove the
-                // file the next time around.
                 try {
                     file.remove(false);
-                } catch (ex) {}
+                } catch (ex) {
+                    // This can fail because of some crappy code in
+                    // nsILocalFile.  That's not the end of the world.  We can
+                    // try to remove the file the next time around.
+                }
             }
             return;
         }
diff --git a/calendar/providers/memory/calMemoryCalendar.js b/calendar/providers/memory/calMemoryCalendar.js
index a69cd3824b..2862d46806 100644
--- a/calendar/providers/memory/calMemoryCalendar.js
+++ b/calendar/providers/memory/calMemoryCalendar.js
@@ -74,7 +74,9 @@ calMemoryCalendar.prototype = {
 
         try {
             listener.onDeleteCalendar(calendar, Components.results.NS_OK, null);
-        } catch (ex) {}
+        } catch (ex) {
+            // Don't bail out if the listener fails
+        }
     },
 
     mRelaxedMode: undefined,
diff --git a/calendar/providers/storage/calStorageUpgrade.jsm b/calendar/providers/storage/calStorageUpgrade.jsm
index e20a0f0039..6e3d6ed5f0 100644
--- a/calendar/providers/storage/calStorageUpgrade.jsm
+++ b/calendar/providers/storage/calStorageUpgrade.jsm
@@ -1546,6 +1546,7 @@ upgrade.v22 = function upgrade_v22(db, version) {
                             try {
                                 ritem.count = aCount;
                             } catch (exc) {
+                                // Don't fail if setting an invalid count
                             }
                         } else {
                             if (aEndDate) {
@@ -1562,6 +1563,7 @@ upgrade.v22 = function upgrade_v22(db, version) {
                         try {
                             ritem.interval = aInterval;
                         } catch (exc) {
+                            // Don't fail if setting an invalid interval
                         }
 
                         let rtypes = {
diff --git a/calendar/providers/wcap/calWcapSession.js b/calendar/providers/wcap/calWcapSession.js
index 8280c05f73..d5bd2a72b0 100644
--- a/calendar/providers/wcap/calWcapSession.js
+++ b/calendar/providers/wcap/calWcapSession.js
@@ -812,6 +812,8 @@ calWcapSession.prototype = {
                 return calendar;
             }
         } catch (exc) {
+            // Fall through to the return statement below in case the uncached
+            // calendar can't be retrieved.
         }
         return null;
     },
diff --git a/calendar/resources/content/calendarCreation.js b/calendar/resources/content/calendarCreation.js
index 54c56f9399..18d00dfc70 100644
--- a/calendar/resources/content/calendarCreation.js
+++ b/calendar/resources/content/calendarCreation.js
@@ -75,7 +75,9 @@ function onSelectProvider(type) {
     try {
         tempCal = Components.classes["@mozilla.org/calendar/calendar;1?type=" + type]
                             .createInstance(Components.interfaces.calICalendar);
-    } catch (e) {}
+    } catch (e) {
+        // keep tempCal undefined if the calendar can not be created
+    }
 
     if (tempCal && tempCal.getProperty("cache.always")) {
         cache.oldValue = cache.checked;
diff --git a/calendar/resources/content/datetimepickers/datetimepickers.xml b/calendar/resources/content/datetimepickers/datetimepickers.xml
index 42cc204431..89c3ab08ef 100644
--- a/calendar/resources/content/datetimepickers/datetimepickers.xml
+++ b/calendar/resources/content/datetimepickers/datetimepickers.xml
@@ -84,7 +84,9 @@
          var text = document.getAnonymousElementByAttribute(this, "anonid", "date-textbox");
           try {
             text.value = this.formatDate(val);
-          } catch (ex) {}
+          } catch (ex) {
+            // Don't fail if date formatting fails.
+          }
           return val;
         ]]></setter>
       </property>
@@ -101,7 +103,9 @@
             // format fails if year <= 1600 on win2k, so try format first.
             try {
               prettyDate = this.formatDate(date);
-            } catch (ex) {} // fall thru
+            } catch (ex) {
+              // Don't fail if date formatting fails.
+            }
           }
           if (date && prettyDate) {
             this.mValue = date;
@@ -302,7 +306,9 @@
               let formattedValue = null;
               try {
                 formattedValue = this.formatDate(aValue);
-              } catch (ex) {} // fall thru
+              } catch (ex) {
+                // formattedValue is checked for a value below
+              }
 
               if (formattedValue) {
                 // format succeeded, safe to set value
@@ -1691,9 +1697,6 @@
         <parameter name="aValue"/>
         <body>
           <![CDATA[
-            // Try/catch this, since some people are apparently
-            // interested in using the datepicker in remote apps, where
-            // calGetString wouldn't exist
             try {
               var noon = calGetString("dateFormat", "noon");
               if (aValue.toLowerCase() == noon.toLowerCase()) {
@@ -1705,6 +1708,9 @@
                 return new Date(0, 0, 0, 0, 0, 0, 0);
               }
             } catch (ex) {
+              // Try/catch this, since some people are apparently
+              // interested in using the datepicker in remote apps, where
+              // calGetString wouldn't exist
             }
 
             var time = null;
diff --git a/calendar/resources/content/publish.js b/calendar/resources/content/publish.js
index 99e05d32a1..efdf7c1fd4 100644
--- a/calendar/resources/content/publish.js
+++ b/calendar/resources/content/publish.js
@@ -213,7 +213,9 @@ var publishingListener = {
             channel = request.QueryInterface(Components.interfaces.nsIHttpChannel);
             requestSucceeded = channel.requestSucceeded;
         } catch (e) {
+            // Don't fail if it is not a http channel, will be handled below
         }
+
         if (channel && !requestSucceeded) {
             Services.prompt.alert(null, calGetString("calendar", "genericErrorTitle"),
                                   props.formatStringFromName('httpPutError', [channel.responseStatus, channel.responseStatusText], 2));
diff --git a/calendar/test/unit/test_alarm.js b/calendar/test/unit/test_alarm.js
index 7ab5b941b4..9a3a9659d1 100644
--- a/calendar/test/unit/test_alarm.js
+++ b/calendar/test/unit/test_alarm.js
@@ -145,7 +145,9 @@ function test_audio_alarm() {
     try {
         alarm.addAttendee(attendee);
         do_throw("AUDIO alarm should not be able to save attendees");
-    } catch (e) {}
+    } catch (e) {
+        // TODO looks like this test is disabled. Why?
+    }
 
     // Test attachments
     let sound = cal.createAttachment();
@@ -169,7 +171,9 @@ function test_audio_alarm() {
     try {
         alarm.addAttachment(sound2);
         do_throw("Adding a second attachment should fail for type AUDIO");
-    } catch (e) {}
+    } catch (e) {
+        // TODO looks like this test is disabled. Why?
+    }
 
     // Deleting should work
     alarm.deleteAttachment(sound);
diff --git a/calendar/test/unit/test_gdata_provider.js b/calendar/test/unit/test_gdata_provider.js
index 34b931b10e..f7697817a5 100644
--- a/calendar/test/unit/test_gdata_provider.js
+++ b/calendar/test/unit/test_gdata_provider.js
@@ -230,7 +230,9 @@ GDataServer.prototype = {
             try {
                 body = JSON.parse(NetUtil.readInputStreamToString(request.bodyInputStream,
                                   request.bodyInputStream.available()));
-            } catch (e) {}
+            } catch (e) {
+                // Don't bail if json parsing failed.
+            }
 
             this.lastMethod = method;
             return nextHandler(request, response, method, parameters, body);