Bug 826732 - fix some JavaScript strict warning seen during "make mozmill" - part 3. r=Standard8,a=Standard8 for warnings fixes for CLOSED TREE

editor/ui/dialogs/content/EdDialogCommon.js

@@ -944,13 +944,11 @@ function FillLinkMenulist(linkMenulist, headingsArray)
     if (anchorList.length)
     {
       // case insensitive sort
-      function compare(a, b)
-      {
-        if(a.sortkey < b.sortkey) return -1;
-        if(a.sortkey > b.sortkey) return 1;
+      anchorList.sort(function compare(a, b) {
+        if (a.sortkey < b.sortkey) return -1;
+        if (a.sortkey > b.sortkey) return 1;
         return 0;
-      }
-      anchorList.sort(compare);
+      });
 
       for (i = 0; i < anchorList.length; i++)
         createMenuItem(menupopup,anchorList[i].anchor);

mail/base/content/msgHdrViewOverlay.js

@@ -2774,7 +2774,7 @@ nsDummyMsgHeader.prototype =
   markHasAttachments : function(hasAttachments) {},
   messageSize : 0,
   recipients : null,
-  from : null,
+  author: null,
   subject : "",
   get mime2DecodedSubject() { return this.subject; },
   ccList : null,

mail/components/addrbook/content/abTrees.js

@@ -51,10 +51,9 @@ abDirTreeItem.prototype = {
       }
 
       // We sort children based on their names
-      function nameSort(a, b) {
+      this._children.sort(function nameSort(a, b) {
         return a._directory.dirName.localeCompare(b._directory.dirName);
-      }
-      this._children.sort(nameSort);
+      });
     }
     return this._children;
   },

mail/test/mozmill/composition/test-send-button.js

@@ -121,9 +121,12 @@ function test_send_enabled_address_contacts_sidebar() {
 
   // Open Contacts sidebar and use our contact.
   cwc.window.toggleAddressPicker();
-  let sidebar = cwc.window.document.getElementById("sidebar");
-  cwc.waitForElement(new elib.ID(sidebar.contentDocument, "ccButton"));
+
+  let sidebar = cwc.e("sidebar");
+  wait_for_frame_load(sidebar,
+    "chrome://messenger/content/addressbook/abContactsPanel.xul");
   sidebar.contentDocument.getElementById("ccButton").click();
+
   // The recipient is filled in, Send must be enabled.
   check_send_commands_state(cwc, true);