From 7f22cfb9d643657de7f8762751d6a8652eda9804 Mon Sep 17 00:00:00 2001 From: Alexander Schmitz Date: Fri, 22 Nov 2024 16:57:02 +0000 Subject: [PATCH] Bug 1928452 - Change in app notification type donation_old to donation_browser. r=freaktechnik Differential Revision: https://phabricator.services.mozilla.com/D229794 --HG-- extra : rebase_source : 27946b6f505b19c7a8dc50e2aa33ae4ef54e9175 --- .../inappnotifications/modules/NotificationManager.sys.mjs | 4 ++-- .../inappnotifications/test/unit/test_notification_manager.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mail/components/inappnotifications/modules/NotificationManager.sys.mjs b/mail/components/inappnotifications/modules/NotificationManager.sys.mjs index 3922da06cb..dbdf718b78 100644 --- a/mail/components/inappnotifications/modules/NotificationManager.sys.mjs +++ b/mail/components/inappnotifications/modules/NotificationManager.sys.mjs @@ -45,7 +45,7 @@ export class NotificationManager extends EventTarget { /** * Check if a notification has UI that should be shown. The only notification - * type that doesn't have UI is the "donation_old" type, which imitates the + * type that doesn't have UI is the "donation_browser" type, which imitates the * appeal behavior, where we open a webseite in the user's browser. * Setting name and private explicitly to work around jsdoc parsing issue. * @@ -55,7 +55,7 @@ export class NotificationManager extends EventTarget { * @returns {boolean} If this notification should show a popup in the UI. */ static #isNotificationWithUI(notification) { - return notification.type !== "donation_old"; + return notification.type !== "donation_browser"; } /** diff --git a/mail/components/inappnotifications/test/unit/test_notification_manager.js b/mail/components/inappnotifications/test/unit/test_notification_manager.js index e8c40a4ceb..a254af44f1 100644 --- a/mail/components/inappnotifications/test/unit/test_notification_manager.js +++ b/mail/components/inappnotifications/test/unit/test_notification_manager.js @@ -365,7 +365,7 @@ add_task(async function test_showDonationsOldNotification() { const notifications = [ { id: "olddonation", - type: "donation_old", + type: "donation_browser", start_at: new Date(now - SAFETY_MARGIN_MS).toISOString(), end_at: new Date(now + SAFETY_MARGIN_MS).toISOString(), URL: "about:blank",