Bug 1710257 - Back out changeset 61ebefcbdd36 (bug 1699386) due to compiler warnings on Windows. r=backout a=rjl

-fPIC is not a valid argument for clang-cl.

--HG--
extra : histedit_source : 56a597c015d3cdb35ee4e22f22970ff69352c498

mail/base/moz.build

@@ -66,4 +66,3 @@ for var in ("OS_CPPFLAGS", "OS_CXXFLAGS", "DEBUG", "OPTIMIZE", "FRAMEPTR"):
     cxx_flags += COMPILE_FLAGS[var] or []
 
 DEFINES["CXXFLAGS"] = " ".join(cxx_flags)
-DEFINES["CXXFLAGS"] += " -fPIC"

third_party/botan/botan.mozbuild

@@ -27,7 +27,7 @@ if CONFIG['OS_ARCH'] == 'WINNT':
     botan_os = 'windows'
 elif CONFIG['OS_ARCH'] == 'Linux':
     botan_os = 'linux'
-    CXXFLAGS += ['-pthread', "-fPIC"]
+    CXXFLAGS += ['-pthread']
 else:
     botan_os = CONFIG['OS_ARCH'].lower()
 

third_party/rnp/moz.build

@@ -79,8 +79,6 @@ if CONFIG["MZLA_SYSTEM_BZIP2"]:
 else:
     LOCAL_INCLUDES += ["../bzip2"]
 
-CXXFLAGS += ["-fPIC"]
-
 if CONFIG["CC_TYPE"] == "clang-cl":
     LOCAL_INCLUDES += [
         "../niwcompat",

third_party/rnpdefs.mozbuild

@@ -27,8 +27,6 @@ if CONFIG["CC_TYPE"] == "clang-cl":
         "-Wno-macro-redefined",  # 'WIN32_LEAN_AND_MEAN' macro redefined
     ]
     USE_STATIC_LIBS = True
-CFLAGS += ["-fPIC"]
-CXXFLAGS += ["-fPIC"]
 
 # MOZ_LIBSTDCXX_TARGET_VERSION should only be set for Taskcluster builds
 # targeting Linux. The below changes those builds to statically link to