Bug 1153671 - Part 2: Remove non-standard for-each-in from remaining tests. r=Ratty a=ewong

suite/common/downloads/tests/chrome/test_cleanup_search.xul

@@ -80,7 +80,7 @@ function test()
     "VALUES (?1, ?2, ?3, ?4)");
 
   try {
-    for each (let site in ["delete.me", "i.live"]) {
+    for (let site of ["delete.me", "i.live"]) {
       stmt.bindByIndex(0, "Super Pimped Download");
       stmt.bindByIndex(1, filePath);
       stmt.bindByIndex(2, "http://" + site + "/file");

suite/common/downloads/tests/chrome/test_open_properties.xul

@@ -102,9 +102,9 @@ function runTest()
       "state, currBytes, maxBytes, preferredAction, autoResume) " +
     "VALUES (:name, :source, :target, :startTime, :endTime, :state, " +
       ":currBytes, :maxBytes, :preferredAction, :autoResume)");
-  for each (var dl in DoneDownloadData) {
-    for (var prop in dl)
-      stmt.params[prop] = dl[prop];
+  for (let dl of DoneDownloadData) {
+    for (let [prop, value] of Object.entries(dl))
+      stmt.params[prop] = value;
 
     stmt.execute();
   }
@@ -148,9 +148,9 @@ function runTest()
           // Populate the download manager with an active download now, and
           // rebuild the list
           stmt.reset();
-          for each (var dl in ActiveDownloadData) {
-            for (var prop in dl)
-              stmt.params[prop] = dl[prop];
+          for (let dl of ActiveDownloadData) {
+            for (let [prop, value] of Object.entries(dl))
+              stmt.params[prop] = value;
 
             stmt.execute();
           }

suite/common/downloads/tests/chrome/test_search_clearlist.xul

@@ -86,7 +86,7 @@ function test()
   sites.push(searchTerm);
 
   try {
-    for each (let site in sites) {
+    for (let site of sites) {
       stmt.bindByIndex(0, filePath);
       stmt.bindByIndex(1, "http://" + site + "/file");
       stmt.bindByIndex(2, dm.DOWNLOAD_FINISHED);