Bug 1802815 - Remove hdr.setPriorityString. r=benc

Differential Revision: https://phabricator.services.mozilla.com/D163291

--HG--
extra : rebase_source : a55ac968122510f5c76a8f779e4c3cb7e077c185
extra : amend_source : 9e42e13e2a70a48b601afea796fe40f1af1a7e97

mailnews/base/public/nsIMsgHdr.idl

@@ -32,7 +32,6 @@ interface nsIMsgDBHdr : nsISupports
     void markHasAttachments(in boolean hasAttachments);
 
     attribute nsMsgPriorityValue priority;
-    void setPriorityString(in string priority);
 
     /* flag handling routines */
     attribute unsigned long flags;

mailnews/db/msgdb/src/nsMsgHdr.cpp

@@ -448,16 +448,6 @@ NS_IMETHODIMP nsMsgHdr::GetLineCount(uint32_t* result) {
   return res;
 }
 
-NS_IMETHODIMP nsMsgHdr::SetPriorityString(const char* priority) {
-  nsMsgPriorityValue priorityVal = nsMsgPriority::Default;
-
-  // We can ignore |NS_MsgGetPriorityFromString()| return value,
-  // since we set a default value for |priorityVal|.
-  NS_MsgGetPriorityFromString(priority, priorityVal);
-
-  return SetPriority(priorityVal);
-}
-
 NS_IMETHODIMP nsMsgHdr::GetAuthor(char** resultAuthor) {
   return m_mdb->RowCellColumnToCharPtr(GetMDBRow(), m_mdb->m_senderColumnToken,
                                        resultAuthor);

mailnews/local/src/nsParseMailbox.cpp

@@ -1407,9 +1407,14 @@ nsresult nsParseMailMessageState::FinalizeHeaders() {
         }
         m_newMsgHdr->SetDate(datePRTime);
 
-        if (priority)
-          m_newMsgHdr->SetPriorityString(priority->value);
-        else if (priorityFlags == nsMsgPriority::notSet)
+        if (priority) {
+          nsMsgPriorityValue priorityVal = nsMsgPriority::Default;
+
+          // We can ignore |NS_MsgGetPriorityFromString()| return value,
+          // since we set a default value for |priorityVal|.
+          NS_MsgGetPriorityFromString(priority->value, priorityVal);
+          m_newMsgHdr->SetPriority(priorityVal);
+        } else if (priorityFlags == nsMsgPriority::notSet)
           m_newMsgHdr->SetPriority(nsMsgPriority::none);
         if (keywords) {
           // When there are many keywords, some may not have been written