Bug 1915397 - remove logically dead code in nsMsgDBView::​SecondaryCompare. r=welpy-cw

CID: 1539175

For id the code bails out already at https://searchfox.org/comm-central/rev/498e1dfdb84c8c9fcc4a0afc20acc9bd1f061500/mailnews/base/src/nsMsgDBView.cpp#4189

Differential Revision: https://phabricator.services.mozilla.com/D220400

--HG--
extra : rebase_source : 981c4d0e553666a72cae3d37ba60b66ae5bf6f45
extra : amend_source : d1e5bbe198966514f9a70d7cb5efdd737acfc492
This commit is contained in:
Magnus Melin 2024-09-02 17:06:11 +03:00
Родитель fa65a2c49b
Коммит b56bed310c
1 изменённых файлов: 2 добавлений и 7 удалений

Просмотреть файл

@ -4244,13 +4244,8 @@ int32_t nsMsgDBView::SecondaryCompare(nsMsgKey key1, nsIMsgFolder* folder1,
return FnSortIdKey(&EntryInfo1, &EntryInfo2, &ctx);
case kU32:
if (sortType == nsMsgViewSortType::byId) {
EntryInfo1.dword = EntryInfo1.id;
EntryInfo2.dword = EntryInfo2.id;
} else {
GetLongField(hdr1, sortType, &EntryInfo1.dword, colHandler);
GetLongField(hdr2, sortType, &EntryInfo2.dword, colHandler);
}
GetLongField(hdr1, sortType, &EntryInfo1.dword, colHandler);
GetLongField(hdr2, sortType, &EntryInfo2.dword, colHandler);
return FnSortIdUint32(&EntryInfo1, &EntryInfo2, &ctx);
default:
return 0;