Bug 1543559 - Fix CSS errors detected using static analysis tests; r=mkmelin

--HG--
rename : mail/themes/windows/mail/icons/tick.png => mail/themes/shared/mail/icons/tick.png

calendar/base/content/dialogs/calendar-event-dialog.css

@@ -41,10 +41,3 @@ freebusy-grid {
     -moz-binding: url(chrome://calendar/content/calendar-event-dialog-freebusy.xml#freebusy-grid);
     -moz-user-focus: normal;
 }
-
-/****************************************************************************************/
-
-timezone-page {
-    -moz-binding: url(chrome://calendar/content/calendar-event-dialog-timezone.xml#timezone-page);
-    -moz-user-focus: normal;
-}

calendar/base/themes/common/calendar-attendees.css

@@ -267,7 +267,6 @@ html|span.ac-emphasize-text {
     .item-attendees-cell {
         border-radius: 3px;
         --attendees-focusBorder: var(--attendees-currentColor);
-        --attendees-focusBottomBorder: var(--attendees-currentColor);
         --attendees-focusImage: linear-gradient(rgba(131, 183, 249, .28),
                                                 rgba(131, 183, 249, .5));
         --attendees-focusShadow: inset 0 0 1px white, inset 0 0 1px white;
@@ -279,7 +278,6 @@ html|span.ac-emphasize-text {
     #calendar-event-dialog-inner .item-attendees-cell {
         --attendees-focusColor: rgb(123, 195, 255);
         --attendees-focusBorder: var(--attendees-focusColor);
-        --attendees-focusBottomBorder: var(--attendees-focusColor);
         --attendees-focusImage: linear-gradient(rgb(205, 232, 255),
                                                 rgb(205, 232, 255));
         --attendees-focusShadow: none;

calendar/base/themes/common/calendar-task-view.css

@@ -199,7 +199,7 @@ window[toolboxId="task-actions-toolbox"] #modelist menuitem:first-child {
 :root[lwt-tree-brighttext] #calendar-add-task-button:not([disabled="true"]):hover:active {
     background: rgba(255, 255, 255, .4);
     border-color: rgba(255, 255, 255, .7);
-    box-shadow: rgba(255, 255, 255, .4) inset;
+    box-shadow: 0 0 rgba(255, 255, 255, .4) inset;
 }
 
 #calendar-add-task-button > .toolbarbutton-text {

calendar/base/themes/common/calendar-views.css

@@ -6,7 +6,6 @@ window {
     --viewColor: #000;
     --viewBackground: #fff;
     --viewBorderColor: #d2d2d2;
-    --viewDoubleBorderColor: var(--viewBackground) var(--viewBorderColor);
     --viewHighlightBorderColor: #67acd8;
     --viewTodayBorderColor: #7fb9ee;
     --viewTodayBackground: #e1f0fd;
@@ -1020,7 +1019,7 @@ radio[calview] > .tab-middle {
 :root[lwt-tree-brighttext] .today-navigation-button:not([disabled="true"]):hover:active {
   background: rgba(255, 255, 255, .4);
   border-color: rgba(255, 255, 255, .7);
-  box-shadow: rgba(255, 255, 255, .4) inset;
+  box-shadow: 0 0 rgba(255, 255, 255, .4) inset;
 }
 
 .view-navigation-button > .toolbarbutton-text {

calendar/base/themes/common/widgets/calendar-widgets.css

@@ -82,7 +82,7 @@ checkbox.treenode-checkbox > .checkbox-label-center-box > .checkbox-label-box >
 :root[lwt-tree-brighttext] .view-navigation-button:not([disabled="true"]):hover:active {
   background: rgba(255, 255, 255, .4);
   border-color: rgba(255, 255, 255, .7);
-  box-shadow: rgba(255, 255, 255, .4) inset;
+  box-shadow: 0 0 rgba(255, 255, 255, .4) inset;
 }
 
 .view-navigation-button[disabled="true"] {

calendar/lightning/themes/common/lightning.css

@@ -70,7 +70,7 @@
 :root[lwthemetextcolor="bright"] #calendar-status-todaypane-button:hover:active {
   background: rgba(255, 255, 255, .4);
   border-color: rgba(255, 255, 255, .7);
-  box-shadow: rgba(255, 255, 255, .4) inset;
+  box-shadow: 0 0 rgba(255, 255, 255, .4) inset;
 }
 
 #calendar-status-todaypane-button > stack > .toolbarbutton-icon-begin {

calendar/providers/gdata/content/browserRequest.css

@@ -22,7 +22,7 @@
   background-position: 4px 3px;
 }
 
-@media (min-resolution: 2ddpx) {
+@media (min-resolution: 2dppx) {
   #security-button[loading="true"] {
     background-image: url("chrome://global/skin/icons/loading@2x.png");
   }
@@ -39,7 +39,7 @@
 
 #addressbox {
     font-weight: bold;
-    font-size: normal;
+    font-size: medium;
     -moz-appearance: textfield;
     overflow: hidden;
     margin: 5px 5px;

chat/themes/conv.css

@@ -28,7 +28,7 @@
 
 #Chat * {
   overflow: visible !important;
-  unicode-bidi: -moz-plaintext;
+  unicode-bidi: plaintext;
 }
 
 #unread-ruler {

chat/themes/imtooltip.css

@@ -17,7 +17,6 @@
 
 .tooltipBuddies {
   margin-left: -3px;
-  --blist-item-height: 20px; /* 16px icon plus padding */
 }
 
 .tooltipDisplayName {

common/src/viewSource.css

@@ -1,7 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-toolbar[printpreview="true"] {
-  -moz-binding: url("chrome://global/content/printPreviewBindings.xml#printpreviewtoolbar");
-}

mail/base/content/converterDialog.css

@@ -2,8 +2,6 @@
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-@import url("chrome://global/skin/plugins.css");
-
 body {
   color: -moz-DialogText;
   font: message-box;

mail/base/jar.mn

@@ -33,7 +33,6 @@ messenger.jar:
     content/messenger/customizeToolbar.css          (../../common/src/customizeToolbar.css)
     content/messenger/customizeToolbar.js           (../../common/src/customizeToolbar.js)
 *   content/messenger/customizeToolbar.xul          (../../common/src/customizeToolbar.xul)
-    content/messenger/viewSource.css                (../../common/src/viewSource.css)
     content/messenger/viewSource.js                 (../../common/src/viewSource.js)
 *   content/messenger/viewSource.xul                (../../common/src/viewSource.xul)
     content/messenger/generalBindings.xml           (../../common/bindings/generalBindings.xml)

mail/components/activity/content/activityBinding.css

@@ -2,24 +2,6 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-/* Activity Management System Bindings */
-
-activity-group {
-  -moz-binding: url('chrome://messenger/content/activity.xml#activity-group');
-}
-
-activity-process {
-  -moz-binding: url('chrome://messenger/content/activity.xml#activity-process');
-}
-
-activity-event {
-  -moz-binding: url('chrome://messenger/content/activity.xml#activity-event');
-}
-
-activity-warning {
-  -moz-binding: url('chrome://messenger/content/activity.xml#activity-warning');
-}
-
 /* Only focus buttons in the selected item */
 
 activity-process:not([selected="true"]) button {

mail/components/im/themes/imAccountWizard.css

@@ -54,7 +54,7 @@
   background-image: url("chrome://global/skin/icons/twisty-collapsed.svg");
 }
 
-.collapsable[closed="true"] .caption-icon:Z:-moz-locale-dir(rtl) {
+.collapsable[closed="true"] .caption-icon:-moz-locale-dir(rtl) {
   background-image: url("chrome://global/skin/icons/twisty-collapsed-rtl.svg");
 }
 

mail/themes/linux/editor/EditorDialog.css

@@ -288,30 +288,6 @@ tree.list {
   min-height: 200px;
 }
 
-/* ::::: select edit dialog ::::: */
-
-#SelectTreeChildren::-moz-tree-cell(SelectSelCol, checked-false) {
-  background: url("chrome://global/skin/checkbox/cbox.gif") 50% 50% no-repeat;
-}
-
-#SelectTreeChildren::-moz-tree-cell(SelectSelCol, checked-true) {
-  background: url("chrome://global/skin/checkbox/cbox-check.gif") 50% 50% no-repeat;
-}
-
-/* ::::: Publishing Progress ::::: */
-
-.progressitem[progress="busy"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-busy.gif");
-}
-
-.progressitem[progress="done"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-done.gif");
-}
-
-.progressitem[progress="failed"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-failed.gif");
-}
-
 /* ::::: groupbox ::::: */
 
 groupbox {

mail/themes/linux/jar.mn

@@ -77,6 +77,7 @@ classic.jar:
   skin/classic/messenger/addressbook/abResultsPane.css        (mail/addrbook/abResultsPane.css)
   skin/classic/messenger/addressbook/icons/abcard.png         (mail/addrbook/abcard.png)
   skin/classic/messenger/addressbook/icons/addrbook.png       (mail/addrbook/addrbook.png)
+  skin/classic/messenger/addressbook/icons/addressbook-toolbar-small.png   (mail/addrbook/addressbook-toolbar-small.png)
   skin/classic/messenger/addressbook/icons/ablist.png         (mail/addrbook/ablist.png)
   skin/classic/messenger/addressbook/icons/contact-generic.png             (mail/addrbook/contact-generic.png)
   skin/classic/messenger/addressbook/icons/contact-generic-tiny.png        (mail/addrbook/contact-generic-tiny.png)
@@ -119,7 +120,6 @@ classic.jar:
   skin/classic/messenger/icons/spring.png                     (mail/icons/spring.png)
   skin/classic/messenger/icons/insecure.png                   (mail/icons/insecure.png)
   skin/classic/messenger/icons/identity.png                   (mail/icons/identity.png)
-  skin/classic/messenger/icons/tick.png                       (mail/icons/tick.png)
   skin/classic/messenger/icons/error.png                      (mail/icons/error.png)
   skin/classic/messenger/icons/cancel.png                     (mail/icons/cancel.png)
   skin/classic/messenger/icons/folder-pane.png                (mail/icons/folder-pane.png)

mail/themes/linux/mail/accountManage.css

@@ -21,14 +21,6 @@
   margin-inline-start: 20px;
 }
 
-.selectForOfflineUseButton {
-  list-style-image: url("chrome://communicator/skin/icons/offline.png");
-}
-
-.selectForOfflineUseButton > .button-box > .button-icon {
-  margin: 0 4px;
-}
-
 .signatureBox {
   font-family: -moz-fixed;
 }

mail/themes/linux/mail/activity/activity.css

@@ -81,10 +81,6 @@ activity-process button {
   display: inline;
 }
 
-.blockedIcon {
-  list-style-image: url(chrome://global/skin/icons/Error.png);
-}
-
 activity-process button {
   -moz-appearance: none;
   min-height: 16px;

mail/themes/linux/mail/browserRequest.css

@@ -29,7 +29,7 @@
 
 #addressbox {
   font-weight: bold;
-  font-size: normal;
+  font-size: medium;
   -moz-appearance: textfield;
   overflow: hidden;
   margin: 0px 5px;

mail/themes/osx/editor/EditorDialog.css

@@ -287,30 +287,6 @@ tree.list {
   min-height: 200px;
 }
 
-/* ::::: select edit dialog ::::: */
-
-#SelectTreeChildren::-moz-tree-cell(SelectSelCol, checked-false) {
-  background: url("chrome://global/skin/checkbox/cbox.gif") 50% 50% no-repeat;
-}
-
-#SelectTreeChildren::-moz-tree-cell(SelectSelCol, checked-true) {
-  background: url("chrome://global/skin/checkbox/cbox-check.gif") 50% 50% no-repeat;
-}
-
-/* ::::: Publishing Progress ::::: */
-
-.progressitem[progress="busy"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-busy.gif");
-}
-
-.progressitem[progress="done"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-done.gif");
-}
-
-.progressitem[progress="failed"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-failed.gif");
-}
-
 /* ::::: groupbox ::::: */
 
 groupbox {

mail/themes/osx/mail/accountWizard.css

@@ -7,7 +7,6 @@
   ======================================================================= */
 
 @import url("chrome://messenger/skin/");
-@import url("chrome://global/skin/wizardOverlay.css");
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 

mail/themes/osx/mail/activity/activity.css

@@ -99,10 +99,6 @@ activity-process button {
   display: inline;
 }
 
-.blockedIcon {
-  list-style-image: url(chrome://messenger/skin/activity/error.png);
-}
-
 activity-process button {
   -moz-appearance: none;
   min-height: 16px;

mail/themes/osx/mail/browserRequest.css

@@ -22,7 +22,7 @@
   background-position: 4px 3px;
 }
 
-@media (min-resolution: 2ddpx) {
+@media (min-resolution: 2dppx) {
   #security-button[loading="true"] {
     background-image: url("chrome://global/skin/icons/loading@2x.png");
   }
@@ -46,7 +46,7 @@
 
 #addressbox {
     font-weight: bold;
-    font-size: normal;
+    font-size: medium;
     -moz-appearance: textfield;
     overflow: hidden;
     margin: 5px 5px;

mail/themes/osx/mail/folderMenus.css

@@ -25,7 +25,6 @@
   list-style-image: url("chrome://messenger-newsblog/skin/rss-feed-folder.png");
   -moz-image-region: auto;
 }
-}
 
 /* ..... special folders ..... */
 
@@ -126,7 +125,6 @@
   .folderMenuItem[IsFeedFolder="true"] {
     list-style-image: url("chrome://messenger-newsblog/skin/rss-feed-folder@2x.png");
     -moz-image-region: auto;
-}
   }
 
   /* ..... special folders ..... */

mail/themes/osx/mail/folderPane.css

@@ -155,7 +155,7 @@ treechildren::-moz-tree-image(folderNameCol, specialFolder-Archive) {
     -moz-image-region: rect(0 64px 32px 32px);
   }
   treechildren::-moz-tree-image(folderNameCol, hasError) {
-    list-style-image: url("chrome://global/skin/icons/error.png");
+    list-style-image: url("chrome://mozapps/skin/extensions/alerticon-error.svg");
     -moz-image-region: rect(0 16px 16px 0);
   }
 

mail/themes/osx/mail/preferences/aboutPreferences.css

@@ -18,11 +18,6 @@ radio[pane][focused="true"] > .radio-check {
   outline: none;
 }
 
-prefpane .groupbox-title {
-  background: none;
-  margin-bottom: 0;
-}
-
 html|h2 {
   border-bottom-width: 0;
   padding-bottom: 2px !important;

mail/themes/osx/mail/preferences/preferences.css

@@ -34,16 +34,6 @@ menulist > menupopup > menuitem {
   padding-inline-end: 2px;
 }
 
-prefpane .groupbox-body {
-  -moz-appearance: none;
-  padding: 8px 4px 4px;
-}
-
-prefpane .groupbox-title {
-  background: url("chrome://global/skin/50pct_transparent_grey.png") repeat-x bottom left;
-  margin-bottom: 4px;
-}
-
 caption {
   border-bottom: 1px solid #ECECEC;
   padding-top: 4px !important;

mail/themes/shared/jar.inc.mn

@@ -82,6 +82,7 @@
   skin/classic/messenger/icons/stop.svg                       (../shared/mail/icons/stop.svg)
   skin/classic/messenger/icons/tag.svg                        (../shared/mail/icons/tag.svg)
   skin/classic/messenger/icons/thread-col.svg                 (../shared/mail/icons/thread-col.svg)
+  skin/classic/messenger/icons/tick.png                       (../shared/mail/icons/tick.png)
   skin/classic/messenger/icons/timeline.svg                   (../shared/mail/icons/timeline.svg)
   skin/classic/messenger/icons/toolbarbutton-arrow.svg        (../shared/mail/icons/toolbarbutton-arrow.svg)
   skin/classic/messenger/icons/userIcon.svg                   (../shared/mail/icons/userIcon.svg)

mail/themes/shared/mail/accountProvisioner.css

@@ -196,13 +196,6 @@ input[type="submit"].search {
   font-weight: bold;
 }
 
-#search #Name {
-  padding-left: 24px;
-  background-image: url("chrome://messenger/content/newmailaccount/search.gif");
-  background-position: 5px center;
-  background-repeat: no-repeat;
-}
-
 #searchFields {
   margin-bottom: 13px;
   width: 100%;

mail/themes/shared/mail/messenger.css

@@ -36,10 +36,6 @@ description.error {
   color: #f00;
 }
 
-toolbar[printpreview="true"] {
-  -moz-binding: url("chrome://global/content/printPreviewBindings.xml#printpreviewtoolbar");
-}
-
 #notification-popup-box > image.notification-anchor-icon {
   width: 16px;
   height: 16px;

mail/themes/shared/mail/tabmail.css

@@ -378,7 +378,7 @@
   background-image: url("chrome://global/skin/icons/loading.png");
 }
 
-@media (min-resolution: 1.1ddpx) {
+@media (min-resolution: 1.1dppx) {
   #security-button[loading="true"] {
     background-image: url("chrome://global/skin/icons/loading@2x.png");
     background-size: 16px;

mail/themes/windows/editor/EditorDialog.css

@@ -293,30 +293,6 @@ tree.list {
   min-height: 200px;
 }
 
-/* ::::: select edit dialog ::::: */
-
-#SelectTreeChildren::-moz-tree-cell(SelectSelCol, checked-false) {
-  background: url("chrome://global/skin/checkbox/cbox.gif") 50% 50% no-repeat;
-}
-
-#SelectTreeChildren::-moz-tree-cell(SelectSelCol, checked-true) {
-  background: url("chrome://global/skin/checkbox/cbox-check.gif") 50% 50% no-repeat;
-}
-
-/* ::::: Publishing Progress ::::: */
-
-.progressitem[progress="busy"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-busy.gif");
-}
-
-.progressitem[progress="done"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-done.gif");
-}
-
-.progressitem[progress="failed"] {
-  list-style-image: url("chrome://editor/skin/icons/progress-failed.gif");
-}
-
 #AddJSEAttributeNameList > menupopup > menuseparator,
 #AddHTMLAttributeNameInput > menupopup > menuseparator {
   -moz-appearance: none;

mail/themes/windows/jar.mn

@@ -141,7 +141,6 @@ classic.jar:
   skin/classic/messenger/icons/spring.png                     (mail/icons/spring.png)
   skin/classic/messenger/icons/insecure.png                   (mail/icons/insecure.png)
   skin/classic/messenger/icons/identity.png                   (mail/icons/identity.png)
-  skin/classic/messenger/icons/tick.png                       (mail/icons/tick.png)
   skin/classic/messenger/icons/error.png                      (mail/icons/error.png)
   skin/classic/messenger/icons/cancel.png                     (mail/icons/cancel.png)
   skin/classic/messenger/icons/mainwindow-dropdown-arrow.png  (mail/icons/mainwindow-dropdown-arrow.png)

mail/themes/windows/mail/accountManage.css

@@ -21,14 +21,6 @@
   margin-inline-start: 20px;
 }
 
-.selectForOfflineUseButton {
-  list-style-image: url("chrome://communicator/skin/icons/offline.png");
-}
-
-.selectForOfflineUseButton > .button-box > .button-icon {
-  margin: 0 4px;
-}
-
 .signatureBox {
   font-family: -moz-fixed;
 }

mail/themes/windows/mail/activity/activity.css

@@ -193,10 +193,6 @@ activity-warning .statusText {
   list-style-image: url(chrome://messenger/skin/activity/defaultEventIcon.png);
 }
 
-.blockedIcon {
-  list-style-image: url(chrome://global/skin/icons/Error.png);
-}
-
 .processIconBox image {
   list-style-image: url(chrome://messenger/skin/activity/defaultProcessIcon.png);
 }

mail/themes/windows/mail/browserRequest.css

@@ -28,7 +28,7 @@
 
 #addressbox {
   font-weight: bold;
-  font-size: normal;
+  font-size: medium;
   -moz-appearance: textfield;
   overflow: hidden;
   margin: 0px 5px;

mail/themes/windows/mail/folderPane.css

@@ -47,7 +47,7 @@ treechildren::-moz-tree-image(folderNameCol, serverType-nntp, open) {
 /* ..... Feed folder, feed item ..... */
 
 treechildren::-moz-tree-image(folderNameCol, isFeed-true) {
-  list-style-image: url("chrome://messenger-newsblog/skin/icons/rss-feed.png");
+  list-style-image: url("chrome://messenger-newsblog/skin/rss-feed.png");
   -moz-image-region: rect(32px 16px 48px 0);
 }
 .tabmail-tab[type="folder"][IsFeedFolder="true"],

mail/themes/windows/mail/messenger.css

@@ -578,7 +578,7 @@ button[type="menu-button"] > button {
   }
 }
 
--.button-menubutton-dropmarker {
+.button-menubutton-dropmarker {
   -moz-appearance: none !important;
   margin: 1px;
   width: 11px;