Fix bug 751925 - Warning "octal literals and octal escape sequences are deprecated" in datetimepickers.xml. r=ssitter

--HG--
extra : rebase_source : 00768cdb4ddd4c0568afbff53b98a5481411e642

calendar/base/content/widgets/calendar-list-tree.xml

@@ -817,7 +817,7 @@
               }
           }
           if (oldIndex < 0) {
-              return;
+              return false;
           }
 
           // If no row is specified (-1), then assume append.

calendar/base/content/widgets/calendar-widgets.xml

@@ -214,6 +214,8 @@
                 let modeAttributeValues = this.getAttribute(aModeAttribute).split(",");
                 let modes = this.getAttribute("mode").split(",");
                 return modeAttributeValues[modes.indexOf(lMode)];
+            } else {
+                return "";
             }
         ]]></body>
       </method>

calendar/providers/wcap/calWcapCalendarItems.js

@@ -919,13 +919,11 @@ calWcapCalendar.prototype.parseItems = function calWcapCalendar_parseItems(
                 switch (itemFilter & calICalendar.ITEM_FILTER_COMPLETED_ALL) {
                     case calICalendar.ITEM_FILTER_COMPLETED_YES:
                         if (!item.isCompleted) {
-                            delete item;
                             item = null;
                         }
                         break;
                     case calICalendar.ITEM_FILTER_COMPLETED_NO:
                         if (item.isCompleted) {
-                            delete item;
                             item = null;
                         }
                         break;

calendar/resources/content/datetimepickers/datetimepickers.xml

@@ -1568,11 +1568,11 @@
             if (probeArray != null) { 
               // Numeric month format
               for (var i = 1; i <= 3; i++) { 
-                switch (Number(probeArray[i])) {
-                  case 02:    this.twoDigitYear = true; // fall thru
-                  case 2002:  this.yearIndex = i;       break;
-                  case 3:     this.monthIndex = i;      break;
-                  case 4:     this.dayIndex = i;        break;
+                switch (probeArray[i]) {
+                  case "02":    this.twoDigitYear = true; // fall thru
+                  case "2002":  this.yearIndex = i;       break;
+                  case "3":     this.monthIndex = i;      break;
+                  case "4":     this.dayIndex = i;        break;
                 }
               }
               // All three indexes are set (not -1) at this point.
@@ -1590,10 +1590,10 @@
               probeArray = this.parseShortDateRegex.exec(probeString);
               if (probeArray != null) {
                 for (var j = 1; j <= 3; j++) { 
-                  switch (Number(probeArray[j])) {
-                    case 02:    this.twoDigitYear = true; // fall thru
-                    case 2002:  this.yearIndex = j;       break;
-                    case 4:     this.dayIndex = j;        break;
+                  switch (probeArray[j]) {
+                    case "02":    this.twoDigitYear = true; // fall thru
+                    case "2002":  this.yearIndex = j;       break;
+                    case "4":     this.dayIndex = j;        break;
                     default:    this.monthIndex = j;      break;
                   }
                 }