Bug 1504130 - Set environment of .eslintrc.js files to node; also fix two warnings; rs=NPOTB

.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
   "root": true,
@@ -44,5 +43,10 @@ module.exports = {
     "rules": {
       "eol-last": "off",
     },
+  }, {
+    "files": "**/.eslintrc.js",
+    "env": {
+      "node": true,
+    },
   }],
 };

calendar/test/mozmill/shared-modules/test-item-editing-helpers.js

@@ -504,7 +504,7 @@ function addAttendees(dialog, innerFrame, attendeesString) {
     let { eid: dlgid } = helpersForController(dialog);
 
     let attendees = attendeesString.split(",");
-    for (var attendee of attendees) {
+    for (let attendee of attendees) {
         let calAttendee = innerFrame.window.attendees.find(
             aAtt => aAtt.id == `mailto:${attendee}`
         );
@@ -538,7 +538,7 @@ function deleteAttendees(event, innerFrame, attendeesString) {
 
     // Now delete the attendees.
     let attendees = attendeesString.split(",");
-    for (var attendee of attendees) {
+    for (let attendee of attendees) {
         let attendeeToDelete = iframeLookup(`${ATTENDEES_ROW}/{"attendeeid":"mailto:${attendee}"}`);
         // Unfortunately the context menu of the attendees is not working in
         // Mozmill tests. Thus we have to use the JS-functions.

mail/base/test/unit/.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
   "extends": [

mail/components/accountcreation/content/.eslintrc.js

@@ -1,6 +1,6 @@
 "use strict";
 
-module.exports = { // eslint-disable-line no-undef
+module.exports = {
   "globals": {
     "Abortable": true,
     "AccountConfig": true,

mail/components/addrbook/content/.eslintrc.js

@@ -1,6 +1,6 @@
 "use strict";
 
-module.exports = { // eslint-disable-line no-undef
+module.exports = {
   "globals": {
     // abCommon.js
     "AbEditCard": true,

mail/components/compose/content/.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
   globals: {

mail/components/extensions/.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
   "globals": {

mail/components/extensions/child/.eslintrc.js

@@ -1,6 +1,6 @@
 "use strict";
 
-module.exports = { // eslint-disable-line no-undef
+module.exports = {
   "globals": {
     // From toolkit/components/extensions/child/.eslintrc.js.
     "EventManager": true,

mail/components/extensions/parent/.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
   "globals": {

mail/components/extensions/test/xpcshell/.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
   "extends": "plugin:mozilla/xpcshell-test",

mail/components/im/content/.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
   overrides: [{

mail/components/preferences/.eslintrc.js

@@ -1,6 +1,6 @@
 "use strict";
 
-module.exports = { // eslint-disable-line no-undef
+module.exports = {
   "globals": {
     // preferences.js
     "AppConstants": true,

mail/components/test/unit/.eslintrc.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-env node */
 
 module.exports = {
     "extends": [

mailnews/.eslintrc.js

@@ -1,6 +1,6 @@
 "use strict";
 
-module.exports = { // eslint-disable-line no-undef
+module.exports = {
   "globals": {
     "Log4Moz": true,
     "MailServices": true,

mailnews/extensions/newsblog/.eslintrc.js

@@ -1,6 +1,6 @@
 "use strict";
 
-module.exports = { // eslint-disable-line no-undef
+module.exports = {
   "globals": {
     "Feed": true,
     "FeedEnclosure": true,