Bug 1017904 - additional selectCol CSS tweaks. r=Paenglab,aleca

mail/base/content/folderDisplay.js

@@ -404,7 +404,6 @@ FolderDisplayWidget.prototype = {
    *  it is actually an appropriate default for the folder type.
    */
   DEFAULT_COLUMNS: [
-    "selectCol",
     "threadCol",
     "attachmentCol",
     "flaggedCol",

mail/base/content/threadPane.js

@@ -87,7 +87,7 @@ function HandleColumnClick(columnID) {
     if (!selection) {
       return;
     }
-    if (treeView.rowCount == selection.count) {
+    if (selection.count > 0) {
       selection.clearSelection();
     } else {
       selection.selectAll();

mail/base/content/threadTree.inc.xul

@@ -29,7 +29,7 @@
                                  fixed="true"
                                  cycler="true"
                                  currentView="unthreaded"
-                                 hidden="false"
+                                 hidden="true"
                                  closemenu="none"
                                  label="&selectColumn.label;"
                                  tooltiptext="&selectColumn.tooltip;"/>

mail/themes/linux/mail/messageIcons.css

@@ -16,21 +16,22 @@ treechildren::-moz-tree-image(selectCol) {
 
 .selectColumnHeader > .treecol-icon,
 treechildren::-moz-tree-image(selectCol) {
-  width: 16px;
-  height: 16px;
-  -moz-context-properties: fill, stroke, stroke-opacity;
-  fill: transparent;
+  width: 14px;
+  height: 14px;
+  -moz-context-properties: fill, fill-opacity, stroke, stroke-opacity;
+  fill: currentColor;
   stroke: currentColor;
+  fill-opacity: 0;
   stroke-opacity: 0;
 }
 
 .selectColumnHeader.someselected > .treecol-icon {
-  stroke-opacity: 0.3;
-  fill: currentColor;
+  stroke-opacity: 1;
 }
 
-.selectColumnHeader.allselected > .treecol-icon {
-  fill: currentColor;
+.selectColumnHeader.allselected > .treecol-icon,
+treechildren::-moz-tree-image(selectCol, selected) {
+  fill-opacity: 1;
 }
 
 treechildren::-moz-tree-image(selectCol) {
@@ -38,10 +39,6 @@ treechildren::-moz-tree-image(selectCol) {
   height: 12px;
 }
 
-treechildren::-moz-tree-image(selectCol, selected) {
-  fill: currentColor;
-}
-
 /* ..... thread column ..... */
 
 .threadColumnHeader {

mail/themes/osx/mail/messageIcons.css

@@ -16,21 +16,22 @@ treechildren::-moz-tree-image(selectCol) {
 
 .selectColumnHeader > .treecol-icon,
 treechildren::-moz-tree-image(selectCol) {
-  width: 16px;
-  height: 16px;
-  -moz-context-properties: fill, stroke, stroke-opacity;
-  fill: transparent;
+  width: 14px;
+  height: 14px;
+  -moz-context-properties: fill, fill-opacity, stroke, stroke-opacity;
+  fill: currentColor;
   stroke: currentColor;
+  fill-opacity: 0;
   stroke-opacity: 0;
 }
 
 .selectColumnHeader.someselected > .treecol-icon {
-  stroke-opacity: 0.3;
-  fill: currentColor;
+  stroke-opacity: 1;
 }
 
-.selectColumnHeader.allselected > .treecol-icon {
-  fill: currentColor;
+.selectColumnHeader.allselected > .treecol-icon,
+treechildren::-moz-tree-image(selectCol, selected) {
+  fill-opacity: 1;
 }
 
 treechildren::-moz-tree-image(selectCol) {
@@ -38,10 +39,6 @@ treechildren::-moz-tree-image(selectCol) {
   height: 12px;
 }
 
-treechildren::-moz-tree-image(selectCol, selected) {
-  fill: currentColor;
-}
-
 /* ..... thread column ..... */
 
 .threadColumnHeader {

mail/themes/shared/mail/icons/check.svg

@@ -1,4 +0,0 @@
-<!-- This Source Code Form is subject to the terms of the Mozilla Public
-   - License, v. 2.0. If a copy of the MPL was not distributed with this
-   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16"><path fill="context-fill" d="M6 14a1 1 0 0 1-.707-.293l-3-3a1 1 0 0 1 1.414-1.414l2.157 2.157 6.316-9.023a1 1 0 0 1 1.639 1.146l-7 10a1 1 0 0 1-.732.427A.863.863 0 0 1 6 14z"></path></svg>

mail/themes/shared/mail/icons/checkbox.svg

@@ -2,6 +2,7 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">
-  <rect fill="context-stroke" fill-opacity="context-stroke-opacity" stroke="context-stroke" stroke-opacity="1" width="16" height="16" x="0" y="0" rx="1.404e-016" ry="1.512e-016" />
-  <path fill="context-fill" fill-opacity="context-fill-opacity" stroke="none" stroke-width="0.5" d="M6 14a1 1 0 0 1-.707-.293l-3-3a1 1 0 0 1 1.414-1.414l2.157 2.157 6.316-9.023a1 1 0 0 1 1.639 1.146l-7 10a1 1 0 0 1-.732.427A.863.863 0 0 1 6 14z"/>
+  <rect fill="none" stroke="context-stroke" stroke-opacity="1" width="15" height="15" x="0.5" y="0.5" rx="2" ry="2" />
+  <path fill="context-fill" fill-opacity="context-fill-opacity" d="M6 14a1 1 0 0 1-.7-.3l-3-3a1 1 0 0 1 1.4-1.4l2.16 2.15 6.32-9.02a1 1 0 0 1 1.64 1.14l-7 10a1 1 0 0 1-.73.43.86.86 0 0 1-.09 0z"/>
+  <path fill="context-fill" fill-opacity="context-stroke-opacity" d="M 2,7 H 14 V 9 H 2 Z"/>
 </svg>

mail/themes/windows/mail/messageIcons.css

@@ -16,33 +16,29 @@ treechildren::-moz-tree-image(selectCol) {
 
 .selectColumnHeader > .treecol-icon,
 treechildren::-moz-tree-image(selectCol) {
-  width: 16px;
-  height: 16px;
-  -moz-context-properties: fill, stroke, stroke-opacity;
-  fill: transparent;
+  width: 14px;
+  height: 14px;
+  -moz-context-properties: fill, fill-opacity, stroke, stroke-opacity;
+  fill: currentColor;
   stroke: currentColor;
+  fill-opacity: 0;
   stroke-opacity: 0;
 }
 
 .selectColumnHeader.someselected > .treecol-icon {
-  stroke-opacity: 0.3;
-  fill: currentColor;
+  stroke-opacity: 1;
 }
 
-.selectColumnHeader.allselected > .treecol-icon {
-  fill: currentColor;
+.selectColumnHeader.allselected > .treecol-icon,
+treechildren::-moz-tree-image(selectCol, selected) {
+  fill-opacity: 1;
 }
 
 treechildren::-moz-tree-image(selectCol) {
-  margin-inline-start: 6px;
   width: 12px;
   height: 12px;
 }
 
-treechildren::-moz-tree-image(selectCol, selected) {
-  fill: currentColor;
-}
-
 /* ..... thread column ..... */
 
 .threadColumnHeader {

mailnews/db/gloda/modules/dbview.js

@@ -103,9 +103,6 @@ GlodaSyntheticView.prototype = {
    * The default set of columns to show.
    */
   DEFAULT_COLUMN_STATES: {
-    selectCol: {
-      visible: true,
-    },
     threadCol: {
       visible: true,
     },