Граф коммитов

10495 Коммитов

Автор SHA1 Сообщение Дата
John Bieling cc365c20dc Bug 1928953 - Improve performance of recent folder queries. r=Fallen
Performance improvements as suggested by Philipp Kewisch.

Differential Revision: https://phabricator.services.mozilla.com/D227822

--HG--
extra : amend_source : 6985daf0f376ed7f7be6c7bec48b068f7eb8fa95
2024-11-19 07:49:56 +02:00
Geoff Lankow 983bf5e47c No bug - Fix a typo in test_folderCompact.js. rs=me
--HG--
extra : rebase_source : 9d81bd43690b4e7e68481b74acedf502c2ea536b
2024-11-19 11:10:17 +13:00
Magnus Melin fe3a5220ef Bug 1928314 - nsImapMailFolder::FolderPrivileges() should not exist. r=john.bieling
The url will have got set up after authentication if there was one. https://searchfox.org/comm-central/rev/6beeb01907990e9aaf01d3ae650ef20f2a716ef7/mailnews/imap/src/nsImapProtocol.cpp#7962
The code was trying to also get it on demand which should not be needed since it was already asked.

Differential Revision: https://phabricator.services.mozilla.com/D229131

--HG--
extra : amend_source : 6a4620e8a5ca2717036c44e735da4168c945015a
extra : absorb_source : e2e46c1db87a6272009363efc6a292d7fce6998e
2024-11-18 18:14:06 +01:00
Magnus Melin 38d8dea289 Bug 1801529 - use eslint-plugin-jsdoc in mailnews/imap. rs=me 2024-11-18 12:33:29 +02:00
Geoff Lankow 5199e1eb10 No bug - Typo in a comment. rs=me 2024-11-18 11:44:14 +13:00
Magnus Melin e405d8ba73 Bug 1801529 - eslint-plugin-jsdoc fixes for mailnews/. rs=me 2024-11-17 12:39:13 +02:00
Magnus Melin f2ed6688f0 Bug 1912579 - Fix intermittent comm/mail/test/browser/message-reader/browser_imageOverflow.js | The message display needs to be less than 400px wide - 832 < 400. r=tobyp
There were a bunch of issues with this test.
Simplified the real code to make it more understandable (and using boolean attributes).

Differential Revision: https://phabricator.services.mozilla.com/D228603

--HG--
rename : mail/test/browser/message-reader/data/Image sizing test.eml => mail/test/browser/message-reader/data/image_sizing_test.eml
extra : moz-landing-system : lando
2024-11-17 00:49:00 +00:00
Kai Engert d4563d7943 Bug 1931508 - Safety checks for ImapOfflineMsgStreamListener. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D229209

--HG--
extra : amend_source : cd747da012478848d441bb661b3fc082e5e1a2dc
2024-11-16 12:31:15 +02:00
John Bieling e2b15e619e Bug 1930724 - Use an integer instead of a boolean to sort folders. r=freaktechnik
Differential Revision: https://phabricator.services.mozilla.com/D228701
2024-11-12 18:47:38 +00:00
Ben Campbell 10d927915a Bug 1929105 - Fix empty-mbox gtests in TestMsgMboxRead. r=kaie
Differential Revision: https://phabricator.services.mozilla.com/D229047

--HG--
extra : amend_source : 04dd9e58d0f5ce12466d8032e4ac4c368f7e6589
2024-11-14 19:38:51 +00:00
Ben Campbell d527c944d5 Bug 1931258 - Make sure reading messages from beyond the end of an mbox file throws a read error. r=darktrojan,kaie
nsFileInputStream will happily let you Seek() past the end, and Read() from there, all without causing an error.
The Read() just returns 0 bytes of data (indicating EOF).

So this patch just tweaks the mbox parser to _require_ that there is a
message at the given position. Previously there was an exception to allow
nsMsgBrkMBoxStore::AsyncScan() to handle the corner case of an empty mbox
file. But AsyncScan() works fine with this patch, so we're OK.

Differential Revision: https://phabricator.services.mozilla.com/D228941

--HG--
extra : amend_source : d25b97a384718eb6f69aa7b2728ed339f1a3c10c
2024-11-14 08:33:38 +00:00
Ben Campbell ec81af2a4d Bug 1929105 - Respond to IMAP offline message read errors by discarding local copy. r=kaie
Differential Revision: https://phabricator.services.mozilla.com/D228621

--HG--
extra : amend_source : 831f998690216a1026a56ccbaca09e62c1dd66d1
2024-11-14 01:54:42 +00:00
Geoff Lankow 7cfd4b2ced Bug 1930787 - Stop IMAP incoming servers trying to do things after shutting down. r=gds
Differential Revision: https://phabricator.services.mozilla.com/D228753

--HG--
extra : rebase_source : 2c360df0590c6a1719a1d98af847370deae0605e
extra : amend_source : e3dc1a61ef60f206679418826b4f523781b1dfbf
2024-11-13 10:41:40 +13:00
Brendan Abolivier a8819d85fc Bug 1930994 - Replace use of mozilla::clamped with std::clamp. r=longsonr,darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D228876

--HG--
extra : rebase_source : b3acfd1976557a7d5d7097d8d082dd0e429cca21
extra : amend_source : 3ae0907f063c9d892281e3f78174aa66044e22e9
2024-11-13 17:22:54 +00:00
Toby Pilling 28b092f2d7 Bug 1924804 - Add support to set EWS message read/unread. r=babolivier
Differential Revision: https://phabricator.services.mozilla.com/D228083

--HG--
extra : moz-landing-system : lando
2024-11-13 16:58:37 +00:00
Yury Ivanovich d211615c05 Bug 1929845 - Remove more remaining needless Ci. abbreviations (except in calendar). r=mkmelin
Fixing https://searchfox.org/comm-central/search?q=var.*+%3D+Ci.&path=&case=true&regexp=true

Differential Revision: https://phabricator.services.mozilla.com/D228533

--HG--
extra : amend_source : 22ae46b499f408cac949477ff6683c1d68919d94
2024-11-11 17:04:05 +01:00
Richard Marti 39d37fbad2 Bug 1930363 - Include the variables.css into the AccountManager vCard dialog. r=freaktechnik
Differential Revision: https://phabricator.services.mozilla.com/D228547

--HG--
extra : amend_source : 3357baf120b0727663f900f216d47f0180ddabad
2024-11-11 17:00:30 +01:00
Yury Ivanovich fd9aa6091d Bug 1929845 - Remove remaining needless Ci. appreviations (except in calendar). r=mkmelin,leftmostcat
Fixing https://searchfox.org/comm-central/search?q=const.*+%3D+Ci.&path=&case=true&regexp=true

Differential Revision: https://phabricator.services.mozilla.com/D228322

--HG--
extra : moz-landing-system : lando
2024-11-08 10:38:19 +00:00
Yury Ivanovich 969bc0c6b3 Bug 1929845 - Remove unused member variable in nsMsgOfflineImapOperation. r=leftmostcat
This was mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1917179#c3

Differential Revision: https://phabricator.services.mozilla.com/D228320

--HG--
extra : moz-landing-system : lando
2024-11-08 10:38:19 +00:00
Yury Ivanovich 9344da472a Bug 1929845 - Add missing call to RowCountChanged() in nsMsgQuickSearchDBView::OnNewSearch(). r=mkmelin
See for comparison:
https://searchfox.org/comm-central/rev/779ea1ebc51dee1cf79f2a3910d417463bd18a35/mailnews/base/src/nsMsgXFVirtualFolderDBView.cpp#357-358

Differential Revision: https://phabricator.services.mozilla.com/D228319

--HG--
extra : moz-landing-system : lando
2024-11-08 10:38:18 +00:00
Gene Smith 444ed5641b Bug 1928026 - Failure of AUTH PLAIN or AUTH LOGIN were not falling back to USERPASS. r=mkmelin
User reported error on "AUTH PLAIN" command. This did not cause AUTH LOGIN or USERPASS
to be tried, so authentication failed. This now ensures that any failure during AUTH
PLAIN or AUTH LOGIN causes the next supported authentication mechanism to be tried.

Differential Revision: https://phabricator.services.mozilla.com/D227792

--HG--
extra : moz-landing-system : lando
2024-11-07 23:38:37 +00:00
Rob Lemley 4d3cbb0496 Bug 1929868 - Port bug 1859597: Do not compile msgMapi.idl during L10n repackaging. r=arschmitz,dandarnell
Bug 1859597 changes desktop_l10n.py in a way that runs `make export`
recursively through the object directory. The MAPI integration for Thunderbird
has an IDL file that the build system tries to compile as a result. It's not
needed for L10n repackaging, so exclude it when --disable-compile-environment
is set in mozconfig.

Differential Revision: https://phabricator.services.mozilla.com/D228347

--HG--
extra : moz-landing-system : lando
2024-11-07 23:38:37 +00:00
Geoff Lankow c169b71f2c Bug 1901705 - Remove dead functions in nsMsgKeySet. r=mkmelin
These functions are unused.

Differential Revision: https://phabricator.services.mozilla.com/D228147

--HG--
extra : amend_source : 35cd81c5d10f7d33712bc5370a5d50fde7573d88
2024-11-06 07:50:30 +00:00
John Bieling 779ea1ebc5 Bug 1928926 - Make getMostRecentFolders() return sorted folders also if length < aMaxHits. r=mkmelin,arschmitz
I stumbled across this while working on a WebExtension API using
a larger number for `aMaxHits` and not getting back a sorted list.

The sort-before-pop-mechanism was added before the list was limited to
30 days. I think it is now faster to sort the list only once and slice
off the part that we do not want, instead of preventing the list to grow
larger then `aMaxHits` and doing frequent sorting.

Differential Revision: https://phabricator.services.mozilla.com/D227821

--HG--
extra : rebase_source : eb190815c4dc010dd1b236affdbd4dc17069e87a
extra : amend_source : 19cf8ba0b2eb6a24d08c532c0a3d2b4a5ec1ac62
2024-11-04 08:38:50 +01:00
Geoff Lankow ce8e7e9231 Bug 1926462 - Prevent duplicate new mail notifications about the same message. r=mkmelin
Instead of only showing notifications about mail with a date after the last biff (which doesn't
work with system notifications anyway), only show notifications with a date after the
most-recently-notified-about message. In this way you can never have a notifcation about the same
message twice (as its date can't be greater than its date) unless it somehow jumps folders.

Differential Revision: https://phabricator.services.mozilla.com/D227790

--HG--
extra : amend_source : 5cc76ec4bcf6cd1e9223e9b4ed4bba7f0b013936
2024-11-06 21:08:57 +00:00
Alexander Schmitz 0995879421 Bug 1929170 - Make mail/* pass commlint. r=john.bieling
Differential Revision: https://phabricator.services.mozilla.com/D227913

--HG--
extra : moz-landing-system : lando
2024-11-06 18:52:40 +00:00
welpy-cw e84f16660d Bug 550414 - Use current identity's compose format for mailto: links. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D227526

--HG--
extra : moz-landing-system : lando
2024-11-06 18:52:39 +00:00
Geoff Lankow 38d96ad547 Bug 1901705 - Remove dead nsMsgAccountManager::GetSortOrder. r=aleca
This was last used in an old account order migration we no longer have.

Differential Revision: https://phabricator.services.mozilla.com/D227883

--HG--
extra : moz-landing-system : lando
2024-11-06 06:50:30 +00:00
Geoff Lankow 877babe84f Bug 1901705 - Remove dead MsgAdvanceToNextLine. r=BenC
This hasn't been used since bug 1719121 rewrote From-line handling.

Differential Revision: https://phabricator.services.mozilla.com/D227906

--HG--
extra : moz-landing-system : lando
2024-11-05 17:34:39 +00:00
Geoff Lankow e4a77ca875 Bug 1901705 - Remove dead MsgGetLocalFileFromURI. r=BenC
This hasn't been used since before ESR60.

Differential Revision: https://phabricator.services.mozilla.com/D227905

--HG--
extra : moz-landing-system : lando
2024-11-05 17:34:38 +00:00
Geoff Lankow 91bc3ba2df Bug 1901705 - Remove dead NS_GetUnicharPreferenceWithDefault. r=BenC
This hasn't been used since the compose service was rewritten.

Differential Revision: https://phabricator.services.mozilla.com/D227904

--HG--
extra : moz-landing-system : lando
2024-11-05 17:34:38 +00:00
Geoff Lankow 5032fa2475 Bug 1901705 - Remove dead MSGApopMD5. r=BenC
This hasn't been used since POP3 was rewritten.

Differential Revision: https://phabricator.services.mozilla.com/D227903

--HG--
extra : moz-landing-system : lando
2024-11-05 17:34:38 +00:00
Geoff Lankow 8104fdfa8b Bug 1921394 - Load folders from the database off the main thread. r=BenC, mkmelin
This does the database read off the main thread. Subsequent patches will add the initial reconciliation of on-disk folders to the task thread.

Differential Revision: https://phabricator.services.mozilla.com/D227453

Depends on D227318

--HG--
extra : rebase_source : 426f7d81b7d8a647e740e80924deec4c67ff6ffb
extra : amend_source : d8ed2727f35aa8a35633a5c608dfb374de4be145
2024-10-31 08:12:24 +00:00
Geoff Lankow ec1e0c18a9 Bug 1921394 - Make C++ shortcuts to infallible Folder properties. r=BenC
XPIDL will do most of the work for us, but not the string properties.

Differential Revision: https://phabricator.services.mozilla.com/D227318

--HG--
extra : rebase_source : 47c7a586a465748630cd3bdb23ca2db79d8a8969
extra : amend_source : d033673e8308868e4409fc465e0cea9101a1dca2
2024-10-31 08:12:18 +00:00
Geoff Lankow 4a04dcf9cb Bug 1929133 - Change nsMsgAccountManager shutdown to use AsyncShutdown. r=BenC
Differential Revision: https://phabricator.services.mozilla.com/D227881

--HG--
extra : rebase_source : af3c7c7d9d625ba1505eedeb6213c1b8558f16a0
extra : amend_source : ff15326437bdf38f009ce2cde3a9eefe0fa7ca94
2024-11-04 22:26:46 +00:00
Magnus Melin b5900efd9c Bug 1928623 - Port bug 1733498 to Thunderbird - Migrate necko errors l10n strings from .properties to Fluent. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D227708

--HG--
extra : amend_source : c3f78806c0f0e364bb0ea0378e69133f958693ad
2024-11-01 18:39:32 +00:00
Kai Engert baf16c6abe Bug 1925929 - Forbid viewing remote content in encrypted OpenPGP messages. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D227048

--HG--
extra : rebase_source : 06f493737a5a3e943cc0042f3cc054207344ef18
2024-10-29 19:17:30 +00:00
Gene Smith 515a6944a1 Bug 1928803 - Allow APOP authenication for POP3 to prompt for corrected password. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D227793
2024-11-04 04:34:27 +00:00
Ben Campbell 02cbeaf4e4 Bug 1926810 - Add telemetry to report potential mbox corruption. r=mkmelin, sancus
Differential Revision: https://phabricator.services.mozilla.com/D227603

Depends on D227315

--HG--
extra : rebase_source : 4c95ffb5e9b96a4553081771896203016bbf1301
extra : amend_source : 03298390673ab3ef81a98fe8fef2c909ca9f83f9
2024-11-04 00:40:19 +00:00
Ben Campbell a3a8396749 Bug 1926810 - Fail mbox reads if offset into mbox file doesn't start at a "From " separator. r=mkmelin
This patch makes the Mbox reader much more fussy. Previously, it'd just start
reading from where it was told to, and ignored a missing "From " separator
line at the beginning of a message.
This patch makes it much more strict, throwing a Read() error if that "From "
line is not there.

Differential Revision: https://phabricator.services.mozilla.com/D227315

Depends on D227314

--HG--
extra : rebase_source : eadc9b10c9174402154e60c8ba7dc7319825038a
extra : amend_source : dbcc189026d6824a1f01aace9ce0b6f4ce231a25
2024-11-04 00:37:55 +00:00
Ben Campbell 91077807ab Bug 1927944 - Remove nsMsgProtocol::m_readCount and redundant use of SlicedInputStreams. r=leftmostcat
Differential Revision: https://phabricator.services.mozilla.com/D227585

--HG--
extra : amend_source : 3e4e25ec922b21610eed62f92d860cc7576441ff
2024-11-01 12:23:35 +02:00
Geoff Lankow 5ba21115c5 Bug 1923526 - Close and clean up temporary output stream on compact failure. r=BenC,kaie
Differential Revision: https://phabricator.services.mozilla.com/D227571

--HG--
extra : amend_source : da9ca459a293253be271679a1cca7486cf4cefdf
2024-11-01 08:54:06 +02:00
Toby Pilling 16ee44107a Bug 1630286 - Hide Subscribe folder search options when not NNTP. r=freaktechnik
== How to Test ==
- Ensure that you have both NNTP and IMAP accounts set up
- Open Subscribe window
- Choose an IMAP account
- [folder search row should be hidden]
- Choose NNTP account
- [folder search row should be visible and operational]

Differential Revision: https://phabricator.services.mozilla.com/D219490

--HG--
extra : amend_source : c190c9571df872e9af38240a368c755590cbd3e4
2024-11-01 08:53:39 +02:00
Sean Burke f8537cc49c Bug 1924758 - Remove copy stream listener interface in favor of single concrete impl. r=BenC,babolivier
Differential Revision: https://phabricator.services.mozilla.com/D225737

--HG--
rename : mailnews/base/src/nsCopyMessageStreamListener.cpp => mailnews/base/src/CopyMessageStreamListener.cpp
rename : mailnews/base/src/nsCopyMessageStreamListener.h => mailnews/base/src/CopyMessageStreamListener.h
extra : rebase_source : 18c6ea098277fbdafb1cdba7fbea3823d3c4b2f2
2024-10-24 18:43:29 +00:00
John Bieling 0a1f76feb7 Bug 1927813 - Do not ask for permission when opening http(s):// and webext protocol links. r=darktrojan
After the preference `security.external_protocol_requires_permission`
was removed and the app behaves now as that preference being set to
true, every usage of the external protocol service triggers a permission
prompt.

This patch stops using the external protocol service directly. Instead
we now always use `openLinkExternally()`, which was modified to add the
permission to use the associated application, so the user is not prompted.

Differential Revision: https://phabricator.services.mozilla.com/D227375

--HG--
extra : rebase_source : 35f86de9e43f31e1039e2aa6b0e5c6c42e65fb9b
extra : amend_source : fa58c5f9ff9a4baef85f81ecb281ae3735b2d793
2024-10-30 15:43:35 +01:00
Martin Giger 680138eb17 Bug 1928097 - Add preference to enable account hub for account creation. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D227361

--HG--
extra : rebase_source : 125767b2b87b8b9066c2f9fa723dcb730799e356
extra : amend_source : d1b4074398febabc5ef3ad369ecd94e428f072ff
2024-10-30 19:20:39 +00:00
Ben Campbell 48e0142206 Bug 1926810 - Modernise test_downloadOffline.js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D227314

--HG--
extra : rebase_source : 18d189a2c4d72f119e43bc447dee5b4d41f26a7b
extra : amend_source : b96ab4040b053aab6cf150da22684924dbcd2139
2024-10-31 01:40:51 +00:00
Geoff Lankow 911644cdac Bug 1927656 - Raise compaction threshold. r=tobyp,aleca
Differential Revision: https://phabricator.services.mozilla.com/D227127

--HG--
extra : rebase_source : 2a28c8f86a44eb2e2d428c5d09066adb04f59ffd
2024-10-29 15:28:53 +13:00
Geoff Lankow 948397bace Bug 1928157 - Stopgap bustage fix, adding MOZ_RUNINIT to Windows and Mac specific files. r=john.bieling
Differential Revision: https://phabricator.services.mozilla.com/D227418

--HG--
extra : amend_source : b897d3aef1352c807d05365462a28e482be88468
2024-10-31 12:20:45 +13:00
Ben Campbell f63ca10344 Bug 1928157 - Stopgap bustage fix, adding MOZ_RUNINIT to gtest data. rs=bustage-fix
--HG--
extra : rebase_source : b8bd35029bef0ab0b445c8af4f57f7d67e57f60f
2024-10-31 11:07:05 +13:00