Performance improvements as suggested by Philipp Kewisch.
Differential Revision: https://phabricator.services.mozilla.com/D227822
--HG--
extra : amend_source : 6985daf0f376ed7f7be6c7bec48b068f7eb8fa95
There were a bunch of issues with this test.
Simplified the real code to make it more understandable (and using boolean attributes).
Differential Revision: https://phabricator.services.mozilla.com/D228603
--HG--
rename : mail/test/browser/message-reader/data/Image sizing test.eml => mail/test/browser/message-reader/data/image_sizing_test.eml
extra : moz-landing-system : lando
nsFileInputStream will happily let you Seek() past the end, and Read() from there, all without causing an error.
The Read() just returns 0 bytes of data (indicating EOF).
So this patch just tweaks the mbox parser to _require_ that there is a
message at the given position. Previously there was an exception to allow
nsMsgBrkMBoxStore::AsyncScan() to handle the corner case of an empty mbox
file. But AsyncScan() works fine with this patch, so we're OK.
Differential Revision: https://phabricator.services.mozilla.com/D228941
--HG--
extra : amend_source : d25b97a384718eb6f69aa7b2728ed339f1a3c10c
User reported error on "AUTH PLAIN" command. This did not cause AUTH LOGIN or USERPASS
to be tried, so authentication failed. This now ensures that any failure during AUTH
PLAIN or AUTH LOGIN causes the next supported authentication mechanism to be tried.
Differential Revision: https://phabricator.services.mozilla.com/D227792
--HG--
extra : moz-landing-system : lando
Bug 1859597 changes desktop_l10n.py in a way that runs `make export`
recursively through the object directory. The MAPI integration for Thunderbird
has an IDL file that the build system tries to compile as a result. It's not
needed for L10n repackaging, so exclude it when --disable-compile-environment
is set in mozconfig.
Differential Revision: https://phabricator.services.mozilla.com/D228347
--HG--
extra : moz-landing-system : lando
I stumbled across this while working on a WebExtension API using
a larger number for `aMaxHits` and not getting back a sorted list.
The sort-before-pop-mechanism was added before the list was limited to
30 days. I think it is now faster to sort the list only once and slice
off the part that we do not want, instead of preventing the list to grow
larger then `aMaxHits` and doing frequent sorting.
Differential Revision: https://phabricator.services.mozilla.com/D227821
--HG--
extra : rebase_source : eb190815c4dc010dd1b236affdbd4dc17069e87a
extra : amend_source : 19cf8ba0b2eb6a24d08c532c0a3d2b4a5ec1ac62
Instead of only showing notifications about mail with a date after the last biff (which doesn't
work with system notifications anyway), only show notifications with a date after the
most-recently-notified-about message. In this way you can never have a notifcation about the same
message twice (as its date can't be greater than its date) unless it somehow jumps folders.
Differential Revision: https://phabricator.services.mozilla.com/D227790
--HG--
extra : amend_source : 5cc76ec4bcf6cd1e9223e9b4ed4bba7f0b013936
This does the database read off the main thread. Subsequent patches will add the initial reconciliation of on-disk folders to the task thread.
Differential Revision: https://phabricator.services.mozilla.com/D227453
Depends on D227318
--HG--
extra : rebase_source : 426f7d81b7d8a647e740e80924deec4c67ff6ffb
extra : amend_source : d8ed2727f35aa8a35633a5c608dfb374de4be145
XPIDL will do most of the work for us, but not the string properties.
Differential Revision: https://phabricator.services.mozilla.com/D227318
--HG--
extra : rebase_source : 47c7a586a465748630cd3bdb23ca2db79d8a8969
extra : amend_source : d033673e8308868e4409fc465e0cea9101a1dca2
This patch makes the Mbox reader much more fussy. Previously, it'd just start
reading from where it was told to, and ignored a missing "From " separator
line at the beginning of a message.
This patch makes it much more strict, throwing a Read() error if that "From "
line is not there.
Differential Revision: https://phabricator.services.mozilla.com/D227315
Depends on D227314
--HG--
extra : rebase_source : eadc9b10c9174402154e60c8ba7dc7319825038a
extra : amend_source : dbcc189026d6824a1f01aace9ce0b6f4ce231a25
== How to Test ==
- Ensure that you have both NNTP and IMAP accounts set up
- Open Subscribe window
- Choose an IMAP account
- [folder search row should be hidden]
- Choose NNTP account
- [folder search row should be visible and operational]
Differential Revision: https://phabricator.services.mozilla.com/D219490
--HG--
extra : amend_source : c190c9571df872e9af38240a368c755590cbd3e4
After the preference `security.external_protocol_requires_permission`
was removed and the app behaves now as that preference being set to
true, every usage of the external protocol service triggers a permission
prompt.
This patch stops using the external protocol service directly. Instead
we now always use `openLinkExternally()`, which was modified to add the
permission to use the associated application, so the user is not prompted.
Differential Revision: https://phabricator.services.mozilla.com/D227375
--HG--
extra : rebase_source : 35f86de9e43f31e1039e2aa6b0e5c6c42e65fb9b
extra : amend_source : fa58c5f9ff9a4baef85f81ecb281ae3735b2d793