Magnus Melin
9bf80863e4
Bug 1896618 - BUG_COMPONENT annotations for thunderbird code. r=john.bieling,clokep,freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D210437
--HG--
extra : amend_source : c9d4bf50d4653b24dc5fc1b51c4e67e021f760c1
2024-05-17 10:30:09 -07:00
John Bieling
57edc3dbaf
Bug 1886948 - Part 4: AutoFix for ./mail directory. r=mkmelin
...
Using D194522 for auto-fixing unused variables.
Differential Revision: https://phabricator.services.mozilla.com/D205434
--HG--
extra : moz-landing-system : lando
2024-03-22 19:12:05 +00:00
Magnus Melin
c349303639
Bug 1885184 - getAttribute fix for browser_extension_update_background_noprompt.js. r=leftmostcat
...
Differential Revision: https://phabricator.services.mozilla.com/D205119
--HG--
extra : moz-landing-system : lando
2024-03-19 22:01:19 +00:00
Magnus Melin
a4f12139e1
Bug 1885184 - Port bug 232598 - getAttribute for xul-elements should return null for unset attributes. r=freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D204943
--HG--
extra : rebase_source : 2b5a3544d8a17271ac93a2892ea2fc6348f46764
extra : amend_source : 51c59baab1a8e78a8a166e07ec39d1297dac624f
2024-03-19 11:48:15 +02:00
Geoff Lankow
090d60f96c
Bug 1882701 - Port bug 1878401 - Always pass BrowsingContext to nsIFilePicker::Init. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D203092
--HG--
extra : rebase_source : 5878d116d8873025ba64fc47fbdbb149c5e4f3be
2024-02-29 12:03:40 +02:00
Magnus Melin
2cbcc82537
Bug 1875495 - Port bug 1780071 - Linter should yell if using assignment or comparisons inside assertion conditions. r=aleca
...
Didn't spot any direct errors, but these are the rewrites the plugin does for `--fix`
Differential Revision: https://phabricator.services.mozilla.com/D199105
--HG--
extra : amend_source : aa962db6dbcba906fb65b8a74ce1c0ad4f367d9f
2024-01-22 11:21:09 +01:00
Alessandro Castellani
7d101fa3a9
Bug 1854255 - Enforce prefer-const eslint rule in the whole mail/ directory. r=john.bieling
...
Differential Revision: https://phabricator.services.mozilla.com/D192040
--HG--
extra : moz-landing-system : lando
2023-10-28 01:16:36 +00:00
Martin Giger
250b7b346b
Bug 1860082 - Catch up on remaining module imports with mozilla-central ES module conversion. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D191455
--HG--
extra : amend_source : 4b62de902b3273a2d7320266c81e3fc582370265
extra : histedit_source : e5d6f14765bb4ff950a2885b61bfb1e3c8fe2c8a
2023-10-24 17:37:01 +01:00
John Bieling
b668327929
Bug 1859090 - ESMify ExtensionSupport.jsm. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D191180
--HG--
rename : mail/modules/ExtensionSupport.jsm => mail/modules/ExtensionSupport.sys.mjs
extra : moz-landing-system : lando
2023-10-18 16:45:48 +00:00
Alessandro Castellani
991fae5d76
Bug 1854255 - Enable `prefer-const` as linting rule for some tests head files. r=vineet
...
Differential Revision: https://phabricator.services.mozilla.com/D188765
--HG--
extra : moz-landing-system : lando
2023-09-21 05:40:50 +00:00
Geoff Lankow
c16e3927b9
Bug 1853491 - Port bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). rs=bustage-fix
2023-09-16 16:28:12 +12:00
Geoff Lankow
5814bedc4b
Bug 1844287 - Fix webextensions tests on Windows. r=aleca
...
The code for finding add-ons to install was overcomplicated and (rightly) failing when given a string like `addons/foo.xpi` to use as a file's leaf name. I simplified it.
Differential Revision: https://phabricator.services.mozilla.com/D184058
--HG--
extra : rebase_source : 7bd47978780d871757f46c43b537418f2a468e94
extra : histedit_source : 63937d8f4f129e449902d5ecdb7a94a5c631c1e7
2023-07-20 00:15:54 +00:00
Geoff Lankow
67e5345e05
Bug 1844287 - Unpack and fix add-ons for tests. r=john.bieling
...
I've changed the build configuration so these add-ons are generated at build time.
The code already existed, except it was in .xpi files. I unpacked them, fixed the import errors and linted them.
Differential Revision: https://phabricator.services.mozilla.com/D183957
--HG--
extra : rebase_source : 77d468c1b92b65568c16e1f7f275d80bf3320edc
2023-07-19 20:27:46 +12:00
Magnus Melin
c06293da69
Bug 1837269 - Port bug 1824612: Convert toolkit/components/extensions to ES modules. r=leftmostcat
...
Differential Revision: https://phabricator.services.mozilla.com/D180416
--HG--
extra : moz-landing-system : lando
2023-06-10 10:39:50 +00:00
John Bieling
aa816feba0
Bug 1836657 - Port bug 1824613: Convert consumers of toolkit/mozapps/extensions/AddonManger.sys.mjs to import ES modules directly. r=freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D179955
--HG--
extra : amend_source : 4ec13163d64f2d33b4a2f5870cb4c391991cce3c
2023-06-06 13:59:18 +00:00
Richard Marti
bc3c68b7b8
Bug 1836657 - Port bug 1824613: Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=john.bieling
...
Differential Revision: https://phabricator.services.mozilla.com/D179887
2023-06-04 10:09:14 +00:00
Magnus Melin
a8cce56ff0
Bug 1834662 - Port Convert ExtensionsUI.jsm strings to Fluent to Thunderbird. r=john.bieling
...
Depends on: D179183
This is syncing a lot of semi-forked code.
Differential Revision: https://phabricator.services.mozilla.com/D179035
2023-05-30 11:19:51 +00:00
Rob Lemley
5af325a42f
Bug 1833949 - Port bug 1826062: Automatic reformatting for Prettier 2.8.8. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D178538
--HG--
extra : amend_source : 1f4ecb957a2e2bf2bf6353b9ef43269d53ebab42
2023-05-21 15:05:52 +10:00
Rob Lemley
58f2dc08f0
Bug 1833949 - Port bug 1826062: Automatic reformatting for Prettier 2.0.5. r=leftmostcat
...
Differential Revision: https://phabricator.services.mozilla.com/D178537
--HG--
extra : amend_source : 4c543c3aeea4bb0a59407f358166956d9026e6a2
2023-05-21 15:05:24 +10:00
Magnus Melin
a5927add12
Bug 1830419 - Thunderbird followup - Only adjust browser CustomizableUITestUtils.jsm. rs=bustage-fix
...
Backed out 59016b361419daa60b3498ed1196d5a2be915676 and only doing a minmal fix
--HG--
extra : amend_source : 6bc16e5f27cc466511c94023ebc7240aee527077
2023-05-19 19:25:35 +10:00
Magnus Melin
ff3ded8507
Bug 1830419 - Adjust Thunderbird code for: Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs. r=bustage-fix
2023-05-19 16:02:52 +10:00
Magnus Melin
38d55fcb26
Bug 1823593 - Port bug 1820124 - Remove some addonManager Telemetry events that we don't need to collect anymore. r=aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D173114
--HG--
extra : moz-landing-system : lando
2023-03-21 21:54:59 +00:00
John Bieling
7e446bd1d8
Bug 1823083 - Port bug 1819940: Remove extension telemetry from WebExtension tests. r=aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D172896
--HG--
extra : moz-landing-system : lando
2023-03-17 22:02:46 +00:00
Geoff Lankow
349ff59c5c
Bug 1814275 - Port bug 1795255: Stop importing useless modules in browser tests. r=freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D168510
--HG--
extra : rebase_source : fcf39ce267d9d7be88bf261c98c1db28c587b63f
2023-02-01 15:44:26 +13:00
Geoff Lankow
dc6ffe33cd
Bug 1811942 - Port bug 1810995 - Rename BrowserTestUtils.loadURI to BrowserTestUtils.loadURIString. r=aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D167609
--HG--
extra : rebase_source : 9383d0e1d32c6b224b0ed8bcae7f7843ce3946bf
extra : amend_source : cece1fc69cd83022153f1f16170379b146fd4b78
2023-01-23 16:41:22 +13:00
Geoff Lankow
6609949d7e
Port Bug 1798335 - Replace the toggle in about:addons with fx-toggle. r=aleca
...
Port of https://hg.mozilla.org/mozilla-central/rev/988871602360
Differential Revision: https://phabricator.services.mozilla.com/D167502
--HG--
extra : rebase_source : d68ead1d968ab69964320c5add401cb4aa16f854
extra : amend_source : d53d66af7724a236fc221c10edbe09b2fbd31f33
extra : absorb_source : b5af15d70bb5412e946a2c3b6233d22f7815d9b6
extra : histedit_source : 7236c62d2dac7e4df6585d960f671f5b7d65e278
2023-01-23 14:38:59 +13:00
Geoff Lankow
3bd442593f
Bug 1803255 - Fix and enable the tests in mail/base/test/webextensions. r=aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D163412
--HG--
extra : rebase_source : 5c05103b8d8bce7e5141310268fbc6180ea04c26
2022-11-29 12:21:41 +13:00
Geoff Lankow
e5c79faedf
Merge comm-central to ash
2022-11-23 20:55:05 +13:00
Magnus Melin
fe9d2f7246
Bug 1801529 - mozilla/valid-jsdoc automatic fixups across the Thunderbird codebase. r=aleca
...
This is the automatic fixes + whitespace fixup:
find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\* @returns +/* @returns /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\* @returns +/* @returns /g' {} \;
find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\* (@returns \{.+\}) +/* \1 /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\* (@returns \{.+\}) +/* \1 /g' {} \;
find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\*( @param)( \S+ \S+ ) +/*\1\2- /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\*( @param)( \S+ \S+ ) +/*\1\2- /g' {} \;
find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\*( @param[^-]*)( - - )/*\1 - /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\*( @param[^-]*)( - - )/*\1 - /g' {} \;
Differential Revision: https://phabricator.services.mozilla.com/D162704
--HG--
extra : rebase_source : 4307935e658ce38943af522b17ce6b1c0d99dfdd
2022-11-23 15:43:25 +11:00
Geoff Lankow
87a5491771
Bug 1787094 - Repair or disable tests outside mail/test. r=aleca
...
Fixes what can reasonably be fixed, and skips the rest.
Differential Revision: https://phabricator.services.mozilla.com/D156533
--HG--
extra : rebase_source : 063761447b37860ac4e00b74194ccaee2f49a3a3
2022-09-01 16:26:31 +12:00
Magnus Melin
a19f8cff33
Bug 1764090 - Fix browser_permissions_unsigned.js failure. r=thunderbird-reviewers,rjl
...
Bug 1754441 has some details. InstallTrigger will be removed at some point.
The test calls installTrigger(url), and obviously that would not work without InstallTrigger.
Differential Revision: https://phabricator.services.mozilla.com/D149518
--HG--
extra : moz-landing-system : lando
2022-06-19 00:48:09 +00:00
Geoff Lankow
2c6f7fd130
Bug 1761749 - In extensions installation tests, wait for about:blank to load. r=#thunderbird-reviewers,aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D144774
--HG--
extra : rebase_source : 2ce6733d85f120c4d251a891650d2ace2dd8ddff
extra : amend_source : aa0b72c1bd9724ce8df6c2252b4933cbd21cb8d7
2022-04-27 10:58:35 +12:00
Magnus Melin
13a350796c
Bug 1761749 - sync browser_permissions_installTrigger.js with upstream. r=john.bieling
...
Differential Revision: https://phabricator.services.mozilla.com/D143340
--HG--
extra : amend_source : 60cf14956221de98def4cef60489eaa08e944f7e
2022-04-11 12:16:54 +02:00
Geoff Lankow
48c2cd9cce
Bug 1762322 - Port bug 1753696 - Use an eslint rule to transform existing setup tasks to use add_setup. r=aleca
...
I've used `eslint --fix` to automatically convert setup tasks named setup.
It seems like a good time to convert (formerly Mozmill) setupModule tasks to add_setup, and remove the name and argument of teardownModule functions, so I've done that too.
Differential Revision: https://phabricator.services.mozilla.com/D142525
--HG--
extra : amend_source : 01a4fb24de8ee38534865e5db242b698c471796d
2022-03-31 13:00:06 +03:00
Geoff Lankow
29565ba20c
Bug 1761209 - Port bug 1759737 - Prevent XPInstalls if they are not triggered by a user gesture. r=john.bieling
...
Differential Revision: https://phabricator.services.mozilla.com/D141943
--HG--
extra : amend_source : 9ca389fe1211fa2a09226f68bb7f47ad37c97369
extra : histedit_source : 7af4121434f30f0f8831211c83aea83add90de4d
2022-03-24 22:03:18 +13:00
Magnus Melin
effda6622e
Bug 1758474 - fix up 2 remaining callers passing {} as the target parameter for `ChromeUtils.import`. rs=eslint
...
--HG--
extra : amend_source : 60d25ad692d2137945f01b3bc4e31306d422fc33
2022-03-12 14:10:26 +02:00
Geoff Lankow
b811087a78
Bug 1616114 follow-up - Fix broken tests. rs=bustage-fix
...
--HG--
extra : rebase_source : 9fe9f67870a6daa9d0bd03560d24dda8cd041d89
extra : histedit_source : 383ed9c10823db46e83e9a42a2e38229e78f6c33
2021-07-08 11:13:27 +12:00
John Bieling
81e2ef827d
Bug 1710359 - Suppress permission update prompts, if add-on already has full access permission. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D119014
--HG--
extra : amend_source : 0dabe5c942aed11290d3d72786100f72da05ebf6
2021-07-04 13:25:25 +03:00
Geoff Lankow
ff6c8fad5d
Backed out changeset 7437d26d24e0 (bug 1710359) for breaking the tests.
...
--HG--
extra : amend_source : f8082743b4fbb7ebd4d9d7edc6f26ec16618bba3
2021-07-02 12:15:47 +12:00
John Bieling
884de970ec
Bug 1710359 - Suppress permission update prompts, if add-on already has full access permission. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D119014
2021-07-01 19:33:58 +00:00
Geoff Lankow
f24bf29792
Port bug 1689240 (take 2) - Rename aboutaddons custom event from ViewChanged to view-loaded. rs=bustage-fix
...
I messed up the first attempt. The add-ons manager is meant to close after each subtest but it never has because the original porting was faulty.
--HG--
extra : rebase_source : 97e17882f107f2db557bde8159c7ee94ddc5e05d
2021-03-26 12:58:53 +13:00
Geoff Lankow
3e13e68a3c
Port bug 1689240 - Rename aboutaddons custom event from ViewChanged to view-loaded. rs=bustage-fix
...
--HG--
extra : amend_source : 0a25baffb840549b0e2851c21be2e512b6ee302c
2021-03-26 11:04:23 +13:00
Geoff Lankow
938bb1a032
Bug 1700015 - Update extension notifications UI. r=john.bieling
...
This brings our notifications more up-to-date. Includes bits of:
* Bug 1695353 - WebExtension permission list should suppress the bullet if the list is only 1 item long
* Bug 1695338 - Update copy for WebExtension install approval panel
* Bug 1697622 - Update copy for WebExtension install confirmation panel
Differential Revision: https://phabricator.services.mozilla.com/D109251
--HG--
extra : rebase_source : db1bffdc9ad8d64ab8e3fc418f9da3760d06d530
extra : amend_source : 072555920e1a6816b15c18259fd5b2fae9931ae1
2021-03-22 14:54:07 +13:00
Magnus Melin
995d3d7bff
Bug 1692438 - Port bug 1692113 to Thunderbird: Review usages of `.getAttribute("hidden")` and rely on the DOM property instead when relevant. r=aleca
...
grep --exclude-dir=.hg --exclude-dir=suite -r 'getAttribute("hidden")' .
2021-02-13 11:56:37 +02:00
Geoff Lankow
3375e3259f
Bug 1692419 - Port bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import'. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D104972
--HG--
extra : amend_source : b43b05b6c5193f7170d1a5722ce3ed77e3a807b0
2021-02-12 11:54:09 +02:00
Geoff Lankow
8266e24084
Port bug 1525179 - Use aboutaddons.html at the root of about:addons. rs=bustage-fix
2021-02-04 13:00:55 +13:00
Geoff Lankow
1091e2f2cf
Bug 1683787 - Make link handling multi-process compatible. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D100383
--HG--
extra : moz-landing-system : lando
2021-01-20 00:06:17 +00:00
Geoff Lankow
1adcabbb8c
Bug 1671301 - Enable E10S and make the tests pass. r=mkmelin
...
The aim of this patch is to have the tests run in E10S mode and not fail. Many tests have been disabled (because they fail) and will be addressed in separate patches.
Differential Revision: https://phabricator.services.mozilla.com/D100366
--HG--
extra : moz-landing-system : lando
2021-01-20 00:06:04 +00:00
Magnus Melin
3b629b5a84
Bug 1646671 - try to fix intermittent comm/mail/base/test/webextensions/browser_permissions_pointerevent.js failures. r=darktrojan
2020-11-26 11:43:46 +02:00
Magnus Melin
24d01a8e56
Bug 1677735 - port bug 1671983 - Remove E10SUtils.shouldLoadURI. r=darktrojan
...
Porting https://hg.mozilla.org/mozilla-central/rev/0a3cf02cfc7a
--HG--
extra : rebase_source : 0c2aec5304846eef331a90d6dd85241c85756cfb
2020-11-17 23:16:17 +02:00