Khushil Mistry
f1aa0b1c4e
Bug 1597964 - Restructure all <xul:dialog> usages such that they are not the top level element in chat/. r=mkmelin
2019-12-11 17:28:00 +13:00
Magnus Melin
47d16f24a8
Bug 1597131 - followup to make chat tooltips work again. r=khusil
...
Previously before bug 1597131 mousethrough was used not to get popupshowing for the wrong tooltipNode.
Using css pointer-events doesn't work the same for this case, so we need to do better matching in the event handler instead.
2019-11-28 13:12:10 +02:00
Magnus Melin
94591fcbae
Bug 1599548 - rewrite Thunderbird consumers of the deprecated "top" and "bottom" align values to "start" and "end" (port bug 1592369). r=pmorris
...
* align="top" -> align="start"
* align="bottom" -> align="end"
* setAttribute("align", "top") -> setAttribute("align", "start")
* setAttribute("align", "bottom") -> setAttribute("align", "end")
grep -rl 'align="top"' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\balign="top"/align="start"/g'
grep -rl 'align="bottom"' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\balign="bottom"/align="end"/g'
grep -rl 'setAttribute("align", "top")' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/setAttribute("align", "top")/setAttribute("align", "start")/g'
grep -rl 'setAttribute("align", "bottom")' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/setAttribute("align", "bottom")/setAttribute("align", "end")/g'
2019-11-27 15:03:43 +02:00
Magnus Melin
6719394cd8
Bug 1596385 - remove XUL [dir="reverse"] usage whose support was removed in bug 1596296. r=clokep,pmorris
2019-11-16 22:23:27 +02:00
Khushil Mistry
368cedeb12
Bug 1591506 - Fixed context menu in chat's IM status dialog. r=mkmelin
...
--HG--
extra : rebase_source : a9ff3a93549beae5bc4eb1adadfa7f52bc1303be
2019-10-29 08:06:00 +01:00
Magnus Melin
95aa507b62
Bug 1591357 - make folder-tooltip, chat-tooltip tooltips proper customized built-ins so they work. r=jorgk DONTBUILD
2019-10-28 12:00:16 +02:00
Jorg K
d240bad229
Bug 1463266 - fix typos in comm-central using codespell. rs=comment-only,typo-fix
2019-10-21 23:07:47 +02:00
Khushil Mistry
48834fa331
Bug 1585302 - Thunderbird CE <richlistitem> related fixes. r=mkmelin
...
--HG--
extra : rebase_source : dbcdf7bc93e834634886d3a29434ad3b9a8fd031
2019-10-14 05:01:00 +02:00
Magnus Melin
4693a34755
Bug 1570954 - Port bug 1479125 to Thunderbird: Rewrite callers firstChild/lastChild/childNodes/previousSibling/nextSibling with firstElementChild/lastElementChild/children/previousElementSibling/nextElementSibling. r=pmorris
...
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.
The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually refers to a text node, or when firstChild is used in a loop to empty out an element):
firstChild->firstElementChild
lastChild->lastElementChild
nextSibling->nextElementSibling
previousSibling->previousElementSibling
childNodes->children
# firstChild -> firstElementChild
grep -rl '\bfirstChild\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bfirstChild\b/firstElementChild/g'
# lastChild->lastElementChild
grep -rl '\lastChild\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\blastChild\b/lastElementChild/g'
# nextSibling->nextElementSibling
grep -rl '\nextSibling\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bnextSibling\b/nextElementSibling/g'
# previousSibling->previousElementSibling
grep -rl '\previousSibling\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bpreviousSibling\b/previousElementSibling/g'
# childNodes->children
grep -rl '\childNodes\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bchildNodes\b/children/g'
# revert for clearning out. lastElementChild.remove() -> lastChild.remove()
grep -rl '\lastElementChild.remove\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\lastElementChild.remove\b/lastChild.remove/g'
# skip matches in cpp and other wrong changes
hg revert mailnews/base/src/nsSubscribableServer.cpp
hg revert mailnews/base/src/nsSubscribableServer.h
hg revert mailnews/mime/src/mimemsig.cpp
hg revert mail/test/mozmill/composition/test-signature-updating.js
hg revert mail/test/mozmill/shared-modules/DOMHelpers.jsm
hg revert mailnews/addrbook/jsaddrbook/AddrBookMailingList.jsm
hg revert mailnews/addrbook/public/nsIAbDirectory.idl
hg revert mailnews/addrbook/test/unit/test_basic_nsIAbDirectory.js
hg revert mailnews/addrbook/test/unit/test_jsaddrbook.js
hg revert mailnews/addrbook/test/unit/test_mailList1.js
hg revert mailnews/addrbook/test/unit/test_uid.js
hg revert mailnews/compose/src/nsMsgCompose.cpp
hg revert mail/test/mozmill/cloudfile/test-cloudfile-attachment-urls.js
hg revert mail/test/mozmill/composition/test-forward-headers.js
hg revert calendar/import-export/calHtmlExport.js
hg revert mail/components/compose/content/cloudAttachmentLinkManager.js
hg revert mail/components/compose/content/dialogs/EdConvertToTable.js
hg revert mail/components/compose/content/dialogs/EdDialogCommon.js
hg revert mail/components/compose/content/dialogs/EdInsertTOC.js
hg revert mail/components/customizableui/CustomizeMode.jsm
hg revert mail/components/customizableui/PanelMultiView.jsm
hg revert mail/test/mozmill/shared-modules/ComposeHelpers.jsm
hg revert mailnews/addrbook/jsaddrbook/AddrBookDirectory.jsm
hg revert mailnews/base/util/JXON.js
hg revert mailnews/base/util/errUtils.js
hg revert mailnews/extensions/newsblog/content/feed-parser.js
hg revert mail/components/compose/texzilla/TeXZilla.js
../mach eslint --fix
2019-10-13 21:42:57 +03:00
Magnus Melin
38da692d5e
Bug 1563009 - Use HTML input instead of XUL textbox in chat/content. r=aleca
2019-09-26 22:46:47 +03:00
Khushil Mistry
bfa0e14463
Bug 1582424 - remove grid usage from chat-tooltip.js. r=mkmelin
2019-09-24 19:53:48 +02:00
Paul Morris
1b81c589fc
Bug 1582573 - Re-indent XUL strings in non-calendar custom elements. r=mkmelin
2019-09-19 21:18:40 -04:00
Alessandro Castellani
55eb6ffe22
Bug 1563122 - Use HTML input instead of XUL textbox in mail/components/im/content/. r=mkmelin
2019-09-13 11:30:55 -07:00
Khushil Mistry
e0b9e01e89
Bug 1581152 - fix invocation of proceedDefaultAction() in chat-account-richlistitem.js. r=clokep
2019-09-13 09:17:00 +02:00
Paul Morris
f771fe4f4d
Bug 1577835 - Fix 'if, else, comments', other formatting in chat/. r=mkmelin
2019-09-01 21:45:34 +02:00
Paul Morris
aeee638528
Bug 1577835 - Reformat chat/ code with eslint and Prettier. r=mkmelin
...
# ignore-this-changeset
These changes were achieved by:
1. Using eslint to add curly brackets to control
statements that did not have them (if, else, etc.),
thanks to the eslint rule: "curly": ["error", "all"]
Done by running |mach eslint chat/ --fix|
2. Reformatting the code using Prettier.
Done by deleting the chat/ line from
the .prettierignore file and running:
|mach eslint chat/ --fix|
2019-08-30 13:43:03 -04:00
Paul Morris
425d00717a
Bug 1573670 - Wrap all Thunderbird custom elements in curly bracket blocks. r=mkmelin
...
Leave re-indentation to Prettier's auto-formatting, to happen
in a subsequent patch. Use `const` instead of `let` for imports.
2019-08-27 12:26:37 -04:00
Khushil Mistry
61d6d659d9
Bug 1577659 - remove statusbarpanel custom element. r=mkmelin
2019-08-30 02:16:00 +02:00
Magnus Melin
bd319c2b85
Bug 1506529 - [de-xbl] convert chat tooltip (imtooltip.xml) binding to custom element <tooltip is="chat-tooltip"/>. r=florian,aleca
...
--HG--
rename : chat/content/imtooltip.xml => chat/content/chat-tooltip.js
2019-08-21 23:10:40 +02:00
Alessandro Castellani
93ecc344f9
Bug 1552227 - OTR: improve UX of 'Add Finderprint' dialog. r=mkmelin,kaie
2019-07-04 21:17:48 -07:00
Kai Engert
ca628dd2db
Bug 1563633 - Port bug 1558602: Use new API for sync calls to Fluent in OTR chat. r=aleca
...
--HG--
extra : amend_source : bd1250645b385c1b92c649ce75882a7934f6d69c
2019-07-05 23:25:18 +02:00
Magnus Melin
0666d6429b
Bug 1556868 - convert <textbox type="number"> to <html:input type="number">. r=Paenglab
...
<html:input type="number"> doesn't have a size attribute. Added class="size2-5" to adjust width.
2019-06-24 09:08:34 +03:00
Kai Engert
657751236e
Bug 1536104 - OTR: Allow the user to disable logging of encrypted conversations. r=florian
...
Differential Revision: https://phabricator.services.mozilla.com/D32840
2019-05-28 17:07:40 +02:00
Geoff Lankow
8f20d493be
Bug 1557829 - Port bug 1557793: Adapt to array changes in nsIStringBundle.formatStringFromName (JS changes). r=jorgk
2019-06-12 16:12:00 +12:00
Kai Engert
73be2258cb
Bug 1536108 - Avoid sending secondary numbers in OTR query message. r=mkmelin
2019-06-04 11:52:57 +02:00
Kai Engert
e0f08d4ab3
Bug 1552004 - dont' use "eval" in the OTR code. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D32839
2019-06-04 22:58:39 +02:00
Kai Engert
ed216ba883
Bug 1552177 - OTR chat: private key generation should be done in the background, remove status UI. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D32838
2019-06-04 22:58:00 +02:00
Kai Engert
e174f30966
Bug 1550487 - OTR: Implement per-account preferences UI. r=mkmelin
...
Contains UI code by Alessandro Castellani <alessandro@thunderbird.net>
Differential Revision: https://phabricator.services.mozilla.com/D32837
2019-06-04 22:57:54 +02:00
Geoff Lankow
9617d1d603
Bug 1555219 - Stop using <resizer>. r=Paenglab
2019-05-30 21:01:35 +12:00
Magnus Melin
77a0566714
Bug 1553077 - Port [Bug 1479538 - Rewrite callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...)]. r=jorgk
...
find . -type f -not -path "*.hg/*" -not -path "*suite/*" -not -path "./chat/protocols/matrix/matrix-sdk/*"
-name '*.js' -exec sed -r -i 's/createElementNS[(]XULNS, /createXULElement(/g' {} \;
find . -type f -not -path "*.hg/*" -not -path "*suite/*" -not -path "./chat/protocols/matrix/matrix-sdk/*"
-name '*.xml' -exec sed -r -i 's/createElementNS[(]XULNS, /createXULElement(/g' {} \;
find . -type f -not -path "*.hg/*" -not -path "*suite/*" -not -path "./chat/protocols/matrix/matrix-sdk/*"
-name '*.js' -exec sed -r -i 's#createElementNS[(]"http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul ",#createXULElement(#g' {} \;
+ some manual fixups
2019-05-21 12:35:48 +03:00
Kai Engert
401cd99f4f
Bug 1550488 - Change the OTR localization to use Fluent. r=mkmelin
2019-05-20 11:33:11 +02:00
Magnus Melin
b5f088faa4
Bug 1546338 - fix some more instances of Port [Bug 1551320 - In XUL documents replace all callers of createElement with createXULElement]. r=jorgk
2019-05-19 16:26:42 +03:00
Magnus Melin
2b1d2dc344
Bug 1546338 - Port [Bug 1551320 - In XUL documents replace all callers of createElement with createXULElement]. r=jorgk
...
find . -type f -not -path "*.hg/*" -not -path "*suite/*" -not -path "./chat/protocols/matrix/matrix-sdk/*"
-not -path "./mail/components/about-support/*" -not -path "./mail/components/newmailaccount/content/*"
-not -path "./mailnews/extensions/newsblog/content/*" -not -path "./mailnews/extensions/newsblog/content/*"
-name '*.js' -exec sed -r -i
'/React.|("(iframe|div|hr|img|title|a|li|ol|ul|h2|h3|facet-result-message|facet-boolean|facet-boolean-filtered|
facet-discrete|select|option|canvas|strong|td|tr|tbody|pre|span|head|meta|map|area|table|caption|p|br|b))"/!
s/createElement[(]/createXULElement(/g' {} \;
2019-05-16 15:21:51 +03:00
Arlo Breault ext:(%2C%20Kai%20Engert%20%3Ckaie%40kuix.de%3E%2C%20Alessandro%20Castellani%20%3Calessandro%40thunderbird.net%3E)
f20cf4817a
Bug 1518172 - Import ctypes-otr, updated by kaie/aleca. r=florian,clokep,mkmelin
...
Original MPL v2 code by Arlo Breault from https://github.com/arlolra/ctypes-otr/
Ported to Thunderbird by Kai Engert, includes UI changes by Alessandro Castellani.
2019-05-17 16:21:48 +02:00
Magnus Melin
06598f8b07
Bug 1547054 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags. r=Paenglab,philipp DONTBUILD
2019-04-28 22:14:40 +02:00
Khushil Mistry
c1fa40fa8e
Bug 1538548 - [de-xbl] convert the chat's conv binding to <richlistitem is='chat-imconv'>. r=mkmelin DONTBUILD
...
--HG--
rename : mail/components/im/content/imconv.xml => mail/components/im/content/chat-imconv.js
extra : rebase_source : 3e63a5b0bb9194417f05fbcab9b8c8c2f0684ab9
2019-04-25 06:15:00 +02:00
Khushil Mistry
c164432999
Bug 1534249 - remove grid usage from addbuddy.xul, imAccountWizard.xul and joinchat.xul. r=mkmelin
2019-04-26 00:31:00 +02:00
Khushil Mistry
7f335f59f7
Bug 1538549 - [de-xbl] convert contact binding to custom element. r=mkmelin DONTBUILD
...
--HG--
rename : mail/components/im/content/imcontact.xml => mail/components/im/content/chat-contact.js
2019-04-09 14:41:00 +02:00
Khushil Mistry
7ed2802b61
Bug 1531312 - [de-xbl] convert account and buttons bindings to custom element. r=mkmelin
2019-03-22 06:43:00 +01:00
Geoff Lankow
46c9d9466a
Port bug 1246594 - Enable ESLint rule no-throw-literal by default; rs=bustage-fix DONTBUILD
2019-03-21 20:45:20 +13:00
Jorg K
3d1da6c620
Bug 1534083 - Follow-up: fix linting issue, missing trailing comma. rs=bustage-fix DONTBUILD
2019-03-11 17:42:41 +01:00
Florian Quèze
abb1e38f6e
Bug 1534083 - buffer messages in background conversation browsers until they are visible, r=clokep.
...
Depends on D22855
Differential Revision: https://phabricator.services.mozilla.com/D22856
--HG--
extra : moz-landing-system : lando
2019-03-11 16:06:50 +00:00
Florian Quèze
751d0b0421
Bug 1531860 - Finish initializing the chat browser when receiving STATE_STOP and STATE_IS_WINDOW, as calling document.open no longer causes notifications at the document level, r=clokep.
...
Differential Revision: https://phabricator.services.mozilla.com/D22613
--HG--
extra : moz-landing-system : lando
2019-03-07 22:13:29 +00:00
Geoff Lankow
c04c2f1e7f
Bug 1533085 - Remove extends="xul:*" and display="xul:*" in XBL bindings; rs=bustage-fix
2019-03-07 15:17:03 +13:00
Patrick Cloke
70dde6f238
Bug 1531067 - Stop preprocessing chat files for Thunderbird. r=florian
2019-03-01 15:24:17 -05:00
Patrick Cloke
7986b2cf84
Bug 1525190 - Manual changes to abide by eslint in chat. r=florian
2019-02-28 09:49:44 -05:00
Patrick Cloke
10f11d2e56
Bug 1525190 - Run eslint --fix over chat modules code. r=florian
2019-02-27 08:11:42 -05:00
aceman
da12742c2f
Bug 1525834 - Port bug 1095602: Remove STATE_SECURE flags from nsIWebProgressListener. r=mkmelin,frg ui-r=Paenglab
2019-02-09 07:48:00 +01:00
Florian Quèze
c5e9e71e6a
Bug 1525730 - Fix the chat copy controller (was broken after the convbrowser.xml -> conversation-browser.js refactoring). r=clokep DONTBUILD
2019-02-07 10:10:16 +01:00
Geoff Lankow
0a77384a34
Bug 1520643 - Port bug 1514594: Change all call sites of ChromeUtils.import() to the "new" scheme; rs=bustage-fix DONTBUILD
2019-01-30 20:53:39 +13:00