Граф коммитов

51 Коммитов

Автор SHA1 Сообщение Дата
Magnus Melin ce399a22e9 Bug 1803332 - Port bug 1801092 to Thunderbird - Add an ESLint rule to disallow single-argument use of Cu.reportError. rs=eslint DONTBUILD 2022-11-30 21:43:13 +11:00
Magnus Melin fe9d2f7246 Bug 1801529 - mozilla/valid-jsdoc automatic fixups across the Thunderbird codebase. r=aleca
This is the automatic fixes + whitespace fixup:

find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\* @returns +/* @returns /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\* @returns +/* @returns /g' {} \;

find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\* (@returns \{.+\}) +/* \1 /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\* (@returns \{.+\}) +/* \1 /g' {} \;

find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\*( @param)( \S+ \S+ ) +/*\1\2- /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\*( @param)( \S+ \S+ ) +/*\1\2- /g' {} \;

find . -type f -not -path "./suite/*" -name "*.js" -exec sed -i -E 's/\*( @param[^-]*)( - - )/*\1 - /g' {} \;
find . -type f -not -path "./suite/*" -name "*.jsm" -exec sed -i -E 's/\*( @param[^-]*)( - - )/*\1 - /g' {} \;

Differential Revision: https://phabricator.services.mozilla.com/D162704

--HG--
extra : rebase_source : 4307935e658ce38943af522b17ce6b1c0d99dfdd
2022-11-23 15:43:25 +11:00
Richard Marti 76c66b8c91 Bug 1795912 - Make the tabmail-tab work on modern flexbox. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D159608

--HG--
extra : amend_source : b67419dde3117ce36901ff8f3303eb6fb1c81408
2022-10-20 21:51:00 +11:00
Richard Marti e03ba5df0c Bug 1784408 - Port bug 1784265: Drop support for flex attribute values other than 0 and 1. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D154507

--HG--
extra : amend_source : 583afa3a0897ea33aa8b412e668d8fd1217f4412
extra : absorb_source : b7a744136b24901688452dd74b7fc4c81602cf6f
2022-08-13 20:22:59 +10:00
Magnus Melin 658036deef Bug 1779145 - Port bug 1667455 to Thunderbird - Expose a "Services" property on all privileged JS scopes (like Cu/Cc/Ci). r=leftmostcat
Changed prettier printWidth to 100 to put Services.jsm on one line, prettified and then
   grep -rEl "/Services.jsm" --exclude-dir=.hg --exclude-dir=suite --include="*.js" --include="*.jsm" --exclude=".*" . | xargs xargs sed -i -e '/\/Services.jsm/d'

Differential Revision: https://phabricator.services.mozilla.com/D151575

--HG--
extra : rebase_source : 43da2706d3b30f5062511cedd527e9fb65631f02
extra : amend_source : 863bfd4ad3930f4fe4ed0b3dba6061370118f9a5
2022-07-18 20:26:40 +10:00
Richard Marti aa25c24e06 Bug 1773406 - Don't apply a negative margin on spaces-toolbar when tab bar is hidden. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D150856
2022-07-04 20:58:53 +00:00
Alessandro Castellani 3f6e76e6af Bug 1715364 - Implement font scaling menu items. r=mkmelin,darktrojan,Paenglab
Differential Revision: https://phabricator.services.mozilla.com/D129454

--HG--
extra : amend_source : be683706c3f35a91430553d4c7f054478c223a88
2022-05-11 22:27:41 +03:00
Micah Ilbery 4585f6f9d8 Bug 1766465 - Implement new tab icons r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D145039

--HG--
extra : absorb_source : 066ecc0fdcb69f159a5317d11824cd104946b02b
2022-04-29 23:09:06 +00:00
Geoff Lankow a59c256e3a Bug 1752038 - Enable running Thunderbird without the old mail tabs. r=mkmelin
Setting mail.useNewMailTabs to true will make Thunderbird open with the new mail tab as the first tab.

Differential Revision: https://phabricator.services.mozilla.com/D136963

--HG--
extra : rebase_source : 517f8c373d0ae80f767e2eb18065a1a464ebcba2
2021-12-22 14:32:34 +13:00
Geoff Lankow 8a988fc3e7 Bug 1741521 - Revert changes to TabAttrModified event from bug 1683865. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D131294

--HG--
extra : rebase_source : b05cfed0fdc43837a205a4e295a1926f98024eaf
2021-11-17 12:07:40 +13:00
Henry Wilkes ebcc2795ec Bug 1734413 - Fix the tabContextMenu event handlers. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D127826

--HG--
extra : moz-landing-system : lando
2021-10-08 23:20:35 +00:00
Henry Wilkes e32a509702 Bug 1731497 - Fix closing tabs issues introduced by rev c6695c5b5708. r=mkmelin
Restored:
+ Middle mouse click on a tab closes it.
+ Prevent switching to a tab before closing it when the tab's close button is clicked.

Differential Revision: https://phabricator.services.mozilla.com/D126971
2021-09-30 11:50:12 +00:00
Magnus Melin 921301dd5b Bug 1602940 - fix Thunderbird consumers of nsIUUIDGenerator which is now in Services.jsm. rs=eslint
--HG--
extra : amend_source : e0ca32aa4dae84ad4a30b159215a9ac51e5074a0
2021-09-07 12:27:32 +03:00
Henry Wilkes 3849f0990b Bug 1683865 - Replace xul:image usage in tab (fav)icon. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D123741

--HG--
extra : amend_source : 1194dfb9a72520b32d572483d2c9b8f064c538d5
2021-08-26 20:13:34 +03:00
Henry Wilkes bcd7ea3f86 Bug 1683865 - Replace xul:image usage in tab close icon. r=mkmelin
Also got rid of some unnecessarily precise `... > .tab-stack > ...` parts of CSS selectors.

Differential Revision: https://phabricator.services.mozilla.com/D123433

Depends on D123432
2021-08-25 13:06:59 +00:00
Geoff Lankow 564bad8f71 Bug 1720662 - Implement a tab type property. r=john.bieling
Differential Revision: https://phabricator.services.mozilla.com/D120046

--HG--
extra : rebase_source : a4553df809fb0cd11ac4a41ca3eb7cc1219cdb9a
2021-07-16 15:08:26 +12:00
Geoff Lankow d3cc17a88d Bug 1719985 follow-up - Use triggerNode of tabContextMenu even for submenus. rs=bustage-fix
This fixes browser_dragndrop.js on Mac, which is failing because the triggerNode property is empty for the Recently Closed Tabs submenu. I'm sure this is actually a platform bug, but we can work around it.
2021-07-12 11:46:34 +12:00
Richard Marti 4a74450ee9 Bug 1719985 - Port bug 1717680: Remove document.popupNode and document.tooltipNode. r=mkmelin
--HG--
extra : amend_source : 70505937c250f6a1d83a1966d87e537627ea4c69
2021-07-11 13:49:59 +03:00
Geoff Lankow 113e4ee5b8 Bug 1718605 - Fix active mode of calendar UI during account set-up. r=mkmelin
This makes two changes:
* When a tab monitor is registered, its onTabSwitched method is now called immediately with the current tab, so that its state can match the current tab at the time of registration.
* When calendar starts up, which may be during the account set-up process, the UI is not put in the "mail" mode if the account set-up tab (or other content tab) is open. Instead the "special" mode is used, which is the right mode for content tabs.

Differential Revision: https://phabricator.services.mozilla.com/D118942

--HG--
extra : rebase_source : 0b9502893d078ecfeb3bd5462f8895f11c509a5d
2021-06-29 21:32:44 +12:00
Magnus Melin ff0d94d5de Bug 1699809 - Remove event.originalTarget from Thunderbird code. r=freaktechnik
# originalTarget -> target
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -not -path "./third_party/*" -exec sed -i -E 's/\.originalTarget/.target/g' {} \;

Differential Revision: https://phabricator.services.mozilla.com/D113790

--HG--
extra : rebase_source : e162bbbf76ad771cf4bcef2a5ed74c252fe51c17
2021-04-29 22:46:13 +03:00
Magnus Melin 8e170aabf9 Bug 1690945 - Remove ErrUtils.jsm. r=rnons
Differential Revision: https://phabricator.services.mozilla.com/D113006

--HG--
extra : rebase_source : 2fc77b6fcc4ffdb995e8c36248fc8b7c15a698a0
2021-04-21 22:10:37 +03:00
Alessandro Castellani 06250493d4 Bug 1702027 - Prevent blurring the current element and focusing on a new Tab if it was opened in the background. r=darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D110327

--HG--
extra : amend_source : 6fb88d0980135eae48efae3893772ff0f712a5cf
2021-03-31 12:38:39 +03:00
Geoff Lankow acd174925a Bug 1695098 - When switching tabs, focus the most recently active element. r=aleca
If when switching tabs the active element is within the current tab, focus is removed from it, and it is remembered so that focus can be restored when that tab becomes selected again.
This prevents elements in background tabs from retaining focus without being visible.

I've added a test which opens a few tabs and switches between them, testing the "selected" attribute, the focussed element, and TabOpen/TabSelect/TabClose events.

Differential Revision: https://phabricator.services.mozilla.com/D106569

--HG--
extra : rebase_source : 53ba220d9cf4487e3343800bbc1461a4d93f7b9b
extra : amend_source : dd0f3053f6b4c34f9548f8c052d96fdec68d21ab
2021-02-26 14:35:35 +13:00
Geoff Lankow 6468f583b2 Bug 1690467 - Fix date/time picker by removing gBrowser variable. r=mkmelin
The presence of gBrowser confuses the DateTimePicker actor. Since pdf.js has now been updated to run without gBrowser (instead using browser.getTabBrowser) this patch removes it.

Differential Revision: https://phabricator.services.mozilla.com/D103974

--HG--
extra : amend_source : c8e871182c56da12a91f0563bf7f60a5bb088771
2021-02-04 12:50:21 +02:00
Magnus Melin dcc568361a Bug 1689079 - allow account provisioning to use provider email and displayname, and fix some bugs. r=aleca
Provider can send back
 - x-thunderbird-account-name specifying the chosen display name
 - x-thunderbird-account-email specifying the chosen email

Other bug fixes:

 - only check main language, so if the provider supports "en", it will be shown to "en-US" users.
 - close the provider window after selecting an account - onload doesn't happen on trunk, and I don't see why we need to wait for the load to finish
 - tabmail: gStatusBar is an <hbox> - and sometimes not there. removing pointless setting of value
 - MsgAccountManager: needed in the provisioner success message, but wasn't included in accountProvisioner.xhtml
2021-02-04 12:45:40 +02:00
Geoff Lankow 1091e2f2cf Bug 1683787 - Make link handling multi-process compatible. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D100383

--HG--
extra : moz-landing-system : lando
2021-01-20 00:06:17 +00:00
Geoff Lankow 52726ddb26 Bug 1667294 - Allow loading of web pages in remote browsers. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D91382

--HG--
extra : moz-landing-system : lando
2021-01-20 00:05:54 +00:00
Magnus Melin ef2f83266c Bug 1682116 - add tabmail.tabs getter for Firefox compatibility (unbreaking mochitests). rs=bustage-fix 2020-12-12 20:28:33 +02:00
Neil Rashbrook 68092a81c4 Bug 1667774 - Fix HTTP refresh for content tabs r=darktrojan 2020-10-02 09:32:26 +03:00
Geoff Lankow 0fb1b375b1 Bug 1662395 - Keep a reference to TabProgressListeners and improve testing of tabs.onUpdated. r=mkmelin
TabProgressListener QIs to nsISupportsWeakReference, which means the instances we add only survive
until the next GC. Also if we change the layout of the 3-pane window, the progress listener on
#messagepane disappears.

Once all that is fixed we can more reliably test events on the tabs API.

Differential Revision: https://phabricator.services.mozilla.com/D89089

--HG--
extra : rebase_source : a1b779c62acf5523d36c8a259dcfac21c2c9dd79
extra : amend_source : 73be9ac58806e67ee8837d9c767f43679f2d9c0c
2020-09-01 21:29:09 +12:00
Geoff Lankow 0c582aff3c Bug 1656148 - Fix more linter "no-undef" errors and remove some dead compose code. r=pmorris
Differential Revision: https://phabricator.services.mozilla.com/D85361

--HG--
extra : rebase_source : ec1282286c7ec898a7c0d9e7c7acc66606e48c6a
extra : amend_source : 4b51403bacd5931bfce079aeefb3ac8bd18f21f4
2020-07-29 22:40:04 +12:00
Neil Rashbrook 337b77d558 Bug 1649188 - Wrap calls to tab monitors in try/catch to prevent them from breaking tabmail. r=darktrojan DONTBUILD
--HG--
extra : rebase_source : 594b79ab37e8aaf24edc7458e0dd765e9e9ac1c1
extra : amend_source : fd2ecb2dabe3114b7d079543641f40081d0c3f36
2020-07-11 18:26:59 +01:00
Geoff Lankow 0a60d34265 Bug 1652371 - Port bug 1649221 and bug 1649554. rs=bustage-fix CLOSED TREE
--HG--
extra : amend_source : cfc6361ee102cb0ee2e0c5b3497ec4a9b71688ca
2020-07-13 11:45:03 +12:00
Jorg K b0826913e4 Bug 1647104 - Fix real bugs found with codespell. r=mkmelin 2020-06-21 15:38:32 +03:00
Geoff Lankow 2f3fb8dea0 Bug 1646483 - Port Bug 1644943 to Thunderbird: Create single webprogress for CanonicalBrowsingContext. rs=bustage-fix
--HG--
extra : histedit_source : 8040ca6cd4ca04a851d77fa631504c433eff98b0%2Ce4ae70ac703f6ce193d7c8543801dcab5391a5b6
2020-06-18 12:15:45 +12:00
alta88@fixall.com 92cc02aec2 Bug 1641345 - Fix up firstTab browser; it is no longer stored in a WeakMap (for web ext), ensure it gets a listener. r=darktrojan
--HG--
extra : amend_source : 1540e894c72e76251b9b70cb01e4098947937d48
2020-06-01 08:04:10 -06:00
alta88@fixall.com 72d1cce056 Bug 1641345 - Relationship among <browser>, tabmail tab, and web-ext tabId is broken for shared messagepane tabs. r=darktrojan 2020-06-02 13:37:26 +03:00
Geoff Lankow 72d831f957 Bug 1631995 - Test events in the browser.windows and browser.tabs APIs and fix things that fail. r=mkmelin DONTBUILD
--HG--
extra : rebase_source : 310f926770b66fd2326a4147c747af4cbbf31cec
extra : amend_source : b70e5946c06f4caf88691de70da649eb176ebd06
2020-04-21 17:15:24 +12:00
Geoff Lankow 6d5f179535 Bug 1627556 - Test events in the browser.tabs API and fix several things that fail. r=mkmelin DONTBUILD 2020-04-10 13:58:49 +03:00
Magnus Melin 771b361ca1 Bug 1620556 - comm-central automatic code fixes for Prettier 1.19.1 upgrade. rs=eslint
--HG--
extra : amend_source : a3a3a71e4de9500d0466ca28f7804bc3ad500426
2020-03-14 14:33:11 +02:00
Magnus Melin b54ce4f72b Bug 1529583 - rename all Thunderbird related modules to .jsm, capitalize names and fix some namings. r=pmorris,Fallen DONTBUILD
grep -rEl EXPORTED_SYMBOLS --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor --include="*.js" --exclude=".*" . | xargs -I '{}' bash -c 'oldpath=$1; oldname=$(basename $1); newname="${oldname/\.js/.jsm}";newname="${newname^}"; newname=$(sed -E "s/(.*)[_-](.)(.*)/\1\U\2\L\3/g" <<< $newname); newpath="${oldpath%/*}/$newname"; echo "$newname $oldpath $newpath"; hg mv $oldpath $newpath; grep -rEl $oldname --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor --exclude-dir=chat/protocols/matrix/ . | xargs sed -E -i "s/( |\\\"|'\''|\/)${oldname/./\\.}/\1$newname/g"' -- {}

hg revert calendar/test/modules/CalendarUtils.jsm
hg revert chat/protocols/matrix/

hg revert chat/protocols/xmpp/xmpp-authmechs.jsm

# change Utils.jsm to utils.jsm
sed -i -e 's/Utils.jsm/utils.jsm/g' mail/test/browser/shared-modules/moz.build

# there's the mozmill/utils.js file
find . -type f -not -path "*.hg/*" -not -path "suite/*" -not -path "editor/*" -exec sed -i 's#mozmill/Utils.jsm*"#mozmill/utils.jsm#g' {} \;

correct sorting in
/home/magnus/Code/tb/mozilla/comm/mailnews/db/gloda/modules/moz.build

* * *
Bug 1529583 - fix linting errors discovered by js -> jsm renaming.

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/util/JXON.jsm:217:21 | 'document' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/util/JsTreeSelection.jsm:7:7 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/util/TraceHelper.jsm:7:7 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Connotent.jsm:14:5 | 'LOG' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Databind.jsm:9:5 | 'DBC_LOG' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Datamodel.jsm:17:9 | 'MailServices' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Datamodel.jsm:24:43 | Replace `"resource:///modules/gloda/Utils.jsm"` with `⏎··"resource:///modules/gloda/Utils.jsm"⏎` (prettier/prettier)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Dbview.jsm:14:9 | 'Gloda' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Dbview.jsm:15:9 | 'GlodaMsgSearcher' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Everybody.jsm:8:5 | 'LOG' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Explattr.jsm:19:9 | 'GlodaUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Explattr.jsm:19:43 | Replace `"resource:///modules/gloda/Utils.jsm"` with `⏎··"resource:///modules/gloda/Utils.jsm"⏎` (prettier/prettier)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Explattr.jsm:26:5 | 'EXT_BUILTIN' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Fundattr.jsm:12:43 | Replace `"resource:///modules/gloda/Utils.jsm"` with `⏎··"resource:///modules/gloda/Utils.jsm"⏎` (prettier/prettier)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Fundattr.jsm:14:9 | 'GlodaDatastore' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Fundattr.jsm:20:9 | 'MimeType' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Gloda.jsm:22:9 | 'GlodaDatabind' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Gloda.jsm:34:43 | Replace `"resource:///modules/gloda/Utils.jsm"` with `⏎··"resource:///modules/gloda/Utils.jsm"⏎` (prettier/prettier)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/IndexAb.jsm:10:9 | 'GlodaDatastore' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/IndexAb.jsm:21:9 | 'GlodaUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/IndexAb.jsm:21:43 | Replace `"resource:///modules/gloda/Utils.jsm"` with `⏎··"resource:///modules/gloda/Utils.jsm"⏎` (prettier/prettier)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/IndexMsg.jsm:17:9 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/IndexMsg.jsm:30:43 | Replace `"resource:///modules/gloda/Utils.jsm"` with `⏎··"resource:///modules/gloda/Utils.jsm"⏎` (prettier/prettier)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/IndexMsg.jsm:84:5 | 'JUNK_HAM_SCORE_STR' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Indexer.jsm:15:9 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Indexer.jsm:22:43 | Replace `"resource:///modules/gloda/Utils.jsm"` with `⏎··"resource:///modules/gloda/Utils.jsm"⏎` (prettier/prettier)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Log4moz.jsm:9:5 | 'MODE_RDONLY' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Log4moz.jsm:13:5 | 'MODE_TRUNCATE' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Log4moz.jsm:16:5 | 'PERMS_DIRECTORY' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Mimemsg.jsm:15:9 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Mimemsg.jsm:19:5 | 'EMITTER_MIME_CODE' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Suffixtree.jsm:42:5 | 'print' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/db/gloda/modules/Suffixtree.jsm:388:10 | 'examplar' is defined but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/fakeserver/Imapd.jsm:500:5 | 'IMAP_FLAG_CASE_INSENSITIVE' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/fakeserver/Imapd.jsm:516:5 | 'IMAP_NAMESPACE_OTHER_USERS' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/fakeserver/Imapd.jsm:517:5 | 'IMAP_NAMESPACE_SHARED' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/resources/IMAPpump.jsm:20:7 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/resources/IMAPpump.jsm:29:7 | 'AuthPLAIN' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/resources/IMAPpump.jsm:29:18 | 'AuthLOGIN' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/resources/IMAPpump.jsm:29:29 | 'AuthCRAM' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/resources/MailTestUtils.jsm:12:7 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/resources/MessageGenerator.jsm:805:10 | 'addMessagesToFolder' is defined but never used. (no-unused-vars)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/test/resources/MockFactory.jsm:7:7 | 'XPCOMUtils' is assigned a value but never used. (no-unused-vars)
* * *
Bug 1529583 - part tree, cleanup and improve some module namings

declare -A x
x["Bond.jsm"]="BondOpenPGP.jsm"
x["Gnupg.jsm"]="GnuPGCryptoAPI.jsm"
x["RnpCryptoapi.jsm"]="RNPCryptoAPI.jsm"
x["Connotent.jsm"]="GlodaContent.jsm"
x["Databind.jsm"]="GlodaDatabind.jsm"
x["Datamodel.jsm"]="GlodaDataModel.jsm"
x["Datastore.jsm"]="GlodaDatastore.jsm"
x["Dbview.jsm"]="GlodaSyntheticView.jsm"
x["Explattr.jsm"]="GlodaExplicitAttr.jsm"
x["Fundattr.jsm"]="GlodaFundAttr.jsm"
x["IndexAb.jsm"]="GlodaMsgIndexer.jsm"
x["Indexer.jsm"]="GlodaIndexer.jsm"
x["Mimemsg.jsm"]="MimeMessage.jsm"
x["MsgSearch.jsm"]="GlodaMsgSearcher.jsm"
x["Public.jsm"]="GlodaPublic.jsm"
x["Query.jsm"]="GlodaQueryClassFactory.jsm"
x["Suffixtree.jsm"]="SuffixTree.jsm"
#x["Utils.js"]="GlodaUtils.jsm"

for f in "${!x[@]}"; do
  export newname=${x[$f]}
  find . -type f -not -path "*.hg/*" -name $f | xargs -I '{}' bash -c 'oldpath=$1; oldname=$(basename $1); newpath="${oldpath%/*}/$newname"; echo " newname=$newname $oldpath -> $newpath"; hg mv $oldpath $newpath; grep -rEl $oldname --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor --exclude-dir=chat/protocols/matrix/ . | xargs sed -E -i "s/( |\\\"|'\''|\/)${oldname/./\\.}/\1$newname/g"' -- {}
done;

hg mv mailnews/db/gloda/modules/Utils.jsm mailnews/db/gloda/modules/GlodaUtils.jsm
grep -rEl --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor "gloda/Utils.jsm" . | xargs sed -i 's#gloda/Utils.jsm#gloda/GlodaUtils.jsm#g'

# manually sort mailnews/db/gloda/modules/moz.build

# manually update some ical.js references to be that as it's the project name

--HG--
rename : calendar/base/modules/ical.js => calendar/base/modules/Ical.jsm
rename : mail/components/appIdleManager.js => mail/components/AppIdleManager.jsm
rename : mail/components/about-support/aboutSupportMac.js => mail/components/about-support/AboutSupportMac.jsm
rename : mail/components/about-support/aboutSupportUnix.js => mail/components/about-support/AboutSupportUnix.jsm
rename : mail/components/about-support/aboutSupportWin32.js => mail/components/about-support/AboutSupportWin32.jsm
rename : mail/components/wintaskbar/windowsJumpLists.js => mail/components/wintaskbar/WindowsJumpLists.jsm
rename : mail/extensions/openpgp/content/bond.js => mail/extensions/openpgp/content/BondOpenPGP.jsm
rename : mail/extensions/openpgp/content/modules/cryptoAPI/gnupg.js => mail/extensions/openpgp/content/modules/cryptoAPI/GnuPGCryptoAPI.jsm
rename : mail/extensions/openpgp/content/modules/cryptoAPI/rnp-cryptoAPI.js => mail/extensions/openpgp/content/modules/cryptoAPI/RNPCryptoAPI.jsm
rename : mailnews/base/src/virtualFolderWrapper.js => mailnews/base/src/VirtualFolderWrapper.jsm
rename : mailnews/base/util/errUtils.js => mailnews/base/util/ErrUtils.jsm
rename : mailnews/base/util/IOUtils.js => mailnews/base/util/IOUtils.jsm
rename : mailnews/base/util/JXON.js => mailnews/base/util/JXON.jsm
rename : mailnews/base/util/jsTreeSelection.js => mailnews/base/util/JsTreeSelection.jsm
rename : mailnews/base/util/mailnewsMigrator.js => mailnews/base/util/MailnewsMigrator.jsm
rename : mailnews/base/util/msgDBCacheManager.js => mailnews/base/util/MsgDBCacheManager.jsm
rename : mailnews/base/util/StringBundle.js => mailnews/base/util/StringBundle.jsm
rename : mailnews/base/util/templateUtils.js => mailnews/base/util/TemplateUtils.jsm
rename : mailnews/base/util/traceHelper.js => mailnews/base/util/TraceHelper.jsm
rename : mailnews/db/gloda/modules/collection.js => mailnews/db/gloda/modules/Collection.jsm
rename : mailnews/db/gloda/modules/everybody.js => mailnews/db/gloda/modules/Everybody.jsm
rename : mailnews/db/gloda/modules/facet.js => mailnews/db/gloda/modules/Facet.jsm
rename : mailnews/db/gloda/modules/gloda.js => mailnews/db/gloda/modules/Gloda.jsm
rename : mailnews/db/gloda/modules/connotent.js => mailnews/db/gloda/modules/GlodaContent.jsm
rename : mailnews/db/gloda/modules/datamodel.js => mailnews/db/gloda/modules/GlodaDataModel.jsm
rename : mailnews/db/gloda/modules/databind.js => mailnews/db/gloda/modules/GlodaDatabind.jsm
rename : mailnews/db/gloda/modules/datastore.js => mailnews/db/gloda/modules/GlodaDatastore.jsm
rename : mailnews/db/gloda/modules/explattr.js => mailnews/db/gloda/modules/GlodaExplicitAttr.jsm
rename : mailnews/db/gloda/modules/fundattr.js => mailnews/db/gloda/modules/GlodaFundAttr.jsm
rename : mailnews/db/gloda/modules/indexer.js => mailnews/db/gloda/modules/GlodaIndexer.jsm
rename : mailnews/db/gloda/modules/index_ab.js => mailnews/db/gloda/modules/GlodaMsgIndexer.jsm
rename : mailnews/db/gloda/modules/msg_search.js => mailnews/db/gloda/modules/GlodaMsgSearcher.jsm
rename : mailnews/db/gloda/modules/public.js => mailnews/db/gloda/modules/GlodaPublic.jsm
rename : mailnews/db/gloda/modules/query.js => mailnews/db/gloda/modules/GlodaQueryClassFactory.jsm
rename : mailnews/db/gloda/modules/dbview.js => mailnews/db/gloda/modules/GlodaSyntheticView.jsm
rename : mailnews/db/gloda/modules/utils.js => mailnews/db/gloda/modules/GlodaUtils.jsm
rename : mailnews/db/gloda/modules/index_msg.js => mailnews/db/gloda/modules/IndexMsg.jsm
rename : mailnews/db/gloda/modules/log4moz.js => mailnews/db/gloda/modules/Log4moz.jsm
rename : mailnews/db/gloda/modules/mimemsg.js => mailnews/db/gloda/modules/MimeMessage.jsm
rename : mailnews/db/gloda/modules/mimeTypeCategories.js => mailnews/db/gloda/modules/MimeTypeCategories.jsm
rename : mailnews/db/gloda/modules/noun_freetag.js => mailnews/db/gloda/modules/NounFreetag.jsm
rename : mailnews/db/gloda/modules/noun_mimetype.js => mailnews/db/gloda/modules/NounMimetype.jsm
rename : mailnews/db/gloda/modules/noun_tag.js => mailnews/db/gloda/modules/NounTag.jsm
rename : mailnews/db/gloda/modules/suffixtree.js => mailnews/db/gloda/modules/SuffixTree.jsm
rename : mailnews/test/fakeserver/auth.js => mailnews/test/fakeserver/Auth.jsm
rename : mailnews/test/fakeserver/imapd.js => mailnews/test/fakeserver/Imapd.jsm
rename : mailnews/test/fakeserver/maild.js => mailnews/test/fakeserver/Maild.jsm
rename : mailnews/test/fakeserver/nntpd.js => mailnews/test/fakeserver/Nntpd.jsm
rename : mailnews/test/fakeserver/pop3d.js => mailnews/test/fakeserver/Pop3d.jsm
rename : mailnews/test/fakeserver/smtpd.js => mailnews/test/fakeserver/Smtpd.jsm
rename : mailnews/test/resources/IMAPpump.js => mailnews/test/resources/IMAPpump.jsm
rename : mailnews/test/resources/localAccountUtils.js => mailnews/test/resources/LocalAccountUtils.jsm
rename : mailnews/test/resources/mailTestUtils.js => mailnews/test/resources/MailTestUtils.jsm
rename : mailnews/test/resources/messageGenerator.js => mailnews/test/resources/MessageGenerator.jsm
rename : mailnews/test/resources/MockFactory.js => mailnews/test/resources/MockFactory.jsm
extra : amend_source : 810c5e4724ae28add2f66a87e88bc144578425e8
2020-01-25 12:05:55 +02:00
Geoff Lankow 24fb5a41e9 Bug 1605845 - Change all references to .xul files to .xhtml instead; rs=bustage-fix
--HG--
extra : rebase_source : f9df1b5f1d278b881373ffc7580aac1aabef2fa6
2019-12-24 22:30:36 +13:00
Magnus Melin 4693a34755 Bug 1570954 - Port bug 1479125 to Thunderbird: Rewrite callers firstChild/lastChild/childNodes/previousSibling/nextSibling with firstElementChild/lastElementChild/children/previousElementSibling/nextElementSibling. r=pmorris
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually refers to a text node, or when firstChild is used in a loop to empty out an element):

firstChild->firstElementChild
lastChild->lastElementChild
nextSibling->nextElementSibling
previousSibling->previousElementSibling
childNodes->children

 # firstChild -> firstElementChild
grep -rl '\bfirstChild\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bfirstChild\b/firstElementChild/g'

 # lastChild->lastElementChild
grep -rl '\lastChild\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\blastChild\b/lastElementChild/g'

 # nextSibling->nextElementSibling
grep -rl '\nextSibling\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bnextSibling\b/nextElementSibling/g'

 # previousSibling->previousElementSibling
grep -rl '\previousSibling\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bpreviousSibling\b/previousElementSibling/g'

 # childNodes->children
grep -rl '\childNodes\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\bchildNodes\b/children/g'

 # revert for clearning out. lastElementChild.remove() -> lastChild.remove()
grep -rl '\lastElementChild.remove\b' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/\lastElementChild.remove\b/lastChild.remove/g'

 # skip matches in cpp and other wrong changes
hg revert mailnews/base/src/nsSubscribableServer.cpp
hg revert mailnews/base/src/nsSubscribableServer.h
hg revert mailnews/mime/src/mimemsig.cpp
hg revert mail/test/mozmill/composition/test-signature-updating.js
hg revert mail/test/mozmill/shared-modules/DOMHelpers.jsm
hg revert mailnews/addrbook/jsaddrbook/AddrBookMailingList.jsm
hg revert mailnews/addrbook/public/nsIAbDirectory.idl
hg revert mailnews/addrbook/test/unit/test_basic_nsIAbDirectory.js
hg revert mailnews/addrbook/test/unit/test_jsaddrbook.js
hg revert mailnews/addrbook/test/unit/test_mailList1.js
hg revert mailnews/addrbook/test/unit/test_uid.js
hg revert mailnews/compose/src/nsMsgCompose.cpp
hg revert mail/test/mozmill/cloudfile/test-cloudfile-attachment-urls.js
hg revert mail/test/mozmill/composition/test-forward-headers.js

hg revert calendar/import-export/calHtmlExport.js
hg revert mail/components/compose/content/cloudAttachmentLinkManager.js
hg revert mail/components/compose/content/dialogs/EdConvertToTable.js
hg revert mail/components/compose/content/dialogs/EdDialogCommon.js
hg revert mail/components/compose/content/dialogs/EdInsertTOC.js
hg revert mail/components/customizableui/CustomizeMode.jsm
hg revert mail/components/customizableui/PanelMultiView.jsm
hg revert mail/test/mozmill/shared-modules/ComposeHelpers.jsm
hg revert mailnews/addrbook/jsaddrbook/AddrBookDirectory.jsm
hg revert mailnews/base/util/JXON.js
hg revert mailnews/base/util/errUtils.js
hg revert mailnews/extensions/newsblog/content/feed-parser.js

hg revert mail/components/compose/texzilla/TeXZilla.js

../mach eslint --fix
2019-10-13 21:42:57 +03:00
Richard Marti d4ab6480c2 Bug 1586091 - Port bug 1514926: Convert the arrowscrollbox binding to a Custom Element. r=aleca DONTBUILD 2019-10-03 22:06:31 +02:00
Jorg K 4fc80ffe10 Bug 1542720 - Follow-up: Fix linting errors. r=mkmelin 2019-09-19 10:56:43 +02:00
Geoff Lankow 9c541d6c7d Bug 1544793 - Fix setting window title preface by windows API; r=mkmelin DONTBUILD 2019-09-02 17:16:00 +12:00
Paul Morris f28d61bbe6 Bug 1577835 - Rewrite atypical for loops in mail/ for Prettier. r=mkmelin 2019-08-30 17:28:34 -04:00
Paul Morris bbcaaa4b09 Bug 1577835 - Reformat mail/ code with eslint and Prettier. r=mkmelin
# ignore-this-changeset

These changes were achieved by:

1. Using eslint to add curly brackets to control
statements that did not have them (if, else, etc.),
thanks to the eslint rule: "curly": ["error", "all"]

Done by running |mach eslint mail/ --fix|

2. Reformatting the code using Prettier.

Done by deleting the mail/ line from
the .prettierignore file and running:
|mach eslint mail/ --fix|
2019-08-30 16:19:44 -04:00
Paul Morris 425d00717a Bug 1573670 - Wrap all Thunderbird custom elements in curly bracket blocks. r=mkmelin
Leave re-indentation to Prettier's auto-formatting, to happen
in a subsequent patch. Use `const` instead of `let` for imports.
2019-08-27 12:26:37 -04:00
Alessandro Castellani a2d50f2c49 Bug 1554629 - [de-xbl] convert the tabmail binding to a custom element. r=mkmelin 2019-08-06 10:45:31 -07:00