**How To Test**
- At the end of the function #initUI() in email.mjs add the following lines of code
``` this.#states[subview].subview.showErrorNotification(
"account-hub-find-settings-failed",
"account-hub-find-settings-failed",
"error"
);
```
- Switch between the different error types in your developer console by replacing the class error in the HTML element #emailFormNotification with either success, info, or warning to see the different styles.
Differential Revision: https://phabricator.services.mozilla.com/D223401
--HG--
extra : amend_source : d2527430491a8f33af1e5c587618e35805fe01a8
There seems little reason the config file should be able to decide on whether the server should be added or not.
This is an internal flag to opt out in certain situations.
Differential Revision: https://phabricator.services.mozilla.com/D223758
--HG--
extra : rebase_source : 926b3ba634afe6b3c14402623678fb09b24f4a28
We got useGlobalPreferredServer from autoconfig, but with no server set up that's a no-go.
Differential Revision: https://phabricator.services.mozilla.com/D223756
--HG--
extra : rebase_source : e96c24f62f306af894ee40e4e29591146bf743cf
### How to test
- Use table view
- Resize columns until the elastic style pushed them back
- Access `Settings` > `General` > `Reading & Display`
- Toggle `Allow horizontal scroll` on
The message list should now have horizontal scrolling enabled
and only the columns that haven't been previously manually resized
should expand. The last column also should be resizable, allowing
more control on the layout.
Differential Revision: https://phabricator.services.mozilla.com/D222886
--HG--
extra : amend_source : da2b8055924e754f3c581982ff932685a6c6180b
Since https://phabricator.services.mozilla.com/D193762 has landed, multiple selected contacts with display names that are dragged into the compose window are treated as attachments. This patch excludes dragged items containing the "text/x-moz-address" flavor from being checked for valid attachments and handles them directly.
Differential Revision: https://phabricator.services.mozilla.com/D222539
--HG--
extra : moz-landing-system : lando
It seems that the test fails are due to a real regression introduced by
Bug 1911977. Test is disabled while the regression is reported to and
handled by upstream.
Differential Revision: https://phabricator.services.mozilla.com/D223311
--HG--
extra : moz-landing-system : lando
The values in `msgHdr.mime2DecodedRecipients` and `msgHdr.mime2DecodedAuthor`
should no longer be used. They will hold invalid values, if the decoded
value includes a comma, but not the encoded value. Since the encoded
value does not need to be quoted, and the decoded mailbox string is not
auto-quoted, it becomes invalid and unusable.
Differential Revision: https://phabricator.services.mozilla.com/D223208
--HG--
extra : rebase_source : bcfa1ed13baba8b58f79b11e76975ab364bed720
This is a continuation of Bug 1898617. Our attachment detection code
missed some edge cases and did not consider inline forwarded messages as
attachments (which is what Thunderbird itself is doing). However, we
also missed to consider forwarded messages as attachments, which do not
have a content-disposition header at all.
This also adds a test for this additional edge case.
Differential Revision: https://phabricator.services.mozilla.com/D223093
--HG--
rename : mail/components/extensions/test/xpcshell/messages/nestedMessageInline.eml => mail/components/extensions/test/xpcshell/messages/nestedMessageNoContentDispositionHeader.eml
extra : amend_source : 5c56c79e94750cd2f1567c99606ccb5ec051663e
This is the result of multiple frustrating days spend on trial-and-error. I was able to
reproduce the issue on a Fedora Workstation 40 installation in a Hyper-V VM and this seems
to fix it for me.
I have absolutly no idea as to *why* this is needed, but it is telling that there actually
is a `isWaylandPopup`getter.
Differential Revision: https://phabricator.services.mozilla.com/D223049
--HG--
extra : amend_source : d916443e4cdf78384e5e159b237ca4b71d8320a4
This is a performance improvement based on Kai's input to minimize the
computational work required to determine whether a message is encrypted.
This also fixes a bug where decrypted attachments where not
returned to the API (but the encrypted one), because a status flag was
not properly set.
This also adds tests.
Differential Revision: https://phabricator.services.mozilla.com/D202755
--HG--
rename : mail/components/extensions/test/xpcshell/test_ext_messages_encrypted_attachment.js => mail/components/extensions/test/xpcshell/test_ext_messages_encrypted.js
extra : amend_source : c1da773281b675f0df08627b2f496d92de295fa7
There's an exception thrown here for other types of connection errors. The error handler logs a
message to the console which can be useful for debugging setup errors.
Differential Revision: https://phabricator.services.mozilla.com/D222592
**How to Test**
- Open account hub through developer console
- Compare the input fields, and check animation
- Check correct icons show up for input statuses
Differential Revision: https://phabricator.services.mozilla.com/D218354
--HG--
extra : moz-landing-system : lando
Very few users will have this, as it's not been shown in the UI for many many years.
Differential Revision: https://phabricator.services.mozilla.com/D221865
--HG--
extra : moz-landing-system : lando
These test sending messages from the compose window with a variety of connection/authentication
problems. They are closely related to the tests named browser_getMessages with the same suffixes.
Sending a message presents a variety of prompt windows to the user, particularly when something
goes wrong. I've tried to avoid writing tests that lock in this behaviour in the hope that one day
somebody will overhaul it.
Differential Revision: https://phabricator.services.mozilla.com/D220857
--HG--
extra : moz-landing-system : lando
This is a cosmetic change. Instead of having two different button types
for Manifest V2 and Manifest V3 and using `choice` to use one or the
other, we move the `choice` into the definition itself.
Differential Revision: https://phabricator.services.mozilla.com/D220364
--HG--
extra : moz-landing-system : lando
Martin Giger
Vineet Deo
Alessandro Castellani
Magnus Melin
welpy-cw
Richard Marti
Geoff Lankow
John Bieling
Micah Ilbery
Alexander Schmitz