Граф коммитов

319 Коммитов

Автор SHA1 Сообщение Дата
Magnus Melin 2e8b2146f5 Bug 1920339 - migrate invalid feed hostnames. r=tobyp
This migrates invalid feeds names to use our standard Feeds.
I found even Thunderbid 5.0 uses "Feeds" at least normally... so might not be super common.

For testing, set up a feed account.
with Thunderbird closed set the hostname to "RSS-News & Weblogs" in prefs.js and edit feeds.json for that account to have
destFolder like "mailbox://nobody@RSS-News & Weblogs/comm-central%20Changelog".
Also make sure the mail.ui-rdf.version pref is less than 45 (if you're testing more than once).

After starting, the hostname should be corrected, and the feeds.json contain good url.
Do another restart Thunderbird, and the feeds should now work properly.

Differential Revision: https://phabricator.services.mozilla.com/D223317

--HG--
extra : moz-landing-system : lando
2024-09-27 21:50:14 +00:00
John Bieling f78c920f81 Bug 1903751 - Reduce errors to warnings in ExtensionSupport.sys.mjs. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D223612

--HG--
extra : amend_source : 74c745bf019e5ffcd78f2e2e5667adf50dfff4cb
2024-09-26 09:58:03 +03:00
welpy-cw cc39fd6852 Bug 1872595 - Continue applying columns/current view to child folders after an error occurred. r=mkmelin
Initially based on https://github.com/Betterbird/thunderbird-patches/blob/main/128/bugs/1872595-apply-columns-fault-tolerant.patch

Differential Revision: https://phabricator.services.mozilla.com/D222601

--HG--
extra : amend_source : 94548c8b7207e860145c694d113217a3bf25830e
2024-09-23 12:05:16 -04:00
Magnus Melin 8566666c5d Bug 1801529 - Enable eslint-plugin-jsdoc for mail/modules . rs=me 2024-09-22 13:16:58 +03:00
Kai Engert 4de6afa05a Bug 1837247 - Fix viewing of attached encrypted messages. r=mkmelin
Loosely inspired by a patch from Betterbird
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1837247-1689326-save-encrypted-attachments.patch

Differential Revision: https://phabricator.services.mozilla.com/D221895

--HG--
extra : rebase_source : fa82f6fda79120313a946f01d1dc2ce1eb31b090
2024-09-12 00:35:31 +02:00
Magnus Melin 443ddae2e7 Bug 1868517 - Remove deprecated trySTARTTLS and migrate any accounts using trySTARTTLS to alwaysSTARTTLS. r=leftmostcat
Very few users will have this, as it's not been shown in the UI for many many years.

Differential Revision: https://phabricator.services.mozilla.com/D221865

--HG--
extra : moz-landing-system : lando
2024-09-12 20:44:48 +00:00
Magnus Melin 7c811028d7 Bug 1917425 - Fix [win perma] comm/calendar/test/unit/providers/test_cal_detection.js. r=tobyp
Use AppConstants instead, since XPCShell tests mess with AppInfo, and that confused us to Windows tried to load *nix .dlls

Differential Revision: https://phabricator.services.mozilla.com/D221599

--HG--
extra : rebase_source : fb84d567d8273010f0cb8e895bd85d672bf3b4e4
extra : amend_source : a134f51a04eaeac1359cef85e6a11921c4b1ce15
2024-09-11 13:49:33 +03:00
welpy-cw 3bdd1607d6 Bug 1402550 - Enable saving an .eml file directly. r=mkmelin
- Fix `cmd_saveAsFile` for .eml files that have just been opened from the file system.
- Disable `cmd_saveAsTemplate` when such a message is displayed.
- When an attached .eml file is opened, try to preserve the filename in the URI (see bug 927640)

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/128/bugs/927640-1402550-fix-saving-eml.patch, which is itself based on SeaMonkey code.

Differential Revision: https://phabricator.services.mozilla.com/D220719

--HG--
extra : amend_source : 5ffbc0fa2887431b173420fcbc7399ab72b76b55
2024-09-06 10:37:37 +12:00
Magnus Melin daed10d50c Bug 1914792 - Port bug 1870226 to Thunderbird - Update eslint-plugin-jsdoc. r=freaktechnik
See https://hg.mozilla.org/mozilla-central/rev/06d1e6e91857

Differential Revision: https://phabricator.services.mozilla.com/D220095

--HG--
extra : rebase_source : b40147a61da24053a546533aed08f0a830b082ed
2024-08-26 08:29:10 +00:00
Magnus Melin 14da5b810f Bug 1801529 - Fix jsdoc comments in mail/modules/DBViewWrapper.sys.mjs. rs=me
--HG--
extra : amend_source : 646c1d0eba42ea59025796d9b1bbdf3e0b8dae16
2024-08-19 20:27:34 +03:00
Magnus Melin 1b334baf19 Bug 1801529 - Fix jsdoc comments in mail/modules/GlobalPopupNotifications.sys.mjs. rs=me 2024-08-18 13:07:36 +03:00
Magnus Melin fa92fbcf3b Bug 1801529 - Fix jsdoc comments in mail/modules/ExtensionSupport.sys.mjs. rs=me 2024-08-18 12:04:21 +03:00
Magnus Melin d1a167479d Bug 1801529 - Fix jsdoc comments in mail/modules/PluralForm.sys.mjs. rs=me
--HG--
extra : rebase_source : 5d5d0822aced00ea18a092a371bc20898554fa61
extra : amend_source : 79248128ca8294b0405a5fa93c15bcff2106ee83
2024-08-15 23:00:01 +01:00
Magnus Melin 8b14870e5d Bug 1801529 - Fix jsdoc comments in mail/modules/CommandController.mjs. rs=me 2024-08-15 09:19:35 +01:00
Magnus Melin b4f1daac2c Bug 1801529 - Fix jsdoc comments in mail/modules/AttachmentInfo.sys.mjs. rs=me
--HG--
extra : rebase_source : 4cc44fa0c769fd2886db28476b8c4f0ffc2ff97e
extra : amend_source : 1e708ad727fedda37315209ed6db6c677520ff45
2024-08-14 09:16:19 +01:00
welpy-cw 5917481a8c Bug 1910168 - Fix refreshing the view after a folder has been repaired. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D218663

--HG--
extra : amend_source : 40ef48f347691f3f38c5780b523006935a459dd0
2024-08-10 13:48:00 +03:00
Magnus Melin b60e8b954a Bug 1801529 - Fix jsdoc comments in mail/modules/SearchSpec.sys.mjs. rs=me
--HG--
extra : rebase_source : 10f12e957c905a70c6f68b8059391c2d66db0910
2024-08-09 09:56:51 +03:00
welpy-cw 0cc5158068 Bug 1908761 - Simplify and improve handling of secondary sorts in DBViewWrapper. r=aleca,babolivier
To set the secondary sort, `DBViewWrapper` lets the view sort itself twice in many cases such as
entering/leaving Quick Filter or leaving Grouped By Sort, as well as just changing the sort type
itself. Since `nsMsgDBView::Sort()` already takes the secondary sort into account, these
additional calls can be removed, which can significantly improve performance depending on the
individual sort types.

When leaving Grouped By Sort, the secondary sort type will always be set to Order Received, which
prevents having a comparably slow sort type such as by From, Recipient, or Correspondents as
secondary sort in place.

Differential Revision: https://phabricator.services.mozilla.com/D217971

--HG--
extra : amend_source : 734d4576517f02968371cd35bad740906afabbfa
2024-08-06 17:15:01 +01:00
Ben Campbell c77adcc204 Bug 1878541 - Add migration code to delete nstmp files left over from failed folder compactions. r=darktrojan,freaktechnik
Differential Revision: https://phabricator.services.mozilla.com/D214916

--HG--
extra : moz-landing-system : lando
2024-07-23 13:00:03 +00:00
Magnus Melin 0b09795f68 Bug 1899602 - Distribute metrics.yaml files to where they belong. r=aleca
Stop using the tb. prefix, and put the probes in component relative metrics.yaml files

Differential Revision: https://phabricator.services.mozilla.com/D217002

--HG--
extra : rebase_source : ba46a84da2a78c3e00a36c94de63e45eb07afb6d
extra : amend_source : c3dc50206c65e5d3cf74605af24cf453d4dbc1e0
2024-07-20 13:38:18 +03:00
Magnus Melin 0f532a5e4d Bug 1801529 - Fix jsdoc comments in mail/modules/DisplayNameUtils.sys.mjs. rs=me 2024-07-15 13:54:58 +03:00
Magnus Melin 4b1b0fa36d Bug 1801529 - Fix jsdoc comments in mail/modules/MailMigrator.sys.mjs. rs=me 2024-07-15 09:06:17 +03:00
Geoff Lankow b904d8acfd Bug 1901705 - Remove migrations that have shipped in at least three ESRs. r=aleca
These migrations have been in version 102, 115, and now 128.

Differential Revision: https://phabricator.services.mozilla.com/D215708

--HG--
extra : rebase_source : 9f417349b75f8dba2aa9132ddf27be0c6a7da36c
extra : amend_source : fafcc9cf3debcddd0e12a55bc018f0230c3a557a
2024-07-03 21:45:40 +12:00
Patrick Cloke ba76a8e278 Bug 1583053 - Fix handling of DNS TXT records with multiple strings. r=darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D210189

--HG--
extra : amend_source : 1a1b1a5e6fe0a8416385216a72ec71bbf2f2f768
2024-07-02 10:53:25 +01:00
Magnus Melin 55a86ace71 Bug 1899602 - migrate tb.mails.folder_opened to glean. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D213124

--HG--
extra : rebase_source : 2624610d09681c415d0f2e185be6d3ec4caad938
2024-06-19 10:23:58 +03:00
Magnus Melin 39c20e97e5 Bug 1899602 - migrate tb.ui.interaction probes to glean. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D213108

--HG--
extra : rebase_source : 5896eb7fbf682a099487d3f7b60de4614edcbb57
2024-06-19 12:22:32 +03:00
Magnus Melin 2da84bad9a Bug 1899602 - convert tb.websearch.usage to Glean. r=vineet
Differential Revision: https://phabricator.services.mozilla.com/D213104

--HG--
extra : rebase_source : f469b94d2506488388216c3cfe4a8bb0de00560b
2024-06-19 10:18:49 +03:00
Martin Giger 5812c7990e Bug 1904035 - Add unit tests for LinkHelper. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D214547

--HG--
extra : amend_source : 32520d44a0d06921d832370a90df41820d6396f9
2024-06-24 15:54:06 +01:00
Magnus Melin 036b36b913 Bug 1801529 - Fix jsdocs in mail/modules/MailUtils.sys.mjs. rs=me
--HG--
extra : rebase_source : 5abebf4d1112b094a426c0f8c4d86732a420bcf2
2024-06-12 13:33:12 +03:00
Geoff Lankow 6eb818be3e Bug 1901926 - Fix folder pane tag folders for tags with special characters. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D213381

--HG--
extra : rebase_source : 98a5f4ca1744a0e7f06d9300ff1e45377f61846a
extra : amend_source : 8c8923d4b10fecb8e82e90b5a06a9540bbb725d9
2024-06-12 16:48:10 +12:00
Alessandro Castellani 76b0f85a58 Bug 1817605 - Implement a simple multiselection option for the tree-listbox-mixin. r=arschmitz,darktrojan,mkmelin
What is supported:
- Hold CTRL while clicking to select multiple rows.
- Hold SHIFT while clicking to select a range of folder from the currently active element.
- Hold CTRL and press arrow up/down to select next/previous row.
- Enable multiselection via data attribute to keep the widget modular.

Specific to Folder pane:
- Enable only a few simple actions when in multiselection
- Open in Tab/Window and Mark as Read are always enabled.
- Move and Copy only if conditions are met.
- Empty trash/junk only if the selected folders are all trash/junk.

Differential Revision: https://phabricator.services.mozilla.com/D203232

--HG--
extra : amend_source : 4386159ceacad69bb8c3d033b9007fa884926f5b
2024-06-08 13:57:35 +03:00
Alessandro Castellani 0db13f3cd8 Bug 1482172 - Implement color customization for accounts. r=mkmelin,vineet
Very simple color customization for servers.
It leverages the same FolderTreeProperties module and flow of the folder pane.

Differential Revision: https://phabricator.services.mozilla.com/D211687

--HG--
extra : moz-landing-system : lando
2024-06-07 22:13:59 +00:00
Martin Giger 12c1938404 Backed out changeset bc7a4b8a50f4 (bug 1817605) for test failures. r=backout DONTBUILD
--HG--
extra : histedit_source : 25988cd21c99d6fa3da96802c4a82180dce43708
2024-06-05 14:28:25 +02:00
Alessandro Castellani d681165779 Bug 1817605 - Implement a simple multiselection option for the tree-listbox-mixin. r=darktrojan,mkmelin,arschmitz
What is supported:
- Hold CTRL while clicking to select multiple rows.
- Hold SHIFT while clicking to select a range of folder from the currently active element.
- Hold CTRL and press arrow up/down to select next/previous row.
- Enable multiselection via data attribute to keep the widget modular.

Specific to Folder pane:
- Enable only a few simple actions when in multiselection
- Open in Tab/Window and Mark as Read are always enabled.
- Move and Copy only if conditions are met.
- Empty trash/junk only if the selected folders are all trash/junk.

Differential Revision: https://phabricator.services.mozilla.com/D203232

--HG--
extra : amend_source : 20aec1999e7f5034189b7740f5e4747a76cd4c06
2024-06-05 11:46:13 +02:00
Magnus Melin 9154a515fa Bug 1801529 - Fix jsdocs in mail/modules/DisplayNameUtils.sys.mjs. r=me
--HG--
extra : rebase_source : 5c1c2d265d668733eaf3a58e2f2a5248ecb5c0a1
2024-06-02 13:58:44 +03:00
Magnus Melin 539239e860 Bug 1801529 - Fix jsdocs in mail/modules/DNS.sys.mjs. r=me 2024-06-01 13:33:04 +03:00
Geoff Lankow f4f17812f5 Bug 1851535 - Remove MsgHdrSyntheticView. r=aleca
We stopped using this with the mail tabs rebuild.

Differential Revision: https://phabricator.services.mozilla.com/D211958

--HG--
extra : amend_source : a4cbe7fdfe4d379eae65d2cd70658159d3650294
2024-05-29 04:50:43 +00:00
Alessandro Castellani 7a60376027 Bug 1894048 - Remove the PreferDisplayName individual property from the contacts and only respect the global condensedAddress pref. r=mkmelin,darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D210886

--HG--
extra : moz-landing-system : lando
2024-05-22 22:06:41 +00:00
Geoff Lankow ccc0a780ec Bug 1890731 - Begin replacing nsITreeView with TreeDataAdapter. r=freaktechnik,aleca
Creates and heavily modifies a copy of PROTO_TREE_VIEW from jsTreeView.js. I've removed a bunch of
things that are no longer needed because we don't need to implement nsITreeView, and tidied up
what remains, while keeping the general concepts intact.

Differential Revision: https://phabricator.services.mozilla.com/D208446

--HG--
rename : mail/base/content/modules/thread-pane-columns.mjs => mail/base/content/modules/ThreadPaneColumns.mjs
rename : mailnews/base/content/jsTreeView.js => mail/base/content/modules/TreeDataAdapter.mjs
rename : mail/base/content/widgets/tree-selection.mjs => mail/base/content/modules/TreeSelection.mjs
rename : mail/base/test/widgets/files/autoTreeView.js => mail/base/test/widgets/files/autoTreeView.mjs
rename : mail/base/test/widgets/files/tree-element-test-common.js => mail/base/test/widgets/files/tree-element-test-common.mjs
rename : mail/base/test/widgets/files/tree-element-test-header.js => mail/base/test/widgets/files/tree-element-test-header.mjs
rename : mail/base/test/widgets/files/tree-element-test-no-header.js => mail/base/test/widgets/files/tree-element-test-no-header.mjs
extra : moz-landing-system : lando
2024-05-21 04:33:23 +00:00
Magnus Melin 06839910e0 Bug 1801529 - Fix jsdocs in MailUsageTelemetry.sys.mjs. r=me 2024-05-18 12:05:47 +03:00
Magnus Melin 29ddecc9e1 Bug 1801529 - Fix jsdocs in PhishingDetector.sys.mjs and SmartMailboxUtils.sys.mjs. r=me
--HG--
extra : rebase_source : 857da578a43873216c3e851ea2f8580a85da6e85
2024-05-17 13:36:54 +03:00
welpy-cw e2da8ff2a9 Bug 1895097 - Fix and extend restoreThreadState(). r=darktrojan
- Fix a recent regression (from bug 1892074) by restoring the thread state when all messages have been loaded in any view searching one or more folders.
- Enable DBViewWrapper._threadExpandAll and threadPane.restoreThreadState() for synthetic views as well. This is necessary to use Grouped-By-Sort in Expand-All state without performance impact.

Differential Revision: https://phabricator.services.mozilla.com/D209493

--HG--
extra : amend_source : 3b08301bd81c8743cae1b9a60c8af1ff143204e3
2024-05-15 10:19:55 +12:00
Patrick Cloke aecde7619b Bug 1571076 - Fix DNS TXT lookups when the answer contains multiple records. r=darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D209966

--HG--
extra : amend_source : 2920d0ed709de4e151ed27125cb075d50fc19f2c
2024-05-13 11:18:22 -07:00
welpy-cw 6bd8a6975f Bug 697706 - Add preference to recreate inbox folder when archiving. r=babolivier,darktrojan,vineet
- Implement the `mail.identity.default.archive_recreate_inbox` preference and the corresponding `nsMsgIdentity` attribute `archiveRecreateInbox`. This defines how the inbox folder is handled when archiving while preserving the folder structure. If the pref is `false`, the inbox is treated like the root folder, if `true`, it is recreated like any other folder.
- Make this preference available in the account archive options. Update and fix the example shown there.

Differential Revision: https://phabricator.services.mozilla.com/D208350

--HG--
extra : amend_source : a17e36bde568e13d2735587e8a54255b9d68bca9
2024-05-13 13:30:19 +03:00
welpy-cw be906a2149 Bug 1893793 - Fix setting view flags for cross-folder/synthetic search views. r=mkmelin
Resorting the messages is only necessary when changing from threaded or grouped to unthreaded.

Differential Revision: https://phabricator.services.mozilla.com/D208830

--HG--
extra : amend_source : 81cc22b8e615e0959a36b214a4e590d47e370a07
2024-05-06 08:15:23 +00:00
Brendan Abolivier 2382f902c6 Bug 1882574 - Enable outgoing message servers other than SMTP. r=leftmostcat
This patch generalises the existing nsISmtpService and nsISmtpServer interfaces
to remove assumptions that the sending mail server is always SMTP. In this new
architecture, the protocol-specific settings are set in a separate,
protocol-specific XPIDL interface that is used to configure the sending server.

I have also removed some attributes and a method from these interfaces, as they
either were not needed across the XPCOM boundary, or were not used at all.

Intentionally left out of scope for this patch:

  * Migrating (from .properties to Fluent) and updating some l10 strings to not
    mention SMTP explicitly.
  * Conditionally defining the outgoing protocol in the account setup code.
  * Conditionally showing a server's details and edit form in the account
    settings code.
  * Migrating prefs to not use "smtp" in their names if the server doesn't
    actually use SMTP.

Differential Revision: https://phabricator.services.mozilla.com/D203799

--HG--
rename : mailnews/compose/public/nsISmtpServer.idl => mailnews/compose/public/nsIMsgOutgoingServer.idl
rename : mailnews/compose/public/nsISmtpService.idl => mailnews/compose/public/nsIMsgOutgoingServerService.idl
rename : mailnews/compose/src/SmtpService.sys.mjs => mailnews/compose/src/OutgoingServerService.sys.mjs
rename : mailnews/compose/test/unit/test_nsSmtpService1.js => mailnews/compose/test/unit/test_nsMsgOutgoingServerService1.js
extra : moz-landing-system : lando
2024-05-09 16:33:15 +00:00
Vineet Deo d37acc3881 Bug 1894831 - Standardize focus behaviour of middle click and context menu action for opening a message in a new tab. r=aleca
**How to Test**
- Check all actions that can open message in a new tab
- Using the context menu or middle click should always open a message in a tab
- Using shift with those above actions should focus those tabs, otherwise the tabs should open the background
- Double clicking a message when loadInBackground pref is false should open and focus on that message in a new tab
- Shift should open the above action in the background
- Vice versa for when loadInBackground pref is true
- Load in background pref should not affect middle click and context menu actions

Differential Revision: https://phabricator.services.mozilla.com/D209609

--HG--
extra : moz-landing-system : lando
2024-05-09 10:01:59 +00:00
Alessandro Castellani a1e730b875 Bug 1893349 - Set windows.notificationserver pref to false to temporarily fix 10 seconds delay for Windows notifications. r=john.bieling
This only removes the 10 seconds delays when clicking on a Windows OS notification.
With these prefs set to `false` the notification is correctly dismissed and the message is visualized.
Unfortunately, the application is not brought to the foreground correctly, but we will take care of this in bug 1863798.

Differential Revision: https://phabricator.services.mozilla.com/D208574

--HG--
extra : amend_source : 441ed8f2688c50caf349c6a064628eb5b4f9f5b1
2024-05-08 18:42:30 +00:00
John Bieling 55d0d49fe7 Bug 1893700 - Move smart folder and virtual tag folder code from mail3pane.js to SmartMailboxUtils.sys.mjs r=freaktechnik
We currently use getSmartServer() in various code areas to create, get
and update the smart account/server/folders. The virtual tags folders
were not handled by that method and the required code was only
triggered, when the user enabled the "tags" folder mode in the UI.

The WebExtension API needs access to these tag folders even if the user
has not yet enabled that folder mode.

This patch adds a SmartMailbox class, which simplifies tasks related to
unified mailbox folders and virtual tag folders, and creates the
virtual tag folders together with the unified mailbox folders.

It renames SmartServerUtils.sys.mjs to SmartMailboxUtils.sys.mjs.

Differential Revision: https://phabricator.services.mozilla.com/D208776

--HG--
rename : mail/modules/SmartServerUtils.sys.mjs => mail/modules/SmartMailboxUtils.sys.mjs
extra : moz-landing-system : lando
2024-05-08 21:49:37 +00:00
John Bieling a5687874b4 Bug 1893669 - Add folders.getTagFolder(). r=mkmelin
This adds a dedicated method to get one of the tags folders.
Including a minimal test.

A follow-up is needed to move the code which actually creates the
virtual tag folders from about3pane.js to SmartServerUtils.sys.mjs

Differential Revision: https://phabricator.services.mozilla.com/D208762

--HG--
extra : moz-landing-system : lando
2024-05-08 21:49:37 +00:00