b7872de632
Bug 1928031 - clean out load-enigmail/load-enigmail. r=kaie
...
- load-engimail and unload-engimail events did not exist anymore
- onUnloadEnigmail was only called from those event handlers, calling it would have caused excptions as Enigmail.columnHandler.onUnloadEnigmail and Enigmail.hdrView.onUnloadEnigmail also no longer existed
- messageCleanup() was only called from messageFrameUnload()
Differential Revision: https://phabricator.services.mozilla.com/D227817
2024-11-04 11:51:37 +00:00
7e36cd0f1c
Bug 1928031 - Avoid key cache population error if an event triggered cleanup during await. r=kaie
...
Clear the cache at same time as we clear the normal cache. This is cleared whenever we get a "openpgp-key-change" notification.
Differential Revision: https://phabricator.services.mozilla.com/D227489
2024-11-11 13:43:31 +00:00
46ce26342d
Bug 1928826 - Re-add support to enable/disable the permission prompt for external apps, introducing mail.external_protocol_requires_permission. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D227776
--HG--
rename : mail/components/extensions/test/browser/browser_ext_content_handler.js => mail/components/extensions/test/browser/browser_ext_content_handler_with_prompt.js
extra : amend_source : ec5b51b2faf8c4442e95b796ab39af91d8fa4383
2024-11-11 17:01:12 +01:00
fd9aa6091d
Bug 1929845 - Remove remaining needless Ci. appreviations (except in calendar). r=mkmelin,leftmostcat
...
Fixing https://searchfox.org/comm-central/search?q=const.*+%3D+Ci.&path=&case=true®exp=true
Differential Revision: https://phabricator.services.mozilla.com/D228322
--HG--
extra : moz-landing-system : lando
2024-11-08 10:38:19 +00:00
baf16c6abe
Bug 1925929 - Forbid viewing remote content in encrypted OpenPGP messages. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D227048
--HG--
extra : rebase_source : 06f493737a5a3e943cc0042f3cc054207344ef18
2024-10-29 19:17:30 +00:00
29442c63ed
Bug 1925747 - Ensure OpenPGP init code in composer is delayed until main init is ready. r=mkmelin,john.bieling
...
Differential Revision: https://phabricator.services.mozilla.com/D227196
--HG--
extra : amend_source : cbd774a220afdbc6b6dc684831fc715451086dc6
2024-11-01 12:22:30 +02:00
373e3b6032
Bug 1927379 - Add a dark style to some info/error pages. r=aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D227481
--HG--
extra : amend_source : db8adc749658889b8779aeebc607ad7f3f085069
2024-10-31 12:23:08 +00:00
0a1f76feb7
Bug 1927813 - Do not ask for permission when opening http(s):// and webext protocol links. r=darktrojan
...
After the preference `security.external_protocol_requires_permission`
was removed and the app behaves now as that preference being set to
true, every usage of the external protocol service triggers a permission
prompt.
This patch stops using the external protocol service directly. Instead
we now always use `openLinkExternally()`, which was modified to add the
permission to use the associated application, so the user is not prompted.
Differential Revision: https://phabricator.services.mozilla.com/D227375
--HG--
extra : rebase_source : 35f86de9e43f31e1039e2aa6b0e5c6c42e65fb9b
extra : amend_source : fa58c5f9ff9a4baef85f81ecb281ae3735b2d793
2024-10-30 15:43:35 +01:00
ab7a5e754b
Bug 1927282 - In OpenPGP key details dialog, lock the visibility setting of passphrases tab to initial state. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D227092
--HG--
extra : rebase_source : 194290b010d1c65226fea610cdf87d1e79f4ab89
2024-10-30 08:15:58 +02:00
7f38681d2e
Bug 1922934 - Reduce the height of the Create key dialog. r=aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D225344
--HG--
extra : moz-landing-system : lando
2024-10-28 00:54:43 +00:00
7b75f1ea5f
Bug 1926443 - Use an enum value instead of a boolean in scrollSelectionIntoView. r=aleca,tobyp
...
This argument changed to a short in 2010, but continued to compile because booleans are integers.
It wasn't actually synchronous, as the enum value is 2 but true is 1, but I don't think it really matters.
Differential Revision: https://phabricator.services.mozilla.com/D226571
--HG--
extra : rebase_source : 59d7fe8a3e999c8c59a98c28eea9efacfe09862e
extra : amend_source : 0f1324795cc6793662b9d36829d04c43d1a9153c
2024-10-23 11:54:25 +13:00
4e514030f2
Bug 1921728 - Handle binary OpenPGP keys ending with whitespace. r=kaie
...
Differential Revision: https://phabricator.services.mozilla.com/D224194
--HG--
extra : rebase_source : c5a854f16d7c79dd1a5d61656084112d0da1bebc
extra : amend_source : c612acf7f3aabde2eae2fa6e1ca4b7a92df88156
2024-10-03 13:28:48 +03:00
745d424b18
Bug 1911080 - Ensure C++ email compose code operates on correct composeSecure flags. r=mkmelin
...
Related correctness changes:
- Two variables that are always treated as an array shouldn't get initialized to null, but to an empty array.
- When deciding whether an URI refers to an encrypted message, always query both S/MIME and OpenPGP trackers.
Differential Revision: https://phabricator.services.mozilla.com/D223826
2024-09-30 17:40:07 +00:00
dcaaca5eb6
Bug 1882832 - Process encrypted MIME parts based on headers, minimize reading MIME parts. r=kaie
...
This is a performance improvement based on Kai's input to minimize the
computational work required to determine whether a message is encrypted.
This also fixes a bug where decrypted attachments where not
returned to the API (but the encrypted one), because a status flag was
not properly set.
This also adds tests.
Differential Revision: https://phabricator.services.mozilla.com/D202755
--HG--
rename : mail/components/extensions/test/xpcshell/test_ext_messages_encrypted_attachment.js => mail/components/extensions/test/xpcshell/test_ext_messages_encrypted.js
extra : amend_source : c1da773281b675f0df08627b2f496d92de295fa7
2024-09-23 12:03:56 -04:00
27d2c2cf3f
Bug 1918946 - Fix shadow/redeclare linting errors in openpgp code. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D222239
--HG--
extra : rebase_source : b36da7c509bb34f291747d63ae97a1f1e896c2e1
2024-09-16 10:16:44 +02:00
63b39af5b1
Bug 1919194 - Ensure stored draft messages are encrypted even when no recipients were specified. r=kaie
...
Differential Revision: https://phabricator.services.mozilla.com/D222418
2024-09-17 08:43:01 +00:00
4de6afa05a
Bug 1837247 - Fix viewing of attached encrypted messages. r=mkmelin
...
Loosely inspired by a patch from Betterbird
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1837247-1689326-save-encrypted-attachments.patch
Differential Revision: https://phabricator.services.mozilla.com/D221895
--HG--
extra : rebase_source : fa82f6fda79120313a946f01d1dc2ce1eb31b090
2024-09-12 00:35:31 +02:00
a7c4954839
Bug 1838308 - Update RNPLib.sys.mjs with new version when updating librnp. r=kaie,dandarnell
...
Differential Revision: https://phabricator.services.mozilla.com/D221355
--HG--
extra : moz-landing-system : lando
2024-09-12 20:44:49 +00:00
5741771690
Bug 1917577 - Fix incorrect log call in decryption.sys.mjs. r=kaie
...
Differential Revision: https://phabricator.services.mozilla.com/D221618
--HG--
extra : rebase_source : e727fec5287c84c3699ec5dc98529b5d74cc3013
extra : amend_source : 2fdcf669fb6ae2159191a6cd86fd6d0eb87d262c
2024-09-11 13:50:15 +03:00
bffe309d76
Bug 1907282 - Improve/fix logging when there are issues with OpenPGP keys. r=kaie
...
This fixes the logging, and just skips the problematic entries.
Differential Revision: https://phabricator.services.mozilla.com/D216679
--HG--
extra : amend_source : 1e2f57f6059b2e867e53307558ecf2db514a71e9
2024-09-04 06:28:21 +12:00
daed10d50c
Bug 1914792 - Port bug 1870226 to Thunderbird - Update eslint-plugin-jsdoc. r=freaktechnik
...
See https://hg.mozilla.org/mozilla-central/rev/06d1e6e91857
Differential Revision: https://phabricator.services.mozilla.com/D220095
--HG--
extra : rebase_source : b40147a61da24053a546533aed08f0a830b082ed
2024-08-26 08:29:10 +00:00
d0e4338aad
Bug 1911227 - Always use base64 encoding for inner signed payload when using external GPGME signing. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D218779
--HG--
extra : amend_source : e10579ff3caa7fb50a86839eabc4fe8460dac562
2024-08-08 10:44:30 +01:00
a8f106bd47
Bug 1906903 - Enable users of external GnuPG to decrypt badly encoded messages with inner ASCII armor. r=mkmelin
...
See also bug 1898832.
Differential Revision: https://phabricator.services.mozilla.com/D217039
--HG--
extra : rebase_source : 6da08bb60b83263e463b74cb3be697109335c994
2024-07-19 00:39:14 +02:00
4b423edc78
Bug 1898832 - Convert GPGME signing output from ASCII armor to binary, if necessary. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D215241
--HG--
extra : amend_source : 6c2a1baa360ee88dd80e8d3e8b34b6b6f7ca5c97
2024-07-18 13:44:44 +03:00
61c4f74c4e
Bug 1908113 - Revert accidental functional change from cleanup, and improve decision logic. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D216749
--HG--
extra : amend_source : 0319bf1706fdb16bc87121962e32a500ebf2aebf
extra : absorb_source : 3f0a439a766982f6660abdb10abe4107b76237e4
2024-07-17 09:28:03 -07:00
1af72a48cc
Bug 1905398 - Remove seemingly unnecessary quotes replacement. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D215237
2024-06-28 18:19:44 +00:00
f7b8ed234e
Bug 1905839 - Use a by C-C owned loading icon. r=arschmitz
...
Differential Revision: https://phabricator.services.mozilla.com/D215468
--HG--
extra : amend_source : a444b0d7c89c060110f734e6ccba76097ff73d62
2024-07-02 10:52:50 +01:00
1af1b65c64
Bug 1899110 - Fix charset issue for inline OpenPGP, when the key was not known. r=kaie
...
For UTF-8 we did not convert to bytestring to begin with, so upon conversion back we got the wrong result.
Differential Revision: https://phabricator.services.mozilla.com/D213780
2024-07-01 15:14:33 +00:00
eaa5327da8
Bug 1905519 - Port bug 1904040: Replace loading.png with loading.svg. r=Paenglab
...
Differential Revision: https://phabricator.services.mozilla.com/D215301
--HG--
extra : moz-landing-system : lando
2024-07-01 02:26:11 +00:00
466d3ca639
Bug 1905014 - Use global code for email name parsing, remove incomplete code from OpenPGP code. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D215112
--HG--
extra : amend_source : 4a35a36d9fccfefc6cff4a9b15efc409a1176e1a
2024-06-30 13:52:21 +03:00
e7065fb14c
Backed out changeset 95df1981616c (bug 1899110) for causing test failures
...
--HG--
extra : amend_source : 089b3963c986be067754a03dead60e07f14d8f93
2024-06-28 13:58:01 +01:00
301691e14e
Bug 1899110 - Fix charset issue for inline OpenPGP, when the key was not known. r=kaie
...
For UTF-8 we did not convert to bytestring to begin with, so upon conversion back we got the wrong result.
Differential Revision: https://phabricator.services.mozilla.com/D213780
--HG--
extra : rebase_source : 2b64490cd3bae63bb6ae5256095e0ccfe4fa8f3e
2024-06-27 13:55:33 +03:00
ed7f474944
Bug 1902991 - S/MIME status must be shown when opening a message from file. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D213938
--HG--
extra : rebase_source : a1597aa18e149df3249d732017bee75a6804a411
extra : amend_source : e0336a663e20017fd240e8297fa4a0e6f26c2b7b
2024-06-17 11:35:25 +02:00
db7d8f9548
Bug 1898832 - With external GnuPG config, never use inner ASCII armor for signature, and fall back to GPGME decoding when seeing BAD_FORMAT error. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D211638
--HG--
extra : rebase_source : 08702e924fa359f2b2920b28f7939ba0211a5555
2024-05-25 01:14:20 +02:00
dd613f2033
Bug 1666507 - Support changing the expiry date of keys with a complex structure. r=aleca,mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D212003
--HG--
extra : amend_source : da5f9147157ebb46142853da9ace7dcd3e17d498
2024-06-05 11:47:08 +02:00
02f296fa63
Bug 1898162 - Disable prompt code in MimeTreeDecrypter() when used by the WebExtension API. r=kaie
...
The MimeTreeDecrypter has some calls to `Services.prompt.*` which need
to be supressed when used from a WebExtension API (because they do not
interact with the UI).
This adds a new option `promptUser` which defaults to true, and is
disabled for the WebExtension API.
Differential Revision: https://phabricator.services.mozilla.com/D211168
--HG--
extra : moz-landing-system : lando
2024-05-24 22:14:36 +00:00
fb7653c27b
Bug 1885353 - Set MIN_RNP_VERSION to 0.17.1. r=kaie
...
Differential Revision: https://phabricator.services.mozilla.com/D211549
--HG--
extra : moz-landing-system : lando
2024-05-24 16:22:26 +00:00
794bb27861
Bug 1581796 - Integrated certificate request (CSR) generation. r=laurel,rrelyea,freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D188140
--HG--
extra : amend_source : 22ec0c69edc2ba6c8b0b1c2dc29e9d09ab509ca6
2024-05-24 09:21:42 +12:00
7f2fdb39c0
Bug 1891241 - Remove EnigmailCryptoAPI indirection. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D211271
--HG--
extra : amend_source : 8e559b4628db8e4bbebd79b74265f8cacdcb0623
2024-05-24 09:20:50 +12:00
5e7817a193
Bug 1891241 - Remove CryptoAPI parent layer. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D211270
--HG--
extra : amend_source : fafd89387d69ead153186ee7240489c132675abc
2024-05-24 09:20:36 +12:00
4d39420062
Bug 1891241 - Remove unnecessary GnuPGCryptoAPI and some other code. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D211243
--HG--
extra : amend_source : da4e77ceea0b27e7ad5342cfe884e8c564704551
2024-05-24 09:20:19 +12:00
b95036e694
Bug 1883855 - Add test for Import of public PGP key where key block has empty line with space after the crc line. r=kaie
...
Works now with RNP 0.17.1
Differential Revision: https://phabricator.services.mozilla.com/D205871
--HG--
extra : moz-landing-system : lando
2024-05-22 10:04:02 +00:00
5e3be4f622
Bug 1874715 - Warn about imported or existing OpenPGP secret keys that advertise unsupported features. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D200823
--HG--
extra : amend_source : 4d4787b8ad90a05b267b9480fa88506401d753df
2024-05-17 10:30:53 -07:00
9bf80863e4
Bug 1896618 - BUG_COMPONENT annotations for thunderbird code. r=john.bieling,clokep,freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D210437
--HG--
extra : amend_source : c9d4bf50d4653b24dc5fc1b51c4e67e021f760c1
2024-05-17 10:30:09 -07:00
90dd1595e7
Bug 1896876 - Allow case insensitive match for email address, fixes Autocrypt header issue. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D210488
--HG--
extra : amend_source : c14744e360c472f0706164f79bb6a0423b294fba
2024-05-15 13:55:13 -07:00
00116c4abb
Bug 1895119 - Remove in themeableDialog.css the in variables.css existing variables. r=freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D209496
--HG--
extra : moz-landing-system : lando
2024-05-06 16:58:49 +00:00
f10d422e86
Bug 1885942 - Port bug 1879815: Fix PGP dialog buttons. r=aleca
...
Differential Revision: https://phabricator.services.mozilla.com/D204945
--HG--
extra : amend_source : 0d93226f2976cc13f7269b4d50fb98553c4b7122
2024-05-03 18:58:19 +03:00
7c890fae17
Bug 1801529 - Fix jsdocs and enable eslint-plugin-jsdoc for smime. rs=me
...
--HG--
extra : amend_source : b7a9924dc210e0b3bb2b310d7a52cb678c92e592
2024-04-27 13:32:59 +03:00
390cbd8e69
Bug 1891689 - Backup secret key to file from account settings doesn't work. r=kaie
...
In https://hg.mozilla.org/comm-central/rev/4ab32edc743e I had missed two cases where promptKeyExport2AsciiFilename are now really async.
The dialogs seemingly do the right thing, but it doesn't actually backup if you check for the file.
Added a test so it doesn't regress again.
Differential Revision: https://phabricator.services.mozilla.com/D207524
--HG--
extra : amend_source : 6c1ae0b6d13bd6eeb1acedadf480f9fc9b899be4
2024-04-23 17:53:46 +02:00
c3c7f562cb
Bug 1801529 - Fix jsdocs and enable eslint-plugin-jsdoc for openpgp. rs=me
...
--HG--
extra : amend_source : ca173b838160807a7a01dfc86cafe8339e8052a4
2024-04-21 13:22:09 +03:00
Magnus Melin
John Bieling
Yury Ivanovich
Kai Engert
Richard Marti
Geoff Lankow
Rob Lemley
Alessandro Castellani
Brendan Abolivier
Martin Giger