This is the last patch for the stack of Bug 1877390. Everything outside
of DBViewWrapper now uses columnIds to for sorting. The special
handling for custom column sort has been moved entirely into the
DBViewWrapper.
Differential Revision: https://phabricator.services.mozilla.com/D200243
--HG--
extra : rebase_source : 20120c5c4dd999e8de965e20b812f923d95e3b5a
This continues the effort to remove redundant code. The relation
between sortType and columnId is defined in DEFAULT_COLUMNS and does not
need to be hard-coded in the DBViewWrapper.primarySortColumnId getter.
Differential Revision: https://phabricator.services.mozilla.com/D200290
--HG--
extra : rebase_source : 58a956816dbc9d4c536712484273c39071a08ee3
Both can be generated from DEFAULT_COLUMNS and do not need to be
maintained manually.
While modifying them, I learned that one of their use-cases in
HandleColumnClick() in threadPane.js can be simplified using the new
getter for primarySortColumnId.
Differential Revision: https://phabricator.services.mozilla.com/D200276
--HG--
extra : rebase_source : 4bea1ba0fdf8b5a2c4b87328b4c569bb6a386742
In threadPane.js exists similar code as in about3pane.js, to convert the
sort type of the current sort column into a columnId.
This patch moves these functions as an additional getter into
DBViewWrapper.jsm.
To avoid circular dependencies, this patch moves OUTGOING_FOLDER_FLAGS
from DBViewWrapper.jsm to FolderUtils.jsm.
Differential Revision: https://phabricator.services.mozilla.com/D200242
--HG--
extra : rebase_source : 1e47ef7b626915999d743915cd842d55fc3bb7d9
The function convertSortTypeToColumnID() uses dbView.curCustomColumn to
convert the "byCustom" sort type to a columnID. This however only works
for the current custom sort column, and not for any custom column. It is
also only used with the primarySortType (and not with any sort type) as
input.
To improve readability of this code, this patch reworks this function to
always return to columnID of the current sort column.
Differential Revision: https://phabricator.services.mozilla.com/D200212
--HG--
extra : rebase_source : 219d43da8faa064fdd95bc14388c1bc185aceb23
This will be set in mozilla-config.h which is force-included in all C++ code so it's
easy to use in #ifdef's or #if defined().
Differential Revision: https://phabricator.services.mozilla.com/D205749
--HG--
extra : moz-landing-system : lando
Firefox restored the ability to load 3rd party libraries without validation in
bug to fix pkcs11 security modules. The same problem occurs with libgpgme
from Homebrew, needed for external GPG smartcard support.
Differential Revision: https://phabricator.services.mozilla.com/D205621
--HG--
extra : amend_source : 0d5b9436012392b58d045f9fa8fb343503ce5a0e
The macOS Rust builds were falling back to the v1 macOS hardened signing configs (for
Firefox). Those were removed in bug 1886051 causing these signing jobs to fail.
Just needed to add the build platform to only-for-build-platforms so the transform picks
it up.
Differential Revision: https://phabricator.services.mozilla.com/D205577
--HG--
extra : amend_source : 62fe74963cf78544e4f5c201967e235c946c954d
Failing at least comm/mail/components/extensions/test/browser/browser_ext_messages_open_attachment.js
--HG--
extra : amend_source : cfb6455a4d8c64f36dddcd841e011a7b7dbe10f6
The pref removal is a port of bug 1705440. Everything else is dead code.
Differential Revision: https://phabricator.services.mozilla.com/D205141
--HG--
extra : amend_source : 9cfb59c281c34a705231816429826dc48c1251e3
Adding back debugging infor for GPGMELib.
This should not be using global console for debug info, if such info is warranted.
For error cases, we can log errors. To see debug only info, people should set `openpgp.loglevel` to `All`.
Differential Revision: https://phabricator.services.mozilla.com/D205423
--HG--
extra : rebase_source : f5399a64a9b0bfc18a60e89f9e1faf51f9ea0410
extra : amend_source : f87ec4551da5615a96bce2a0b23548b4a15077fa
After recent linter changes, these are reported as
`'context' is assigned a value but never used. (no-unused-vars)`
Differential Revision: https://phabricator.services.mozilla.com/D205453
--HG--
extra : moz-landing-system : lando
Update outdated .jsm references in the tree.
Depends on D204766
Differential Revision: https://phabricator.services.mozilla.com/D204769
--HG--
extra : rebase_source : cdf8c1367702bb00c51a750cc712e156db65d371
extra : amend_source : 5f2256fc97ae8f3de2086ffbe99acde9fdef0473
John Bieling
solange valverde
Daniel Darnell
Geoff Lankow
Rob Lemley
Magnus Melin
Richard Marti
Martin Giger
Silvia Bonavista i Serrat
Kai Engert
Micah Ilbery
Thunderbird Updatebot