CID 1137656 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)2. uninit_member: Non-static class member m_offlineMsgSize is not initialized in this constructor nor in any functions that it calls.
Differential Revision: https://phabricator.services.mozilla.com/D111624
--HG--
extra : rebase_source : 1e6f6b6a5413ed9aeb3dd10b7f9afd67a2e91b1f
CID 1416479 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)2. uninit_member: Non-static class member mResult is not initialized in this constructor nor in any functions that it calls.
Differential Revision: https://phabricator.services.mozilla.com/D111623
--HG--
extra : rebase_source : d6bc34342d31465bdaaf2e7573959e81a5ecc746
CID 1137658 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)3. uninit_member: Non-static class member m_meteorsSpinning is not initialized in this constructor nor in any functions that it calls.
Differential Revision: https://phabricator.services.mozilla.com/D111622
--HG--
extra : rebase_source : c82176590c0b1445f410d0061dc8dd2b3fc48af6
uninit_member: Non-static class member m_startTime is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member m_parsingDone is not initialized in this constructor nor in any functions that it calls.
CID 1260151 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)6. uninit_member: Non-static class member m_urlInProgress is not initialized in this constructor nor in any functions that it calls.
Differential Revision: https://phabricator.services.mozilla.com/D111621
--HG--
extra : rebase_source : 873f26cd889079aa02e134c5eb1a5b097d64d7cb
CID 1417611: Dereference before null check (REVERSE_INULL)
notnull: At condition curPos, the value of curPos cannot be nullptr.
dead_error_condition: The condition curPos must be true.
CID 1417612 (#1 of 1): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach the expression NS_MsgCreatePathStringFromFolderURI(curPos, newPath, nsTLiteralString<char>(operator "" _ns("none", 4UL)).operator nsTString const &(), false) inside this statement: NS_MsgCreatePathStringFromF....
Differential Revision: https://phabricator.services.mozilla.com/D111620
--HG--
extra : rebase_source : 609d0394448c1b5c3c7a47abb27a38a65c594c6a
CID 1459799 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)2. uninit_member: Non-static class member mResult is not initialized in this constructor nor in any functions that it calls.
Differential Revision: https://phabricator.services.mozilla.com/D111619
--HG--
extra : rebase_source : 14c1930627170a7c9a9c769856117cb51d72126f
Except for chat's logger.jsm (and test), ext-compose.js (no IOUtils in extension API implementations)
and converterWorker (uses OS.File.open to read and write big files).
Differential Revision: https://phabricator.services.mozilla.com/D111298
--HG--
extra : moz-landing-system : lando
Found by coverity. leaked_storage: Variable newFileStream going out of scope leaks the storage it points to.
CID 1137477
Differential Revision: https://phabricator.services.mozilla.com/D111547
--HG--
extra : rebase_source : 87f6ef054782ca9c3f4db289fbd342cc5c6def2e
extra : amend_source : 99e89ab70cd7ba571dfbfbc3097cff99eb7c248e
The problem is SmtpService.jsm doesn't use nsISmtpUrl, so do_QueryInterface would always fail.
--HG--
extra : rebase_source : 9be167f7f3557f1a2ecbe90807daab3e9855a014
From rfc5321#section-2.3.5
> A domain name that is not in FQDN form is no more than a local alias.
> Local aliases MUST NOT appear in any SMTP transaction.
--HG--
extra : rebase_source : ecaebe98acc678c754589619592c9a3c6e5620b2
The error happens when
- forwarding a message as attachment, but delete the message before sending
- drag/drop a message into compose window, delete the message before sending
Differential Revision: https://phabricator.services.mozilla.com/D110226
--HG--
extra : amend_source : 04c870549b477c6c55abef09943ff58d7c479143
Under the following conditions, both a taskbar icon and a notify icondisppear
so that there is no way to bring Thunderbird's window back.
- No unread email
- `mail.minimizetotray = true`
This happens because `IconWindowProc` deletes the notify icon without updating
the flag `nsMessengerWinIntegration::mTrayIconShown`. This patch makes sure
that flag is set to `false` every time we delete the notify icon through
`Shell_NotifyIconW`. In order for `IconWindowProc` to access the instance of
`nsMessengerWinIntegration`, this patch associates the instance pointer with
the window handle.
Differential Revision: https://phabricator.services.mozilla.com/D110218
--HG--
extra : amend_source : 814bb713606b20240b8a7a21d03ea893bab9a0fe
In Thunderbird, an instance of `TaskbarWindowPreview` is created when
`WinUnreadBadge.updateUnreadCount` calls `WinTaskbar::GetOverlayIconController`.
However, that instance is freed immdiately after `updateUnreadCount` exits
because nobody owns it. As a result, the taskbar icon disappears even when
`mail.minimizeToTray = false`.
This patch makes `WinUnreadBadge` own a reference to `TaskbarWindowPreview`
so that its instance is kept alive after the method exits.
This approach is the same as Firefox stores `TaskbarWindowPreview` as
`DownloadsTaskbar._taskbarProgress`.
Differential Revision: https://phabricator.services.mozilla.com/D110191
--HG--
extra : amend_source : 6817b4fb4e049a3e5005505fbac5eae9994a404c
Also fix error msg of NS_MSG_ERROR_ATTACHING_FILE.
Differential Revision: https://phabricator.services.mozilla.com/D110054
--HG--
extra : amend_source : 0b3a54db2a7b7a9fce30c3bf927c4ff3098c484b
This looks like a lot of code removal but it isn't. I'm copying a file then removing half of each copy.
In this patch I've also added a cleanUp function to nsIAbDirectory. It's essentially an async destructor that runs at shutdown or if the directory is deleted.
This allowed me to tidy up the shutdown process and block shutdown until the databases are closed.
Differential Revision: https://phabricator.services.mozilla.com/D108400
--HG--
rename : mailnews/addrbook/modules/AddrBookDirectory.jsm => mailnews/addrbook/modules/SQLiteDirectory.jsm
extra : moz-landing-system : lando
Hidden accounts include the unified folder account. Further this fixes reordering after an account
is marked as default.
Differential Revision: https://phabricator.services.mozilla.com/D108944
Depends on D108943
--HG--
extra : rebase_source : e5789a9416c175b5b8d93269b95f191f8f4d17e3
Magnus Melin
Ping Chen
Martin Giger
Alessandro Castellani
Geoff Lankow
Mark Banner
Richard Marti
Ben Campbell
Toshihito Kikuchi
Neil Rashbrook
Khushil Mistry
it@henk.com.au
Jorg K
gene smith