Merge pull request #418 from mozilla/footer-link-blank

_blank all footer links

frontend/src/download.js

@@ -14,23 +14,17 @@ $(document).ready(function() {
   //link back to homepage
   $('.send-new').attr('href', window.location.origin);
 
-  $('.send-new').click(function(target) {
-    target.preventDefault();
+  $('.send-new').click(function() {
     sendEvent('recipient', 'restarted', {
       cd2: 'completed'
-    }).then(() => {
-      location.href = target.currentTarget.href;
     });
   });
 
   $('.legal-links a, .social-links a, #dl-firefox').click(function(target) {
-    target.preventDefault();
     const metric = findMetric(target.currentTarget.href);
     // record exited event by recipient
     sendEvent('recipient', 'exited', {
       cd3: metric
-    }).then(() => {
-      location.href = target.currentTarget.href;
     });
   });
 

frontend/src/upload.js

@@ -23,35 +23,26 @@ $(document).ready(function() {
   $('#file-upload').change(onUpload);
 
   $('.legal-links a, .social-links a, #dl-firefox').click(function(target) {
-    target.preventDefault();
     const metric = findMetric(target.currentTarget.href);
     // record exited event by recipient
     sendEvent('sender', 'exited', {
       cd3: metric
-    }).then(() => {
-      location.href = target.currentTarget.href;
     });
   });
 
-  $('#send-new-completed').click(function(target) {
-    target.preventDefault();
+  $('#send-new-completed').click(function() {
     // record restarted event
+    storage.referrer = 'errored-upload';
     sendEvent('sender', 'restarted', {
       cd2: 'completed'
-    }).then(() => {
-      storage.referrer = 'completed-upload';
-      location.href = target.currentTarget.href;
     });
   });
 
-  $('#send-new-error').click(function(target) {
-    target.preventDefault();
+  $('#send-new-error').click(function() {
     // record restarted event
+    storage.referrer = 'errored-upload';
     sendEvent('sender', 'restarted', {
       cd2: 'errored'
-    }).then(() => {
-      storage.referrer = 'errored-upload';
-      location.href = target.currentTarget.href;
     });
   });
 

views/layouts/main.handlebars

@@ -43,12 +43,12 @@
   </div>
   <div class="footer">
     <div class="legal-links">
-      <a href="https://www.mozilla.org"><img class="mozilla-logo" src="/resources/mozilla-logo.svg"/></a>
-      <a href="https://www.mozilla.org/about/legal" data-l10n-id="footerLinkLegal">Legal</a>
-      <a href="https://testpilot.firefox.com/about" data-l10n-id="footerLinkAbout">About Test Pilot</a>
-      <a href="/legal" data-l10n-id="footerLinkPrivacy">Privacy</a>
-      <a href="/legal" data-l10n-id="footerLinkTerms">Terms</a>
-      <a href="https://www.mozilla.org/privacy/websites/#cookies" data-l10n-id="footerLinkCookies">Cookies</a>
+      <a href="https://www.mozilla.org" target="_blank"><img class="mozilla-logo" src="/resources/mozilla-logo.svg"/></a>
+      <a href="https://www.mozilla.org/about/legal" data-l10n-id="footerLinkLegal" target="_blank">Legal</a>
+      <a href="https://testpilot.firefox.com/about" data-l10n-id="footerLinkAbout" target="_blank">About Test Pilot</a>
+      <a href="/legal" data-l10n-id="footerLinkPrivacy" target="_blank">Privacy</a>
+      <a href="/legal" data-l10n-id="footerLinkTerms" target="_blank">Terms</a>
+      <a href="https://www.mozilla.org/privacy/websites/#cookies" data-l10n-id="footerLinkCookies" target="_blank">Cookies</a>
     </div>
     <div class="social-links">
       <a href="https://github.com/mozilla/send" target="_blank" rel="noreferrer noopener"><img class="github" src="/resources/github-icon.svg"/></a>