make hiding the UI a bit better but not quite there yet.

2010-09-30 17:50:03 -07:00 · 2010-09-30 17:50:03 -07:00 · 3b95420339
--- a/tasks.txt
+++ b/tasks.txt
@ -28,6 +28,8 @@ Tasks:
 * Do a build, preseed the UI so it is fast on first click. And just snap down the       - James
  UI right away instead of waiting for load? Then in that case skip the animation.

+* Move auth.html, remove tab transition animation on first set - James
+
 * Instructions: want honest feedback on if they would recommend. - Andy

 * Above the fold work on the home page. -Andy
--- a/web/share/index.html
+++ b/web/share/index.html
@ -7,9 +7,9 @@
  <script src="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8/jquery-ui.min.js"></script>
  <script>require(["index.js"]);</script>
 </head>
-<body class="invisible">
+<body>

-<div id="tabs">
+<div id="tabs" class="invisible">

  <ul class="nav">
    <li class="twitterTab leftTab hidden"><a class="icon twitter" href="#twitter"></a></li>
--- a/web/share/index.js
+++ b/web/share/index.js
@ -323,6 +323,13 @@ function (require,   $,    fn,     rdapi,   oauth,   jig,     url,
        selection = '#settings';
      }
      tabDom.tabs('select', selection);
+      //Make the body visible now to the user, now that tabs have been set up.
+      //TODO: on first run, just need the tab selection to go without the
+      //jQuery animation transition, then this setTimeout can be removed.
+      setTimeout(function () {
+        tabDom.removeClass('invisible');
+      }, 100);
+
  
      //TODO: HACK, clean this up later.
      updateUserTab(null, {panel: $(selection)[0]});
@ -569,9 +576,6 @@ function (require,   $,    fn,     rdapi,   oauth,   jig,     url,
      });
    });

-    //Make the body visible now to the user, now that tabs have been set up.
-    bodyDom.removeClass('invisible');
-
    //In settings, hook up remove buttons to remove an account
    bodyDom.delegate('.accountRemove', 'click', function (evt) {
      var buttonNode = evt.target,
--- a/web/share/share.css
+++ b/web/share/share.css
@ -49,7 +49,8 @@ ul.nav li.hidden {
  display: none;
 }

-.invisible {
+.invisible,
+body #tabs.invisible {
    visibility: hidden;
 }