fix busy state when collections tree unavailable (list view closed).

content/collections.js

@@ -217,10 +217,7 @@ let CollectionsView = {
   },
 
   onMessagesCompleted: function(aSourceId) {
-    // Source refresh completed, reset busy property.
-    if (SnowlService.sourcesByID[aSourceId])
-      SnowlService.sourcesByID[aSourceId].busy = false;
-      
+    // Source refresh completed, refresh tree.
     this._tree.treeBoxObject.invalidate();
   },
 

modules/service.js

@@ -298,10 +298,10 @@ let SnowlService = {
     }
 
     if (allSources.length > 0) {
-      // Don't set busy on 'all' until we know when the last one is done so it
-      // can be unset.
+      // TODO: Don't set busy on 'all' until we know when the last one is done
+      // so it can be unset.
 //      this._collectionStatsByCollectionID["all"].busy = true;
-      Observers.notify("snowl:messages:completed", "refresh");
+//      Observers.notify("snowl:messages:completed", "refresh");
     }
 
     // We specify the same refresh time when refreshing sources so that all

modules/source.js

@@ -454,6 +454,7 @@ this._log.info("persist placeID:sources.id - " + this.placeID + " : " + this.id)
           SnowlService._collectionStatsByCollectionID = null;
 
         // Notify collections view on completion of refresh.
+        SnowlService.sourcesByID[this.id].busy = false;
         Observers.notify("snowl:messages:completed", this.id);
       }