Bug 1227682 - Enable the ESLint no-extra-semi rule & fix infringements

Disallows unnecessary semicolons
http://eslint.org/docs/rules/no-extra-semi

.eslintrc

@@ -9,7 +9,6 @@
         // Remove a line to enable the rule.
         "comma-dangle": 0,
         "no-console": 0,
-        "no-extra-semi": 0,
         "no-redeclare": 0,
         "no-undef": 0,
         "no-unused-vars": 0,

ui/js/controllers/perf/graphs.js

@@ -580,7 +580,7 @@ perf.controller('GraphsCtrl', [
                              // a hint on what the problem is
                              alert("Error loading performance data\n\n" + error);
                          });
-        };
+        }
 
         $scope.removeSeries = function(projectName, signature) {
             var newSeriesList = [];

ui/js/models/repository.js

@@ -106,7 +106,7 @@ treeherder.factory('ThRepositoryModel', [
                             } else {
                                 this.pushlogURL = this.url + "/pushloghtml";
                             }
-                        };
+                        }
                         Repo.prototype = {
                             getRevisionHref: function(revision) {
                                 if (this.dvcs_type == 'git') {

ui/js/models/resultsets_store.js

@@ -284,7 +284,7 @@ treeherder.factory('ThResultSetStore', [
 
                 if (jobList.length === 0) {
                     thNotify.send("No new jobs available");
-                };
+                }
 
                 mapResultSetJobs(repoName, jobList);
             });

ui/js/perf.js

@@ -16,7 +16,7 @@ treeherder.factory('PhSeries', ['$http', 'thServiceDomain', function($http, thSe
         return signatureProps.suite + " " + testName;
     };
 
-    function _getSeriesOptions(signatureProps, optionCollectionMap) {
+    var _getSeriesOptions = function(signatureProps, optionCollectionMap) {
         var options = [ optionCollectionMap[signatureProps.option_collection_hash] ];
         if (signatureProps.test_options) {
             options = options.concat(signatureProps.test_options);