Bug 1318295 - Vagrant: Move yarn install to shell provisioner

puppet/manifests/classes/nodejs.pp

@@ -1,11 +0,0 @@
-class nodejs {
-
-  exec{"yarn-install":
-    cwd => "${PROJ_DIR}",
-    user => "${APP_USER}",
-    # We have to use `--no-bin-links` to work around symlink issues with Windows hosts.
-    # TODO: Switch the flag to a global yarn pref once yarn adds support.
-    command => "yarn install --no-bin-links",
-  }
-
-}

puppet/manifests/vagrant.pp

@@ -18,7 +18,6 @@ file {"/etc/profile.d/treeherder.sh":
 
 class vagrant {
     class {
-        nodejs: before => Class["treeherder"];
         treeherder: before => Class["dev"];
         dev:;
     }

vagrant/setup.sh

@@ -95,6 +95,11 @@ fi
 echo '-----> Running pip install'
 pip install --require-hashes -r requirements/common.txt -r requirements/dev.txt | sed -e '/^Requirement already satisfied:/d'
 
+echo '-----> Running yarn install'
+# We have to use `--no-bin-links` to work around symlink issues with Windows hosts.
+# TODO: Switch the flag to a global yarn pref once yarn adds support.
+yarn install --no-bin-links
+
 echo '-----> Initialising MySQL database'
 # The default `root@localhost` grant only allows loopback interface connections.
 mysql -u root -e 'GRANT ALL PRIVILEGES ON *.* to root@"%"'