Bug 1164898 - Warn when more retriggers needed to be confident in comparison

ui/js/directives/perf/compare.js

@@ -20,8 +20,7 @@ treeherder.directive(
     return {
       templateUrl: 'partials/perf/compareconfidence.html',
       scope: {
-          text: '@',
-          value: '@'
+          result: '='
       }
     }
   });

ui/partials/perf/compareconfidence.html

@@ -1,3 +1,8 @@
-<span ng-if="text && value">
-  {{value|displayPrecision}} (<abbr title="Result of running t-test on base versus new result distribution: higher values indicate greater confidence that the indicated performance difference is statistically meaningful">{{text}}</abbr>)
+<span ng-if="result.confidenceText && result.confidence">
+  {{result.confidence|displayPrecision}} (<abbr title="Result of running t-test on base versus new result distribution: higher values indicate greater confidence that the indicated performance difference is statistically meaningful">{{result.confidenceText}}</abbr>)
+  </span><span ng-if="result.originalRuns.length < 5 || result.newRuns.length < 5"
+        class="glyphicon glyphicon-warning-sign text-warning"
+        tooltip="5 Base / New runs recommended for increased confidence in comparison"
+        tooltip-placement="left"
+        style="cursor:default">
 </span>

ui/partials/perf/comparectrl.html

@@ -41,8 +41,7 @@
             <td ng-if="compareResult.delta" width="20%"><div ng-class="getCompareClasses(compareResult, 'bar')" style="margin-{{compareResult.marginDirection}}: {{compareResult.barGraphMargin}}%;"></div></td>
             <td ng-if="!compareResult.delta"></td>
             <td>
-              <ph-confidence value="{{compareResult.confidence}}"
-                             text="{{compareResult.confidenceText}}"/>
+              <ph-confidence result="compareResult"/>
             </td>
           </tr>
         </tbody>

ui/partials/perf/comparesubtestctrl.html

@@ -40,8 +40,7 @@
           <td ng-if="compareResult.delta" width="20%"><div ng-class="getCompareClasses(compareResult, 'bar')" style="margin-{{compareResult.marginDirection}}: {{compareResult.barGraphMargin}}%;"></div></td>
           <td ng-if="!compareResult.delta"></td>
           <td>
-            <ph-confidence value="{{compareResult.confidence|displayPrecision}}"
-                           text="{{compareResult.confidenceText}}"/>
+            <ph-confidence result="compareResult"/>
           </td>
         </tr>
       </tbody>