From 163a94a2f64c0dcc0b2c0813a6b2e4390454835a Mon Sep 17 00:00:00 2001
From: Ed Morley <501702+edmorley@users.noreply.github.com>
Date: Wed, 4 Apr 2018 20:34:26 +0100
Subject: [PATCH] Bug 1451428 - Remove unused settings panel (#3395)

Since it's hidden and has never been used.

The `thSettingsPanel.html` partial is a leftover from when this
feature was first added in 3e625f3 / 6b0c56e.
---
 ui/css/treeherder-navbar-panels.css       | 13 -------------
 ui/entry-index.js                         |  1 -
 ui/js/controllers/main.js                 |  6 ------
 ui/js/controllers/settings.js             |  6 ------
 ui/partials/main/thGlobalTopNavPanel.html | 13 -------------
 ui/partials/main/thSettingsPanel.html     |  3 ---
 6 files changed, 42 deletions(-)
 delete mode 100644 ui/js/controllers/settings.js
 delete mode 100644 ui/partials/main/thSettingsPanel.html

diff --git a/ui/css/treeherder-navbar-panels.css b/ui/css/treeherder-navbar-panels.css
index 5aef919b0..d3b5a4987 100644
--- a/ui/css/treeherder-navbar-panels.css
+++ b/ui/css/treeherder-navbar-panels.css
@@ -1,16 +1,3 @@
-/*
- * Shared navbar panel settings
- */
-
-.th-top-nav-options-panel {
-    background-color: white;
-    padding: 10px 10px 0;
-    border-bottom: 1px solid black;
-    max-height: 400px;
-    overflow-y: auto;
-    font-size: 12px;
-}
-
 /*
  * Update notification panel
  */
diff --git a/ui/entry-index.js b/ui/entry-index.js
index e145277e9..703d16c4d 100644
--- a/ui/entry-index.js
+++ b/ui/entry-index.js
@@ -61,7 +61,6 @@ import './js/models/bug_suggestions';
 import './js/models/text_log_step';
 import './js/models/perf/series';
 import './js/controllers/main';
-import './js/controllers/settings';
 import './js/controllers/repository';
 import './js/controllers/notification';
 import './js/controllers/filters';
diff --git a/ui/js/controllers/main.js b/ui/js/controllers/main.js
index 6a06e68bf..317a19677 100644
--- a/ui/js/controllers/main.js
+++ b/ui/js/controllers/main.js
@@ -402,7 +402,6 @@ treeherderApp.controller('MainCtrl', [
 
             // Shortcut: escape closes any open panels and clears selected job
             ['escape', function () {
-                $scope.$evalAsync($scope.setSettingsPanelShowing(false));
                 $scope.$evalAsync($scope.closeJob());
                 $scope.$evalAsync($scope.setOnscreenShortcutsShowing(false));
             }],
@@ -695,11 +694,6 @@ treeherderApp.controller('MainCtrl', [
             $scope.onscreenOverlayShowing = tf;
         };
 
-        $scope.isSettingsPanelShowing = false;
-        $scope.setSettingsPanelShowing = function (tf) {
-            $scope.isSettingsPanelShowing = tf;
-        };
-
         $scope.pinboardCount = thPinboard.count;
         $scope.pinnedJobs = thPinboard.pinnedJobs;
         $scope.jobFilters = thJobFilters;
diff --git a/ui/js/controllers/settings.js b/ui/js/controllers/settings.js
deleted file mode 100644
index c7c2c4754..000000000
--- a/ui/js/controllers/settings.js
+++ /dev/null
@@ -1,6 +0,0 @@
-import treeherderApp from '../treeherder_app';
-
-treeherderApp.controller('SettingsCtrl',
-    function SheriffController() {
-    }
-);
diff --git a/ui/partials/main/thGlobalTopNavPanel.html b/ui/partials/main/thGlobalTopNavPanel.html
index 8157c816b..1a0d2bc18 100644
--- a/ui/partials/main/thGlobalTopNavPanel.html
+++ b/ui/partials/main/thGlobalTopNavPanel.html
@@ -174,19 +174,6 @@
         </ul>
       </span>
 
-      <!-- Settings Button - currently suppressed -->
-      <span ng-show="false"
-            class="btn btn-view-nav btn-right-navbar nav-menu-btn"
-            ng-class="{'active': (isSettingsPanelShowing)}"
-            ng-click="setSettingsPanelShowing(!isSettingsPanelShowing)"
-            tabindex="0"
-            role="button"><span>Settings</span>
-        <i class="fa fa-angle-down lightgray"
-           ng-hide="isSettingsPanelShowing"></i>
-        <i class="fa fa-angle-up lightgray"
-           ng-show="isSettingsPanelShowing"></i>
-      </span>
-
       <!-- Login/Register Button -->
       <login on-user-change="$root.user = $event.user"></login>
     </span>
diff --git a/ui/partials/main/thSettingsPanel.html b/ui/partials/main/thSettingsPanel.html
deleted file mode 100644
index bf31dd0c1..000000000
--- a/ui/partials/main/thSettingsPanel.html
+++ /dev/null
@@ -1,3 +0,0 @@
-<div class="th-top-nav-options-panel" id="settings_panel" ng-controller="SettingsCtrl">
-  <span>{{user}}</span>
-</div>