Bug 1414255 - Fix shellcheck warnings about missing quotes

`SC2086: Double quote to prevent globbing and word splitting`

See:
https://github.com/koalaman/shellcheck/wiki/SC2086

bin/post_compile

@@ -5,7 +5,7 @@
 set -euo pipefail
 
 # Make the current Git revision accessible at <site-root>/revision.txt
-echo $SOURCE_VERSION > ui/revision.txt
+echo "$SOURCE_VERSION" > ui/revision.txt
 
 # Create a `dist/` directory containing built/minified versions of the `ui/` assets.
 # Uses the node binaries/packages installed by the nodejs buildpack previously.

bin/run_celery_worker

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_celery_worker_buildapi

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_celery_worker_hp

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_celery_worker_log_parser

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_celery_worker_pushlog

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_celerybeat

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_gunicorn

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_read_pulse_jobs

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

bin/run_read_pulse_pushes

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SRC_DIR=$(dirname "$(dirname "${BASH_SOURCE[0]}")")
-cd $SRC_DIR
+cd "$SRC_DIR"
 
 source /etc/profile.d/treeherder.sh
 

vagrant/setup.sh

@@ -83,7 +83,7 @@ if ! cmp -s vagrant/mysql.cnf /etc/mysql/conf.d/treeherder.cnf; then
     sudo systemctl restart mysql.service
 fi
 
-if [[ "$($PYTHON_DIR/bin/python --version 2>&1)" != *"$PYTHON_VERSION" ]]; then
+if [[ "$("${PYTHON_DIR}/bin/python" --version 2>&1)" != *"$PYTHON_VERSION" ]]; then
     echo "-----> Installing Python"
     rm -rf "$PYTHON_DIR"
     mkdir -p "$PYTHON_DIR"
@@ -91,7 +91,7 @@ if [[ "$($PYTHON_DIR/bin/python --version 2>&1)" != *"$PYTHON_VERSION" ]]; then
     curl -sSf "https://lang-python.s3.amazonaws.com/heroku-16/runtimes/python-$PYTHON_VERSION.tar.gz" | tar -xz -C "$PYTHON_DIR"
 fi
 
-if [[ "$($PYTHON_DIR/bin/pip --version 2>&1)" != *"$PIP_VERSION"* ]]; then
+if [[ "$("${PYTHON_DIR}/bin/pip" --version 2>&1)" != *"$PIP_VERSION"* ]]; then
     echo "-----> Installing pip"
     curl -sSf https://bootstrap.pypa.io/get-pip.py | python - "pip==$PIP_VERSION"
 fi