From 37d1d3cd72befc38bd7fbe46ec1cb8ea78b167b4 Mon Sep 17 00:00:00 2001 From: Ehsan Akhgari Date: Thu, 8 Apr 2010 19:33:10 -0400 Subject: [PATCH] Bug 557934 - Follow-up: Direction shouldn't change its meaning; r=catlee --HG-- branch : 1.0 --- treeherder/perfalert/perfalert/analyze_talos.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/treeherder/perfalert/perfalert/analyze_talos.py b/treeherder/perfalert/perfalert/analyze_talos.py index 48483a5db..f7038473d 100644 --- a/treeherder/perfalert/perfalert/analyze_talos.py +++ b/treeherder/perfalert/perfalert/analyze_talos.py @@ -277,18 +277,18 @@ class AnalysisRunner: good_build_time = datetime.fromtimestamp(good.timestamp).strftime("%Y-%m-%d %H:%M:%S") if self.isTestReversed(test_name): if new_value > initial_value: - direction = "decrease" reason = "Improvement" else: - direction = "increase" reason = "Regression" else: if new_value > initial_value: - direction = "increase" reason = "Regression" else: - direction = "decrease" reason = "Improvement" + if new_value > initial_value: + direction = "increase" + else: + direction = "decrease" chart_url = self.shorten(self.makeChartUrl(series, bad)) if good.revision: @@ -374,18 +374,18 @@ class AnalysisRunner: good_build_time = datetime.fromtimestamp(good.timestamp).strftime("%Y-%m-%d %H:%M:%S") if self.isTestReversed(test_name): if new_value > initial_value: - direction = "decrease" reason = "Improvement" else: - direction = "increase" reason = "Regression" else: if new_value > initial_value: - direction = "increase" reason = "Regression" else: - direction = "decrease" reason = "Improvement" + if new_value > initial_value: + direction = "increase" + else: + direction = "decrease" if state == "machine": bad_machine_name = self.source.getMachineName(bad.machine_id) good_machine_name = self.source.getMachineName(good.machine_id)