Bug 1370229 - Make mock_log_parser mock store_failure_lines too

Since otherwise tests that ingest jobs that have structured error
summary logs will hit the network, causing non-deterministic test
failures, such as the failures in `test_ingest_pulse_jobs` currently
being seen on Travis (since the log in question no longer exists on
S3).

tests/conftest.py

@@ -151,9 +151,9 @@ def mock_log_parser(monkeypatch):
     def task_mock(*args, **kwargs):
         pass
 
-    monkeypatch.setattr(tasks,
-                        'parse_log',
-                        task_mock)
+    monkeypatch.setattr(tasks, 'parse_log', task_mock)
+    monkeypatch.setattr(tasks, 'store_failure_lines', task_mock)
+    monkeypatch.setattr(tasks, 'crossreference_error_lines', task_mock)
 
 
 @pytest.fixture

tests/etl/test_job_loader.py

@@ -74,9 +74,7 @@ def test_ingest_pulse_jobs(pulse_jobs, test_repository, result_set_stored,
                       "parse_status": 0},
                      {"name": "errorsummary_json",
                       "url": "http://mozilla-releng-blobs.s3.amazonaws.com/blobs/Mozilla-Inbound-Non-PGO/sha512/05c7f57df6583c6351c6b49e439e2678e0f43c2e5b66695ea7d096a7519e1805f441448b5ffd4cc3b80b8b2c74b244288fda644f55ed0e226ef4e25ba02ca466",
-                      # Note that the test causes store_failure_lines to be
-                      # run, which sets this to parsed.
-                      "parse_status": 1}]
+                      "parse_status": 0}]
     assert [{"name": item.name, "url": item.url, "parse_status": item.status}
             for item in job_logs.all()] == logs_expected