Bug 1187000 - Always show e10s data in compare view

We can add some kind of a filtering interface later, but until that's
ready it's confusing to just not display it unless people specify
a magic flag (e10s=1).
This commit is contained in:
William Lachance 2015-10-16 13:10:48 -04:00
Родитель 2b2b2a5a58
Коммит 626678ab83
3 изменённых файлов: 5 добавлений и 10 удалений

Просмотреть файл

@ -113,8 +113,7 @@ perf.controller('CompareResultsCtrl', [
$scope.originalProject.name,
timeRange,
optionCollectionMap,
{e10s: $scope.e10s,
excludedPlatforms: $scope.excludedPlatforms }).then(
{ excludedPlatforms: $scope.excludedPlatforms }).then(
function(originalSeriesData) {
$scope.platformList = originalSeriesData.platformList;
$scope.testList = originalSeriesData.testList;
@ -137,7 +136,7 @@ perf.controller('CompareResultsCtrl', [
$scope.newProject.name,
timeRange,
optionCollectionMap,
{e10s: $scope.e10s}).then(
{ excludedPlatforms: $scope.excludedPlatforms }).then(
function(newSeriesData) {
$scope.platformList = _.union($scope.platformList,
newSeriesData.platformList).sort();
@ -239,7 +238,6 @@ perf.controller('CompareResultsCtrl', [
return;
}
$scope.e10s = Boolean($stateParams.e10s);
// we are excluding macosx 10.10 by default for now, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1201615
$scope.excludedPlatforms = Boolean($stateParams.showExcludedPlatforms) ?
[] : [ 'osx-10-10' ];

Просмотреть файл

@ -169,11 +169,8 @@ perf.factory('PhSeries', ['$http', 'thServiceDomain', function($http, thServiceD
return _getAllSeries(projectName, timeRange, optionMap).then(function(lists) {
lists.seriesList.forEach(function(seriesSummary) {
// Only keep summary signatures, filter in/out e10s
if (!seriesSummary.subtestSignatures ||
(userOptions.e10s && !_.contains(seriesSummary.options, 'e10s')) ||
(!userOptions.e10s && _.contains(seriesSummary.options, 'e10s'))) {
if (!seriesSummary.subtestSignatures) {
// Only keep summary signatures for now
return;
} else {
// We don't generate number for tp5n, this is xperf and we collect counters

Просмотреть файл

@ -12,7 +12,7 @@ perf.config(function($compileProvider, $stateProvider, $urlRouterProvider) {
controller: 'GraphsCtrl'
}).state('compare', {
templateUrl: 'partials/perf/comparectrl.html',
url: '/compare?originalProject&originalRevision&newProject&newRevision&hideMinorChanges&e10s&showExcludedPlatforms',
url: '/compare?originalProject&originalRevision&newProject&newRevision&hideMinorChanges&showExcludedPlatforms',
controller: 'CompareResultsCtrl'
}).state('comparesubtest', {
templateUrl: 'partials/perf/comparesubtestctrl.html',