Bug 1441617 - Always import angular explicitly

...rather than relying on `window.angular`.

And also switch to ES6 imports.

neutrino-custom/base.js

@@ -240,7 +240,6 @@ module.exports = neutrino => {
             return options;
         });
 
-    // Now provide a few globals (providing angular here does not seem to work, though)
     neutrino.config
         .plugin('provide')
         .use(webpack.ProvidePlugin, {

neutrino-custom/lint.js

@@ -82,7 +82,6 @@ module.exports = neutrino => {
                 globals: [
                     '$',
                     '_',
-                    'angular',
                     'jQuery',
                     'Mousetrap',
                     'React',

tests/ui/unit/init.js

@@ -1,14 +1,16 @@
 // Karma/webpack entry for tests
 
+// Manually import angular since angular-mocks doesn't do so itself
+import 'angular';
+import 'angular-mocks';
+
 // Global variables are set here instead of with webpack.ProvidePlugin
 // because neutrino removes plugin definitions for karma runs
 window.$ = require('jquery');
 window.jQuery = require('jquery');
 window._ = require('lodash');
-window.angular = require('angular');
 window.React = require('react');
 require('jasmine-jquery');
-require('angular-mocks');
 require('mousetrap');
 
 const Adapter = require('enzyme-adapter-react-16');

ui/entry-index.js

@@ -16,7 +16,6 @@ require('./css/treeherder-bugfiler.css');
 require('./css/treeherder-loading-overlay.css');
 
 // Vendor JS
-require('angular');
 require('bootstrap/dist/js/bootstrap');
 require('mousetrap');
 require('jquery.scrollto');

ui/entry-logviewer.js

@@ -8,7 +8,6 @@ require('./css/treeherder-global.css');
 require('./css/logviewer.css');
 
 // Vendor JS
-require('angular');
 require('bootstrap/dist/js/bootstrap');
 
 // Bootstrap the Angular modules against which everything will be registered

ui/entry-perf.js

@@ -11,7 +11,6 @@ require('./css/treeherder-loading-overlay.css');
 require('metrics-graphics/dist/metricsgraphics.css');
 
 // Vendor JS
-require('angular');
 require('mousetrap');
 require('bootstrap/dist/js/bootstrap');
 // The official 'flot' NPM package is out of date, so we're using 'jquery.flot'

ui/js/controllers/perf/graphs.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import perf from '../../perf';
 
 perf.controller('GraphsCtrl', [

ui/js/filters.js

@@ -1,3 +1,4 @@
+import angular from 'angular';
 import numeral from 'numeral';
 
 import treeherder from './treeherder';

ui/js/logviewer.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherderModule from './treeherder';
 
 const logViewerApp = angular.module('logviewer', [treeherderModule.name]);

ui/js/models/bug_job_map.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThBugJobMapModel', [

ui/js/models/build_platform.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThBuildPlatformModel', [

ui/js/models/classification.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThJobClassificationModel', [

ui/js/models/failure_lines.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThFailureLinesModel', [

ui/js/models/job.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThJobModel', [

ui/js/models/job_group.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThJobGroupModel', [

ui/js/models/job_log_url.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThJobLogUrlModel', [

ui/js/models/job_type.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThJobTypeModel', [

ui/js/models/matcher.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThMatcherModel', [

ui/js/models/resultset.js

@@ -1,3 +1,4 @@
+import angular from 'angular';
 import jsyaml from 'js-yaml';
 import { Queue, slugid } from 'taskcluster-client-web';
 

ui/js/models/runnable_job.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThRunnableJobModel', [

ui/js/models/text_log_errors.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThTextLogErrorsModel', [

ui/js/models/user.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../treeherder';
 
 treeherder.factory('ThUserModel', [

ui/js/perf.js

@@ -1,3 +1,4 @@
+import angular from 'angular';
 import angularClipboardModule from 'angular-clipboard';
 import uiBootstrap from 'angular1-ui-bootstrap4';
 import uiRouter from 'angular-ui-router';

ui/js/treeherder.js

@@ -1,3 +1,4 @@
+import angular from 'angular';
 import ngResource from 'angular-resource';
 import ngSanitize from 'angular-sanitize';
 import LocalStorageModule from 'angular-local-storage';

ui/js/treeherder_app.js

@@ -1,3 +1,4 @@
+import angular from 'angular';
 import angularToArrayfilter from 'angular-toarrayfilter';
 import hcMarked from 'angular-marked';
 import ngReactModule from 'ngreact';

ui/js/userguide.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 const userguideApp = angular.module('userguide', []);
 
 userguideApp.config(['$compileProvider', function ($compileProvider) {

ui/plugins/failure_summary/controller.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../../js/treeherder';
 
 treeherder.controller('BugsPluginCtrl', [

ui/plugins/similar_jobs/controller.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../../js/treeherder';
 import { getBtnClass, getStatus } from "../../helpers/jobHelper";
 

ui/plugins/tabs.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 import treeherder from '../js/treeherder';
 
 treeherder.factory('thTabs', [

ui/vendor/resizer.js

@@ -1,3 +1,5 @@
+import angular from 'angular';
+
 /* From: http://stackoverflow.com/a/22253161/295132 (author: Mario Campa) */
 angular.module('mc.resizer', []).directive('resizer', ['$document', function($document) {
     return function($scope, $element, $attrs) {