Fixes Bug 1537890 - formats numbers in tooltips (#5551)

This commit is contained in:
Viktor Stojanov 2019-10-25 19:57:10 +02:00 коммит произвёл Sarah Clements
Родитель 3bb49ae223
Коммит 87ad902dcc
2 изменённых файлов: 7 добавлений и 5 удалений

Просмотреть файл

@ -12,7 +12,7 @@ import {
} from '@fortawesome/free-solid-svg-icons';
import SimpleTooltip from '../../shared/SimpleTooltip';
import { displayNumber } from '../helpers';
import { displayNumber, formatNumber } from '../helpers';
import { compareTableText } from '../constants';
import ProgressBar from '../ProgressBar';
import { hashFunction } from '../../helpers/utils';
@ -32,7 +32,7 @@ export default class CompareTable extends React.PureComponent {
};
deltaTooltipText = (delta, percentage, improvement) =>
`Mean difference: ${displayNumber(delta)} (= ${Math.abs(
`Mean difference: ${formatNumber(displayNumber(delta))} (= ${Math.abs(
displayNumber(percentage),
)}% ${improvement ? 'better' : 'worse'})`;

Просмотреть файл

@ -9,9 +9,11 @@ import TooltipGraph from './TooltipGraph';
const TableAverage = ({ value, stddev, stddevpct, replicates }) => {
let tooltipText;
if (replicates.length > 1) {
tooltipText = `Runs: < ${replicates.join(' ')} > ${formatNumber(
displayNumber(stddev),
)} = ${formatNumber(displayNumber(stddevpct))}% standard deviation)`;
tooltipText = `Runs: < ${replicates
.map(value => formatNumber(value))
.join(' ')} > ${formatNumber(displayNumber(stddev))} = ${formatNumber(
displayNumber(stddevpct),
)}% standard deviation)`;
} else if (replicates.length === 1) {
tooltipText = 'Only one run (consider more for greater confidence)';
}