Upgrade to Neutrino 9 RC4 (#5454)

* Upgrade to Neutrino 9 RC4
* yarn-deduplicate

package.json

@@ -19,9 +19,8 @@
     "@fortawesome/free-regular-svg-icons": "5.11.2",
     "@fortawesome/free-solid-svg-icons": "5.11.2",
     "@fortawesome/react-fontawesome": "0.1.5",
-    "@neutrinojs/copy": "9.0.0-rc.3",
-    "@neutrinojs/react": "9.0.0-rc.3",
-    "@testing-library/react": "9.3.0",
+    "@neutrinojs/copy": "9.0.0-rc.4",
+    "@neutrinojs/react": "9.0.0-rc.4",
     "@types/prop-types": "*",
     "@types/react": "*",
     "@types/react-dom": "*",
@@ -40,7 +39,7 @@
     "metrics-graphics": "2.15.6",
     "moment": "2.24.0",
     "mousetrap": "1.6.3",
-    "neutrino": "9.0.0-rc.3",
+    "neutrino": "9.0.0-rc.4",
     "ng-text-truncate-2": "1.0.1",
     "numeral": "2.0.6",
     "prop-types": "15.7.2",
@@ -71,8 +70,8 @@
     "webpack-cli": "3.3.9"
   },
   "devDependencies": {
-    "@neutrinojs/eslint": "9.0.0-rc.3",
-    "@neutrinojs/jest": "9.0.0-rc.3",
+    "@neutrinojs/eslint": "9.0.0-rc.4",
+    "@neutrinojs/jest": "9.0.0-rc.4",
     "@testing-library/jest-dom": "4.1.0",
     "@testing-library/react": "9.3.0",
     "codecov": "3.6.1",

tests/ui/perfherder/replicates_graph_test.jsx

@@ -221,7 +221,6 @@ test('graph with available data displays properly', async () => {
     expectedIndexes.map(index => getByText(index.toString())),
   );
 
-  // eslint-disable-next-line no-unused-vars
   for (const replicateIndex of xAxisReplicateIndexes) {
     expect(replicateIndex).toBeInTheDocument();
   }

ui/helpers/object.js

@@ -1,7 +1,6 @@
 export const extendProperties = function extendProperties(dest, src) {
   /* Version of _.extend that works with property descriptors */
   if (dest !== src) {
-    // eslint-disable-next-line no-unused-vars
     for (const key in src) {
       if (!Object.prototype.hasOwnProperty.call(src, key)) {
         continue;

ui/helpers/revision.js

@@ -15,7 +15,6 @@ export const isSHAorCommit = function isSHAorCommit(str) {
 
 export const getRevisionTitle = function getRevisionTitle(revisions) {
   let title;
-  // eslint-disable-next-line no-unused-vars
   for (const revision of revisions) {
     title = revision.comments;
     /*

ui/intermittent-failures/View.jsx

@@ -132,7 +132,6 @@ const withView = defaultState => WrappedComponent => {
         max += 800;
       }
 
-      // eslint-disable-next-line no-unused-vars
       for (const result of await Promise.all(results)) {
         bugsList = [...bugsList, ...result.data.bugs];
       }

ui/job-view/redux/stores/pushes.js

@@ -160,7 +160,6 @@ const fetchNewJobs = () => {
         dispatch(setSelectedJob(updatedSelectedJob));
       }
     } else {
-      // eslint-disable-next-line no-unused-vars
       for (const error of errors) {
         notify(error, 'danger', { sticky: true });
       }

ui/models/job.js

@@ -100,7 +100,6 @@ export default class JobModel {
         (await PushModel.getDecisionTaskMap(pushIds, notify));
       const uniquePerPushJobs = groupBy(jobs, job => job.push_id);
 
-      // eslint-disable-next-line no-unused-vars
       for (const [key, value] of Object.entries(uniquePerPushJobs)) {
         const decisionTaskId = taskIdMap[key].id;
 
@@ -205,7 +204,6 @@ export default class JobModel {
       );
 
       /* eslint-disable no-await-in-loop */
-      // eslint-disable-next-line no-unused-vars
       for (const job of jobs) {
         const decisionTaskId = taskIdMap[job.push_id].id;
         const results = await TaskclusterModel.load(

ui/perfherder/Validation.jsx

@@ -124,7 +124,6 @@ const withValidation = (
       const { projects, frameworks } = this.props;
       let errors = [];
 
-      // eslint-disable-next-line no-unused-vars
       for (const [param, value] of Object.entries(params)) {
         if (!value && requiredParams.has(param)) {
           errors.push(`${param} is required`);

ui/perfherder/compare/CompareTableControls.jsx

@@ -91,7 +91,6 @@ export default class CompareTableControls extends React.Component {
 
     const filteredResults = new Map(compareResults);
 
-    // eslint-disable-next-line no-unused-vars
     for (const [testName, values] of filteredResults) {
       const filteredValues = values.filter(result =>
         this.filterResult(testName, result),