From a5e8646b60d572a66ca557ed79c5c77152c2fd06 Mon Sep 17 00:00:00 2001 From: mdoglio Date: Mon, 16 Dec 2013 09:32:56 +0000 Subject: [PATCH] remove unuseful comments --- .../closed_bugs_suggestions/controller.js | 2 -- ui/plugins/controller.js | 7 +------ ui/plugins/open_bugs_suggestions/controller.js | 2 -- ui/plugins/pluginpanel.html | 17 ----------------- 4 files changed, 1 insertion(+), 27 deletions(-) diff --git a/ui/plugins/closed_bugs_suggestions/controller.js b/ui/plugins/closed_bugs_suggestions/controller.js index bdabc8a01..09395cf52 100644 --- a/ui/plugins/closed_bugs_suggestions/controller.js +++ b/ui/plugins/closed_bugs_suggestions/controller.js @@ -4,8 +4,6 @@ treeherder.controller('ClosedBugsPluginCtrl', function ClosedBugsPluginCtrl($scope, $rootScope, $log) { $log.log("closed bugs plugin initialized"); - // camd: I don't see ``$scope.jobArtifacts`` being set anywhere, so this - // watch may never get triggered. $scope.$watch('artifacts', function(newValue, oldValue){ $scope.closed_bugs = []; $scope.bugs_count= 0; diff --git a/ui/plugins/controller.js b/ui/plugins/controller.js index 38cea289f..7841856e2 100644 --- a/ui/plugins/controller.js +++ b/ui/plugins/controller.js @@ -25,12 +25,7 @@ treeherder.controller('PluginCtrl', "Build Arch": $scope.job.build_architecture || undef, "Build OS": $scope.job.build_os || undef }; - /*this call retrieves (again) a job detail. can we avoid it? - * - * camd: this has different job detail info than we get with the resultsets. - * specifically artifact info and log info. I considered it too heavy weight to - * get this for each job inthe resultset, since we would only want it for hte few - * jobs we view in this panel. */ + $http.get(thServiceDomain + $scope.job.resource_uri). success(function(data) { $scope.logs = data.logs; diff --git a/ui/plugins/open_bugs_suggestions/controller.js b/ui/plugins/open_bugs_suggestions/controller.js index 2cd1e8975..0fff4fd74 100644 --- a/ui/plugins/open_bugs_suggestions/controller.js +++ b/ui/plugins/open_bugs_suggestions/controller.js @@ -4,8 +4,6 @@ treeherder.controller('OpenBugsPluginCtrl', function OpenBugsPluginCtrl($scope, $log) { $log.log("open bugs plugin initialized"); - // camd: I don't see ``$scope.jobArtifacts`` being set anywhere, so this - // watch may never get triggered. $scope.$watch('artifacts', function(newValue, oldValue){ $scope.open_bugs = []; $scope.bugs_count= 0; diff --git a/ui/plugins/pluginpanel.html b/ui/plugins/pluginpanel.html index 43a4e140a..6edc07d80 100644 --- a/ui/plugins/pluginpanel.html +++ b/ui/plugins/pluginpanel.html @@ -1,5 +1,4 @@
-
@@ -10,7 +9,6 @@ {{ job.machine_name }} - {{label}}{{ value | limitTo:12 }} @@ -27,22 +25,10 @@
-
- - - - - - - - - - - {{ tab.title }} {{tab.num_items}} @@ -56,16 +42,13 @@ - - -