Bug 1485090 - Cleanup props for default user object prior to load

ui/job-view/JobView.jsx

@@ -41,7 +41,7 @@ class JobView extends React.Component {
 
     this.state = {
       repoName: getUrlParam('repo'),
-      user: { isLoggedIn: false },
+      user: { isLoggedIn: false, isStaff: false },
       isFieldFilterVisible: false,
       filterBarFilters: [
        ...this.thJobFilters.getNonFieldFiltersArray(),

ui/job-view/Push.jsx

@@ -167,11 +167,6 @@ Push.propTypes = {
   currentRepo: PropTypes.object.isRequired,
   $injector: PropTypes.object.isRequired,
   repoName: PropTypes.string.isRequired,
-  isLoggedIn: PropTypes.bool,
-  isStaff: PropTypes.bool,
-};
-
-Push.defaultProps = {
-  isLoggedIn: false,
-  isStaff: false,
+  isLoggedIn: PropTypes.bool.isRequired,
+  isStaff: PropTypes.bool.isRequired,
 };

ui/job-view/PushHeader.jsx

@@ -287,15 +287,13 @@ PushHeader.propTypes = {
   showRunnableJobsCb: PropTypes.func.isRequired,
   hideRunnableJobsCb: PropTypes.func.isRequired,
   cycleWatchState: PropTypes.func.isRequired,
+  isLoggedIn: PropTypes.bool.isRequired,
+  isStaff: PropTypes.bool.isRequired,
   jobCounts: PropTypes.object,
   watchState: PropTypes.string,
-  isLoggedIn: PropTypes.bool,
-  isStaff: PropTypes.bool,
 };
 
 PushHeader.defaultProps = {
   jobCounts: null,
   watchState: 'none',
-  isLoggedIn: false,
-  isStaff: false,
 };