зеркало из https://github.com/mozilla/treeherder.git
Bug 1838024 - Limit the length of the replicates tooltip to 250 chars. (#7718)
This commit is contained in:
Родитель
ab3299339d
Коммит
c457ccc374
|
@ -3,6 +3,7 @@ import PropTypes from 'prop-types';
|
|||
import { Badge } from 'reactstrap';
|
||||
|
||||
import SimpleTooltip from '../../shared/SimpleTooltip';
|
||||
import { replicatesMaxLength } from '../perf-helpers/constants';
|
||||
import { displayNumber, formatNumber } from '../perf-helpers/helpers';
|
||||
|
||||
import TooltipGraph from './TooltipGraph';
|
||||
|
@ -10,11 +11,38 @@ import TooltipGraph from './TooltipGraph';
|
|||
const TableAverage = ({ value, stddev, stddevpct, replicates, app }) => {
|
||||
let tooltipText;
|
||||
if (replicates.length > 1) {
|
||||
tooltipText = `Runs: < ${replicates
|
||||
const replicatesStr = replicates
|
||||
.map((value) => formatNumber(value))
|
||||
.join(' ')} > ${formatNumber(displayNumber(stddev))} = ${formatNumber(
|
||||
displayNumber(stddevpct),
|
||||
)}% standard deviation)`;
|
||||
.join(' ');
|
||||
|
||||
if (replicatesStr.length > replicatesMaxLength) {
|
||||
tooltipText = (
|
||||
<>
|
||||
{`Runs: < ${replicatesStr.slice(
|
||||
0,
|
||||
Math.floor(replicatesMaxLength / 2),
|
||||
)}`}
|
||||
...
|
||||
{`${replicatesStr.slice(
|
||||
replicatesStr.length - Math.floor(replicatesMaxLength / 2),
|
||||
)} > `}
|
||||
{`${formatNumber(displayNumber(stddev))} = ${formatNumber(
|
||||
displayNumber(stddevpct),
|
||||
)}% `}
|
||||
standard deviation
|
||||
<br />
|
||||
(use JSON download button to see more)
|
||||
</>
|
||||
);
|
||||
} else {
|
||||
tooltipText = (
|
||||
<>
|
||||
{`Runs: < ${replicatesStr} > ${formatNumber(
|
||||
displayNumber(stddev),
|
||||
)} = ${formatNumber(displayNumber(stddevpct))}% standard deviation`}
|
||||
</>
|
||||
);
|
||||
}
|
||||
} else if (replicates.length === 1) {
|
||||
tooltipText = 'Only one run (consider more for greater confidence)';
|
||||
}
|
||||
|
|
|
@ -202,3 +202,5 @@ export const noiseProfiles = {
|
|||
};
|
||||
|
||||
export const timeToTriage = 3;
|
||||
|
||||
export const replicatesMaxLength = 250;
|
||||
|
|
Загрузка…
Ссылка в новой задаче