Bug 1456894 - Import lodash explicitly

Rather than relying on `ProvidePlugin`.

neutrino-custom/base.js

@@ -278,7 +278,6 @@ module.exports = neutrino => {
             'window.$': require.resolve('jquery'),
             'window.jQuery': require.resolve('jquery'),
             React: require.resolve('react'),
-            _: require.resolve('lodash'),
         });
 
     neutrino.config.devtool('source-map');

neutrino-custom/lint.js

@@ -61,7 +61,6 @@ module.exports = neutrino => {
                 },
                 globals: [
                     '$',
-                    '_',
                     'jQuery',
                     'React',
                     'SERVICE_DOMAIN',

tests/ui/unit/init.js

@@ -1,7 +1,6 @@
 // Karma/webpack entry for tests
 
 import jQuery from 'jquery';
-import _ from 'lodash';
 import React from 'react';
 // Manually import angular since angular-mocks doesn't do so itself
 import 'angular';
@@ -14,7 +13,6 @@ import Adapter from 'enzyme-adapter-react-16';
 // because neutrino removes plugin definitions for karma runs
 window.$ = jQuery;
 window.jQuery = jQuery;
-window._ = _;
 window.React = React;
 
 configure({ adapter: new Adapter() });

ui/details-panel/JobDetailsPane.jsx

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import PropTypes from 'prop-types';
 import { react2angular } from 'react2angular/index.es2015';
 

ui/helpers/autoclassifyHelper.jsx

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 export const stringOverlap = function (str1, str2) {
   // Get a measure of the similarity of two strings by a simple process
   // of tokenizing and then computing the ratio of the tokens in common to

ui/helpers/jobHelper.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import { thPlatformMap } from '../js/constants';
 
 const btnClasses = {

ui/job-view/JobGroup.jsx

@@ -1,5 +1,6 @@
+import _ from 'lodash';
 import PropTypes from 'prop-types';
-import * as _ from 'lodash';
+
 import JobButton from './JobButton';
 import JobCountComponent from './JobCount';
 import { getBtnClass, getStatus } from "../helpers/jobHelper";

ui/job-view/PushJobs.jsx

@@ -1,6 +1,7 @@
+import _ from 'lodash';
 import React from 'react';
 import PropTypes from 'prop-types';
-import * as _ from 'lodash';
+
 import { thPlatformMap, thEvents } from '../js/constants';
 import { getPushTableId, getPlatformRowId } from '../helpers/aggregateIdHelper';
 import Platform from './Platform';

ui/job-view/Revision.jsx

@@ -1,4 +1,6 @@
+import _ from 'lodash';
 import PropTypes from 'prop-types';
+
 import { parseAuthor } from '../helpers/revisionHelper';
 
 export function Initials(props) {

ui/js/components/auth.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../treeherder';
 import AuthService from '../auth/AuthService';
 import { loggedOutUser } from '../auth/auth-utils';

ui/js/components/perf/compare.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../../treeherder';
 import trendTableTemplate from '../../../partials/perf/trendtable.html';
 import compareTableTemplate from '../../../partials/perf/comparetable.html';

ui/js/controllers/bugfiler.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../treeherder';
 import { getApiUrl } from "../../helpers/urlHelper";
 

ui/js/controllers/logviewer.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import logViewerApp from '../logviewer';
 import { getInspectTaskUrl, getReftestUrl } from "../../helpers/urlHelper";
 import { isReftest } from "../../helpers/jobHelper";

ui/js/controllers/main.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import Mousetrap from 'mousetrap';
 
 import treeherderApp from '../treeherder_app';

ui/js/controllers/perf/alerts.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import angular from 'angular';
 
 import perf from '../../perf';

ui/js/controllers/perf/compare.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import metricsgraphics from 'metrics-graphics';
 
 import perf from '../../perf';

ui/js/controllers/perf/dashboard.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import perf from '../../perf';
 import { thDefaultRepo, phBlockers, phTimeRanges } from "../../constants";
 

ui/js/controllers/perf/graphs.js

@@ -2,6 +2,7 @@
 // TODO: Vet/fix the use-before-defines to ensure switching var
 // to let/const won't break anything.
 
+import _ from 'lodash';
 import angular from 'angular';
 import Mousetrap from 'mousetrap';
 

ui/js/models/bug_job_map.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import angular from 'angular';
 
 import treeherder from '../treeherder';

ui/js/models/job.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import angular from 'angular';
 
 import treeherder from '../treeherder';

ui/js/models/option_collection.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../treeherder';
 import { getApiUrl } from '../../helpers/urlHelper';
 

ui/js/models/perf/alerts.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../../treeherder';
 import { getApiUrl } from "../../../helpers/urlHelper";
 import {

ui/js/models/perf/series.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../../treeherder';
 import { getProjectUrl, getApiUrl } from "../../../helpers/urlHelper";
 

ui/js/models/repository.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../treeherder';
 import { getApiUrl } from '../../helpers/urlHelper';
 import { thRepoGroupOrder } from "../constants";

ui/js/models/resultset.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import angular from 'angular';
 import jsyaml from 'js-yaml';
 import { Queue, slugid } from 'taskcluster-client-web';

ui/js/models/resultsets_store.js

@@ -2,6 +2,8 @@
 // TODO: Vet/fix the use-before-defines to ensure switching var
 // to let/const won't break anything (such as bug 1443667).
 
+import _ from 'lodash';
+
 import { thPlatformMap, thOptionOrder, thEvents } from '../constants';
 import { escapeId, getGroupMapKey } from '../../helpers/aggregateIdHelper';
 import treeherder from '../treeherder';

ui/js/services/jobfilters.js

@@ -1,5 +1,7 @@
 /* eslint-disable no-use-before-define */
 
+import _ from 'lodash';
+
 import treeherder from '../treeherder';
 import { getStatus } from '../../helpers/jobHelper';
 import { thFailureResults, thDefaultFilterResultStates, thEvents } from "../constants";

ui/js/services/main.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../treeherder';
 import tcJobActionsTemplate from '../../partials/main/tcjobactions.html';
 import { thPlatformMap } from '../constants';

ui/js/services/perf/compare.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../../treeherder';
 import { getApiUrl } from "../../../helpers/urlHelper";
 import { phTimeRanges } from "../../constants";

ui/js/services/perf/math.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../../treeherder';
 
 treeherder.factory('math', [

ui/js/services/pinboard.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import treeherder from '../treeherder';
 import { thPinboardCountError, thEvents } from "../constants";
 

ui/js/services/taskcluster.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import { OIDCCredentialAgent, fromNow } from 'taskcluster-client-web';
 
 const thTaskcluster = (() => {

ui/js/services/tcactions.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import jsone from 'json-e';
 import { Queue } from 'taskcluster-client-web';
 

ui/plugins/controller.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import jsyaml from 'js-yaml';
 import { Queue, slugid } from 'taskcluster-client-web';
 

ui/plugins/pinboard.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import Mousetrap from 'mousetrap';
 
 import treeherder from '../js/treeherder';

ui/plugins/similar_jobs/controller.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import angular from 'angular';
 
 import treeherder from '../../js/treeherder';